[{"id":1767889,"web_url":"http://patchwork.ozlabs.org/comment/1767889/","msgid":"<20170913133618.lclorawve7364xxi@localhost>","list_archive_url":null,"date":"2017-09-13T13:36:18","subject":"Re: [PATCH v2 09/28] arm64/sve: Signal frame and context structure\n\tdefinition","submitter":{"id":938,"url":"http://patchwork.ozlabs.org/api/people/938/","name":"Catalin Marinas","email":"catalin.marinas@arm.com"},"content":"On Thu, Aug 31, 2017 at 06:00:41PM +0100, Dave P Martin wrote:\n> +/*\n> + * The SVE architecture leaves space for future expansion of the\n> + * vector length beyond its initial architectural limit of 2048 bits\n> + * (16 quadwords).\n> + */\n> +#define SVE_VQ_BYTES\t\t0x10\t/* number of bytes per quadword */\n> +\n> +#define SVE_VQ_MIN\t\t1\n> +#define SVE_VQ_MAX\t\t0x200\n\nJust a nitpick (up to you): could you use 16 and 512 here instead of\nhex? I usually associate hex numbers with some bit fields.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84553-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"PjnleeHU\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsjPB6W7Vz9sNV\n\tfor ;\n\tWed, 13 Sep 2017 23:36:30 +1000 (AEST)","(qmail 19294 invoked by alias); 13 Sep 2017 13:36:24 -0000","(qmail 19094 invoked by uid 89); 13 Sep 2017 13:36:23 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-type:in-reply-to; q=dns; s=default; b=Zxyc\n\tfZx1gmQg4wu1lnUaxRk29TCoVuKPpyhukeeIvQh/UA33a2r4oLu3v5pfrRKSa7nz\n\tbM9Vm8U0q/m0mF2fBojqio3cbYhqh2khFJIWhc8gZu0FOBvK8T3Vh3dDDqq6BXAh\n\tvis0D/i9/Z52Et7SPY0GqoPDHPHHl7CkZY0Njyo=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-type:in-reply-to; s=default; bh=6lJC7AdPHf\n\tCHmPRqtynBYGedoR4=; b=PjnleeHU9PClq3xUBqb2qs88dYxIlhsJOqd4E6FzlR\n\tM6TYyX7u2QZkcFAawn+eYoNKe+rIOmas32SjxnZR6sM6tD4PPBs6eKj9LZAMRRn3\n\t82YtGXVoEJHFkKm3ODKXf8CvAcOEhbMlhdVkpAyd5SgLm/C0kTmhcIyKFV212Y3X\n\tU=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,\n\tRP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 spammy=","X-Spam-User":"qpsmtpd, 2 recipients","X-HELO":"foss.arm.com","Date":"Wed, 13 Sep 2017 06:36:18 -0700","From":"Catalin Marinas ","To":"Dave Martin ","Cc":"linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org,\n\tlibc-alpha@sourceware.org, gdb@sourceware.org, Ard Biesheuvel\n\t, Szabolcs Nagy ,\n\tYao Qi , \tAlan Hayward ,\n\tWill Deacon , Richard Sandiford\n\t, Alex =?iso-8859-1?q?Benn=E9e?=\n\t, \tkvmarm@lists.cs.columbia.edu","Subject":"Re: [PATCH v2 09/28] arm64/sve: Signal frame and context structure\n\tdefinition","Message-ID":"<20170913133618.lclorawve7364xxi@localhost>","References":"<1504198860-12951-1-git-send-email-Dave.Martin@arm.com>\n\t<1504198860-12951-10-git-send-email-Dave.Martin@arm.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1504198860-12951-10-git-send-email-Dave.Martin@arm.com>","User-Agent":"NeoMutt/20170113 (1.7.2)"}},{"id":1768205,"web_url":"http://patchwork.ozlabs.org/comment/1768205/","msgid":"<20170913213307.GF23415@e103592.cambridge.arm.com>","list_archive_url":null,"date":"2017-09-13T21:33:08","subject":"Re: [PATCH v2 09/28] arm64/sve: Signal frame and context structure\n\tdefinition","submitter":{"id":26612,"url":"http://patchwork.ozlabs.org/api/people/26612/","name":"Dave Martin","email":"Dave.Martin@arm.com"},"content":"On Wed, Sep 13, 2017 at 06:36:18AM -0700, Catalin Marinas wrote:\n> On Thu, Aug 31, 2017 at 06:00:41PM +0100, Dave P Martin wrote:\n> > +/*\n> > + * The SVE architecture leaves space for future expansion of the\n> > + * vector length beyond its initial architectural limit of 2048 bits\n> > + * (16 quadwords).\n> > + */\n> > +#define SVE_VQ_BYTES\t\t0x10\t/* number of bytes per quadword */\n> > +\n> > +#define SVE_VQ_MIN\t\t1\n> > +#define SVE_VQ_MAX\t\t0x200\n> \n> Just a nitpick (up to you): could you use 16 and 512 here instead of\n> hex? I usually associate hex numbers with some bit fields.\n\nI have no strong opinion other than a desire to make these constants\ntypo-proof.\n\nThere's no particular reason why these shouldn't be in decimal, so I can\nchange them if you like, provided you promise to notice if I misspell\n512 as 521...\n\n(git grep 131027)\n\nCheers\n---Dave","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84578-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"g+l3YtDP\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsvzr4gn2z9s81\n\tfor ;\n\tThu, 14 Sep 2017 07:33:44 +1000 (AEST)","(qmail 120702 invoked by alias); 13 Sep 2017 21:33:16 -0000","(qmail 120679 invoked by uid 89); 13 Sep 2017 21:33:15 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-type:in-reply-to; q=dns; s=default; b=KWXO\n\tWfoOxguTgb6TFAC4KDnVyN4fcJFCMZNv25CK5h+t1oJPBlYyrUShhIPzluZytE7C\n\tzUXFbQLKjPZBQw8i4ewD+LOrDjqjS/QqrwsvkjlkM63vDo5w1ZXGrch3Gw8Xy/BQ\n\taiBmhN9MnT54Mw0gsI1EgsoTWy1I3NhVEMUUSmM=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-type:in-reply-to; s=default; bh=gMncCGGEQq\n\tIf0Mift8LC0wxYruA=; b=g+l3YtDPYVH2oyT0GuJcLZ0SbIjA83iS/Jg+DwI21q\n\tbwqHcUD/juxdKppgEIiiB4AT2D4bfAHhth0wfdWB4NkkVkiQVrHWazH6Oju6crPh\n\tsifkcniIg+l1q8VSJqCWcGLIl+C3voROyK3cSl6JMu4Tp8J8qHRwqb/jqCbWZLR3\n\tg=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,\n\tRP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 spammy=","X-Spam-User":"qpsmtpd, 2 recipients","X-HELO":"foss.arm.com","Date":"Wed, 13 Sep 2017 22:33:08 +0100","From":"Dave Martin ","To":"Catalin Marinas ","Cc":"linux-arch@vger.kernel.org, libc-alpha@sourceware.org, Ard Biesheuvel\n\t, Szabolcs Nagy ,\n\tgdb@sourceware.org, Yao Qi ,\n\tWill Deacon , Richard Sandiford\n\t, \tAlan Hayward , Alex\n\t=?iso-8859-1?q?Benn=E9e?= ,\n\tkvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org","Subject":"Re: [PATCH v2 09/28] arm64/sve: Signal frame and context structure\n\tdefinition","Message-ID":"<20170913213307.GF23415@e103592.cambridge.arm.com>","References":"<1504198860-12951-1-git-send-email-Dave.Martin@arm.com>\n\t<1504198860-12951-10-git-send-email-Dave.Martin@arm.com>\n\t<20170913133618.lclorawve7364xxi@localhost>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170913133618.lclorawve7364xxi@localhost>","User-Agent":"Mutt/1.5.23 (2014-03-12)"}}]