[{"id":1767947,"web_url":"http://patchwork.ozlabs.org/comment/1767947/","msgid":"<87o9qeac2s.fsf@linaro.org>","list_archive_url":null,"date":"2017-09-13T14:48:59","subject":"Re: [PATCH v2 06/28] arm64/sve: System register and exception\n\tsyndrome definitions","submitter":{"id":39532,"url":"http://patchwork.ozlabs.org/api/people/39532/","name":"Alex Bennée","email":"alex.bennee@linaro.org"},"content":"Dave Martin writes:\n\n> The SVE architecture adds some system registers, ID register fields\n> and a dedicated ESR exception class.\n>\n> This patch adds the appropriate definitions that will be needed by\n> the kernel.\n>\n> Signed-off-by: Dave Martin \n> Cc: Alex Bennée \n\nReviewed-by: Alex Bennée \n\n>\n> ---\n>\n> Changes since v1\n> ----------------\n>\n> Requested by Alex Bennée:\n>\n> * Add comments to clarify CPACR_EL1_ZEN_ELxEN bit meanings.\n> * Add comment clarifying the status of the LEN field expansion bits.\n> ---\n> arch/arm64/include/asm/esr.h | 3 ++-\n> arch/arm64/include/asm/kvm_arm.h | 1 +\n> arch/arm64/include/asm/sysreg.h | 21 +++++++++++++++++++++\n> arch/arm64/kernel/traps.c | 1 +\n> 4 files changed, 25 insertions(+), 1 deletion(-)\n>\n> diff --git a/arch/arm64/include/asm/esr.h b/arch/arm64/include/asm/esr.h\n> index 66ed8b6..014d7d8 100644\n> --- a/arch/arm64/include/asm/esr.h\n> +++ b/arch/arm64/include/asm/esr.h\n> @@ -43,7 +43,8 @@\n> #define ESR_ELx_EC_HVC64\t(0x16)\n> #define ESR_ELx_EC_SMC64\t(0x17)\n> #define ESR_ELx_EC_SYS64\t(0x18)\n> -/* Unallocated EC: 0x19 - 0x1E */\n> +#define ESR_ELx_EC_SVE\t\t(0x19)\n> +/* Unallocated EC: 0x1A - 0x1E */\n> #define ESR_ELx_EC_IMP_DEF\t(0x1f)\n> #define ESR_ELx_EC_IABT_LOW\t(0x20)\n> #define ESR_ELx_EC_IABT_CUR\t(0x21)\n> diff --git a/arch/arm64/include/asm/kvm_arm.h b/arch/arm64/include/asm/kvm_arm.h\n> index 61d694c..dbf0537 100644\n> --- a/arch/arm64/include/asm/kvm_arm.h\n> +++ b/arch/arm64/include/asm/kvm_arm.h\n> @@ -185,6 +185,7 @@\n> #define CPTR_EL2_TCPAC\t(1 << 31)\n> #define CPTR_EL2_TTA\t(1 << 20)\n> #define CPTR_EL2_TFP\t(1 << CPTR_EL2_TFP_SHIFT)\n> +#define CPTR_EL2_TZ\t(1 << 8)\n> #define CPTR_EL2_DEFAULT\t0x000033ff\n>\n> /* Hyp Debug Configuration Register bits */\n> diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h\n> index 480ecd6..36fe2ae 100644\n> --- a/arch/arm64/include/asm/sysreg.h\n> +++ b/arch/arm64/include/asm/sysreg.h\n> @@ -145,6 +145,7 @@\n>\n> #define SYS_ID_AA64PFR0_EL1\t\tsys_reg(3, 0, 0, 4, 0)\n> #define SYS_ID_AA64PFR1_EL1\t\tsys_reg(3, 0, 0, 4, 1)\n> +#define SYS_ID_AA64ZFR0_EL1\t\tsys_reg(3, 0, 0, 4, 4)\n>\n> #define SYS_ID_AA64DFR0_EL1\t\tsys_reg(3, 0, 0, 5, 0)\n> #define SYS_ID_AA64DFR1_EL1\t\tsys_reg(3, 0, 0, 5, 1)\n> @@ -163,6 +164,8 @@\n> #define SYS_ACTLR_EL1\t\t\tsys_reg(3, 0, 1, 0, 1)\n> #define SYS_CPACR_EL1\t\t\tsys_reg(3, 0, 1, 0, 2)\n>\n> +#define SYS_ZCR_EL1\t\t\tsys_reg(3, 0, 1, 2, 0)\n> +\n> #define SYS_TTBR0_EL1\t\t\tsys_reg(3, 0, 2, 0, 0)\n> #define SYS_TTBR1_EL1\t\t\tsys_reg(3, 0, 2, 0, 1)\n> #define SYS_TCR_EL1\t\t\tsys_reg(3, 0, 2, 0, 2)\n> @@ -253,6 +256,8 @@\n>\n> #define SYS_PMCCFILTR_EL0\t\tsys_reg (3, 3, 14, 15, 7)\n>\n> +#define SYS_ZCR_EL2\t\t\tsys_reg(3, 4, 1, 2, 0)\n> +\n> #define SYS_DACR32_EL2\t\t\tsys_reg(3, 4, 3, 0, 0)\n> #define SYS_IFSR32_EL2\t\t\tsys_reg(3, 4, 5, 0, 1)\n> #define SYS_FPEXC32_EL2\t\t\tsys_reg(3, 4, 5, 3, 0)\n> @@ -335,6 +340,7 @@\n> #define ID_AA64ISAR1_DPB_SHIFT\t\t0\n>\n> /* id_aa64pfr0 */\n> +#define ID_AA64PFR0_SVE_SHIFT\t\t32\n> #define ID_AA64PFR0_GIC_SHIFT\t\t24\n> #define ID_AA64PFR0_ASIMD_SHIFT\t\t20\n> #define ID_AA64PFR0_FP_SHIFT\t\t16\n> @@ -343,6 +349,7 @@\n> #define ID_AA64PFR0_EL1_SHIFT\t\t4\n> #define ID_AA64PFR0_EL0_SHIFT\t\t0\n>\n> +#define ID_AA64PFR0_SVE\t\t\t0x1\n> #define ID_AA64PFR0_FP_NI\t\t0xf\n> #define ID_AA64PFR0_FP_SUPPORTED\t0x0\n> #define ID_AA64PFR0_ASIMD_NI\t\t0xf\n> @@ -444,6 +451,20 @@\n> #endif\n>\n>\n> +/*\n> + * The ZCR_ELx_LEN_* definitions intentionally include bits [8:4] which\n> + * are reserved by the SVE architecture for future expansion of the LEN\n> + * field, with compatible semantics.\n> + */\n> +#define ZCR_ELx_LEN_SHIFT\t0\n> +#define ZCR_ELx_LEN_SIZE\t9\n> +#define ZCR_ELx_LEN_MASK\t0x1ff\n> +\n> +#define CPACR_EL1_ZEN_EL1EN\t(1 << 16) /* enable EL1 access */\n> +#define CPACR_EL1_ZEN_EL0EN\t(1 << 17) /* enable EL0 access, if EL1EN set */\n> +#define CPACR_EL1_ZEN\t\t(CPACR_EL1_ZEN_EL1EN | CPACR_EL1_ZEN_EL0EN)\n> +\n> +\n> /* Safe value for MPIDR_EL1: Bit31:RES1, Bit30:U:0, Bit24:MT:0 */\n> #define SYS_MPIDR_SAFE_VAL\t\t(1UL << 31)\n>\n> diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c\n> index 5ea4b85..f202932 100644\n> --- a/arch/arm64/kernel/traps.c\n> +++ b/arch/arm64/kernel/traps.c\n> @@ -603,6 +603,7 @@ static const char *esr_class_str[] = {\n> \t[ESR_ELx_EC_HVC64]\t\t= \"HVC (AArch64)\",\n> \t[ESR_ELx_EC_SMC64]\t\t= \"SMC (AArch64)\",\n> \t[ESR_ELx_EC_SYS64]\t\t= \"MSR/MRS (AArch64)\",\n> +\t[ESR_ELx_EC_SVE]\t\t= \"SVE\",\n> \t[ESR_ELx_EC_IMP_DEF]\t\t= \"EL3 IMP DEF\",\n> \t[ESR_ELx_EC_IABT_LOW]\t\t= \"IABT (lower EL)\",\n> \t[ESR_ELx_EC_IABT_CUR]\t\t= \"IABT (current EL)\",\n\n\n--\nAlex Bennée","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84563-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"CzV3pOHZ\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsl1B5Szzz9s76\n\tfor ;\n\tThu, 14 Sep 2017 00:49:18 +1000 (AEST)","(qmail 63890 invoked by alias); 13 Sep 2017 14:49:11 -0000","(qmail 63820 invoked by uid 89); 13 Sep 2017 14:49:05 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:references:from:to:cc:subject:in-reply-to:date\n\t:message-id:mime-version:content-type:content-transfer-encoding;\n\tq=dns; s=default; b=ERbV9CmQ90H0KDddgfDHwULbD5Lw8f+LI8iAO01itxQ\n\tt0ITIBlfdEg75X3hguyO0Qvw5xRzMTXQBn9uY4tgv103yFO/9+pF5rR1uCRpdKgd\n\tQ7g8n1Bv3ZrXzbJpGb6JOzax7q/pZdqM1wq1MOi8ev0ycRy3DE8SXKHWqiesJalY\n\t=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:references:from:to:cc:subject:in-reply-to:date\n\t:message-id:mime-version:content-type:content-transfer-encoding;\n\ts=default; bh=l03/dm/uCK9HY4Wy5uMedz+250w=; b=CzV3pOHZVA95ADuSC\n\tmxjiLfAaYs4doP+mZZ0WRzHFscAOBuahX1jni3RiOY4O63BxyzBKipuWjwzFp3ud\n\tNx+APzlEdcvbg5QLAYA14mII8aoJGf0E6CQQ1O8IBf4VeUIAEw/ZVpGeO/pqc3cI\n\t9e6BTNJFOglKV9hFPHJvYCTrnk=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-25.9 required=5.0 tests=AWL, BAYES_00,\n\tGIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=IMP","X-HELO":"mail-wr0-f181.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:references:user-agent:from:to:cc:subject\n\t:in-reply-to:date:message-id:mime-version:content-transfer-encoding; \n\tbh=FE3xfVnzi54ajW48VxxwuXsT/sbXh2YchgGpDVBWqOU=;\n\tb=CgSznQnAyUyRXPzmQsUhE03SUufBuln8EmNfpEfOngfJ/82oUpbPREFE+rnMVOfRq6\n\tLMDsShIikwQmfpqXqQfEywJZMpV0MvJAS82VcmAnXsLXwlkpIYEX1l2mZrL01uHlDzn0\n\tMdzqDSFpTjnXFYIn9mNmESuGXkGwem7uqow3YO+RGpvnnTVKpqyG4JfkOyU9e3RWCAV6\n\tOddd3Wg4WgBE1Gi5XCHLwCF5r7EpW+Ws5SptikEHk9Kq0Ckf1iiAIeR/PYSjlg7ZRTyv\n\tpv1uKYRe8eGW+Dmz7Tz8T8soVducEIQ1qMmcI21Rx7zHrrNGCrI6Nn3FjjGDiY0fSwYY\n\t+Fpg==","X-Gm-Message-State":"AHPjjUgScGodWb/Pjl55vZEVDw+u51Vqq0/8Hcg3Pmb9ACTCZZY2xYPs\n\tjIDFq4aOM4aYFzWX","X-Google-Smtp-Source":"ADKCNb46jA+FnGkd0vnrAXb+y+0eeEG9kyRMy38/eL7pHvOLCEPPZXDsTxi+3U3KDpEZllLcrKWIMg==","X-Received":"by 10.223.164.206 with SMTP id\n\th14mr14953790wrb.221.1505314140703; \n\tWed, 13 Sep 2017 07:49:00 -0700 (PDT)","References":"<1504198860-12951-1-git-send-email-Dave.Martin@arm.com>\n\t<1504198860-12951-7-git-send-email-Dave.Martin@arm.com>","User-agent":"mu4e 0.9.19; emacs 25.2.50.3","From":"Alex =?utf-8?q?Benn=C3=A9e?= ","To":"Dave Martin ","Cc":"linux-arm-kernel@lists.infradead.org,\n\tCatalin Marinas ,\n\tWill Deacon ,\n\tArd Biesheuvel ,\n\tSzabolcs Nagy ,\n\tRichard Sandiford ,\n\tkvmarm@lists.cs.columbia.edu, libc-alpha@sourceware.org,\n\tlinux-arch@vger.kernel.org","Subject":"Re: [PATCH v2 06/28] arm64/sve: System register and exception\n\tsyndrome definitions","In-reply-to":"<1504198860-12951-7-git-send-email-Dave.Martin@arm.com>","Date":"Wed, 13 Sep 2017 15:48:59 +0100","Message-ID":"<87o9qeac2s.fsf@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"8bit"}}]