[{"id":1761376,"web_url":"http://patchwork.ozlabs.org/comment/1761376/","msgid":"<20170831232633.GA678@bistromath.localdomain>","list_archive_url":null,"date":"2017-08-31T23:26:33","subject":"Re: [PATCH net-next v5 2/2] tcp_diag: report TCP MD5 signing keys\n\tand addresses","submitter":{"id":47767,"url":"http://patchwork.ozlabs.org/api/people/47767/","name":"Sabrina Dubroca","email":"sd@queasysnail.net"},"content":"2017-08-31, 09:59:39 -0700, Ivan Delalande wrote:\n> diff --git a/net/ipv4/tcp_diag.c b/net/ipv4/tcp_diag.c\n> index a748c74aa8b7..abbf0edcf6c2 100644\n> --- a/net/ipv4/tcp_diag.c\n> +++ b/net/ipv4/tcp_diag.c\n[...]\n> +static int tcp_diag_get_aux(struct sock *sk, bool net_admin,\n> +\t\t\t struct sk_buff *skb)\n> +{\n> +#ifdef CONFIG_TCP_MD5SIG\n> +\tif (net_admin) {\n\nIn tcp_diag_get_aux_size() you put a check for sk_fullsock. I don't\nsee anything preventing you from reaching this with a !fullsock?\n\n\n> +\t\tstruct tcp_md5sig_info *md5sig;\n> +\t\tint err = 0;\n> +\n> +\t\trcu_read_lock();\n> +\t\tmd5sig = rcu_dereference(tcp_sk(sk)->md5sig_info);\n> +\t\tif (md5sig)\n> +\t\t\terr = tcp_diag_put_md5sig(skb, md5sig);\n> +\t\trcu_read_unlock();\n> +\t\tif (err < 0)\n> +\t\t\treturn err;\n> +\t}\n> +#endif\n> +\n> +\treturn 0;\n> +}\n> +\n> +static size_t tcp_diag_get_aux_size(struct sock *sk, bool net_admin)\n> +{\n> +\tsize_t size = 0;\n> +\n> +#ifdef CONFIG_TCP_MD5SIG\n> +\tif (net_admin && sk_fullsock(sk)) {\n> +\t\tconst struct tcp_md5sig_info *md5sig;\n> +\t\tconst struct tcp_md5sig_key *key;\n> +\t\tsize_t md5sig_count = 0;\n> +\n> +\t\trcu_read_lock();\n> +\t\tmd5sig = rcu_dereference(tcp_sk(sk)->md5sig_info);\n> +\t\tif (md5sig) {\n> +\t\t\thlist_for_each_entry_rcu(key, &md5sig->head, node)\n> +\t\t\t\tmd5sig_count++;\n> +\t\t}\n> +\t\trcu_read_unlock();\n> +\t\tsize += nla_total_size(md5sig_count *\n> +\t\t\t\t sizeof(struct tcp_diag_md5sig));\n> +\t}\n> +#endif\n> +\n> +\treturn size;\n> +}\n> +\n> static void tcp_diag_dump(struct sk_buff *skb, struct netlink_callback *cb,\n> \t\t\t const struct inet_diag_req_v2 *r, struct nlattr *bc)\n> {","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none)\n\theader.from=queasysnail.net","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=none smtp.mailfrom=sd@queasysnail.net"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjz676z1bz9s7p\n\tfor ;\n\tFri, 1 Sep 2017 09:26:39 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751415AbdHaX0h (ORCPT );\n\tThu, 31 Aug 2017 19:26:37 -0400","from mx1.redhat.com ([209.132.183.28]:41648 \"EHLO mx1.redhat.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751307AbdHaX0h (ORCPT );\n\tThu, 31 Aug 2017 19:26:37 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 5693FC04B938;\n\tThu, 31 Aug 2017 23:26:36 +0000 (UTC)","from bistromath.localdomain (ovpn-116-179.ams2.redhat.com\n\t[10.36.116.179])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 1EBE25D6A2;\n\tThu, 31 Aug 2017 23:26:34 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 5693FC04B938","DKIM-Filter":"OpenDKIM Filter v2.11.0 mx1.redhat.com 5693FC04B938","Date":"Fri, 1 Sep 2017 01:26:33 +0200","From":"Sabrina Dubroca ","To":"Ivan Delalande ","Cc":"David Miller ,\n\tEric Dumazet , netdev@vger.kernel.org","Subject":"Re: [PATCH net-next v5 2/2] tcp_diag: report TCP MD5 signing keys\n\tand addresses","Message-ID":"<20170831232633.GA678@bistromath.localdomain>","References":"<20170831165939.5121-1-colona@arista.com>\n\t<20170831165939.5121-3-colona@arista.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20170831165939.5121-3-colona@arista.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tThu, 31 Aug 2017 23:26:37 +0000 (UTC)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1761397,"web_url":"http://patchwork.ozlabs.org/comment/1761397/","msgid":"<20170901002118.sprwhuybmk4spy34@ycc.fr>","list_archive_url":null,"date":"2017-09-01T00:21:18","subject":"Re: [PATCH net-next v5 2/2] tcp_diag: report TCP MD5 signing keys\n\tand addresses","submitter":{"id":65664,"url":"http://patchwork.ozlabs.org/api/people/65664/","name":"Ivan Delalande","email":"colona@arista.com"},"content":"On Fri, Sep 01, 2017 at 01:26:33AM +0200, Sabrina Dubroca wrote:\n> 2017-08-31, 09:59:39 -0700, Ivan Delalande wrote:\n> > diff --git a/net/ipv4/tcp_diag.c b/net/ipv4/tcp_diag.c\n> > index a748c74aa8b7..abbf0edcf6c2 100644\n> > --- a/net/ipv4/tcp_diag.c\n> > +++ b/net/ipv4/tcp_diag.c\n> [...]\n> > +static int tcp_diag_get_aux(struct sock *sk, bool net_admin,\n> > +\t\t\t struct sk_buff *skb)\n> > +{\n> > +#ifdef CONFIG_TCP_MD5SIG\n> > +\tif (net_admin) {\n> \n> In tcp_diag_get_aux_size() you put a check for sk_fullsock. I don't\n> see anything preventing you from reaching this with a !fullsock?\n\nCurrently handler->idiag_get_aux is only called from inet_sk_diag_fill\nwhich has a `BUG_ON(!sk_fullsock(sk));`, but I could add another\nexplicit check in that function if you think it's more consistent.\n\nActually, I wasn't sure when adding this idiag_get_aux in v2 if it\nshould be called from inet_twsk_diag_fill, inet_req_diag_fill and\ninet_csk_diag_fill, or just the last one. I chose that simpler approach\nfor now to avoid duplicating these state checks in the idiag_get_aux\ndefined by protocols and because we didn't need for INET_DIAG_MD5SIG,\nbut it shouldn't be too hard to change. Do you think this could be\nuseful for other protocols or attributes?\n\nThank you,","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=arista.com header.i=@arista.com\n\theader.b=\"b47tVdqC\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xk0KL2HChz9s81\n\tfor ;\n\tFri, 1 Sep 2017 10:21:26 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751440AbdIAAVV (ORCPT );\n\tThu, 31 Aug 2017 20:21:21 -0400","from mail-wm0-f41.google.com ([74.125.82.41]:36949 \"EHLO\n\tmail-wm0-f41.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751345AbdIAAVU (ORCPT\n\t); Thu, 31 Aug 2017 20:21:20 -0400","by mail-wm0-f41.google.com with SMTP id u26so6623130wma.0\n\tfor ; Thu, 31 Aug 2017 17:21:20 -0700 (PDT)","from grunt.ycc.fr (grunt.ycc.fr. [51.15.180.229])\n\tby smtp.gmail.com with ESMTPSA id\n\tz39sm854933wrz.61.2017.08.31.17.21.18\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 31 Aug 2017 17:21:19 -0700 (PDT)","by grunt.ycc.fr (Postfix, from userid 1000)\n\tid 529A080A4B; Fri, 1 Sep 2017 02:21:18 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=google;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=pf7kAL79lEGqAnCd4hbSoKyN791sRUdGal6Trg4A4Z4=;\n\tb=b47tVdqCnkLFFcK1Z9+3z6QNkqpkVyPtLCwKuggve+38gLqvPBlLfJz3uzv1aHFTPg\n\tUyHC8OJeV7BV88tL9zh0fId1w7UbWvRxMX5XEZQRGM1TQA7s5iwpWemREhHEF34sTrf9\n\tMKC4Rg0U1qEcZl9z/Dy+lPZvH0K+cUD/cjIik=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=pf7kAL79lEGqAnCd4hbSoKyN791sRUdGal6Trg4A4Z4=;\n\tb=akiJgzcaLEArCJCF1u1bKdmlU8WN0hFqlterEzvP6UpyxWKBCr09syTuUL8YrB7pdi\n\tnH2kIvMQdAy2CAw+3J8faqsGlXsn/y3r/xqD5gy5iFhH5dBDyv8vLLkCP6krbBvjCEv3\n\tFS6osUmjn8zJqFzjsOB4EhkYSvtRA0uRvuZ3GUUKekQS+1kK+wtw3YXlzRchDfKcNJdX\n\trrIzRuS+2GINcIt+vUHw6DAdZsoSVjXK0ZZmLaTUfn0N9Iq2VpUsMSwS82AiGh7itYgR\n\tF1K5VORkLivBDlYAI6oeTbe3icH5ulr3E5D7+U+0LmUsGTkJSxS5eI6AByDMvWDv61Md\n\tMwlg==","X-Gm-Message-State":"AHPjjUgbHqOY1n1qhSt36qDWnKNRMJ9cSanZpjELVcieN1c1zAc4kL2M\n\t48s4GLKU3OWKVqys","X-Google-Smtp-Source":"ADKCNb4Iqtiz0dS49SeRcQrTaSMs3NFUfs9JnhS9Bfy5daaH9WmfKs7IW7fnloKZOBkaLt7Ar8ghbA==","X-Received":"by 10.28.188.67 with SMTP id m64mr1413655wmf.174.1504225279595; \n\tThu, 31 Aug 2017 17:21:19 -0700 (PDT)","Date":"Fri, 1 Sep 2017 02:21:18 +0200","From":"Ivan Delalande ","To":"Sabrina Dubroca ","Cc":"David Miller ,\n\tEric Dumazet , netdev@vger.kernel.org","Subject":"Re: [PATCH net-next v5 2/2] tcp_diag: report TCP MD5 signing keys\n\tand addresses","Message-ID":"<20170901002118.sprwhuybmk4spy34@ycc.fr>","References":"<20170831165939.5121-1-colona@arista.com>\n\t<20170831165939.5121-3-colona@arista.com>\n\t<20170831232633.GA678@bistromath.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170831232633.GA678@bistromath.localdomain>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1761444,"web_url":"http://patchwork.ozlabs.org/comment/1761444/","msgid":"<1504234729.15310.20.camel@edumazet-glaptop3.roam.corp.google.com>","list_archive_url":null,"date":"2017-09-01T02:58:49","subject":"Re: [PATCH net-next v5 2/2] tcp_diag: report TCP MD5 signing keys\n\tand addresses","submitter":{"id":2404,"url":"http://patchwork.ozlabs.org/api/people/2404/","name":"Eric Dumazet","email":"eric.dumazet@gmail.com"},"content":"On Thu, 2017-08-31 at 09:59 -0700, Ivan Delalande wrote:\n> Report TCP MD5 (RFC2385) signing keys, addresses and address prefixes to\n> processes with CAP_NET_ADMIN requesting INET_DIAG_INFO. Currently it is\n> not possible to retrieve these from the kernel once they have been\n> configured on sockets.\n> \n> Signed-off-by: Ivan Delalande \n> ---\n> include/uapi/linux/inet_diag.h | 1 +\n> include/uapi/linux/tcp.h | 9 ++++\n> net/ipv4/tcp_diag.c | 109 ++++++++++++++++++++++++++++++++++++++---\n> 3 files changed, 113 insertions(+), 6 deletions(-)\n\nAcked-by: Eric Dumazet ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"qiYIepyC\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xk3q21x3Mz9s83\n\tfor ;\n\tFri, 1 Sep 2017 12:58:54 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751478AbdIAC6w (ORCPT );\n\tThu, 31 Aug 2017 22:58:52 -0400","from mail-pf0-f196.google.com ([209.85.192.196]:38749 \"EHLO\n\tmail-pf0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751346AbdIAC6v (ORCPT\n\t); Thu, 31 Aug 2017 22:58:51 -0400","by mail-pf0-f196.google.com with SMTP id r187so843577pfr.5\n\tfor ; Thu, 31 Aug 2017 19:58:51 -0700 (PDT)","from [192.168.86.171] (c-67-180-167-114.hsd1.ca.comcast.net.\n\t[67.180.167.114]) by smtp.googlemail.com with ESMTPSA id\n\tu31sm1117182pgn.72.2017.08.31.19.58.49\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 31 Aug 2017 19:58:50 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=message-id:subject:from:to:cc:date:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=47HxI/dnc2Pp3IPl+GmBG8KrrZl8Y8bDcUNzE0nvdTU=;\n\tb=qiYIepyCaaDrvZrfpu1Tvv38D/9Vj8MQCq2fjcqRoXTeLVVqCCIbOwLfhtg/E3JeXC\n\tviZwMtHkhEb/0ePu7ahK7p6BtRjURPg3w7p7zU4J7yP3lznLmXeJ/dY7s3sNDXbCjlVR\n\tNj+W+cB6RdcHAvSnWNznKwR05jbIVJaStgpU5sUpJe3oGpwEc2ntec6WLa2JJJ/OEapl\n\tB/E6dYQhzHRV5DaHtQzgAxleh98PgvDIuFrLtsg+qH4S42+6GQRW7xZQI7iyeViHu05Z\n\tdpqggqOAzqQRdKySsSyQM+Qnm3ADYh3GaEvgDUJcy5iWfd48lEYYby/gE7eJhrUTBWoc\n\tZ46g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=47HxI/dnc2Pp3IPl+GmBG8KrrZl8Y8bDcUNzE0nvdTU=;\n\tb=c5D6Jr8zwo6OSe5wo+X5T+InRSBZybNK1460rGAmMuJrPyCO1fYelN4mXJxRyxxRKd\n\tcjApdytrXDDXMLA5Kqf5Ct9fmJGXSs7QrXwnSps1Tk+eVKGKVc1R5/W04IrxeVRm9Wna\n\tsF/ut18kP7eCBbV2stoKsUmS+w89nkflfqzeLQU+UtDeuuTAtvDarDJQ1Ln+VCAjZZVR\n\tbO0o4Ue9nPe2q4MZwPyaVaN3i+fSilYrh7dcYVbuQBKJf929DWllt9oi81WWgQWbedFE\n\tgNUU9kSgHqOwNeStrtNEMzS6G5AoLtW7bv46bhuKe8MK1Zh+hGB0ZUrYK9kMAniEfCf6\n\tzFjA==","X-Gm-Message-State":"AHPjjUgcGNO+6QQjhU8cKOWvC2VNz5FEHstiUyrwWiAJ+om4+7iBR1CR\n\txPQGAPeDKVKITg==","X-Google-Smtp-Source":"ADKCNb5Q9drssvd5KVDjQFcGFE1VBCiCaVesNXFMtycYSIAUtmNFSh94DwFfIrKwKkb8gJsGMs/CLg==","X-Received":"by 10.84.132.67 with SMTP id 61mr662699ple.156.1504234730784;\n\tThu, 31 Aug 2017 19:58:50 -0700 (PDT)","Message-ID":"<1504234729.15310.20.camel@edumazet-glaptop3.roam.corp.google.com>","Subject":"Re: [PATCH net-next v5 2/2] tcp_diag: report TCP MD5 signing keys\n\tand addresses","From":"Eric Dumazet ","To":"Ivan Delalande ","Cc":"David Miller , netdev@vger.kernel.org","Date":"Thu, 31 Aug 2017 19:58:49 -0700","In-Reply-To":"<20170831165939.5121-3-colona@arista.com>","References":"<20170831165939.5121-1-colona@arista.com>\n\t<20170831165939.5121-3-colona@arista.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.10.4-0ubuntu2 ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1761772,"web_url":"http://patchwork.ozlabs.org/comment/1761772/","msgid":"<20170901154744.GA5673@bistromath.localdomain>","list_archive_url":null,"date":"2017-09-01T15:47:44","subject":"Re: [PATCH net-next v5 2/2] tcp_diag: report TCP MD5 signing keys\n\tand addresses","submitter":{"id":47767,"url":"http://patchwork.ozlabs.org/api/people/47767/","name":"Sabrina Dubroca","email":"sd@queasysnail.net"},"content":"2017-09-01, 02:21:18 +0200, Ivan Delalande wrote:\n> On Fri, Sep 01, 2017 at 01:26:33AM +0200, Sabrina Dubroca wrote:\n> > 2017-08-31, 09:59:39 -0700, Ivan Delalande wrote:\n> > > diff --git a/net/ipv4/tcp_diag.c b/net/ipv4/tcp_diag.c\n> > > index a748c74aa8b7..abbf0edcf6c2 100644\n> > > --- a/net/ipv4/tcp_diag.c\n> > > +++ b/net/ipv4/tcp_diag.c\n> > [...]\n> > > +static int tcp_diag_get_aux(struct sock *sk, bool net_admin,\n> > > +\t\t\t struct sk_buff *skb)\n> > > +{\n> > > +#ifdef CONFIG_TCP_MD5SIG\n> > > +\tif (net_admin) {\n> > \n> > In tcp_diag_get_aux_size() you put a check for sk_fullsock. I don't\n> > see anything preventing you from reaching this with a !fullsock?\n> \n> Currently handler->idiag_get_aux is only called from inet_sk_diag_fill\n> which has a `BUG_ON(!sk_fullsock(sk));`, but I could add another\n\nOh, right, that's the part I was missing. Thanks.\n\n> explicit check in that function if you think it's more consistent.\n> \n> Actually, I wasn't sure when adding this idiag_get_aux in v2 if it\n> should be called from inet_twsk_diag_fill, inet_req_diag_fill and\n> inet_csk_diag_fill, or just the last one. I chose that simpler approach\n> for now to avoid duplicating these state checks in the idiag_get_aux\n> defined by protocols and because we didn't need for INET_DIAG_MD5SIG,\n> but it shouldn't be too hard to change. Do you think this could be\n> useful for other protocols or attributes?\n\nNo opinion. It can be added later if necessary.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none)\n\theader.from=queasysnail.net","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=none smtp.mailfrom=sd@queasysnail.net"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkNtG64TPz9t2x\n\tfor ;\n\tSat, 2 Sep 2017 01:47:50 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752439AbdIAPrs (ORCPT );\n\tFri, 1 Sep 2017 11:47:48 -0400","from mx1.redhat.com ([209.132.183.28]:48984 \"EHLO mx1.redhat.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752329AbdIAPrr (ORCPT );\n\tFri, 1 Sep 2017 11:47:47 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 3CA4F61481;\n\tFri, 1 Sep 2017 15:47:47 +0000 (UTC)","from bistromath.localdomain (ovpn-116-179.ams2.redhat.com\n\t[10.36.116.179])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 0575D78206;\n\tFri, 1 Sep 2017 15:47:45 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 3CA4F61481","DKIM-Filter":"OpenDKIM Filter v2.11.0 mx1.redhat.com 3CA4F61481","Date":"Fri, 1 Sep 2017 17:47:44 +0200","From":"Sabrina Dubroca ","To":"Ivan Delalande ","Cc":"David Miller ,\n\tEric Dumazet , netdev@vger.kernel.org","Subject":"Re: [PATCH net-next v5 2/2] tcp_diag: report TCP MD5 signing keys\n\tand addresses","Message-ID":"<20170901154744.GA5673@bistromath.localdomain>","References":"<20170831165939.5121-1-colona@arista.com>\n\t<20170831165939.5121-3-colona@arista.com>\n\t<20170831232633.GA678@bistromath.localdomain>\n\t<20170901002118.sprwhuybmk4spy34@ycc.fr>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20170901002118.sprwhuybmk4spy34@ycc.fr>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tFri, 01 Sep 2017 15:47:47 +0000 (UTC)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]