[{"id":1762222,"web_url":"http://patchwork.ozlabs.org/comment/1762222/","msgid":"<1e838306-09f4-b3dc-18e2-437a17f7c927@mellanox.com>","list_archive_url":null,"date":"2017-09-03T07:19:52","subject":"Re: [PATCH][next] net/mlx4_core: fix memory leaks on error exit path","submitter":{"id":68926,"url":"http://patchwork.ozlabs.org/api/people/68926/","name":"Tariq Toukan","email":"tariqt@mellanox.com"},"content":"On 31/08/2017 7:30 PM, Colin King wrote:\n> From: Colin Ian King \n> \n> The structures hca_param and func_cap are not being kfree'd on an error\n> exit path causing two memory leaks. Fix this by jumping to the existing\n> free memory error exit path.\n> \n> Detected by CoverityScan, CID#1455219, CID#1455224 (\"Resource Leak\")\n> \n> Fixes: c73c8b1e47ca (\"net/mlx4_core: Dynamically allocate structs at mlx4_slave_cap\")\n> Signed-off-by: Colin Ian King \n> ---\n> drivers/net/ethernet/mellanox/mlx4/main.c | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c\n> index 1c92101b3ec2..d46f3283ec36 100644\n> --- a/drivers/net/ethernet/mellanox/mlx4/main.c\n> +++ b/drivers/net/ethernet/mellanox/mlx4/main.c\n> @@ -977,7 +977,8 @@ static int mlx4_slave_cap(struct mlx4_dev *dev)\n> \tif (dev->caps.num_ports > MLX4_MAX_PORTS) {\n> \t\tmlx4_err(dev, \"HCA has %d ports, but we only support %d, aborting\\n\",\n> \t\t\t dev->caps.num_ports, MLX4_MAX_PORTS);\n> -\t\treturn -ENODEV;\n> +\t\terr = -ENODEV;\n> +\t\tgoto free_mem;\n> \t}\n> \n> \tmlx4_replace_zero_macs(dev);\n> \n\nAcked-by: Tariq Toukan \n\nThanks Colin!","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=Mellanox.com header.i=@Mellanox.com\n\theader.b=\"xfV6isWd\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=tariqt@mellanox.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlPWq0ckmz9sP3\n\tfor ;\n\tSun, 3 Sep 2017 17:20:23 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751580AbdICHUK (ORCPT );\n\tSun, 3 Sep 2017 03:20:10 -0400","from mail-he1eur01on0069.outbound.protection.outlook.com\n\t([104.47.0.69]:26048\n\t\"EHLO EUR01-HE1-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1751224AbdICHUH (ORCPT );\n\tSun, 3 Sep 2017 03:20:07 -0400","from [10.8.2.253] (193.47.165.251) by\n\tHE1PR05MB1803.eurprd05.prod.outlook.com (2a01:111:e400:7a28::17) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10;\n\tSun, 3 Sep 2017 07:19:58 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=FZE/jat3Z7Qi0V95mI4zUMuhbgODMi1RoyztE+atISM=;\n\tb=xfV6isWdLnaoiofvKkZx7LPyPS7aZOTom57MmGOHF1O3RIjLsLCJ9PvbTNxS3mJrjjouMA3nbf++CY8yD1AAgEUrOMQXJiLyoKLIWHENB2q8DRvN4ypl2rl7nI3RP5AHAUww83KKMUnBYpJS/0241sD6ClGQNdc/7WDXj3MNpgI=","Subject":"Re: [PATCH][next] net/mlx4_core: fix memory leaks on error exit path","To":"Colin King ,\n\tTariq Toukan , netdev@vger.kernel.org,\n\tlinux-rdma@vger.kernel.org","Cc":"kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org","References":"<20170831163053.2349-1-colin.king@canonical.com>","From":"Tariq Toukan ","Message-ID":"<1e838306-09f4-b3dc-18e2-437a17f7c927@mellanox.com>","Date":"Sun, 3 Sep 2017 10:19:52 +0300","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170831163053.2349-1-colin.king@canonical.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[193.47.165.251]","X-ClientProxiedBy":"DB6PR0801CA0065.eurprd08.prod.outlook.com\n\t(2603:10a6:4:2b::33) To HE1PR05MB1803.eurprd05.prod.outlook.com\n\t(2a01:111:e400:7a28::17)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"8dccc7a0-516d-4129-3de3-08d4f29c3202","X-MS-Office365-Filtering-HT":"Tenant","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:HE1PR05MB1803; ","X-Microsoft-Exchange-Diagnostics":["1; HE1PR05MB1803;\n\t3:hhdzctd4msfyev69SiXFTKiEaaGPQpoiaENsZ7JMDSAXNDxQu13tOynT2ssoTildtV00GDlQT7QqGqEo/8yhTrzjmT654lazCvV8dxifkDf7DiqK3LOmTs2QvThUqKyMaxiXecSzg0mYJTMZOLkcMy6YE08lQIXlBvZ74gFgcnby9snk9fZwIetyglKezM6wlZ9BTxo5bQhxv3359GrYsmNZ/ckeMF5SUwjuOoXfts7neLqqLtIEucb4lOHkriVz;\n\t25:O2MjukZbp4IwrmaRpiZLmutLWxB+azkrPDLhziZ9erkMia5j4NYS7Er/kqg0aIlOHDcp4rmyhu5C0Z/dv8BmduL+RRh3tKRnfCUwRpigRIGa2lPhlz+aq9t0uVOe7Ac6pDPqDoHFP8IG/QP9PYhgYEpQC0wU0loC+6kQ5W9RlIQD9/96eYl573+7xho6rhkxC9vl4cLa1m4C3yRkjpwkPuyOtHOaiQgz9e3rqF2r2pGpENABFK5juLYSsPC9HVmUF17dpO5Cp/6bj4jwvyXP0Z5kjKMNdIiGvX/rNMrADx5Gm0h3aoJ0bhcw5KCAna7o+QYSZYoVzPO1pl88cfdA1A==;\n\t31:6aV/9ckHRo+OsjWw7QY+c3AeecGLcPMKIrrZf3fsd2Qd2n6gmdIdBD+NBMZJJtYV3glIU6+b/KIXGU+MWe97eQ1UXkkpXhFO8bhYeURLFOGsMGMBoAPuEUhMAogoEAiMGqy3iY01ZzQd8oNN1u8Oln6Ps/eNzU3xNNFsRZY/aMPA0XBckiiUqqNK0IyTvYXf37RYtcr6fPEW/C/7jX3xCIDK/yJfYWhU1xvvAaab9C0=","1; HE1PR05MB1803;\n\t20:mw71hl303o/4zKbKSACpYp7LPh6PorF0qrUBc4+23dsXInIZ81fOSMBVSCIB0eR5Q7RrX0I75N3ObnzLJFZ0zv9MaX3wNNktHWWDiXOFZfgdp06OXYJoE4zn0ExQWYiHi1VaJW/zTw48VbucFjqVS/q77NndXgfMh+YiyOlq1vLfxu7Fknd7pU0I+NAnVzHtdT41x2so4sg38KWHq6bbRiFbaYvSjvI2AOB1X/gptOcBsUewblNBk7z436RLU5TBe7hepR+KtrC63++QlRbgNPWRicv6uJPBHilMm4DKxqBXOqbRpSdIktyUt25OsFiKnN+KPibi36z6qhzN95joHExKmpjq9SsvShKkcmHnY1GPv8aIR2Mbgz//GvbUYq3M/E27SjLVDA0AKI6EAdgkyVzfYD/+CgkCdOVNcMev99VUFsJNC1q6Q9JGI7lDnAf/+AHWFp/0pXVpc1pfylRNBoEC30aDv1NefMfyxtZjiZ5i9eTaw0ha6wRdD5IpJi42;\n\t4:CBYx4WIwSOTXHFW5PnVK1wixSNuf9cPOsUq0d4JPTOoC605PEx2mDqkAglhUuhsHbJaj+K9yOz9hSvRAEbRgYlTJm0V9d9Dxj8mIzGEaa9CWn1yKkCNXTG06fj3kqyi2JJroU5zT228Jj5Ec5a1G03Ly64Y0uPEpe7K+ugeld2oika3Xsng4WcxmGcHn4rGaEiEEuggxmY8KDTZvIGzEabQsarKkkv5elwLTx+7XyNEU07q4EIPPBXeB5T3/B5HQrXuF1nfCafsknaCY6I4dDHo+C2Ylvf3JlcETjH1zMHk=","=?utf-8?q?1=3BHE1PR05MB1803=3B23=3AyGrt?=\n\t=?utf-8?q?40jGLYZrCVpa8dCQea+5Al1/odSi762bjMrSyMJrHJGEHwkxKyH1f/jV?=\n\t=?utf-8?q?4NXnNJoPLIXRmqar28H741Z/bx5tVnzAPrlF7NJB9oS0c68Lh1tdkqnw?=\n\t=?utf-8?q?BEwvWSaeWkFYTn4wcZ9R+OHYqysQ1cP4g0+ZOKWvGx0UyDKIzGF8XYJ9?=\n\t=?utf-8?q?p122ceYslry61/+pBEKzCgvKORtZt0qkcgVDCwNA/GtFGvjMt4IaLCCn?=\n\t=?utf-8?q?intkel9vo2hXlnR/Ccv1pEHoatInNSuNRh66xm3t6Pp82fsgmbP3kPVn?=\n\t=?utf-8?q?AQltaVMoMnCjHcxWLThGarMlZyslAiCB5zrUK4fa8+S69bwXSOtZE5eO?=\n\t=?utf-8?q?T24Nisp2recmL5jORhUoYh+oGasprGQBfbGPOQE5vawrXVvpVQWtKu7A?=\n\t=?utf-8?q?XdmYBQWwpPgtUI02utJt67YtNHIDRHjThZ4UkXoF6rmG1FaP2inLpIE4?=\n\t=?utf-8?q?U4UIy2d+YxkoLPbCEe33eern4vDSnv5p9AtPyFBFiaArOyBjbyM66gO4?=\n\t=?utf-8?q?MUv4H4dmmY/6IPsWPlVZLyyUuZFw08MjKhdhbgQ3hJ6uSs5XYSYN5Cwc?=\n\t=?utf-8?q?8K5GpXNFkU7bzw7hprymMlQmJlOpslVd2ge3eZ3kVS7xsuv5mchOrwp6?=\n\t=?utf-8?q?RyjUQJ8I02qWjlhC8z/foQHolgoU27MAlugencj8yFpnq1zFtWjivGY3?=\n\t=?utf-8?q?fVu/WQlkSPM4TXvaC6s3eYPnkqI1JSW732R1YCsDFxenxfgJL4BaagEM?=\n\t=?utf-8?q?sDeeT9tgyV0dD0Mux0N0gmoSisddjFKnSz3jfTkU7DPIgsv0NcrNrq7y?=\n\t=?utf-8?q?EXr4Z30V9u9kVnMlptgMqeiSMpSXm3ji6EDMQL3ptsXqrQwdolnDToLM?=\n\t=?utf-8?q?oeqBMJCd5SBjYKS3FjFd0ts3tfuMb1MC2aWBc38MyXJetb6jT2GIC+y1?=\n\t=?utf-8?q?umCuQwKpfhuplXj3E2Hc7unMTA4Zf5D4aao8rbDAZfoxFDCYjedR4ByG?=\n\t=?utf-8?q?NVLZAWMr/BGwJ8diDIjqDupQ1MtYN+66SZEWEyeemMPb8aix0zEtUlOv?=\n\t=?utf-8?q?K6lnWxX5slHeUsGU4+rhznrxJduySeL0uQarmdnuVpXgwU/gCPqBBlQH?=\n\t=?utf-8?q?l9inEdJqDfae3XqzNw47r/PQp9Q2YCKeGTojIZlWPfiqBqayRhKoGPt6?=\n\t=?utf-8?q?FnOfILfbDC7qPVqt7P4gvu92CC/yuoeN2wvVEQgNRZxRJYmGK1a5bjPA?=\n\t=?utf-8?q?i44+X4Zg2Yu6JFVSD8LJ6OnFjYl9qZW4Sqlq1iY1dRKbZUiMZwVMZLWi?=\n\t=?utf-8?q?Ar1eEjfZlD4jMW2ruWB70MZmkVBW7lThf2mBTJlb8QSDq9pQLYfxhJ6A?=\n\t=?utf-8?q?wDXi1Ul69CMYJsV3FdKpJGzC06+SP5qLsS3QvbLYRS6DyLJcOQb2ynG/?=\n\t=?utf-8?q?7F8IBhSutzaVJW1BNw=3D=3D?=","1; HE1PR05MB1803;\n\t6:4rkXNlga0BT4EjcVnIhpJBwHmQw+cYvxqOKU6ya6ScxNXThW/fKqx6XddbMiyKYCRDebxmWFOIxQ6tVVDN5twBuwtk3dI1Fb2t4wGXh8YIn34Bpbh5IrQY5pwH9+uZ5Qz3OuGZWyzN9zrd6LuLLCb8yJPeiJYdPFPjSTLnd796hK+I8Z5/g1bv+X9cwGuveTjPBW9E3uNij7bMt+u976A9GRrvqMVwy0qKFIXLthK+UFt9+ZVLfQBdiO8RwHNQIQRd5iNgXFAh9K1VYgBYop7ZM+WK3ZVhVZSd56qKdenQFV6xO0pxKyQTIIXN8yIA4byKKls2QDAd5Uhmyenx9Dtg==;\n\t5:ANZAtqTTPjM5XxhozUDeu9qnZbDb8QS8gWnEctdIdEze0BOzoQU51lkdg4tFM5ENz1y0OW7E5Nlu9lAhhgQGVXP9f+ukBJhAUv/DuEc9X1eFpvsBZ/rFiRMb3zz4qt11zZXSJu5/hnZEWVjsloEq2A==;\n\t24:J+vbrK5jwGu6aADuWltaHNWFc6bGaRIDmeNL9RVyIjcbFSikOZVp8mIRhz7zzIu79Gj9grEzdfHJcbT4qjyenvI26v9kGw6LJutbvuLhV74=;\n\t7:DSfY/FW8lbV6Ob5bWiMxmYFMq2dzgg2lc9fJqWxlviWaG9w2XRzRmM54gHT4lWDNcdDg3qV/jdM6PWiGdcpnDPcTgTvvzODQ36gefLGzqIfO0PYnNcHwpcIbttiO+ktz+vBcColH0EXnVhjTF3aKbMlZi+aAML/CDsfm7qtuYQlvVPVdy5vshJZrTG1zjp5yhECp3mInFEMJCqc7N1W/Hh66UnynCkS324izO0D+nlE="],"X-MS-TrafficTypeDiagnostic":"HE1PR05MB1803:","X-Exchange-Antispam-Report-Test":"UriScan:(198206253151910);","X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123560025)(20161123555025)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:HE1PR05MB1803; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:HE1PR05MB1803; ","X-Forefront-PRVS":"041963B986","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10009020)(7370300001)(4630300001)(6049001)(6009001)(39860400002)(199003)(377454003)(189002)(24454002)(106356001)(23676002)(101416001)(76176999)(77096006)(50986999)(54356999)(6246003)(2906002)(105586002)(97736004)(7350300001)(36756003)(6486002)(25786009)(6116002)(3846002)(229853002)(83506001)(230700001)(4001350100001)(4326008)(478600001)(33646002)(86362001)(53546010)(8676002)(31686004)(47776003)(65806001)(66066001)(5660300001)(65956001)(50466002)(6666003)(31696002)(2950100002)(68736007)(305945005)(189998001)(42186005)(64126003)(81166006)(81156014)(7736002)(65826007)(53936002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR05MB1803; H:[10.8.2.253];\n\tFPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"Mellanox.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"03 Sep 2017 07:19:58.7971\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"HE1PR05MB1803","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1762315,"web_url":"http://patchwork.ozlabs.org/comment/1762315/","msgid":"<20170903.105732.1712307481321249919.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-03T17:57:32","subject":"Re: [PATCH][next] net/mlx4_core: fix memory leaks on error exit path","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Colin King \nDate: Thu, 31 Aug 2017 17:30:53 +0100\n\n> From: Colin Ian King \n> \n> The structures hca_param and func_cap are not being kfree'd on an error\n> exit path causing two memory leaks. Fix this by jumping to the existing\n> free memory error exit path.\n> \n> Detected by CoverityScan, CID#1455219, CID#1455224 (\"Resource Leak\")\n> \n> Fixes: c73c8b1e47ca (\"net/mlx4_core: Dynamically allocate structs at mlx4_slave_cap\")\n> Signed-off-by: Colin Ian King \n\nApplied.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlggd2JvGz9t3f\n\tfor ;\n\tMon, 4 Sep 2017 03:58:05 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753177AbdICR5f (ORCPT );\n\tSun, 3 Sep 2017 13:57:35 -0400","from shards.monkeyblade.net ([184.105.139.130]:56372 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753061AbdICR5d (ORCPT\n\t); Sun, 3 Sep 2017 13:57:33 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 32ED511D698A7;\n\tSun, 3 Sep 2017 10:57:33 -0700 (PDT)"],"Date":"Sun, 03 Sep 2017 10:57:32 -0700 (PDT)","Message-Id":"<20170903.105732.1712307481321249919.davem@davemloft.net>","To":"colin.king@canonical.com","Cc":"tariqt@mellanox.com, netdev@vger.kernel.org,\n\tlinux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH][next] net/mlx4_core: fix memory leaks on error exit path","From":"David Miller ","In-Reply-To":"<20170831163053.2349-1-colin.king@canonical.com>","References":"<20170831163053.2349-1-colin.king@canonical.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Sun, 03 Sep 2017 10:57:33 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]