[{"id":1761203,"web_url":"http://patchwork.ozlabs.org/comment/1761203/","msgid":"<59A842D6.3010907@arm.com>","list_archive_url":null,"date":"2017-08-31T17:09:42","subject":"Re: [PATCH][aarch64] Change argument type passed to ifunc resolvers","submitter":{"id":65667,"url":"http://patchwork.ozlabs.org/api/people/65667/","name":"Szabolcs Nagy","email":"szabolcs.nagy@arm.com"},"content":"On 31/08/17 17:00, Steve Ellcey wrote:\n> This is a one line patch split out from:\n> \n> https://sourceware.org/ml/libc-alpha/2017-08/msg01310.html\n> \n> It just changes the type of the argument passed to ifunc resolvers from\n> 'unsigned int long' to 'uint64_t'. This should make no difference for\n> the existing LP64 ABI but will also work for the new ILP32 ABI. I\n> would like to check this in before submitting a patch to GCC that uses\n> IFUNCs in libatomic so that the types agree.\n> \n> Tested on aarch64, OK to checkin?\n> \n\nOK for master.\n\n> Steve Ellcey\n> sellcey@cavium.com\n> \n> \n> \n> 2017-08-31 Steve Ellcey \n> \n> \t* sysdeps/aarch64/dl-irel.h: (elf_ifunc_invoke): Change argument type\n> \tin resolver call.\n> \n> \n> diff --git a/sysdeps/aarch64/dl-irel.h b/sysdeps/aarch64/dl-irel.h\n> index 4a80275..a794c82 100644\n> --- a/sysdeps/aarch64/dl-irel.h\n> +++ b/sysdeps/aarch64/dl-irel.h\n> @@ -31,7 +31,7 @@ static inline ElfW(Addr)\n> __attribute ((always_inline))\n> elf_ifunc_invoke (ElfW(Addr) addr)\n> {\n> - return ((ElfW(Addr) (*) (unsigned long int)) (addr)) (GLRO(dl_hwcap));\n> + return ((ElfW(Addr) (*) (uint64_t)) (addr)) (GLRO(dl_hwcap));\n> }\n> \n> static inline void\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-83988-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"xoNyrpus\"; dkim-atps=neutral","sourceware.org; auth=none","spf=none (sender IP is )\n\tsmtp.mailfrom=Szabolcs.Nagy@arm.com; "],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjpm96G5nz9s81\n\tfor ;\n\tFri, 1 Sep 2017 03:10:33 +1000 (AEST)","(qmail 129183 invoked by alias); 31 Aug 2017 17:10:01 -0000","(qmail 129085 invoked by uid 89); 31 Aug 2017 17:10:00 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:message-id:date:from:mime-version:to:cc\n\t:subject:references:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=YmWc2DUjee/I7aPL\n\tU69WGK8kfLtfEplh6ISxEbGr9V/QbZ0CT+kzu4QEyhD+KcVZ0PclyyQI8WixCpdU\n\tM5tOeAd5KlH5Rtzqd94FKID4Fi2gjhb+qQaYeVTa8qc99bWfW49Oz7Dil9KtPerd\n\tFeG0WHMfZ2Utsp47tAuqbRzyfS0=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:message-id:date:from:mime-version:to:cc\n\t:subject:references:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=XYsepkXLS50kw+gMrWgUR9\n\tiGvSM=; b=xoNyrpusEuotc72hAZ0TJxHaJz6KYVXrBpWIgm1YVeNysbbESEu1tL\n\tsB7HMASRnRp30lg8CDUJHDOhz5EaukB6Pf2sQfNpUG8es4M7jwM6RYEi4X7LUD2n\n\tJAA0L1e+3ZeyGdg8W9ZB2cAY4kpW+N/OBx9u/S2cIzhLD9v8ctU5g=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-24.6 required=5.0 tests=AWL, BAYES_00,\n\tGIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3,\n\tRCVD_IN_DNSWL_NONE, SPF_HELO_PASS,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"EUR03-VE1-obe.outbound.protection.outlook.com","Message-ID":"<59A842D6.3010907@arm.com>","Date":"Thu, 31 Aug 2017 18:09:42 +0100","From":"Szabolcs Nagy ","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:31.0) Gecko/20100101 Thunderbird/31.8.0","MIME-Version":"1.0","To":"sellcey@cavium.com, libc-alpha ","CC":"nd@arm.com","Subject":"Re: [PATCH][aarch64] Change argument type passed to ifunc resolvers","References":"<1504195258.3182.13.camel@cavium.com>","In-Reply-To":"<1504195258.3182.13.camel@cavium.com>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"HE1PR0301CA0012.eurprd03.prod.outlook.com\n\t(2603:10a6:3:76::22) To AM5PR0802MB2484.eurprd08.prod.outlook.com\n\t(2603:10a6:203:9b::23)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"0ff5befb-a158-4828-7e79-08d4f093157f","X-MS-Office365-Filtering-HT":"Tenant","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:AM5PR0802MB2484; ","X-Microsoft-Exchange-Diagnostics":["1; AM5PR0802MB2484;\n\t3:Cu3zaWZ/S2UurTXG5wJMu6vZsKXZOV129hk+jrbzi55TQyEQmkMXRZ/KpTMqK94gE64Zsk8cDQ8aMBeywKnXlViz1paifMsbj74RXr3q1Fyg/14at2H+8c8lvxP3kqk52qtGL2li0DqjrcWf3R63TCak/aL5kT40igLu/8Koy7Sg5AA76VeiaTk5e96+VAsYVxy351MkOJSva2TMS/9vj8Xhq5XjiEF6VCS8aoTpC1RZ8EJCF8qg7+L5jT+gSRmk;\n\t25:qHX0tVs4ruJVUH1GT/eVFCKa4aASAPZoDAGYKE8TkU4Ng0hHf8oXfqdqZOFQnme5jIZEt+MvkjsYjQRE61WGo0d7hHCWfTkpWKvRFlQ+jRIm0YUP+JRupFyPIHKxqw1KkbLMj28tvP8GaLwUKzMbXNpD2rEBpB9V2XdAS+zpOuia+Nzp3pnxmRomiTaYSslo6tQTNq/oH/ilzmFObl95ClDRD9Ze6xlvIAQLclheaF4wH2qaMBhpBuYWgot6+w4/EJy4hEk8/CUvF7QZ2BrukBgQSgmQPacISZt+JKZZDytNL3FbiGAuoIYR/VK/dLAJsteq8pCKfs9iclHpM7Jlhg==;\n\t31:VL2nGbIIRKpKkjouJRJSaesAWHVrWxbHFxM9g6GiX072MW+A+8b8jVyphIkduJWNrbz7In2EIO6PevmkkWaldYJUeIb8+S0Mys+jGHF1rYLNQ9UaYv1vl3Dtx8OY2B0RlVyWprthP6MwQfF3V56SVGn5YIAhcA7EuWS2zf6ZjT++eQrCtxnIUj1jjQsriUgPawsRGkyyWxQJXeh5B47rZsyXpyms8c5aF+IYjX3AGOI=","1; AM5PR0802MB2484;\n\t20:UkYc2gXmdTd5S/vMya5Q6ZOF7pdBFVEoW2A98+IP5dLPgAeDmrlpQzSy4RqYRigecruUgl/55oxsg7HE69VZOPR3BiMFD5u8T8M5uqlefk3Ye11mZ3k95kn+zM9EupyEHCc2ejmrgeU7p63JKaBlU13rQQsmUHm3jcKG7bMbCD4=;\n\t4:IpTPOwdGoxf5tml+xvuxRZ1sMHl7IO6rZvRM5Th0b+gNJYQCvnDTOKCKT59/Vr6MezvQ35b4AWj5+9Vx7d4n0304SANhZRNjTxZ7sarSXfa7HPBlBIul9ctoPw/nZnKxYcCZaNIW1a61MfRrR7qL0lC4RvYOmWGMQPYOdBrjZJ2mD/gNNHgoey//0DL8wrruxapBd7xm36XemE6ZXwerpuWrII+FSezPaKagfpX9qLaL5KkCYbBB+fg1CZnMjEmu","=?utf-8?q?1=3BAM5PR0802MB2484=3B23=3AiS?=\n\t=?utf-8?q?u+KuYiAzNmlSdG8EtEsbBk546zwCl0rlJtVReCObBlgEvtKuQqWhBDHG?=\n\t=?utf-8?q?TlWu+hxTPPF58uzWi9ufBM0OiWfH5yo0UJuL4fGjre3R4VrvQXkUGJwm?=\n\t=?utf-8?q?P6C6vBKmE8+EtH//FO2YPWRF1DEUx0/78tcMPBKewYQAhhU2DV4/WW85?=\n\t=?utf-8?q?X8LaT+SjPw2Mql8YEz/6HoiAj4Na6NnTvRotp25Vms5bBOa4gY7gxVDS?=\n\t=?utf-8?q?GI/B2FfN7+7UTjwEeQm96Rvln8nOyogY5DiFZaf96PG3avafLdFcqo9O?=\n\t=?utf-8?q?wrvkAcnpILCtn7jVXMydoyjWsoGsETHpun/iIWn3OBhLl/8GQZXhKNYu?=\n\t=?utf-8?q?q3+llo78PRoQh/RfMBmnEVzrHVtZ+n9f/MOEyEKFceuiJRC805cNEE1c?=\n\t=?utf-8?q?ju2GVanR6ROEkvRVfUzxW5TA6wQ8aXWCzbmFtdvQeI2BpkgHlR4duUga?=\n\t=?utf-8?q?xvz4st6f1ktociT+l1i3cuPa0cC6zps/lPdNFth6o8GjOcdNZfXkdE1Y?=\n\t=?utf-8?q?P+Qdk8PuWwnPaQ2hzu2esOjBFEtrnBMnaO07sWWJte7R77huMvVPMBWD?=\n\t=?utf-8?q?osuEQQuRUWnlYO8TjqeU9XHJLaGOM2RFMzjBWOldgWQlYTrqFqzbVdjr?=\n\t=?utf-8?q?G4766yfdi02jPmD14aBpMCKMXrLwuWS1jhA0tsECJNsh7KLX8IYFCm/b?=\n\t=?utf-8?q?zU9pK3tHj/i+7ro4iqWZ1Uu4f+tqv1zxj4Ua5UXflGK17yuEUgFfSaJR?=\n\t=?utf-8?q?z8DYLXYqiHjA6o8Md70zIfSAu4eBop10QHiNqeqB6Y25mT5LI6nOsWRb?=\n\t=?utf-8?q?kPPh5i6d5Nn/+QXD1VShpYtf0sTRCBmp98z6M7iuWg5VHh04IWFEwOd+?=\n\t=?utf-8?q?pC6uj/R31kDf0eDgocxecE/D+/ne7IK7jyQHDnTjTlp0rsuaim9fKDyh?=\n\t=?utf-8?q?Y1+lazE6OVDeR7iDtvScoJ5kbfkwFpOH42udnojRaehvnCOkX1pzTLok?=\n\t=?utf-8?q?zSgo4pstE1MO4blHYjs87bFhzxMgZkCgEnBI30/txGxksN3yw8Qut8Sk?=\n\t=?utf-8?q?4fctREihrk0BtsjoeN1SpK0ZGbv985KNYEh8mNNt0GIbTU+TDsZTqJd+?=\n\t=?utf-8?q?LZH1b33zkONuyxvgAxhp20YgcIHu5gcgLmOFqzSPUyxsQMKCqWEQ00Jn?=\n\t=?utf-8?q?eWc7APaTcLv2G6DW2PMXrI815wUh1B5M2MpLuwqH9crd7rb8rCjzTeGL?=\n\t=?utf-8?q?MzyiDzW2bUP1JWligQmghCFgPSNLz0mZq2xtUa8RicjodLHRbd3JuGlg?=\n\t=?utf-8?q?81FUSlGAbyJJJ8qgz4a04qyd4Lg94tE0MIPVZgWUeej68T1cewvQGJ2s?=\n\t=?utf-8?q?eaJyfuLlPSFaGhQWS8kMjGci7rVZpZNy4YtrMQYjNQAxILX7SEe2CZPN?=\n\t=?utf-8?q?WyD0SxXlMlCrnoQl3W69vslhhM0sUSJOjNqZ3cXvfSL8PqjFt036yQFj?=\n\t=?utf-8?q?zy+a514itEY2ck5IswQZcwUjBjkG2f4DiPb4Y2mHY/LSx8s19TibymCr?=\n\t=?utf-8?q?8RriA23VXLIJey?=","1; AM5PR0802MB2484;\n\t6:hAcVDdxRhHayXjuqBuE7SfIviDshng1sa8RZDcK0EEHdjMlnzMn3r0Un2jTRaLz7NdKaCEujRXiN2sjNZcK1kJng3PY+7UwHzo5/woJ6gOEqA4QWEFV9oJJ8shMkwxBCH6NwSaRmCXg5ECDCqZpfTInie31uUtxNik8cAbRwBj1oyc8f0w3qgQASjFeUcEV1WmDM06lQxXcnZChv8HwuWpZbxXwzCVkngYnLVWlerlHQn3GOmYMBKpTsOHtRr1YNLRNOCCVhGtMu9lP+QjBZQ33K3gMQ5LGGXvLTUe3s5+S0xJfEcZitg456rr7GY9MBTzHljUp9IPHzta6HxbRKsg==;\n\t5:kYvXHxUubGe5pZZ8fXtxkTYj3nw0y9LqlP+DhwXpnR9QJKvxxVUkCCCdvJevuh1hlm8ZGkmlfV9YAb/GGXGfCnJs4lgLZJqhBdaGVjUiB2JPUGAAWeLmSNh4heJZwI+y/oqn98zXtk0GNdGcNXvmcQ==;\n\t24:pTnwMj09PITqQUdalIg+h7eC1I/zE0GRoNNJoCOlxAivsX1BHTfprEnHlWCmA7XQS+DV0WAiSZZ0JebLi21+MWGlpIEOO5byk+PHnZp2FcA=;\n\t7:YUKoibYBl61S5p4mZ7dBZtcLb6+TPzy8uWU90QlGUMSg0F72PWYKFr1wTUkIUf7D1gPIaeQhQ+END3eO+sV7h8wpr6WDARPHwy8hI0QAD5JJ5cKtQvHTeG+pi5ALSVgeQCsPsS9cUGAtzng7Rp2eT/aQX416VlCIV6UpViR1+xjnW9VA2sjRID9X60t4W6A766Ow9xEkiIj5zACIpfH8yhY+X7QE/MHRkGQbCPo7zaA="],"X-MS-TrafficTypeDiagnostic":"AM5PR0802MB2484:","NoDisclaimer":"True","X-Exchange-Antispam-Report-Test":"UriScan:;","X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123562025)(20161123564025)(20161123560025)(20161123558100)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:AM5PR0802MB2484; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:AM5PR0802MB2484; ","X-Forefront-PRVS":"04163EF38A","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10009020)(7370300001)(4630300001)(6009001)(6049001)(39860400002)(377424004)(189002)(199003)(24454002)(7736002)(6246003)(54356999)(87266999)(86362001)(59896002)(33656002)(50986999)(25786009)(305945005)(6486002)(80316001)(68736007)(66066001)(65956001)(189998001)(7350300001)(77096006)(76176999)(81156014)(53546010)(105586002)(101416001)(47776003)(6306002)(36756003)(81166006)(106356001)(6116002)(3846002)(65806001)(4326008)(478600001)(72206003)(966005)(2906002)(53936002)(65816999)(110136004)(5660300001)(42186005)(64126003)(83506001)(2950100002)(6666003)(97736004)(23676002)(229853002)(50466002)(4001350100001)(8676002)(6916009)(230700001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0802MB2484;\n\tH:[10.2.206.69]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1;\n\tLANG:en; ","Received-SPF":"None (protection.outlook.com: arm.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"arm.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"31 Aug 2017 17:09:47.1368\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AM5PR0802MB2484"}}]