[{"id":1761247,"web_url":"http://patchwork.ozlabs.org/comment/1761247/","msgid":"<81fb67fb-6d5c-b1ae-e544-e0d652218800@denx.de>","list_archive_url":null,"date":"2017-08-31T18:20:13","subject":"Re: [U-Boot] [PATCH v2] imx: imx7d: remove CamelCase from ENET_xMHz\n\tmacros","submitter":{"id":5771,"url":"http://patchwork.ozlabs.org/api/people/5771/","name":"Stefano Babic","email":"sbabic@denx.de"},"content":"Hi Eric,\n\nOn 31/08/2017 17:34, Eric Nelson wrote:\n> Update these macros to use all upper-case to avoid checkpatch\n> warnings:\n> \n> \tENET_25MHz,\n> \tENET_50MHz,\n> \tENET_125MHz,\n> \n> Signed-off-by: Eric Nelson \n> ---\n> V2 fixes a couple of references in mx7/clock.c\n> arch/arm/include/asm/arch-mx7/clock.h | 6 +++---\n> arch/arm/mach-imx/mx7/clock.c | 6 +++---\n> board/freescale/mx7dsabresd/mx7dsabresd.c | 2 +-\n> board/technexion/pico-imx7d/pico-imx7d.c | 2 +-\n> board/toradex/colibri_imx7/colibri_imx7.c | 2 +-\n> 5 files changed, 9 insertions(+), 9 deletions(-)\n> \n> diff --git a/arch/arm/include/asm/arch-mx7/clock.h b/arch/arm/include/asm/arch-mx7/clock.h\n> index 688d236..3b115ad 100644\n> --- a/arch/arm/include/asm/arch-mx7/clock.h\n> +++ b/arch/arm/include/asm/arch-mx7/clock.h\n> @@ -318,9 +318,9 @@ struct clk_root_map {\n> };\n> \n> enum enet_freq {\n> -\tENET_25MHz,\n> -\tENET_50MHz,\n> -\tENET_125MHz,\n> +\tENET_25MHZ,\n> +\tENET_50MHZ,\n> +\tENET_125MHZ,\n> };\n> \n> u32 get_root_clk(enum clk_root_index clock_id);\n> diff --git a/arch/arm/mach-imx/mx7/clock.c b/arch/arm/mach-imx/mx7/clock.c\n> index 2cfde46..8150faa 100644\n> --- a/arch/arm/mach-imx/mx7/clock.c\n> +++ b/arch/arm/mach-imx/mx7/clock.c\n> @@ -966,15 +966,15 @@ int set_clk_enet(enum enet_freq type)\n> \tclock_enable(CCGR_ENET2, 0);\n> \n> \tswitch (type) {\n> -\tcase ENET_125MHz:\n> +\tcase ENET_125MHZ:\n> \t\tenet1_ref = ENET1_REF_CLK_ROOT_FROM_PLL_ENET_MAIN_125M_CLK;\n> \t\tenet2_ref = ENET2_REF_CLK_ROOT_FROM_PLL_ENET_MAIN_125M_CLK;\n> \t\tbreak;\n> -\tcase ENET_50MHz:\n> +\tcase ENET_50MHZ:\n> \t\tenet1_ref = ENET1_REF_CLK_ROOT_FROM_PLL_ENET_MAIN_50M_CLK;\n> \t\tenet2_ref = ENET2_REF_CLK_ROOT_FROM_PLL_ENET_MAIN_50M_CLK;\n> \t\tbreak;\n> -\tcase ENET_25MHz:\n> +\tcase ENET_25MHZ:\n> \t\tenet1_ref = ENET1_REF_CLK_ROOT_FROM_PLL_ENET_MAIN_25M_CLK;\n> \t\tenet2_ref = ENET2_REF_CLK_ROOT_FROM_PLL_ENET_MAIN_25M_CLK;\n> \t\tbreak;\n> diff --git a/board/freescale/mx7dsabresd/mx7dsabresd.c b/board/freescale/mx7dsabresd/mx7dsabresd.c\n> index a681ece..5819b18 100644\n> --- a/board/freescale/mx7dsabresd/mx7dsabresd.c\n> +++ b/board/freescale/mx7dsabresd/mx7dsabresd.c\n> @@ -260,7 +260,7 @@ static int setup_fec(void)\n> \t\t(IOMUXC_GPR_GPR1_GPR_ENET1_TX_CLK_SEL_MASK |\n> \t\t IOMUXC_GPR_GPR1_GPR_ENET1_CLK_DIR_MASK), 0);\n> \n> -\treturn set_clk_enet(ENET_125MHz);\n> +\treturn set_clk_enet(ENET_125MHZ);\n> }\n> \n> \n> diff --git a/board/technexion/pico-imx7d/pico-imx7d.c b/board/technexion/pico-imx7d/pico-imx7d.c\n> index b4c9be7..67bab51 100644\n> --- a/board/technexion/pico-imx7d/pico-imx7d.c\n> +++ b/board/technexion/pico-imx7d/pico-imx7d.c\n> @@ -182,7 +182,7 @@ static int setup_fec(void)\n> \t\t\t(IOMUXC_GPR_GPR1_GPR_ENET1_TX_CLK_SEL_MASK |\n> \t\t\tIOMUXC_GPR_GPR1_GPR_ENET1_CLK_DIR_MASK), 0);\n> \n> -\treturn set_clk_enet(ENET_125MHz);\n> +\treturn set_clk_enet(ENET_125MHZ);\n> }\n> \n> int board_phy_config(struct phy_device *phydev)\n> diff --git a/board/toradex/colibri_imx7/colibri_imx7.c b/board/toradex/colibri_imx7/colibri_imx7.c\n> index 5cb14b4..13b2b57 100644\n> --- a/board/toradex/colibri_imx7/colibri_imx7.c\n> +++ b/board/toradex/colibri_imx7/colibri_imx7.c\n> @@ -280,7 +280,7 @@ static int setup_fec(void)\n> \t\t\tIOMUXC_GPR_GPR1_GPR_ENET1_TX_CLK_SEL_MASK);\n> #endif\n> \n> -\treturn set_clk_enet(ENET_50MHz);\n> +\treturn set_clk_enet(ENET_50MHZ);\n> }\n> \n> int board_phy_config(struct phy_device *phydev)\n> \n\n\nReviewed-by: Stefano Babic \n\nBest regards,\nStefano Babic","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjrKF2kj2z9s7c\n\tfor ;\n\tFri, 1 Sep 2017 04:20:49 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid A099EC21EAB; Thu, 31 Aug 2017 18:20:43 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 6AAFFC21D7B;\n\tThu, 31 Aug 2017 18:20:41 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 60E41C21EAB; Thu, 31 Aug 2017 18:20:28 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9])\n\tby lists.denx.de (Postfix) with ESMTPS id 6E02FC21E30\n\tfor ; Thu, 31 Aug 2017 18:20:28 +0000 (UTC)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xjrJq603Jz1rpL1;\n\tThu, 31 Aug 2017 20:20:27 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xjrJq3glLz3hhTk;\n\tThu, 31 Aug 2017 20:20:27 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id gdC7zWnalISq; Thu, 31 Aug 2017 20:20:25 +0200 (CEST)","from babic.homelinux.org (host-88-217-136-221.customer.m-online.net\n\t[88.217.136.221])\n\t(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPS;\n\tThu, 31 Aug 2017 20:20:25 +0200 (CEST)","from localhost (mail.babic.homelinux.org [127.0.0.1])\n\tby babic.homelinux.org (Postfix) with ESMTP id B8ED04540507;\n\tThu, 31 Aug 2017 20:20:24 +0200 (CEST)","from babic.homelinux.org ([127.0.0.1])\n\tby localhost (mail.babic.homelinux.org [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id leIsz2lTeOWl; Thu, 31 Aug 2017 20:20:14 +0200 (CEST)","from [192.168.178.89] (stefano-MacBookPro.fritz.box\n\t[192.168.178.89])\n\tby babic.homelinux.org (Postfix) with ESMTPS id ACD114540376;\n\tThu, 31 Aug 2017 20:20:13 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":["amavisd-new at mnet-online.de","Debian amavisd-new at babic.homelinux.org"],"To":"Eric Nelson , u-boot@lists.denx.de","References":"<1504132162-25617-1-git-send-email-eric@nelint.com>\n\t<1504193663-3903-1-git-send-email-eric@nelint.com>","From":"Stefano Babic ","Message-ID":"<81fb67fb-6d5c-b1ae-e544-e0d652218800@denx.de>","Date":"Thu, 31 Aug 2017 20:20:13 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<1504193663-3903-1-git-send-email-eric@nelint.com>","Content-Language":"en-US","Cc":"stefan.agner@toradex.com, adrian.alonso@nxp.com, vanessa.maegima@nxp.com,\n\tfabio.estevam@nxp.com","Subject":"Re: [U-Boot] [PATCH v2] imx: imx7d: remove CamelCase from ENET_xMHz\n\tmacros","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1771854,"web_url":"http://patchwork.ozlabs.org/comment/1771854/","msgid":"","list_archive_url":null,"date":"2017-09-20T13:37:34","subject":"Re: [U-Boot] [PATCH v2] imx: imx7d: remove CamelCase from ENET_xMHz\n\tmacros","submitter":{"id":5771,"url":"http://patchwork.ozlabs.org/api/people/5771/","name":"Stefano Babic","email":"sbabic@denx.de"},"content":"On 31/08/2017 17:34, Eric Nelson wrote:\n> Update these macros to use all upper-case to avoid checkpatch\n> warnings:\n> \n> \tENET_25MHz,\n> \tENET_50MHz,\n> \tENET_125MHz,\n> \n> Signed-off-by: Eric Nelson \n> ---\n\nApplied to u-boot-imx, thanks !\n\nBest regards,\nStefano Babic","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xy15k4rrYz9s7c\n\tfor ;\n\tWed, 20 Sep 2017 23:38:02 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 74489C21E2C; Wed, 20 Sep 2017 13:38:00 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 6D93DC21EAE;\n\tWed, 20 Sep 2017 13:37:55 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 8AB20C21F38; Wed, 20 Sep 2017 13:37:41 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10])\n\tby lists.denx.de (Postfix) with ESMTPS id 3373DC21F05\n\tfor ; Wed, 20 Sep 2017 13:37:41 +0000 (UTC)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xy15J2kBwz1qw7h;\n\tWed, 20 Sep 2017 15:37:40 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xy15J1xz0z1r0wp;\n\tWed, 20 Sep 2017 15:37:40 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id H8z8B2V9xb8x; Wed, 20 Sep 2017 15:37:37 +0200 (CEST)","from babic.homelinux.org (host-88-217-136-221.customer.m-online.net\n\t[88.217.136.221])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPS;\n\tWed, 20 Sep 2017 15:37:37 +0200 (CEST)","from localhost (mail.babic.homelinux.org [127.0.0.1])\n\tby babic.homelinux.org (Postfix) with ESMTP id 728DE45406A6;\n\tWed, 20 Sep 2017 15:37:37 +0200 (CEST)","from babic.homelinux.org ([127.0.0.1])\n\tby localhost (mail.babic.homelinux.org [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id PRh4gBai7HDu; Wed, 20 Sep 2017 15:37:34 +0200 (CEST)","from [192.168.178.132] (papero.fritz.box [192.168.178.132])\n\tby babic.homelinux.org (Postfix) with ESMTP id 7C30B454055D;\n\tWed, 20 Sep 2017 15:37:34 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":["amavisd-new at mnet-online.de","Debian amavisd-new at babic.homelinux.org"],"To":"Eric Nelson , u-boot@lists.denx.de","References":"<1504132162-25617-1-git-send-email-eric@nelint.com>\n\t<1504193663-3903-1-git-send-email-eric@nelint.com>","From":"Stefano Babic ","Message-ID":"","Date":"Wed, 20 Sep 2017 15:37:34 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1504193663-3903-1-git-send-email-eric@nelint.com>","Content-Language":"de-DE","Cc":"stefan.agner@toradex.com, adrian.alonso@nxp.com, vanessa.maegima@nxp.com,\n\tfabio.estevam@nxp.com","Subject":"Re: [U-Boot] [PATCH v2] imx: imx7d: remove CamelCase from ENET_xMHz\n\tmacros","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]