[{"id":1761146,"web_url":"http://patchwork.ozlabs.org/comment/1761146/","msgid":"<5aa15941-49fc-1cc3-941e-d715333df704@redhat.com>","list_archive_url":null,"date":"2017-08-31T16:02:53","subject":"Re: [Qemu-devel] [PATCH v2 3/5] qapi: Use OrderedDict from standard\n\tlibrary if available","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 08/31/2017 09:24 AM, Daniel P. Berrange wrote:\n> The OrderedDict class appeared in the 'collections' module\n> from python 2.7 onwards, so use that in preference to our\n> local backport if available.\n\nSince we're now using argparse.py as a third-party import (commit\n47e1cb1f) also for the sake of 2.6, can we treat ordereddict.py as the\nsame sort of third-party import?\n\n> \n> Signed-off-by: Daniel P. Berrange \n> ---\n> scripts/qapi.py | 5 ++++-\n> 1 file changed, 4 insertions(+), 1 deletion(-)\n> \n> diff --git a/scripts/qapi.py b/scripts/qapi.py\n> index d89af7d6c6..05cb1ee38c 100644\n> --- a/scripts/qapi.py\n> +++ b/scripts/qapi.py\n> @@ -18,7 +18,10 @@ import os\n> import re\n> import string\n> import sys\n> -from ordereddict import OrderedDict\n> +try:\n> + from collections import OrderedDict\n> +except:\n> + from ordereddict import OrderedDict\n> \n> builtin_types = {\n> 'null': 'QTYPE_QNULL',\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjnLd01cGz9sD9\n\tfor ;\n\tFri, 1 Sep 2017 02:06:49 +1000 (AEST)","from localhost ([::1]:56574 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnRzT-0006mu-0b\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 12:06:47 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44062)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnRvy-0004PA-Tk\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 12:03:15 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnRvp-0001g8-HL\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 12:03:10 -0400","from mx1.redhat.com ([209.132.183.28]:40578)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnRvp-0001fM-7k\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 12:03:01 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 410E1C0467C4;\n\tThu, 31 Aug 2017 16:02:58 +0000 (UTC)","from [10.10.122.186] (ovpn-122-186.rdu2.redhat.com [10.10.122.186])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id CC69980A88;\n\tThu, 31 Aug 2017 16:02:53 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 410E1C0467C4","To":"\"Daniel P. Berrange\" , qemu-devel@nongnu.org","References":"<20170831142430.16665-1-berrange@redhat.com>\n\t<20170831142430.16665-4-berrange@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<5aa15941-49fc-1cc3-941e-d715333df704@redhat.com>","Date":"Thu, 31 Aug 2017 11:02:53 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170831142430.16665-4-berrange@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"V8MvJboOcaGdDUiVoB2SkoSVThfF0Hu4j\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tThu, 31 Aug 2017 16:02:58 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v2 3/5] qapi: Use OrderedDict from standard\n\tlibrary if available","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Markus Armbruster ,\n\tMichael Roth ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]