[{"id":1762056,"web_url":"http://patchwork.ozlabs.org/comment/1762056/","msgid":"<20170901.183540.2023957151661748902.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-02T01:35:40","subject":"Re: [PATCH] ipv6: sr: Use ARRAY_SIZE macro","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Thomas Meyer \nDate: Thu, 31 Aug 2017 16:18:15 +0200\n\n> Grepping for \"sizeof\\(.+\\) / sizeof\\(\" found this as one of the first\n> candidates.\n> Maybe a coccinelle can catch all of those.\n> \n> Signed-off-by: Thomas Meyer \n\nApplied, thanks.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkdwn5Xl9z9sPm\n\tfor ;\n\tSat, 2 Sep 2017 11:35:53 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752360AbdIBBfm (ORCPT );\n\tFri, 1 Sep 2017 21:35:42 -0400","from shards.monkeyblade.net ([184.105.139.130]:56596 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751411AbdIBBfl (ORCPT\n\t); Fri, 1 Sep 2017 21:35:41 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id DB8A513408B2D;\n\tFri, 1 Sep 2017 18:35:40 -0700 (PDT)"],"Date":"Fri, 01 Sep 2017 18:35:40 -0700 (PDT)","Message-Id":"<20170901.183540.2023957151661748902.davem@davemloft.net>","To":"thomas@m3y3r.de","Cc":"netdev@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH] ipv6: sr: Use ARRAY_SIZE macro","From":"David Miller ","In-Reply-To":"<20170831141815.28003-1-thomas@m3y3r.de>","References":"<20170831141815.28003-1-thomas@m3y3r.de>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Fri, 01 Sep 2017 18:35:41 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1762081,"web_url":"http://patchwork.ozlabs.org/comment/1762081/","msgid":"<1504324315.2361.25.camel@perches.com>","list_archive_url":null,"date":"2017-09-02T03:51:55","subject":"Re: [PATCH] ipv6: sr: Use ARRAY_SIZE macro","submitter":{"id":771,"url":"http://patchwork.ozlabs.org/api/people/771/","name":"Joe Perches","email":"joe@perches.com"},"content":"On Fri, 2017-09-01 at 18:35 -0700, David Miller wrote:\n> From: Thomas Meyer \n> Date: Thu, 31 Aug 2017 16:18:15 +0200\n> \n> > Grepping for \"sizeof\\(.+\\) / sizeof\\(\" found this as one of the first\n> > candidates.\n> > Maybe a coccinelle can catch all of those.\n\nUmm: try scripts/coccinelle/misc/array_size.cocci\n\nUntil then, maybe a perl script?\n\n$ git grep --name-only sizeof.*/.*sizeof drivers/net | \\\n xargs perl -p -i -e 's/\\bsizeof\\s*\\(\\s*(\\w+)\\s*\\)\\s*\\/\\s*sizeof\\s*\\(\\s*\\1\\s*\\[\\s*0\\s*\\]\\s*\\)/ARRAY_SIZE(\\1)/g'\n\ngives:\n\n$ git diff --stat drivers/net\n drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c                   |   2 +-\n drivers/net/ethernet/mellanox/mlx4/fw.c                         |   4 +--\n drivers/net/ethernet/mellanox/mlx4/main.c                       |   8 +++---\n drivers/net/wireless/ath/ath9k/ar9003_eeprom.c                  |   2 +-\n drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_n.c | 186 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------------------------------------\n 5 files changed, 101 insertions(+), 101 deletions(-)","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkhy42Fr8z9s7c\n\tfor ;\n\tSat, 2 Sep 2017 13:52:12 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752158AbdIBDv7 (ORCPT );\n\tFri, 1 Sep 2017 23:51:59 -0400","from smtprelay0173.hostedemail.com ([216.40.44.173]:36485 \"EHLO\n\tsmtprelay.hostedemail.com\" rhost-flags-OK-OK-OK-FAIL)\n\tby vger.kernel.org with ESMTP id S1750941AbdIBDv6 (ORCPT\n\t); Fri, 1 Sep 2017 23:51:58 -0400","from filter.hostedemail.com (clb03-v110.bra.tucows.net\n\t[216.40.38.60])\n\tby smtprelay01.hostedemail.com (Postfix) with ESMTP id 79E87100E6DCD; \n\tSat, 2 Sep 2017 03:51:57 +0000 (UTC)","from XPS-9350 (cpe-23-242-70-174.socal.res.rr.com [23.242.70.174])\n\t(Authenticated sender: joe@perches.com)\n\tby omf04.hostedemail.com (Postfix) with ESMTPA;\n\tSat, 2 Sep 2017 03:51:56 +0000 (UTC)"],"X-Session-Marker":"6A6F6540706572636865732E636F6D","X-Spam-Summary":"2, 0, 0, , d41d8cd98f00b204, joe@perches.com, :::::::,\n\tRULES_HIT:41:69:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3866:4321:5007:6119:7576:7903:10004:10400:10848:10967:11232:11658:11783:11889:11914:12043:12291:12485:12555:12679:12683:12690:12737:12740:12895:13069:13311:13357:13439:13894:14095:14181:14659:14721:14879:21080:21451:21627:30054:30055:30090:30091,\n\t0, RBL:none, CacheIP:none, Bayesian:0.5, 0.5, 0.5,\n\tNetcheck:none, DomainCache:0, MSF:not bulk, SPF:, MSBL:0,\n\tDNSBL:none, Custom_rules:0:0:0, LFtime:1, LUA_SUMMARY:none","X-HE-Tag":"note58_2e1221af63a4c","X-Filterd-Recvd-Size":"1973","Message-ID":"<1504324315.2361.25.camel@perches.com>","Subject":"Re: [PATCH] ipv6: sr: Use ARRAY_SIZE macro","From":"Joe Perches ","To":"David Miller , thomas@m3y3r.de","Cc":"netdev@vger.kernel.org, linux-kernel@vger.kernel.org","Date":"Fri, 01 Sep 2017 20:51:55 -0700","In-Reply-To":"<20170901.183540.2023957151661748902.davem@davemloft.net>","References":"<20170831141815.28003-1-thomas@m3y3r.de>\n\t<20170901.183540.2023957151661748902.davem@davemloft.net>","Content-Type":"text/plain; charset=\"ISO-8859-1\"","X-Mailer":"Evolution 3.22.6-1ubuntu1 ","Mime-Version":"1.0","Content-Transfer-Encoding":"8bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1762089,"web_url":"http://patchwork.ozlabs.org/comment/1762089/","msgid":"<20170902062402.akr7m6zauo6a3xyd@olymp>","list_archive_url":null,"date":"2017-09-02T06:24:02","subject":"Re: [PATCH] ipv6: sr: Use ARRAY_SIZE macro","submitter":{"id":10277,"url":"http://patchwork.ozlabs.org/api/people/10277/","name":"Thomas Meyer","email":"thomas@m3y3r.de"},"content":"On Fri, Sep 01, 2017 at 08:51:55PM -0700, Joe Perches wrote:\n> On Fri, 2017-09-01 at 18:35 -0700, David Miller wrote:\n> > From: Thomas Meyer \n> > Date: Thu, 31 Aug 2017 16:18:15 +0200\n> > \n> > > Grepping for \"sizeof\\(.+\\) / sizeof\\(\" found this as one of the first\n> > > candidates.\n> > > Maybe a coccinelle can catch all of those.\n> \nHi,\n\n> Umm: try scripts/coccinelle/misc/array_size.cocci\n\nYes, I found out/remembered after I submitted above patch... I used to\nrun most of the cocci spatches (some just run too long) after each rc1 release, but lost interest/time. nobody seems to\ndo this regularly, at least for existing spatches.\n\nSee 6 patches with Message-ID 20170901212907.5662-1-thomas@m3y3r.de\n\n> Until then, maybe a perl script?\n> \n> $ git grep --name-only sizeof.*/.*sizeof drivers/net | \\\n> xargs perl -p -i -e 's/\\bsizeof\\s*\\(\\s*(\\w+)\\s*\\)\\s*\\/\\s*sizeof\\s*\\(\\s*\\1\\s*\\[\\s*0\\s*\\]\\s*\\)/ARRAY_SIZE(\\1)/g'\n> \n> gives:\n> \n> $ git diff --stat drivers/net\n>  drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c                   |   2 +-\n>  drivers/net/ethernet/mellanox/mlx4/fw.c                         |   4 +--\n>  drivers/net/ethernet/mellanox/mlx4/main.c                       |   8 +++---\n>  drivers/net/wireless/ath/ath9k/ar9003_eeprom.c                  |   2 +-\n>  drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_n.c | 186 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------------------------------------\n>  5 files changed, 101 insertions(+), 101 deletions(-)\n\nWhich makes me wonder why cocci didn't found above places...\nAlso cocci includes linux/kernel.h if not already present.\n\nI will give above regex a try for the whole kernel tree and check for\nfalse positives.\n\nwith kind regards\nthomas","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkmKg24frz9s7M\n\tfor ;\n\tSat, 2 Sep 2017 16:24:23 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751551AbdIBGYJ (ORCPT );\n\tSat, 2 Sep 2017 02:24:09 -0400","from www17.your-server.de ([213.133.104.17]:44304 \"EHLO\n\twww17.your-server.de\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751228AbdIBGYI (ORCPT\n\t); Sat, 2 Sep 2017 02:24:08 -0400","from [95.222.27.135] (helo=olymp)\n\tby www17.your-server.de with esmtpsa\n\t(TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.85_2)\n\t(envelope-from )\n\tid 1do1qg-00080P-Pw; Sat, 02 Sep 2017 08:24:06 +0200"],"Date":"Sat, 2 Sep 2017 08:24:02 +0200","From":"Thomas Meyer ","To":"Joe Perches ","Cc":"David Miller , netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH] ipv6: sr: Use ARRAY_SIZE macro","Message-ID":"<20170902062402.akr7m6zauo6a3xyd@olymp>","References":"<20170831141815.28003-1-thomas@m3y3r.de>\n\t<20170901.183540.2023957151661748902.davem@davemloft.net>\n\t<1504324315.2361.25.camel@perches.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<1504324315.2361.25.camel@perches.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","X-Authenticated-Sender":"thomas@m3y3r.de","X-Virus-Scanned":"Clear (ClamAV 0.99.2/23756/Sat Sep 2 06:39:20 2017)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]