[{"id":1761306,"web_url":"http://patchwork.ozlabs.org/comment/1761306/","msgid":"","list_archive_url":null,"date":"2017-08-31T20:34:20","subject":"Re: [PATCH][net-next] net: qualcomm: rmnet: remove unused variable\n\tpriv","submitter":{"id":65547,"url":"http://patchwork.ozlabs.org/api/people/65547/","name":"Subash Abhinov Kasiviswanathan","email":"subashab@codeaurora.org"},"content":"On 2017-08-31 08:07, Colin King wrote:\n> From: Colin Ian King \n> \n> priv is being assigned but is never used, so remove it.\n> \n> Cleans up clang build warning:\n> \"warning: Value stored to 'priv' is never read\"\n> \n> Fixes: ceed73a2cf4a (\"drivers: net: ethernet: qualcomm: rmnet: Initial\n> implementation\")\n> Signed-off-by: Colin Ian King \n> ---\n> drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 3 ---\n> 1 file changed, 3 deletions(-)\n> \n> diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c\n> b/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c\n> index c8b573d28dcf..bf7455fdafcc 100644\n> --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c\n> +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c\n> @@ -73,9 +73,6 @@ static const struct net_device_ops rmnet_vnd_ops = {\n> */\n> void rmnet_vnd_setup(struct net_device *rmnet_dev)\n> {\n> -\tstruct rmnet_priv *priv;\n> -\n> -\tpriv = netdev_priv(rmnet_dev);\n> \tnetdev_dbg(rmnet_dev, \"Setting up device %s\\n\", rmnet_dev->name);\n> \n> \trmnet_dev->netdev_ops = &rmnet_vnd_ops;\n\nThanks for fixing this.\n\nAcked-by: Subash Abhinov Kasiviswanathan ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=codeaurora.org header.i=@codeaurora.org\n\theader.b=\"hfhMxEX9\"; \n\tdkim=pass (1024-bit key) header.d=codeaurora.org\n\theader.i=@codeaurora.org header.b=\"Zmzk6DuY\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjvHw46vRz9s8P\n\tfor ;\n\tFri, 1 Sep 2017 06:34:52 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751415AbdHaUeY (ORCPT );\n\tThu, 31 Aug 2017 16:34:24 -0400","from smtp.codeaurora.org ([198.145.29.96]:37258 \"EHLO\n\tsmtp.codeaurora.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750968AbdHaUeW (ORCPT\n\t); Thu, 31 Aug 2017 16:34:22 -0400","by smtp.codeaurora.org (Postfix, from userid 1000)\n\tid 5BA226084D; Thu, 31 Aug 2017 20:34:21 +0000 (UTC)","from mail.codeaurora.org (localhost.localdomain [127.0.0.1])\n\tby smtp.codeaurora.org (Postfix) with ESMTP id A9FED6075A;\n\tThu, 31 Aug 2017 20:34:20 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1504211661;\n\tbh=UDYwZNBcJjK7n+qt694jQSVaFeIyp3EpO4lQxrpEFWw=;\n\th=Date:From:To:Cc:Subject:In-Reply-To:References:From;\n\tb=hfhMxEX9FWxIEu4ExaWcXuTQ5ouM+TCe704r1bWdImoi8NIDsX7hMQOp/unqAjY15\n\tID7uypjPr/6yULhpRHp7qZFc/I+3VCKA7WEHtACK8hPUpgn56RCK+5ktf/8IYCIVfb\n\tNggY/Oih/++VwAqf3PSQ/dLLxrzllsv2r+48TiLw=","v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1504211660;\n\tbh=UDYwZNBcJjK7n+qt694jQSVaFeIyp3EpO4lQxrpEFWw=;\n\th=Date:From:To:Cc:Subject:In-Reply-To:References:From;\n\tb=Zmzk6DuYMhIjjmg/ZNsiDlkWJfmiKY+c4zf7JfBLIEh2HpZ52+9kEcy1bGxm/Ibe8\n\tgwMl1Y8juN2dX6gDOJhfRBZult9WPGewLOCJTRyjNVX3Ljse3JoSTosOKLX0ndufGP\n\tZnwMyX2xUNHVqguBEWmtora5RY1cA1rllF7+X8yI="],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tpdx-caf-mail.web.codeaurora.org","X-Spam-Level":"","X-Spam-Status":"No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00,\n\tDKIM_SIGNED,\n\tT_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII;\n format=flowed","Content-Transfer-Encoding":"7bit","Date":"Thu, 31 Aug 2017 14:34:20 -0600","From":"Subash Abhinov Kasiviswanathan ","To":"Colin King ","Cc":"\"David S . Miller\" , netdev@vger.kernel.org,\n\tkernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH][net-next] net: qualcomm: rmnet: remove unused variable\n\tpriv","In-Reply-To":"<20170831140727.28170-1-colin.king@canonical.com>","References":"<20170831140727.28170-1-colin.king@canonical.com>","Message-ID":"","X-Sender":"subashab@codeaurora.org","User-Agent":"Roundcube Webmail/1.2.5","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1762055,"web_url":"http://patchwork.ozlabs.org/comment/1762055/","msgid":"<20170901.183452.1095616327099284759.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-02T01:34:52","subject":"Re: [PATCH][net-next] net: qualcomm: rmnet: remove unused variable\n\tpriv","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Colin King \nDate: Thu, 31 Aug 2017 15:07:27 +0100\n\n> From: Colin Ian King \n> \n> priv is being assigned but is never used, so remove it.\n> \n> Cleans up clang build warning:\n> \"warning: Value stored to 'priv' is never read\"\n> \n> Fixes: ceed73a2cf4a (\"drivers: net: ethernet: qualcomm: rmnet: Initial implementation\")\n> Signed-off-by: Colin Ian King \n\nApplied.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkdvx02LKz9sPm\n\tfor ;\n\tSat, 2 Sep 2017 11:35:09 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750941AbdIBBey (ORCPT );\n\tFri, 1 Sep 2017 21:34:54 -0400","from shards.monkeyblade.net ([184.105.139.130]:56560 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750780AbdIBBex (ORCPT\n\t); Fri, 1 Sep 2017 21:34:53 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id E88C8136A4ACD;\n\tFri, 1 Sep 2017 18:34:52 -0700 (PDT)"],"Date":"Fri, 01 Sep 2017 18:34:52 -0700 (PDT)","Message-Id":"<20170901.183452.1095616327099284759.davem@davemloft.net>","To":"colin.king@canonical.com","Cc":"subashab@codeaurora.org, netdev@vger.kernel.org,\n\tkernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH][net-next] net: qualcomm: rmnet: remove unused variable\n\tpriv","From":"David Miller ","In-Reply-To":"<20170831140727.28170-1-colin.king@canonical.com>","References":"<20170831140727.28170-1-colin.king@canonical.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Fri, 01 Sep 2017 18:34:53 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]