[{"id":1761415,"web_url":"http://patchwork.ozlabs.org/comment/1761415/","msgid":"<20170901010129.GK28143@bubble.grove.modra.org>","list_archive_url":null,"date":"2017-09-01T01:01:29","subject":"Re: [PATCH] Remove zero terminator for .eh_frame in libc.so [BZ\n\t#22053]","submitter":{"id":4298,"url":"http://patchwork.ozlabs.org/api/people/4298/","name":"Alan Modra","email":"amodra@gmail.com"},"content":"On Thu, Aug 31, 2017 at 06:53:08AM -0700, H.J. Lu wrote:\n> elf/sofini.c has a zero terminator for .eh_frame in libc.so. It was\n> added before -eh-frame-hdr is added to ld. Since -eh-frame-hdr is\n> always used to build libc.so, zero terminator in elf/sofini.c can be\n> removed.\n\nThis might be true, but the real problem is that elf/sofini.os appears\non the libc.so link command line before -lgcc.\n\n> Tested on x86-64. OK for master?\n> \n> H.J.\n> ---\n> \t[BZ #22053]\n> \t* elf/sofini.c (__FRAME_END__): Removed.\n> ---\n> elf/sofini.c | 8 --------\n> 1 file changed, 8 deletions(-)\n> \n> diff --git a/elf/sofini.c b/elf/sofini.c\n> index 13e74b7903..7ec313be4e 100644\n> --- a/elf/sofini.c\n> +++ b/elf/sofini.c\n> @@ -9,11 +9,3 @@ static void (*const __DTOR_END__[1]) (void)\n> __attribute__ ((used, section (\".dtors\")))\n> = { 0 };\n> #endif\n> -\n> -/* Terminate the frame unwind info section with a 4byte 0 as a sentinel;\n> - this would be the 'length' field in a real FDE. */\n> -\n> -typedef unsigned int ui32 __attribute__ ((mode (SI)));\n> -static const ui32 __FRAME_END__[1]\n> - __attribute__ ((used, section (\".eh_frame\")))\n> - = { 0 };\n> -- \n> 2.13.5\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84005-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"OoiaDnCi\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xk1Cs2l5pz9ryv\n\tfor ;\n\tFri, 1 Sep 2017 11:01:44 +1000 (AEST)","(qmail 18534 invoked by alias); 1 Sep 2017 01:01:39 -0000","(qmail 18445 invoked by uid 89); 1 Sep 2017 01:01:38 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-type:in-reply-to; q=dns; s=default; b=WN3Z\n\tua4SrNCINoD79sK3dKrSr5M7lVY9lKCvAzR3cF6tTLakiXU+SUrCvefuT0Q+quL5\n\tjeO57yszrfOWLyx1oJRnWTbHV/+zSOfqkhrHJNb2wQaSbAwXpwd0ckI95l1dw3n1\n\ti5iATuevMJ0cSBZ0SiNy3D70P0z2c5Sjcvoup6o=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-type:in-reply-to; s=default; bh=EBy5egKoXf\n\t7sy0rOaYByBSj1LOg=; b=OoiaDnCidMiCYp8E+YICZlynJ7Mes1fBhhSxZ8VBbO\n\tLtZNDRXjXWtdZLTp3tKaqIxmh0XVznPKVE4lGy3I5P2e8zVxpRQaligIzLOG21+B\n\tqqLDxeU8oaTBJA3fXvDF5mnE287JZIJATz5XUwRfwl02eJ0z70GluUin6CyNd+tv\n\tw=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-24.7 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2,\n\tGIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1258","X-HELO":"mail-pg0-f47.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=9Std3NzCsZDyz+8EEHiBN29svP+ZcqkwV4S/fCyre40=;\n\tb=EqXIAJMZuiKNcSpehOIp+xljv7JsPCtcGw9ibB6f/aJQCjUWtcIvwsJdogdhjoXWF/\n\tJqb15nw500bKZ3KXuW2HcK+WD+tLC5kjcxrNp6OujB9ARo5Dx3IyhzObS1sxSbQg/1B8\n\tdppOs5BtFPYBQP+gBM0ttCxjYpqaQqG8pkxF7miR3uPy8bUstHMINkdtOBConIwpjbbW\n\txt4S7Vuw51YOQYrrOgq6eMqXBzflGFyDecwz3Cp7S+QH5haxWm/kGoDevtEfyMcjznDG\n\tnFkfCxHBw3OE7i4klIuw0biUBGfy7XKPTO1eH857LH75mNsxi/+1+7NsadscpOsgveNy\n\tYN+g==","X-Gm-Message-State":"AHPjjUifUnk9dZ0L3Gr655udlMPnLTTE6ARuR5nRtcHZpwpAvabbIVSq\n\tqgPOyRv7N38E8w==","X-Google-Smtp-Source":"ADKCNb6J2ch+DtkJj9Ft03Y4eQaUMZ5ymwF5FG/ZCy+gj9J2qS+Q/f6jse3vBKC+ZzN7HwRK3uzz2g==","X-Received":"by 10.98.2.210 with SMTP id 201mr350297pfc.151.1504227695863;\n\tThu, 31 Aug 2017 18:01:35 -0700 (PDT)","Date":"Fri, 1 Sep 2017 10:31:29 +0930","From":"Alan Modra ","To":"\"H.J. Lu\" ","Cc":"GNU C Library ","Subject":"Re: [PATCH] Remove zero terminator for .eh_frame in libc.so [BZ\n\t#22053]","Message-ID":"<20170901010129.GK28143@bubble.grove.modra.org>","References":"<20170831135308.GA26865@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170831135308.GA26865@gmail.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)"}},{"id":1761749,"web_url":"http://patchwork.ozlabs.org/comment/1761749/","msgid":"","list_archive_url":null,"date":"2017-09-01T15:06:31","subject":"Re: [PATCH] Remove zero terminator for .eh_frame in libc.so [BZ\n\t#22053]","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/people/4387/","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"content":"On Thu, Aug 31, 2017 at 6:01 PM, Alan Modra wrote:\n> On Thu, Aug 31, 2017 at 06:53:08AM -0700, H.J. Lu wrote:\n>> elf/sofini.c has a zero terminator for .eh_frame in libc.so. It was\n>> added before -eh-frame-hdr is added to ld. Since -eh-frame-hdr is\n>> always used to build libc.so, zero terminator in elf/sofini.c can be\n>> removed.\n>\n> This might be true, but the real problem is that elf/sofini.os appears\n> on the libc.so link command line before -lgcc.\n>\n\nThis has been fixed for glibc 2.27.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84022-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"NGU+9+jI\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkMyq4K8qz9t2Z\n\tfor ;\n\tSat, 2 Sep 2017 01:06:43 +1000 (AEST)","(qmail 4443 invoked by alias); 1 Sep 2017 15:06:36 -0000","(qmail 4431 invoked by uid 89); 1 Sep 2017 15:06:36 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; q=dns; s=default; b=aZ/P\n\t5nt6qtotL0lI08Y48NpR6mslMWmWyjGPjXZPhw2lqAGXsp0ckI+7vIiLHc0P/Vhk\n\t+74gDMn02A3Ik+C9fmpvZxCepRtk1z0s6GZySq+mm4jXr+gC+NQ0xJjlEhIDNXFq\n\t2QjiS+JuJVMqlxrI+3L32TGbl/0zduWFK2m2MDg=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; s=default; bh=ZtYj0r6roQ\n\twsdFoDiXULChgzo9U=; b=NGU+9+jInp2Yh1J4fw6RILiXnJDrBXuwGpu1v3GhdV\n\tqN5BBuvJQsXgX/ToQfli9Bas5ILDqesEKLIjNUZLToFh09Njy+ysWwliLfEDQJZk\n\tz36Ryzh83VNTkpqJD6wslSy8M/0r1KXhKS3lE1lY0FfjKWVCQhQrkTY9Q4YwQOBL\n\tg=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.5 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=no version=3.3.2 spammy=","X-HELO":"mail-oi0-f66.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=Jp6RdpDU5cdNvvDZbWBmENqlFQdR//IiiXvXjWNyE7Q=;\n\tb=c9L5JsWy+WJe4G3KiC/jeHfnhHK5uQCH7oQj/S/gxm1vGLESx1FHUIBQUDKawDD374\n\t/zJvPvdhEOFUX9VGn+revFCE4xGRUKQdTf+b+oy/7d1Zp9daiosxiATLeZ5cNrQIxVx9\n\t0JYJKx/gCDKANGR7g9kwOrgOLZE9pIXf/PvS16qXKJO0c5ZnKBpxiZJNh0ihk4sG7DPg\n\t1oUBO+sS1vxLqp4bX3CkJ/WdY7t912SLDLtD4M2eCGy+drbpPJMFiKAWIWau+d1ZbSPP\n\t24hUOmIekWOCH6bnkr5OhYqQCf1G4i7E7TcEx9XFKx+PQjzFDRw7WlpYMtwUq5eQ8dfU\n\tNyBg==","X-Gm-Message-State":"AHPjjUi9NWkBckjQSYFK7vm6/4AVRBb368rCzPu9LhxSDXQpFs6LOwL9\n\tYHKKtOX/dADTTMd61q3lDBsKvQPKWw==","X-Google-Smtp-Source":"ADKCNb49+A2EpVM3WthIYsmz3mvUb+Wmefx7HuHE1zB2UtYzN4Bma+J08uJS/fZ/hNG5z2yUit6qMBpFat1qTYfL3nE=","X-Received":"by 10.202.196.149 with SMTP id\n\tu143mr1866012oif.301.1504278392471; \n\tFri, 01 Sep 2017 08:06:32 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170901010129.GK28143@bubble.grove.modra.org>","References":"<20170831135308.GA26865@gmail.com>\n\t<20170901010129.GK28143@bubble.grove.modra.org>","From":"\"H.J. Lu\" ","Date":"Fri, 1 Sep 2017 08:06:31 -0700","Message-ID":"","Subject":"Re: [PATCH] Remove zero terminator for .eh_frame in libc.so [BZ\n\t#22053]","To":"Alan Modra ","Cc":"GNU C Library ","Content-Type":"text/plain; charset=\"UTF-8\""}}]