[{"id":1761160,"web_url":"http://patchwork.ozlabs.org/comment/1761160/","msgid":"","list_archive_url":null,"date":"2017-08-31T16:19:44","subject":"Re: [Qemu-devel] [PATCH 2/2] .dir-locals.el: add json schema to\n\tauto-mode","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 08/31/2017 08:14 AM, Marc-André Lureau wrote:\n> The json schema is more friendly to python-mode since it doesn't\n> follow strictly json (comments to start with).\n\nI found that hard to read, and missing a key word of 'emacs'. Maybe\nreword it as:\n\nUnder emacs, our QAPI files (.json suffix) are more friendly to edit\nunder python-mode than the per-suffix default of json-mode (in part\nbecause of our use of comments).\n\n> \n> All schema files add file variables to set the python mode, but most\n> tests didn't. This will cover all json files now.\n> \n> Signed-off-by: Marc-André Lureau \n> ---\n\n> +++ b/.dir-locals.el\n> @@ -2,6 +2,8 @@\n> (indent-tabs-mode . nil)))\n> (nil . ((eval . (setq auto-mode-alist (append\n> '((\"Makefile.*\" . makefile-gmake-mode)\n> - (\"\\\\.mak\\\\'\" . makefile-gmake-mode))\n> + (\"\\\\.mak\\\\'\" . makefile-gmake-mode)\n> + ;; json schema is not pure json\n> + (\"\\\\.json\\\\'\" . python-mode))\n> auto-mode-alist))))\n> ))\n\nNot sure if the comment could be worded better, maybe:\n\n;; Our .json files are QAPI, and allow more than pure json\n\nAgain, the idea makes sense to me, but you may want to get feedback from\nother power emacs users.\n\n[Also, don't forget the 0/2 cover letter if you send v2]","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=208.118.235.17; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [208.118.235.17])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjnfY5SjNz9sMN\n\tfor ;\n\tFri, 1 Sep 2017 02:20:37 +1000 (AEST)","from localhost ([::1]:56633 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnSCp-0005Vy-Ma\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 12:20:35 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49027)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnSC8-0005ST-NK\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 12:19:57 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnSC6-0008Ot-2m\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 12:19:52 -0400","from mx1.redhat.com ([209.132.183.28]:55030)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnSC5-0008OL-Q8\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 12:19:50 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E44D4C0587EF;\n\tThu, 31 Aug 2017 16:19:48 +0000 (UTC)","from [10.10.122.186] (ovpn-122-186.rdu2.redhat.com [10.10.122.186])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 3D96D60842;\n\tThu, 31 Aug 2017 16:19:45 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E44D4C0587EF","To":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\tqemu-devel@nongnu.org","References":"<20170831131425.3953-1-marcandre.lureau@redhat.com>\n\t<20170831131425.3953-2-marcandre.lureau@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"","Date":"Thu, 31 Aug 2017 11:19:44 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170831131425.3953-2-marcandre.lureau@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"ieMFVq5tQWfacSwWKf0KlnSQnWuPQXoPF\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tThu, 31 Aug 2017 16:19:49 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH 2/2] .dir-locals.el: add json schema to\n\tauto-mode","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"armbru@redhat.com, Michael Roth ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]