[{"id":1761332,"web_url":"http://patchwork.ozlabs.org/comment/1761332/","msgid":"<20170831.143827.1561921608795766649.davem@davemloft.net>","list_archive_url":null,"date":"2017-08-31T21:38:27","subject":"Re: [PATCH net-next 7/8] net: hns3: add vlan filter config of Ports","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Lipeng \nDate: Thu, 31 Aug 2017 21:39:08 +0800\n\n> Config the self_define vlan_type as TPID(0x8100) for vlan identification.\n> When normal port initialize vlan configure, set default vlan id as 0.\n> \n> Signed-off-by: Mingguang Qu \n> Signed-off-by: Lipeng \n\nNo, that's not what this patch is doing.\n\n> @@ -3308,6 +3308,7 @@ static int hclge_add_mac_vlan_tbl(struct hclge_vport *vport,\n> \t\tmc_desc[1].flag |= cpu_to_le16(HCLGE_CMD_FLAG_NEXT);\n> \t\thclge_cmd_reuse_desc(&mc_desc[2], false);\n> \t\tmc_desc[2].flag &= cpu_to_le16(~HCLGE_CMD_FLAG_NEXT);\n> +\n> \t\tmemcpy(mc_desc[0].data, req,\n> \t\t sizeof(struct hclge_mac_vlan_tbl_entry));\n> \t\tret = hclge_cmd_send(&hdev->hw, mc_desc, 3);\n\nAll it does is add an empty line.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjwjb442Gz9s81\n\tfor ;\n\tFri, 1 Sep 2017 07:38:43 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751555AbdHaVib (ORCPT );\n\tThu, 31 Aug 2017 17:38:31 -0400","from shards.monkeyblade.net ([184.105.139.130]:58960 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751009AbdHaVia (ORCPT\n\t); Thu, 31 Aug 2017 17:38:30 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id C8237133EDF7D;\n\tThu, 31 Aug 2017 14:38:29 -0700 (PDT)"],"Date":"Thu, 31 Aug 2017 14:38:27 -0700 (PDT)","Message-Id":"<20170831.143827.1561921608795766649.davem@davemloft.net>","To":"lipeng321@huawei.com","Cc":"netdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinuxarm@huawei.com, yisen.zhuang@huawei.com, salil.mehta@huawei.com","Subject":"Re: [PATCH net-next 7/8] net: hns3: add vlan filter config of Ports","From":"David Miller ","In-Reply-To":"<1504186749-8926-8-git-send-email-lipeng321@huawei.com>","References":"<1504186749-8926-1-git-send-email-lipeng321@huawei.com>\n\t<1504186749-8926-8-git-send-email-lipeng321@huawei.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Thu, 31 Aug 2017 14:38:30 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]