[{"id":1760992,"web_url":"http://patchwork.ozlabs.org/comment/1760992/","msgid":"<2326944.Wi9TMObRze@avalon>","list_archive_url":null,"date":"2017-08-31T13:30:22","subject":"Re: [PATCH v2 1/2] drm/bridge: add Silicon Image SiI9234 driver","submitter":{"id":11034,"url":"http://patchwork.ozlabs.org/api/people/11034/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Maciej,\n\nThank you for the patch.\n\nOn Thursday, 31 August 2017 15:27:13 EEST Maciej Purski wrote:\n> SiI9234 transmitter converts eTMDS/HDMI signal to MHL 1.0.\n> It is controlled via I2C bus. Its interaction with other\n> devices in video pipeline is performed mainly on HW level.\n> The only interaction it does on device driver level is\n> filtering-out unsupported video modes, it exposes drm_bridge\n> interface to perform this operation.\n> \n> This patch is based on the code refactored by Tomasz Stanislawski\n> , which was initially developed by:\n> Adam Hampson \n> Erik Gilling \n> Shankar Bandal \n> Dharam Kumar \n> \n> Signed-off-by: Maciej Purski \n> ---\n> Changes in v2:\n> - use bulk_requlators instead of single one\n> - substitute some of the magic values with macros\n> - improve coding style\n> - improved error handling in sii9234_probe()\n> ---\n> .../devicetree/bindings/display/bridge/sii9234.txt | 34 +\n> drivers/gpu/drm/bridge/Kconfig | 8 +\n> drivers/gpu/drm/bridge/Makefile | 1 +\n> drivers/gpu/drm/bridge/sii9234.c | 993 ++++++++++++++++++\n> 4 files changed, 1036 insertions(+)\n> create mode 100644\n> Documentation/devicetree/bindings/display/bridge/sii9234.txt create mode\n> 100644 drivers/gpu/drm/bridge/sii9234.c\n> \n> diff --git a/Documentation/devicetree/bindings/display/bridge/sii9234.txt\n> b/Documentation/devicetree/bindings/display/bridge/sii9234.txt new file\n> mode 100644\n> index 0000000..3ce7413\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/display/bridge/sii9234.txt\n> @@ -0,0 +1,34 @@\n> +Silicon Image SiI9234 HDMI/MHL bridge bindings\n> +\n> +Required properties:\n> +\t- compatible : \"sil,sii9234\".\n> +\t- reg : I2C address for TPI interface, use 0x39\n> +\t- avcc33-supply : MHL/USB Switch Supply Voltage (3.3V)\n> +\t- iovcc18-supply : I/O Supply Voltage (1.8V)\n> +\t- avcc12-supply : TMDS Analog Supply Voltage (1.2V)\n> +\t- cvcc12-supply : Digital Core Supply Voltage (1.2V)\n> +\t- interrupts, interrupt-parent: interrupt specifier of INT pin\n> +\t- reset-gpios: gpio specifier of RESET pin (active low)\n> +\t- video interfaces: Device node can contain video interface port\n> +\t\t\t node for HDMI encoder according to [1].\n> +\n> +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt\n\nDoesn't this chip have two ports, one input connected to the SoC and one \noutput connected to an HDMI connector ? If so there should be two ports in DT \ntoo.\n\n> +Example:\n> +\tsii9234@39 {\n> +\t\tcompatible = \"sil,sii9234\";\n> +\t\treg = <0x39>;\n> +\t\tavcc33-supply = <&vcc33mhl>;\n> +\t\tiovcc18-supply = <&vcc18mhl>;\n> +\t\tavcc12-supply = <&vsil12>;\n> +\t\tcvcc12-supply = <&vsil12>;\n> +\t\treset-gpios = <&gpf3 4 GPIO_ACTIVE_LOW>;\n> +\t\tinterrupt-parent = <&gpf3>;\n> +\t\tinterrupts = <5 IRQ_TYPE_LEVEL_HIGH>;\n> +\n> +\t\tport {\n> +\t\t\tmhl_to_hdmi: endpoint {\n> +\t\t\t\tremote-endpoint = <&hdmi_to_mhl>;\n\nIt would be useful to include the remote DT nodes in the example too.\n\n> +\t\t\t};\n> +\t\t};\n> +\t};","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pBYJoPW6\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjjsV05j7z9sPt\n\tfor ;\n\tThu, 31 Aug 2017 23:29:50 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751024AbdHaN3s (ORCPT\n\t);\n\tThu, 31 Aug 2017 09:29:48 -0400","from galahad.ideasonboard.com ([185.26.127.97]:38411 \"EHLO\n\tgalahad.ideasonboard.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751009AbdHaN3r (ORCPT\n\t); Thu, 31 Aug 2017 09:29:47 -0400","from avalon.localnet (8.138-240-81.adsl-dyn.isp.belgacom.be\n\t[81.240.138.8])\n\tby galahad.ideasonboard.com (Postfix) with ESMTPSA id 7C8E62021B;\n\tThu, 31 Aug 2017 15:27:58 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1504186078;\n\tbh=SwFwHicfEqiLeTOD/7oaZRYEcv6p3qDiQ66HQ9HNUcs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=pBYJoPW66HlZGYw5kB0Yl0FdiRY2flsua09gHABVU39UggXqWAVDKY5zVQtsQ3CRE\n\tuQjrx8ommeGsx5OCxWS93y+brxBpXYVPogovcwQQ6jLa+FG8Nf9bVIIn7iqvRQLKv9\n\tmy8gxbGDoRIUhehr+1PiZNXO0l29OAvYFWnU/X+M=","From":"Laurent Pinchart ","To":"dri-devel@lists.freedesktop.org","Cc":"Maciej Purski , devicetree@vger.kernel.org,\n\tlinux-samsung-soc@vger.kernel.org, mark.rutland@arm.com,\n\tb.zolnierkie@samsung.com, krzk@kernel.org, robh+dt@kernel.org","Subject":"Re: [PATCH v2 1/2] drm/bridge: add Silicon Image SiI9234 driver","Date":"Thu, 31 Aug 2017 16:30:22 +0300","Message-ID":"<2326944.Wi9TMObRze@avalon>","In-Reply-To":"<1504182434-8201-2-git-send-email-m.purski@samsung.com>","References":"<1504182434-8201-1-git-send-email-m.purski@samsung.com>\n\t\n\t<1504182434-8201-2-git-send-email-m.purski@samsung.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"us-ascii\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1763335,"web_url":"http://patchwork.ozlabs.org/comment/1763335/","msgid":"","list_archive_url":null,"date":"2017-09-05T13:01:54","subject":"Re: [PATCH v2 1/2] drm/bridge: add Silicon Image SiI9234 driver","submitter":{"id":72100,"url":"http://patchwork.ozlabs.org/api/people/72100/","name":"Maciej Purski","email":"m.purski@samsung.com"},"content":"Hi Laurent,\n\nThank you for your reply. The problem was already discussed when adding sil8620 driver.\nIt can be solved later. I'm CC-ing Andrzej Hajda, as he used to discuss it with you.\n\nhttps://patchwork.freedesktop.org/patch/114224/\nhttps://lists.freedesktop.org/archives/dri-devel/2015-December/096756.html\n\nRegards,\n\n\tMaciej\n\nOn 31/08/17 15:30, Laurent Pinchart wrote:\n\n> Hi Maciej,\n>\n> Thank you for the patch.\n>\n> On Thursday, 31 August 2017 15:27:13 EEST Maciej Purski wrote:\n>> SiI9234 transmitter converts eTMDS/HDMI signal to MHL 1.0.\n>> It is controlled via I2C bus. Its interaction with other\n>> devices in video pipeline is performed mainly on HW level.\n>> The only interaction it does on device driver level is\n>> filtering-out unsupported video modes, it exposes drm_bridge\n>> interface to perform this operation.\n>>\n>> This patch is based on the code refactored by Tomasz Stanislawski\n>> , which was initially developed by:\n>> Adam Hampson \n>> Erik Gilling \n>> Shankar Bandal \n>> Dharam Kumar \n>>\n>> Signed-off-by: Maciej Purski \n>> ---\n>> Changes in v2:\n>> - use bulk_requlators instead of single one\n>> - substitute some of the magic values with macros\n>> - improve coding style\n>> - improved error handling in sii9234_probe()\n>> ---\n>> .../devicetree/bindings/display/bridge/sii9234.txt | 34 +\n>> drivers/gpu/drm/bridge/Kconfig | 8 +\n>> drivers/gpu/drm/bridge/Makefile | 1 +\n>> drivers/gpu/drm/bridge/sii9234.c | 993 ++++++++++++++++++\n>> 4 files changed, 1036 insertions(+)\n>> create mode 100644\n>> Documentation/devicetree/bindings/display/bridge/sii9234.txt create mode\n>> 100644 drivers/gpu/drm/bridge/sii9234.c\n>>\n>> diff --git a/Documentation/devicetree/bindings/display/bridge/sii9234.txt\n>> b/Documentation/devicetree/bindings/display/bridge/sii9234.txt new file\n>> mode 100644\n>> index 0000000..3ce7413\n>> --- /dev/null\n>> +++ b/Documentation/devicetree/bindings/display/bridge/sii9234.txt\n>> @@ -0,0 +1,34 @@\n>> +Silicon Image SiI9234 HDMI/MHL bridge bindings\n>> +\n>> +Required properties:\n>> +\t- compatible : \"sil,sii9234\".\n>> +\t- reg : I2C address for TPI interface, use 0x39\n>> +\t- avcc33-supply : MHL/USB Switch Supply Voltage (3.3V)\n>> +\t- iovcc18-supply : I/O Supply Voltage (1.8V)\n>> +\t- avcc12-supply : TMDS Analog Supply Voltage (1.2V)\n>> +\t- cvcc12-supply : Digital Core Supply Voltage (1.2V)\n>> +\t- interrupts, interrupt-parent: interrupt specifier of INT pin\n>> +\t- reset-gpios: gpio specifier of RESET pin (active low)\n>> +\t- video interfaces: Device node can contain video interface port\n>> +\t\t\t node for HDMI encoder according to [1].\n>> +\n>> +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt\n> Doesn't this chip have two ports, one input connected to the SoC and one\n> output connected to an HDMI connector ? If so there should be two ports in DT\n> too.\n>\n>> +Example:\n>> +\tsii9234@39 {\n>> +\t\tcompatible = \"sil,sii9234\";\n>> +\t\treg = <0x39>;\n>> +\t\tavcc33-supply = <&vcc33mhl>;\n>> +\t\tiovcc18-supply = <&vcc18mhl>;\n>> +\t\tavcc12-supply = <&vsil12>;\n>> +\t\tcvcc12-supply = <&vsil12>;\n>> +\t\treset-gpios = <&gpf3 4 GPIO_ACTIVE_LOW>;\n>> +\t\tinterrupt-parent = <&gpf3>;\n>> +\t\tinterrupts = <5 IRQ_TYPE_LEVEL_HIGH>;\n>> +\n>> +\t\tport {\n>> +\t\t\tmhl_to_hdmi: endpoint {\n>> +\t\t\t\tremote-endpoint = <&hdmi_to_mhl>;\n> It would be useful to include the remote DT nodes in the example too.\n>\n>> +\t\t\t};\n>> +\t\t};\n>> +\t};\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmn164PCbz9t16\n\tfor ;\n\tTue, 5 Sep 2017 23:02:02 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751285AbdIENCB (ORCPT\n\t);\n\tTue, 5 Sep 2017 09:02:01 -0400","from mailout2.w1.samsung.com ([210.118.77.12]:35478 \"EHLO\n\tmailout2.w1.samsung.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751236AbdIENB7 (ORCPT\n\t); Tue, 5 Sep 2017 09:01:59 -0400","from eucas1p1.samsung.com (unknown [182.198.249.206])\n\tby mailout2.w1.samsung.com (KnoxPortal) with ESMTP id\n\t20170905130157euoutp02aafbe4794c4e91484acc3e31d108f8bc~heMA9OKtv0053700537euoutp02e;\n\tTue, 5 Sep 2017 13:01:57 +0000 (GMT)","from eusmges2.samsung.com (unknown [203.254.199.241]) by\n\teucas1p2.samsung.com (KnoxPortal) with ESMTP id\n\t20170905130156eucas1p2b95cbb1dc3980979fa48fa3e9a071e9c~heMANTrwP2526225262eucas1p2J;\n\tTue, 5 Sep 2017 13:01:56 +0000 (GMT)","from eucas1p1.samsung.com ( [182.198.249.206]) by\n\teusmges2.samsung.com (EUCPMTA) with SMTP id 0C.B3.12907.440AEA95;\n\tTue, 5 Sep 2017 14:01:56 +0100 (BST)","from eusmgms2.samsung.com (unknown [182.198.249.180]) by\n\teucas1p2.samsung.com (KnoxPortal) with ESMTP id\n\t20170905130156eucas1p2280bab7b7e67f79151f12cc77a2f243a~heL-idjcx2526925269eucas1p2F;\n\tTue, 5 Sep 2017 13:01:56 +0000 (GMT)","from eusync1.samsung.com ( [203.254.199.211]) by\n\teusmgms2.samsung.com (EUCPMTA) with SMTP id E6.0D.20118.340AEA95;\n\tTue, 5 Sep 2017 14:01:56 +0100 (BST)","from [106.120.51.25] by eusync1.samsung.com (Oracle Communications\n\tMessaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA\n\tid <0OVT0078S5J7Z790@eusync1.samsung.com>;\n\tTue, 05 Sep 2017 14:01:55 +0100 (BST)"],"X-AuditID":"cbfec7f1-f793a6d00000326b-43-59aea044bbd2","Subject":"Re: [PATCH v2 1/2] drm/bridge: add Silicon Image SiI9234 driver","To":"Laurent Pinchart ,\n\tdri-devel@lists.freedesktop.org","Cc":"devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,\n\tmark.rutland@arm.com, b.zolnierkie@samsung.com, krzk@kernel.org,\n\trobh+dt@kernel.org, Andrzej Hajda ","From":"Maciej Purski ","Message-id":"","Date":"Tue, 05 Sep 2017 15:01:54 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-version":"1.0","In-reply-to":"<2326944.Wi9TMObRze@avalon>","Content-type":"text/plain; charset=\"utf-8\"; format=\"flowed\"","Content-transfer-encoding":"7bit","Content-language":"en-US","X-Brightmail-Tracker":["H4sIAAAAAAAAA+NgFlrJKsWRmVeSWpSXmKPExsWy7djPc7ouC9ZFGjQdkLe4te4cq8XGGetZ\n\tLeYfAbKufH3PZnH+/AZ2i86JS9gtZpzfx2Sx9PpFJovWvUfYHTg91sxbw+gxu2Mmq8emVZ1s\n\tHve7jzN59G1ZxejxeZNcAFsUl01Kak5mWWqRvl0CV8biB7+YCm7KVKxZdZa9gXGCeBcjJ4eE\n\tgInEg/u/GSFsMYkL99azdTFycQgJLGWU+H1rKyOE85lR4vSrHWwwHSv/T2KHSCxjlNh4bTZY\n\tQkjgGaPE80NxILawgIfE1oZVLCC2iEC0xK4Ne1lBGpgF9jNK3Jy8lqmLkYODTUBLYk17PIjJ\n\tK2Ancf+mPUg5i4CqxO59s1lBbFGBCIlt32eAjecVEJT4Mfke2EhOAQ2JOze7wGxmASuJZ/9a\n\tWSFseYnNa94yQ9jiEs2tN1kgbn7NJrGsXwvCdpF48RxivoSAsMSr41vYIWwZicuTu6HqqyUu\n\tft0F9W+NROPtDVA11hKfJ22Bms8nMWnbdGaQ8yUEeCU62oQgSjwkuhcsY4awHSW2PprHDgmd\n\t94wS/3ZqTmCUn4Xkm1lIPpiF5INZSD5YwMiyilEktbQ4Nz212EivODG3uDQvXS85P3cTIzAB\n\tnf53/OMOxvcnrA4xCnAwKvHwCiSujRRiTSwrrsw9xCjBwawkwntg8rpIId6UxMqq1KL8+KLS\n\tnNTiQ4zSHCxK4ry2UW2RQgLpiSWp2ampBalFMFkmDk6pBka7iyesXqxW3aW1Ye4Mc5c6Ba5w\n\tgzNWwZVSJRq79ickPo19uJbhn9D9xoM9Jcf9Nf+u/Ljqsb9XSHxjFuvflcoJk4oPS9ZziG3w\n\tDnBbviJg+vZ/9S/NV28qnM59fWrKhhq/W0pzIzV38n74udtjxsfIgBmhZmc3zzr/YUdWiHRC\n\tzyfRt63GAvuVWIozEg21mIuKEwHss2esPAMAAA==","H4sIAAAAAAAAA+NgFmpikeLIzCtJLcpLzFFi42I5/e/4ZV2XBesiDdZtZrS4te4cq8XGGetZ\n\tLeYfAbKufH3PZnH+/AZ2i86JS9gtZpzfx2Sx9PpFJovWvUfYHTg91sxbw+gxu2Mmq8emVZ1s\n\tHve7jzN59G1ZxejxeZNcAFsUl01Kak5mWWqRvl0CV8biB7+YCm7KVKxZdZa9gXGCeBcjJ4eE\n\tgInEyv+T2CFsMYkL99azdTFycQgJLGGU2PaynQXCecYocanxPCNIlbCAh8TWhlUsILaIQLTE\n\tmUOHmUGKmAX2M0q8WnmcGaLjPaNE97UXQLM4ONgEtCTWtMeDmLwCdhL3b9qD9LIIqErs3jeb\n\tFcQWFYiQ6Ht7GewKXgFBiR+T74HN5xTQkLhzswvMZhYwk/jy8jArhC0vsXnNW2YIW1yiufUm\n\tywRGwVlI2mchaZmFpGUWkpYFjCyrGEVSS4tz03OLjfSKE3OLS/PS9ZLzczcxAmNm27GfW3Yw\n\tdr0LPsQowMGoxMPLEbU2Uog1say4MvcQowQHs5II74HJ6yKFeFMSK6tSi/Lji0pzUosPMUpz\n\tsCiJ8/buWR0pJJCeWJKanZpakFoEk2Xi4JRqYJR6tfVEyHzP3Yk/r3ez6KoZKu084stSfTTH\n\th8PkaKwbl7NvmaBLjZCkku2+4peLL/r+vCvTUPjoqUBsdHDr5LdWDnLb/k/+4yPkM0F8bnrh\n\tX4HMv68a01YpTr/6X6070pbVf6d7y6ckdbPKAscZ/ssnCEgtF+W4omHSX9r6ctXx3v5tMvv2\n\tK7EUZyQaajEXFScCAJaixz2VAgAA"],"X-CMS-MailID":"20170905130156eucas1p2280bab7b7e67f79151f12cc77a2f243a","X-Msg-Generator":"CA","X-Sender-IP":"182.198.249.180","X-Local-Sender":"=?utf-8?q?Maciej_Purski=1BSecurity_=28TP=29=1BSamsung_Ele?=\n\t=?utf-8?q?ctronics=1BTrainee_=28=29?=","X-Global-Sender":"=?utf-8?q?Maciej_Purski=1BSecurity_=28TP=29=1BSamsung_El?=\n\t=?utf-8?q?ectronics=1BTrainee_=28=29?=","X-Sender-Code":"=?utf-8?q?C10=1BEHQ=1BC10CD02CD027395?=","CMS-TYPE":"201P","X-CMS-RootMailID":"20170831122745eucas1p27a178da2e30023292c57653a8dc45813","X-RootMTR":"20170831122745eucas1p27a178da2e30023292c57653a8dc45813","References":"<1504182434-8201-1-git-send-email-m.purski@samsung.com>\n\t\n\t<1504182434-8201-2-git-send-email-m.purski@samsung.com>\n\t<2326944.Wi9TMObRze@avalon>","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1763429,"web_url":"http://patchwork.ozlabs.org/comment/1763429/","msgid":"<1569224.pDUtqo7azG@avalon>","list_archive_url":null,"date":"2017-09-05T15:05:53","subject":"Re: [PATCH v2 1/2] drm/bridge: add Silicon Image SiI9234 driver","submitter":{"id":11034,"url":"http://patchwork.ozlabs.org/api/people/11034/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Maciej,\n\nOn Tuesday, 5 September 2017 16:01:54 EEST Maciej Purski wrote:\n> Hi Laurent,\n> \n> Thank you for your reply. The problem was already discussed when adding\n> sil8620 driver. It can be solved later. I'm CC-ing Andrzej Hajda, as he\n> used to discuss it with you.\n\nI'm afraid it can't be solved later. DT bindings are supposed to be a stable \nABI, we can't merge a binding that we already know isn't correct.\n\n> https://patchwork.freedesktop.org/patch/114224/\n> https://lists.freedesktop.org/archives/dri-devel/2015-December/096756.html\n> \n> Regards,\n> \n> \tMaciej\n> \n> On 31/08/17 15:30, Laurent Pinchart wrote:\n> > Hi Maciej,\n> > \n> > Thank you for the patch.\n> > \n> > On Thursday, 31 August 2017 15:27:13 EEST Maciej Purski wrote:\n> >> SiI9234 transmitter converts eTMDS/HDMI signal to MHL 1.0.\n> >> It is controlled via I2C bus. Its interaction with other\n> >> devices in video pipeline is performed mainly on HW level.\n> >> The only interaction it does on device driver level is\n> >> filtering-out unsupported video modes, it exposes drm_bridge\n> >> interface to perform this operation.\n> >> \n> >> This patch is based on the code refactored by Tomasz Stanislawski\n> >> , which was initially developed by:\n> >> Adam Hampson \n> >> Erik Gilling \n> >> Shankar Bandal \n> >> Dharam Kumar \n> >> \n> >> Signed-off-by: Maciej Purski \n> >> ---\n> >> Changes in v2:\n> >> - use bulk_requlators instead of single one\n> >> - substitute some of the magic values with macros\n> >> - improve coding style\n> >> - improved error handling in sii9234_probe()\n> >> ---\n> >> \n> >> .../devicetree/bindings/display/bridge/sii9234.txt | 34 +\n> >> drivers/gpu/drm/bridge/Kconfig | 8 +\n> >> drivers/gpu/drm/bridge/Makefile | 1 +\n> >> drivers/gpu/drm/bridge/sii9234.c | 993\n> >> ++++++++++++++++++\n> >> 4 files changed, 1036 insertions(+)\n> >> create mode 100644\n> >> \n> >> Documentation/devicetree/bindings/display/bridge/sii9234.txt create mode\n> >> 100644 drivers/gpu/drm/bridge/sii9234.c\n> >> \n> >> diff --git a/Documentation/devicetree/bindings/display/bridge/sii9234.txt\n> >> b/Documentation/devicetree/bindings/display/bridge/sii9234.txt new file\n> >> mode 100644\n> >> index 0000000..3ce7413\n> >> --- /dev/null\n> >> +++ b/Documentation/devicetree/bindings/display/bridge/sii9234.txt\n> >> @@ -0,0 +1,34 @@\n> >> +Silicon Image SiI9234 HDMI/MHL bridge bindings\n> >> +\n> >> +Required properties:\n> >> +\t- compatible : \"sil,sii9234\".\n> >> +\t- reg : I2C address for TPI interface, use 0x39\n> >> +\t- avcc33-supply : MHL/USB Switch Supply Voltage (3.3V)\n> >> +\t- iovcc18-supply : I/O Supply Voltage (1.8V)\n> >> +\t- avcc12-supply : TMDS Analog Supply Voltage (1.2V)\n> >> +\t- cvcc12-supply : Digital Core Supply Voltage (1.2V)\n> >> +\t- interrupts, interrupt-parent: interrupt specifier of INT pin\n> >> +\t- reset-gpios: gpio specifier of RESET pin (active low)\n> >> +\t- video interfaces: Device node can contain video interface port\n> >> +\t\t\t node for HDMI encoder according to [1].\n> >> +\n> >> +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt\n> > \n> > Doesn't this chip have two ports, one input connected to the SoC and one\n> > output connected to an HDMI connector ? If so there should be two ports in\n> > DT too.\n> > \n> >> +Example:\n> >> +\tsii9234@39 {\n> >> +\t\tcompatible = \"sil,sii9234\";\n> >> +\t\treg = <0x39>;\n> >> +\t\tavcc33-supply = <&vcc33mhl>;\n> >> +\t\tiovcc18-supply = <&vcc18mhl>;\n> >> +\t\tavcc12-supply = <&vsil12>;\n> >> +\t\tcvcc12-supply = <&vsil12>;\n> >> +\t\treset-gpios = <&gpf3 4 GPIO_ACTIVE_LOW>;\n> >> +\t\tinterrupt-parent = <&gpf3>;\n> >> +\t\tinterrupts = <5 IRQ_TYPE_LEVEL_HIGH>;\n> >> +\n> >> +\t\tport {\n> >> +\t\t\tmhl_to_hdmi: endpoint {\n> >> +\t\t\t\tremote-endpoint = <&hdmi_to_mhl>;\n> > \n> > It would be useful to include the remote DT nodes in the example too.\n> > \n> >> +\t\t\t};\n> >> +\t\t};\n> >> +\t};","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KBd51p5f\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmqm6102xz9s0g\n\tfor ;\n\tWed, 6 Sep 2017 01:05:58 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751276AbdIEPF4 (ORCPT\n\t);\n\tTue, 5 Sep 2017 11:05:56 -0400","from galahad.ideasonboard.com ([185.26.127.97]:39070 \"EHLO\n\tgalahad.ideasonboard.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751031AbdIEPF4 (ORCPT\n\t); Tue, 5 Sep 2017 11:05:56 -0400","from avalon.localnet (42.red-81-35-203.dynamicip.rima-tde.net\n\t[81.35.203.42])\n\tby galahad.ideasonboard.com (Postfix) with ESMTPSA id 7E4B02017E;\n\tTue, 5 Sep 2017 17:03:53 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1504623833;\n\tbh=KpZq7iWSX+jnjClBMsiOu7VHM2pbZXvD3Kpqy5f26aU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=KBd51p5fNfvg5TM3FmCJ5ROGsqQAhhaMNsCa6qVE6OuFyDZVf6vwwWO55rRCzhBax\n\tIPhaLBnjd+xP5gRfZtVJSiR4pmhyG+UQK0Es5WmgvgKIQQ4CnDqhwBcebHuwxUS0nu\n\tKX9+3/iPN0zu+b4QLEcnJrb7/e+mUve6TcseULOA=","From":"Laurent Pinchart ","To":"Maciej Purski ","Cc":"dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,\n\tlinux-samsung-soc@vger.kernel.org, mark.rutland@arm.com,\n\tb.zolnierkie@samsung.com, krzk@kernel.org, robh+dt@kernel.org,\n\tAndrzej Hajda ","Subject":"Re: [PATCH v2 1/2] drm/bridge: add Silicon Image SiI9234 driver","Date":"Tue, 05 Sep 2017 18:05:53 +0300","Message-ID":"<1569224.pDUtqo7azG@avalon>","In-Reply-To":"","References":"<1504182434-8201-1-git-send-email-m.purski@samsung.com>\n\t<2326944.Wi9TMObRze@avalon>\n\t","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"us-ascii\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1764573,"web_url":"http://patchwork.ozlabs.org/comment/1764573/","msgid":"<3492951c-f57a-99b5-7cc7-f3071b1893b9@samsung.com>","list_archive_url":null,"date":"2017-09-07T08:09:59","subject":"Re: [PATCH v2 1/2] drm/bridge: add Silicon Image SiI9234 driver","submitter":{"id":47122,"url":"http://patchwork.ozlabs.org/api/people/47122/","name":"Andrzej Hajda","email":"a.hajda@samsung.com"},"content":"Hi Laurent,\n\nOn 05.09.2017 17:05, Laurent Pinchart wrote:\n> Hi Maciej,\n>\n> On Tuesday, 5 September 2017 16:01:54 EEST Maciej Purski wrote:\n>> Hi Laurent,\n>>\n>> Thank you for your reply. The problem was already discussed when adding\n>> sil8620 driver. It can be solved later. I'm CC-ing Andrzej Hajda, as he\n>> used to discuss it with you.\n> I'm afraid it can't be solved later. DT bindings are supposed to be a stable \n> ABI, we can't merge a binding that we already know isn't correct.\n\nThe problem here is that bridge output is connected to micro-USB\nconnector(not HDMI !!!).\nAnd currently there are no bindings for micro-USB connector. Creating\ngood bindings can be tricky\nbecause micro-USB connector can be used to multiple functions:\n- USB,\n- charging,\n- UART,\n- MHL,\n- audio,\n- ...\nAnd it can be controlled by different chips (MUICs), with different\ncapabilities.\n\nI plan to send RFC in near future of such bindings (as I need them for\nsii8620), but I guess it would require more review before it will be\naccepted.\n\nReturning to SiI9234, solution would be to add output port bindings to\nSiI9234, but do not add them to dts. It will make bindings for Sii9234\ncomplete.\n\nRegards\nAndrzej\n\n\n>\n>> https://patchwork.freedesktop.org/patch/114224/\n>> https://lists.freedesktop.org/archives/dri-devel/2015-December/096756.html\n>>\n>> Regards,\n>>\n>> \tMaciej\n>>\n>> On 31/08/17 15:30, Laurent Pinchart wrote:\n>>> Hi Maciej,\n>>>\n>>> Thank you for the patch.\n>>>\n>>> On Thursday, 31 August 2017 15:27:13 EEST Maciej Purski wrote:\n>>>> SiI9234 transmitter converts eTMDS/HDMI signal to MHL 1.0.\n>>>> It is controlled via I2C bus. Its interaction with other\n>>>> devices in video pipeline is performed mainly on HW level.\n>>>> The only interaction it does on device driver level is\n>>>> filtering-out unsupported video modes, it exposes drm_bridge\n>>>> interface to perform this operation.\n>>>>\n>>>> This patch is based on the code refactored by Tomasz Stanislawski\n>>>> , which was initially developed by:\n>>>> Adam Hampson \n>>>> Erik Gilling \n>>>> Shankar Bandal \n>>>> Dharam Kumar \n>>>>\n>>>> Signed-off-by: Maciej Purski \n>>>> ---\n>>>> Changes in v2:\n>>>> - use bulk_requlators instead of single one\n>>>> - substitute some of the magic values with macros\n>>>> - improve coding style\n>>>> - improved error handling in sii9234_probe()\n>>>> ---\n>>>>\n>>>> .../devicetree/bindings/display/bridge/sii9234.txt | 34 +\n>>>> drivers/gpu/drm/bridge/Kconfig | 8 +\n>>>> drivers/gpu/drm/bridge/Makefile | 1 +\n>>>> drivers/gpu/drm/bridge/sii9234.c | 993\n>>>> ++++++++++++++++++\n>>>> 4 files changed, 1036 insertions(+)\n>>>> create mode 100644\n>>>>\n>>>> Documentation/devicetree/bindings/display/bridge/sii9234.txt create mode\n>>>> 100644 drivers/gpu/drm/bridge/sii9234.c\n>>>>\n>>>> diff --git a/Documentation/devicetree/bindings/display/bridge/sii9234.txt\n>>>> b/Documentation/devicetree/bindings/display/bridge/sii9234.txt new file\n>>>> mode 100644\n>>>> index 0000000..3ce7413\n>>>> --- /dev/null\n>>>> +++ b/Documentation/devicetree/bindings/display/bridge/sii9234.txt\n>>>> @@ -0,0 +1,34 @@\n>>>> +Silicon Image SiI9234 HDMI/MHL bridge bindings\n>>>> +\n>>>> +Required properties:\n>>>> +\t- compatible : \"sil,sii9234\".\n>>>> +\t- reg : I2C address for TPI interface, use 0x39\n>>>> +\t- avcc33-supply : MHL/USB Switch Supply Voltage (3.3V)\n>>>> +\t- iovcc18-supply : I/O Supply Voltage (1.8V)\n>>>> +\t- avcc12-supply : TMDS Analog Supply Voltage (1.2V)\n>>>> +\t- cvcc12-supply : Digital Core Supply Voltage (1.2V)\n>>>> +\t- interrupts, interrupt-parent: interrupt specifier of INT pin\n>>>> +\t- reset-gpios: gpio specifier of RESET pin (active low)\n>>>> +\t- video interfaces: Device node can contain video interface port\n>>>> +\t\t\t node for HDMI encoder according to [1].\n>>>> +\n>>>> +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt\n>>> Doesn't this chip have two ports, one input connected to the SoC and one\n>>> output connected to an HDMI connector ? If so there should be two ports in\n>>> DT too.\n>>>\n>>>> +Example:\n>>>> +\tsii9234@39 {\n>>>> +\t\tcompatible = \"sil,sii9234\";\n>>>> +\t\treg = <0x39>;\n>>>> +\t\tavcc33-supply = <&vcc33mhl>;\n>>>> +\t\tiovcc18-supply = <&vcc18mhl>;\n>>>> +\t\tavcc12-supply = <&vsil12>;\n>>>> +\t\tcvcc12-supply = <&vsil12>;\n>>>> +\t\treset-gpios = <&gpf3 4 GPIO_ACTIVE_LOW>;\n>>>> +\t\tinterrupt-parent = <&gpf3>;\n>>>> +\t\tinterrupts = <5 IRQ_TYPE_LEVEL_HIGH>;\n>>>> +\n>>>> +\t\tport {\n>>>> +\t\t\tmhl_to_hdmi: endpoint {\n>>>> +\t\t\t\tremote-endpoint = <&hdmi_to_mhl>;\n>>> It would be useful to include the remote DT nodes in the example too.\n>>>\n>>>> +\t\t\t};\n>>>> +\t\t};\n>>>> +\t};\n>\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xntRR1w3hz9sRY\n\tfor ;\n\tThu, 7 Sep 2017 18:10:11 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754591AbdIGIKI (ORCPT\n\t);\n\tThu, 7 Sep 2017 04:10:08 -0400","from mailout1.w1.samsung.com ([210.118.77.11]:48944 \"EHLO\n\tmailout1.w1.samsung.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754586AbdIGIKF (ORCPT\n\t); Thu, 7 Sep 2017 04:10:05 -0400","from eucas1p2.samsung.com (unknown [182.198.249.207])\n\tby mailout1.w1.samsung.com (KnoxPortal) with ESMTP id\n\t20170907081002euoutp01e0f386d73854d3c978914bad7a987d45~iBftXy4j22096420964euoutp01S;\n\tThu, 7 Sep 2017 08:10:02 +0000 (GMT)","from eusmges4.samsung.com (unknown [203.254.199.244]) by\n\teucas1p1.samsung.com (KnoxPortal) with ESMTP id\n\t20170907081001eucas1p1947e0022bbbe5744bf81327fd3c53ed5~iBfstZIyH1246612466eucas1p1A;\n\tThu, 7 Sep 2017 08:10:01 +0000 (GMT)","from eucas1p1.samsung.com ( [182.198.249.206]) by\n\teusmges4.samsung.com (EUCPMTA) with SMTP id 11.04.12944.9DEF0B95;\n\tThu, 7 Sep 2017 09:10:01 +0100 (BST)","from eusmgms2.samsung.com (unknown [182.198.249.180]) by\n\teucas1p2.samsung.com (KnoxPortal) with ESMTP id\n\t20170907081001eucas1p22470f1ea3a508b63c4d81a18e8756fcc~iBfsAvPNl2175421754eucas1p27;\n\tThu, 7 Sep 2017 08:10:01 +0000 (GMT)","from eusync4.samsung.com ( [203.254.199.214]) by\n\teusmgms2.samsung.com (EUCPMTA) with SMTP id 7A.D7.20118.9DEF0B95;\n\tThu, 7 Sep 2017 09:10:01 +0100 (BST)","from [106.120.43.17] by eusync4.samsung.com (Oracle Communications\n\tMessaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA\n\tid <0OVW009K2HCON890@eusync4.samsung.com>;\n\tThu, 07 Sep 2017 09:10:01 +0100 (BST)"],"X-AuditID":"cbfec7f4-f79ab6d000003290-24-59b0fed975fb","Subject":"Re: [PATCH v2 1/2] drm/bridge: add Silicon Image SiI9234 driver","To":"Laurent Pinchart ,\n\tMaciej Purski ","Cc":"dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,\n\tlinux-samsung-soc@vger.kernel.org, mark.rutland@arm.com,\n\tb.zolnierkie@samsung.com, krzk@kernel.org, robh+dt@kernel.org","From":"Andrzej Hajda ","Message-id":"<3492951c-f57a-99b5-7cc7-f3071b1893b9@samsung.com>","Date":"Thu, 07 Sep 2017 10:09:59 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-version":"1.0","In-reply-to":"<1569224.pDUtqo7azG@avalon>","Content-type":"text/plain; charset=\"utf-8\"","Content-transfer-encoding":"7bit","Content-language":"en-US","X-Brightmail-Tracker":["H4sIAAAAAAAAA+NgFlrHKsWRmVeSWpSXmKPExsWy7djPc7o3/22INFh2VsVi44z1rBbzj5xj\n\ttbjy9T2bxfnzG9gtOicuYbeYcX4fk8WCl7dYLJZev8hk0br3CLsDp8eaeWsYPWZ3zGT12LSq\n\tk83jfvdxJo++LasYPT5vkgtgi+KySUnNySxLLdK3S+DKePiph71gt1rFr7VH2BoYO+S7GDk5\n\tJARMJLbu6mWHsMUkLtxbzwZiCwksZZRYOkO1i5ELyP7MKNHX0MgG0/C9/S47RGIZo8TRrd+Z\n\tIZxnjBKTjtxiAqkSFvCQ2NqwigXEFhFIkOi6cp0ZxGYW2M0ocWeuMIjNJqAp8XfzTbCpvAJ2\n\tEmuu/wSzWQRUJbo+XQCbIyoQIbHt+wyoGkGJH5Pvgc3kFNCQOHH6NNRMTYkXXyaxQNjyEpvX\n\tvIWKi0s0t95kATlOQuAzm8T8T59YIV5wkXh+fjkLhC0s8er4Fqj/ZSQuT+6GauhmlPjUf4Id\n\twpnCKPHvwwxmiCpricPHL7JCrOCTmLRtOlCcAyjOK9HRJgRR4iGx49NnJgjbUeLd97VskCDq\n\tYJK4vecV8wRG+VlIPpqF5ItZSL6YheSLBYwsqxhFUkuLc9NTi030ihNzi0vz0vWS83M3MQJT\n\t0el/x7/sYFx8zOoQowAHoxIPb8L/9ZFCrIllxZW5hxglOJiVRHi1/myIFOJNSaysSi3Kjy8q\n\tzUktPsQozcGiJM5rG9UWKSSQnliSmp2aWpBaBJNl4uCUamCMmspZf5Xjy6VVsZFcV/5O5Gmu\n\tEzYVCngo6KHRdut/Vdwrbveg51Xp+1XkQtbPr+C69Xxn5dFjX7mXx11O8G7gEPleLqBwVN4m\n\tfvNJhshfIS/WPixmMojY/ozXsaxuC8dZjjfil7szJotYtHHPaYmZJGn/q9pOQnSDmsfqGqPr\n\tby6HHbp+RE6JpTgj0VCLuag4EQCiQACCQQMAAA==","H4sIAAAAAAAAA+NgFmpikeLIzCtJLcpLzFFi42I5/e/4Nd2b/zZEGiy6ymKxccZ6Vov5R86x\n\tWlz5+p7N4vz5DewWnROXsFvMOL+PyWLBy1ssFkuvX2SyaN17hN2B02PNvDWMHrM7ZrJ6bFrV\n\tyeZxv/s4k0ffllWMHp83yQWwRXHZpKTmZJalFunbJXBlPPzUw16wW63i19ojbA2MHfJdjJwc\n\tEgImEt/b77JD2GISF+6tZ+ti5OIQEljCKLFuyTJWCOcZo8TXD2+YQaqEBTwktjasYgGxRQQS\n\tJDpOTgLrYBbYzSix7+15FoiONiaJWXOesYJUsQloSvzdfJMNxOYVsJNYc/0nmM0ioCrR9ekC\n\tE4gtKhAh0ff2MjtEjaDEj8n3wDZwCmhInDh9GmgzB9AGdYkpU3JBwswC8hKb17xlhrDFJZpb\n\tb7JMYBSchaR7FkLHLCQds5B0LGBkWcUoklpanJueW2ykV5yYW1yal66XnJ+7iREYM9uO/dyy\n\tg7HrXfAhRgEORiUe3oT/6yOFWBPLiitzDzFKcDArifBq/dkQKcSbklhZlVqUH19UmpNafIhR\n\tmoNFSZy3d8/qSCGB9MSS1OzU1ILUIpgsEwenVAOjafUqY8f1MUe/+59aP7GZyePPwewHczkm\n\tr3hwWMkyWe3rmzdNz0uXn7q/9KPo22mmFr9PRVl1yO8TfK7u2findOchVq2g3SVOa4POWk7T\n\tuLVqxtpre50Pu0w5aLYp7IO74zTnHzuPTS6+9Ojq4y0b0r7Z1L2vP7WYxeq+dsr+73q3hHo3\n\t7z946YoSS3FGoqEWc1FxIgDSiR9slQIAAA=="],"X-CMS-MailID":"20170907081001eucas1p22470f1ea3a508b63c4d81a18e8756fcc","X-Msg-Generator":"CA","X-Sender-IP":"182.198.249.180","X-Local-Sender":"=?utf-8?q?Andrzej_Hajda=1BSRPOL-Kernel_=28TP=29=1B?=\n\t=?utf-8?b?7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?=","X-Global-Sender":"=?utf-8?q?Andrzej_Hajda=1BSRPOL-Kernel_=28TP=29=1BSamsun?=\n\t=?utf-8?q?g_Electronics=1BSenior_Software_Engineer?=","X-Sender-Code":"=?utf-8?q?C10=1BEHQ=1BC10CD02CD027392?=","CMS-TYPE":"201P","X-CMS-RootMailID":"20170905150603epcas2p16add56f42aca1f48cabca3329d359e1d","X-RootMTR":"20170905150603epcas2p16add56f42aca1f48cabca3329d359e1d","References":"<1504182434-8201-1-git-send-email-m.purski@samsung.com>\n\t<2326944.Wi9TMObRze@avalon>\n\t\n\t\n\t<1569224.pDUtqo7azG@avalon>","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]