[{"id":1760937,"web_url":"http://patchwork.ozlabs.org/comment/1760937/","msgid":"<9df365ed-4c97-34b6-e739-360866929f5d@redhat.com>","list_archive_url":null,"date":"2017-08-31T12:53:16","subject":"Re: [Qemu-devel] [PATCH 1/1] s390x/css: fix cc handling for XSCH","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 31.08.2017 14:18, Halil Pasic wrote:\n> The function ioinst_handle_xsch is presenting cc 2 when it's supposed to\n> present cc 1 and the other way around, because css_do_xsch has the error\n> codes mixed up. Because cc 1 has precedence over cc 2 we also have to\n> swap the two checks.\n> \n> Let us fix this.\n> \n> Signed-off-by: Halil Pasic \n> Reported-by: Pierre Morel \n> ---\n> \n> Was previously a part of a series (due to an accident the\n> series had no name). This version also fixes the priority\n> (aka precedence) problem.\n> \n> ---\n> hw/s390x/css.c | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/hw/s390x/css.c b/hw/s390x/css.c\n> index 1880b1a0ff..e04e0ea3a8 100644\n> --- a/hw/s390x/css.c\n> +++ b/hw/s390x/css.c\n> @@ -1276,16 +1276,16 @@ int css_do_xsch(SubchDev *sch)\n> goto out;\n> }\n> \n> + if (s->ctrl & SCSW_CTRL_MASK_STCTL) {\n> + ret = -EINPROGRESS;\n> + goto out;\n> + }\n> +\n> if (!(s->ctrl & SCSW_CTRL_MASK_FCTL) ||\n> ((s->ctrl & SCSW_CTRL_MASK_FCTL) != SCSW_FCTL_START_FUNC) ||\n> (!(s->ctrl &\n> (SCSW_ACTL_RESUME_PEND | SCSW_ACTL_START_PEND | SCSW_ACTL_SUSP))) ||\n> (s->ctrl & SCSW_ACTL_SUBCH_ACTIVE)) {\n> - ret = -EINPROGRESS;\n> - goto out;\n> - }\n> -\n> - if (s->ctrl & SCSW_CTRL_MASK_STCTL) {\n> ret = -EBUSY;\n> goto out;\n> }\n> \n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjj3v2wM6z9s7g\n\tfor ;\n\tThu, 31 Aug 2017 22:53:47 +1000 (AEST)","from localhost ([::1]:55633 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnOyf-0001s0-Ij\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 08:53:45 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47871)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnOyJ-0001rf-Gb\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 08:53:24 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnOyG-0007NL-FV\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 08:53:23 -0400","from mx1.redhat.com ([209.132.183.28]:35756)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnOyG-0007Mu-8G\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 08:53:20 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E0D835AFED;\n\tThu, 31 Aug 2017 12:53:18 +0000 (UTC)","from [10.36.116.27] (ovpn-116-27.ams2.redhat.com [10.36.116.27])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 9FA6A9ABBC;\n\tThu, 31 Aug 2017 12:53:17 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E0D835AFED","To":"Halil Pasic , Cornelia Huck ","References":"<20170831121828.85885-1-pasic@linux.vnet.ibm.com>","From":"Thomas Huth ","Message-ID":"<9df365ed-4c97-34b6-e739-360866929f5d@redhat.com>","Date":"Thu, 31 Aug 2017 14:53:16 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170831121828.85885-1-pasic@linux.vnet.ibm.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tThu, 31 Aug 2017 12:53:19 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/1] s390x/css: fix cc handling for XSCH","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Dong Jia Shi ,\n\tPierre Morel , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1760985,"web_url":"http://patchwork.ozlabs.org/comment/1760985/","msgid":"<20170831152433.0394264e.cohuck@redhat.com>","list_archive_url":null,"date":"2017-08-31T13:24:33","subject":"Re: [Qemu-devel] [PATCH 1/1] s390x/css: fix cc handling for XSCH","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Thu, 31 Aug 2017 14:18:28 +0200\nHalil Pasic wrote:\n\n> The function ioinst_handle_xsch is presenting cc 2 when it's supposed to\n> present cc 1 and the other way around, because css_do_xsch has the error\n> codes mixed up. Because cc 1 has precedence over cc 2 we also have to\n> swap the two checks.\n> \n> Let us fix this.\n> \n> Signed-off-by: Halil Pasic \n> Reported-by: Pierre Morel \n> ---\n> \n> Was previously a part of a series (due to an accident the\n> series had no name). This version also fixes the priority\n> (aka precedence) problem.\n> \n> ---\n> hw/s390x/css.c | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n\nThanks, applied.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjjm83zZZz9sPm\n\tfor ;\n\tThu, 31 Aug 2017 23:25:12 +1000 (AEST)","from localhost ([::1]:55811 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnPT4-0006iD-JX\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 09:25:10 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56767)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnPSb-0006gt-QJ\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:24:42 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnPSX-00042P-Ru\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:24:41 -0400","from mx1.redhat.com ([209.132.183.28]:49970)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnPSX-00042G-LX\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:24:37 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id A96514629B;\n\tThu, 31 Aug 2017 13:24:36 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 69E6EC4517;\n\tThu, 31 Aug 2017 13:24:35 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com A96514629B","Date":"Thu, 31 Aug 2017 15:24:33 +0200","From":"Cornelia Huck ","To":"Halil Pasic ","Message-ID":"<20170831152433.0394264e.cohuck@redhat.com>","In-Reply-To":"<20170831121828.85885-1-pasic@linux.vnet.ibm.com>","References":"<20170831121828.85885-1-pasic@linux.vnet.ibm.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tThu, 31 Aug 2017 13:24:36 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/1] s390x/css: fix cc handling for XSCH","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Dong Jia Shi ,\n\tPierre Morel ,\n\tThomas Huth , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]