[{"id":1760917,"web_url":"http://patchwork.ozlabs.org/comment/1760917/","msgid":"","list_archive_url":null,"date":"2017-08-31T12:30:28","subject":"Re: [PATCH] libio: Assume _LIBC, weak_alias, errno, (__set_)errno &c\n\tare defined","submitter":{"id":65878,"url":"http://patchwork.ozlabs.org/api/people/65878/","name":"Zack Weinberg","email":"zackw@panix.com"},"content":"On Thu, Aug 31, 2017 at 8:14 AM, Florian Weimer wrote:\n> libio lives exclusively in glibc these days, so there is no reason to\n> preserve _LIBC conditionals.\n>\n> While at it, I also removed some unnecessary indirections and conditions\n> on other always-defined macros (F_GETFL, EIO, etc.).\n>\n> I checked that this does not change the produced binaries on i686.\n\nLGTM.\n\nIf you're in a mood to clean up libio, may I suggest going after\n_IO_MTSAFE_IO next? ;-)\n\nzw","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-83912-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"a/5jA+Xl\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjhYS5G00z9sMN\n\tfor ;\n\tThu, 31 Aug 2017 22:30:52 +1000 (AEST)","(qmail 78640 invoked by alias); 31 Aug 2017 12:30:46 -0000","(qmail 78476 invoked by uid 89); 31 Aug 2017 12:30:45 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; q=dns; s=default; b=mvrC\n\t10vEM8mDjXYTNHIce2RDtwQ8LADXvLrDb++Ezdb2Jewv3AFREtoGW0ZqdZlhuKMM\n\tEvm8VjDmPRa2Ntm608/8yCq6azO6/fX9vb3amcQ+40P/Hi948U5UU9DO6lg6ZxpH\n\tK3+DHfKRy0v3yLXwQ71l/WpuKqcXWC2SJcA2ewY=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; s=default; bh=NN3EePlmlu\n\tc1RnTEbJ6o+Xgbo8Y=; b=a/5jA+Xl4qA+y8iVQu7lLyUFG+pI4U4UyjZfODGEKT\n\t6lct2HkpyriKskC+mQiMnFmC0BojHzcGminXHN/5IfLlDthfSzWpQMO+Lcv+Dq9+\n\tWKjVtJkyr9ZUtU6NvdzG6hgRt+kniTChtrN6t5wG1wYkDrkLSJeyjeXlqzPl8ghW\n\ts=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.5 required=5.0 tests=AWL, BAYES_00,\n\tRCVD_IN_SORBS_SPAM, RP_MATCHES_RCVD,\n\tSPF_PASS autolearn=no version=3.3.2 spammy=mood","X-HELO":"mailbackend.panix.com","X-Gm-Message-State":"AHPjjUj7kf6pknfkSxcAq3i1wrcyMMOJbr83RWB48MQgJSR9DM49VTyS\n\twivQhYhEHtsOVzC4VWGDtpC54jTW9Q==","X-Google-Smtp-Source":"ADKCNb4U2AHW/XO1mL4CoAjx270FTS0o20K0XzZLLe5uXfpL6kVlf0zY8TF1LVdo3f3tsXlLfcIG1v8UF5dSmsoOddY=","X-Received":"by 10.107.130.166 with SMTP id m38mr4738279ioi.325.1504182632938;\n\tThu, 31 Aug 2017 05:30:32 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<4919e435-9006-dd2d-8811-2a732f9fdac7@redhat.com>","References":"<4919e435-9006-dd2d-8811-2a732f9fdac7@redhat.com>","From":"Zack Weinberg ","Date":"Thu, 31 Aug 2017 08:30:28 -0400","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH] libio: Assume _LIBC, weak_alias, errno, (__set_)errno &c\n\tare defined","To":"Florian Weimer ","Cc":"GNU C Library ","Content-Type":"text/plain; charset=\"UTF-8\""}},{"id":1760930,"web_url":"http://patchwork.ozlabs.org/comment/1760930/","msgid":"","list_archive_url":null,"date":"2017-08-31T12:47:38","subject":"Re: [PATCH] libio: Assume _LIBC, weak_alias, errno, (__set_)errno &c\n\tare defined","submitter":{"id":14312,"url":"http://patchwork.ozlabs.org/api/people/14312/","name":"Florian Weimer","email":"fweimer@redhat.com"},"content":"On 08/31/2017 02:30 PM, Zack Weinberg wrote:\n> On Thu, Aug 31, 2017 at 8:14 AM, Florian Weimer wrote:\n>> libio lives exclusively in glibc these days, so there is no reason to\n>> preserve _LIBC conditionals.\n>>\n>> While at it, I also removed some unnecessary indirections and conditions\n>> on other always-defined macros (F_GETFL, EIO, etc.).\n>>\n>> I checked that this does not change the produced binaries on i686.\n> \n> LGTM.\n> \n> If you're in a mood to clean up libio, may I suggest going after\n> _IO_MTSAFE_IO next? ;-)\n\nAfter internal_function perhaps. _IO_MTSAFE_IO is quite hard because\nit's not consistently defined across glibc.\n\nThanks,\nFlorian","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-83913-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"GR2P4hSF\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=fweimer@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjhxC6TCnz9s7g\n\tfor ;\n\tThu, 31 Aug 2017 22:47:59 +1000 (AEST)","(qmail 85979 invoked by alias); 31 Aug 2017 12:47:52 -0000","(qmail 85928 invoked by uid 89); 31 Aug 2017 12:47:51 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=IH/yb+GHFcq3JA9L\n\tO7BUZIZl5fGeTqG6+eJBdzAk2C7LuNZLBLzNNQ2Zqgv3G5B38Q+fvK6ZjIQmTl6I\n\tpt3FcqZM6SrHjHBeim5D3CUpldL0m2xdagRiSTN5urdx2WJ/0y/ie/Xiqhq+vrLC\n\tCM74tjH2p5aSA4aKGoSMAoaL4p0=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=ba+vTc2Dz5CniYd8sHke+S\n\tFRzWc=; b=GR2P4hSF6KxxOrPdUiX7PxoVQ2m4s7CW2IBEKDGGe4OU5+8eYwhOBV\n\thteDko9pE2CvZMtkn27ppu88cFhpmrxarrCEDhQv4rNqAH1nDsWB4/YSDEnyGe29\n\tojIvXwjCKVDR8W9Bt0W6CLn/ZKBfQeX02vPkjgxnuAwIACf7Ir7Xc=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,\n\tRP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2 spammy=mood","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 8CE04C057F93","Subject":"Re: [PATCH] libio: Assume _LIBC, weak_alias, errno, (__set_)errno &c\n\tare defined","To":"Zack Weinberg ","Cc":"GNU C Library ","References":"<4919e435-9006-dd2d-8811-2a732f9fdac7@redhat.com>\n\t","From":"Florian Weimer ","Message-ID":"","Date":"Thu, 31 Aug 2017 14:47:38 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}}]