[{"id":1760921,"web_url":"http://patchwork.ozlabs.org/comment/1760921/","msgid":"<59A80308.307@iogearbox.net>","list_archive_url":null,"date":"2017-08-31T12:37:28","subject":"Re: [PATCH net-next] x86: bpf_jit: small optimization in\n\temit_bpf_tail_call()","submitter":{"id":65705,"url":"http://patchwork.ozlabs.org/api/people/65705/","name":"Daniel Borkmann","email":"daniel@iogearbox.net"},"content":"On 08/31/2017 01:53 PM, Eric Dumazet wrote:\n> From: Eric Dumazet \n>\n> Saves 4 bytes replacing following instructions :\n>\n> lea rax, [rsi + rdx * 8 + offsetof(...)]\n> mov rax, qword ptr [rax]\n> cmp rax, 0\n>\n> by :\n>\n> mov rax, [rsi + rdx * 8 + offsetof(...)]\n> test rax, rax\n>\n> Signed-off-by: Eric Dumazet \n> Cc: Alexei Starovoitov \n> Cc: Daniel Borkmann \n\nLGTM, thanks Eric!\n\nAcked-by: Daniel Borkmann ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjhjF07TQz9s7g\n\tfor ;\n\tThu, 31 Aug 2017 22:37:36 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751547AbdHaMhe (ORCPT );\n\tThu, 31 Aug 2017 08:37:34 -0400","from www62.your-server.de ([213.133.104.62]:46778 \"EHLO\n\twww62.your-server.de\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751453AbdHaMhd (ORCPT\n\t); Thu, 31 Aug 2017 08:37:33 -0400","from [92.105.166.74] (helo=localhost.localdomain)\n\tby www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-SHA:256)\n\t(Exim 4.85_2) (envelope-from )\n\tid 1dnOiv-0007fX-1t; Thu, 31 Aug 2017 14:37:29 +0200"],"Message-ID":"<59A80308.307@iogearbox.net>","Date":"Thu, 31 Aug 2017 14:37:28 +0200","From":"Daniel Borkmann ","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:31.0) Gecko/20100101 Thunderbird/31.7.0","MIME-Version":"1.0","To":"Eric Dumazet , David Miller ","CC":"netdev , Alexei Starovoitov ","Subject":"Re: [PATCH net-next] x86: bpf_jit: small optimization in\n\temit_bpf_tail_call()","References":"<1504180422.15310.12.camel@edumazet-glaptop3.roam.corp.google.com>","In-Reply-To":"<1504180422.15310.12.camel@edumazet-glaptop3.roam.corp.google.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","X-Authenticated-Sender":"daniel@iogearbox.net","X-Virus-Scanned":"Clear (ClamAV 0.99.2/23745/Thu Aug 31 10:37:08 2017)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1761066,"web_url":"http://patchwork.ozlabs.org/comment/1761066/","msgid":"<20170831143818.6s7lbu6ai7dqveah@ast-mbp.dhcp.thefacebook.com>","list_archive_url":null,"date":"2017-08-31T14:38:20","subject":"Re: [PATCH net-next] x86: bpf_jit: small optimization in\n\temit_bpf_tail_call()","submitter":{"id":42586,"url":"http://patchwork.ozlabs.org/api/people/42586/","name":"Alexei Starovoitov","email":"alexei.starovoitov@gmail.com"},"content":"On Thu, Aug 31, 2017 at 04:53:42AM -0700, Eric Dumazet wrote:\n> From: Eric Dumazet \n> \n> Saves 4 bytes replacing following instructions :\n> \n> lea rax, [rsi + rdx * 8 + offsetof(...)] \n> mov rax, qword ptr [rax]\n> cmp rax, 0\n> \n> by :\n> \n> mov rax, [rsi + rdx * 8 + offsetof(...)] \n> test rax, rax\n> \n> Signed-off-by: Eric Dumazet \n\nNicely spotted. Much appreciate it!\nAcked-by: Alexei Starovoitov ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"uaD1BztD\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjlNc0QnMz9s7G\n\tfor ;\n\tFri, 1 Sep 2017 00:38:24 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751431AbdHaOiV (ORCPT );\n\tThu, 31 Aug 2017 10:38:21 -0400","from mail-pg0-f67.google.com ([74.125.83.67]:35035 \"EHLO\n\tmail-pg0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751011AbdHaOiU (ORCPT\n\t); Thu, 31 Aug 2017 10:38:20 -0400","by mail-pg0-f67.google.com with SMTP id r133so598080pgr.2\n\tfor ; Thu, 31 Aug 2017 07:38:20 -0700 (PDT)","from ast-mbp.dhcp.thefacebook.com ([2620:10d:c090:200::7:324e])\n\tby smtp.gmail.com with ESMTPSA id\n\tu73sm7724482pfk.79.2017.08.31.07.38.18\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 31 Aug 2017 07:38:18 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=nkinr59LQlFVrKL0NbNFicye16Dbe0vziKC+Ktq7nvY=;\n\tb=uaD1BztDoErf4XCrAU47+tavM5DHh/VPgEap0I5BZSuhLZ0ZgfByaeJ6p6a2uw8LZB\n\tVlfJY7ZYmvVA5lL4FYAIP9BH8jhMl4MgJx2Jzti0FZOMKeknDmuSrKlXQtlgtvK+GR35\n\tuM/2U2J+EhdB5uiJdPQsl8q0lAQyACGg8uIrQLE8rs0LbXtoWeh0GPGY/5nww3my9KsY\n\tfQ1yJG6v2E10g4tdXCYV1NE3NW270EQR/9fKLtWp92ZHvQ7cdWIAvdHE9Y0VVhRcjdxt\n\tg8ICNjyWQ4u6NHEgDjVaUX7fowToHxzMVeEVRbxQF2/LvOEi3rsslKOeVmRrQiPOskYC\n\tEcTw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=nkinr59LQlFVrKL0NbNFicye16Dbe0vziKC+Ktq7nvY=;\n\tb=aFlsMn16VOYL/q+eOBt+9hiuNfSkzbmA5xMPxLHdEsBcdKXK8hIxpOZ+fxWLmjGh5N\n\t+GXOQTX9OmAC15/jArE76P0rhOllgdTi8u7h6XBpOPxLjYUfJaOSwy/k3KZk/RmdiQcI\n\t2MKdmDePg/H3oSvzmzSBQckfhE41ZFhgGsn/6EzCWsLH/ml2ah/mphaU5OG+rIW6gSby\n\tflmBilx69khpW0waCS//jk2a1VMKXxpsVNp0x9p1AlzY0DZXeCqHttIY4RRKk2RUfPY9\n\tij42cgh9e/AQIKU5o9jtiSknxfjldCoB108Bt5lcgeJ/RLIawF24DD6uHGXmgXPoARtE\n\tNHjw==","X-Gm-Message-State":"AHYfb5ilk2NrG2CpM01UhItq9ZKIf3tQNCr8dCvUAT8knabwgxTHcunX\n\t8WZiyHMsfcgQWw==","X-Google-Smtp-Source":"ADKCNb6eprWIVsI5nzLX3agorSBLEIqzC5EFAVlxu2Oru3jEvB++C2pcxl497Wh5fkwVEpkAqYD6Hw==","X-Received":"by 10.84.167.2 with SMTP id c2mr2844146plb.421.1504190299818;\n\tThu, 31 Aug 2017 07:38:19 -0700 (PDT)","Date":"Thu, 31 Aug 2017 07:38:20 -0700","From":"Alexei Starovoitov ","To":"Eric Dumazet ","Cc":"David Miller , netdev ,\n\tAlexei Starovoitov ,\n\tDaniel Borkmann ","Subject":"Re: [PATCH net-next] x86: bpf_jit: small optimization in\n\temit_bpf_tail_call()","Message-ID":"<20170831143818.6s7lbu6ai7dqveah@ast-mbp.dhcp.thefacebook.com>","References":"<1504180422.15310.12.camel@edumazet-glaptop3.roam.corp.google.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1504180422.15310.12.camel@edumazet-glaptop3.roam.corp.google.com>","User-Agent":"NeoMutt/20170421 (1.8.2)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1761267,"web_url":"http://patchwork.ozlabs.org/comment/1761267/","msgid":"<20170831.115814.350681783104301165.davem@davemloft.net>","list_archive_url":null,"date":"2017-08-31T18:58:14","subject":"Re: [PATCH net-next] x86: bpf_jit: small optimization in\n\temit_bpf_tail_call()","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Eric Dumazet \nDate: Thu, 31 Aug 2017 04:53:42 -0700\n\n> From: Eric Dumazet \n> \n> Saves 4 bytes replacing following instructions :\n> \n> lea rax, [rsi + rdx * 8 + offsetof(...)] \n> mov rax, qword ptr [rax]\n> cmp rax, 0\n> \n> by :\n> \n> mov rax, [rsi + rdx * 8 + offsetof(...)] \n> test rax, rax\n> \n> Signed-off-by: Eric Dumazet \n\nApplied.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjs8T4krlz9s7f\n\tfor ;\n\tFri, 1 Sep 2017 04:58:17 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751755AbdHaS6Q (ORCPT );\n\tThu, 31 Aug 2017 14:58:16 -0400","from shards.monkeyblade.net ([184.105.139.130]:55974 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751639AbdHaS6P (ORCPT\n\t); Thu, 31 Aug 2017 14:58:15 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 6B6C112537446;\n\tThu, 31 Aug 2017 11:58:14 -0700 (PDT)"],"Date":"Thu, 31 Aug 2017 11:58:14 -0700 (PDT)","Message-Id":"<20170831.115814.350681783104301165.davem@davemloft.net>","To":"eric.dumazet@gmail.com","Cc":"netdev@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net","Subject":"Re: [PATCH net-next] x86: bpf_jit: small optimization in\n\temit_bpf_tail_call()","From":"David Miller ","In-Reply-To":"<1504180422.15310.12.camel@edumazet-glaptop3.roam.corp.google.com>","References":"<1504180422.15310.12.camel@edumazet-glaptop3.roam.corp.google.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Thu, 31 Aug 2017 11:58:14 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]