[{"id":1760842,"web_url":"http://patchwork.ozlabs.org/comment/1760842/","msgid":"<20170831132710.3b245a6a@redhat.com>","list_archive_url":null,"date":"2017-08-31T11:27:10","subject":"Re: [PATCH net-next] samples/bpf: Fix compilation issue in redirect\n\tdummy program","submitter":{"id":13625,"url":"http://patchwork.ozlabs.org/api/people/13625/","name":"Jesper Dangaard Brouer","email":"brouer@redhat.com"},"content":"On Thu, 31 Aug 2017 14:16:39 +0300\nTariq Toukan wrote:\n\n> Fix compilation error below:\n> \n> $ make samples/bpf/\n> \n> LLVM ERROR: 'xdp_redirect_dummy' label emitted multiple times to\n> assembly file\n> make[1]: *** [samples/bpf/xdp_redirect_kern.o] Error 1\n> make: *** [samples/bpf/] Error 2\n> \n> Fixes: 306da4e685b4 (\"samples/bpf: xdp_redirect load XDP dummy prog on TX device\")\n> Signed-off-by: Tariq Toukan \n> ---\n\nAcked-by: Jesper Dangaard Brouer \n\nWhat LLVM/clang version do you use?\n\nI don't see this compile error, and I have:\n $ clang --version\n clang version 3.9.1 (tags/RELEA","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=brouer@redhat.com"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjg8B3GGQz9t1t\n\tfor ;\n\tThu, 31 Aug 2017 21:27:22 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751286AbdHaL1S (ORCPT );\n\tThu, 31 Aug 2017 07:27:18 -0400","from mx1.redhat.com ([209.132.183.28]:50520 \"EHLO mx1.redhat.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751250AbdHaL1Q (ORCPT );\n\tThu, 31 Aug 2017 07:27:16 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id AD1C181DFD;\n\tThu, 31 Aug 2017 11:27:16 +0000 (UTC)","from localhost (ovpn-200-27.brq.redhat.com [10.40.200.27])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id AAF7F60A98;\n\tThu, 31 Aug 2017 11:27:12 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com AD1C181DFD","Date":"Thu, 31 Aug 2017 13:27:10 +0200","From":"Jesper Dangaard Brouer ","To":"Tariq Toukan ","Cc":"brouer@redhat.com, \"David S. Miller\" ,\n\tnetdev@vger.kernel.org, Eran Ben Elisha ","Subject":"Re: [PATCH net-next] samples/bpf: Fix compilation issue in redirect\n\tdummy program","Message-ID":"<20170831132710.3b245a6a@redhat.com>","In-Reply-To":"<1504178199-12410-1-git-send-email-tariqt@mellanox.com>","References":"<1504178199-12410-1-git-send-email-tariqt@mellanox.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tThu, 31 Aug 2017 11:27:16 +0000 (UTC)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1760863,"web_url":"http://patchwork.ozlabs.org/comment/1760863/","msgid":"<59A7F658.4020606@iogearbox.net>","list_archive_url":null,"date":"2017-08-31T11:43:20","subject":"Re: [PATCH net-next] samples/bpf: Fix compilation issue in redirect\n\tdummy program","submitter":{"id":65705,"url":"http://patchwork.ozlabs.org/api/people/65705/","name":"Daniel Borkmann","email":"daniel@iogearbox.net"},"content":"On 08/31/2017 01:27 PM, Jesper Dangaard Brouer wrote:\n> On Thu, 31 Aug 2017 14:16:39 +0300\n> Tariq Toukan wrote:\n>\n>> Fix compilation error below:\n>>\n>> $ make samples/bpf/\n>>\n>> LLVM ERROR: 'xdp_redirect_dummy' label emitted multiple times to\n>> assembly file\n>> make[1]: *** [samples/bpf/xdp_redirect_kern.o] Error 1\n>> make: *** [samples/bpf/] Error 2\n>>\n>> Fixes: 306da4e685b4 (\"samples/bpf: xdp_redirect load XDP dummy prog on TX device\")\n>> Signed-off-by: Tariq Toukan \n>> ---\n>\n> Acked-by: Jesper Dangaard Brouer \n\nAcked-by: Daniel Borkmann \n\n> What LLVM/clang version do you use?\n>\n> I don't see this compile error, and I have:\n> $ clang --version\n> clang version 3.9.1 (tags/RELEA\n\nI'm seeing the error as well with a fairly recent LLVM from git\ntree (6.0.0git-2d810c2).\n\nLooks like the llvm error is triggered when section name and\nthe function name for XDP prog is the same. Changing either the\nfunction or the section name right above resolves the issue. If\nsuch error didn't trigger on older versions, people could be\nusing such naming scheme as done here, so seems to me like a\nregression on LLVM side we might need to look at ...\n\nIn any case, patch here is fine, thanks!","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjgVr227Dz9sQl\n\tfor ;\n\tThu, 31 Aug 2017 21:43:32 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751024AbdHaLna (ORCPT );\n\tThu, 31 Aug 2017 07:43:30 -0400","from www62.your-server.de ([213.133.104.62]:37874 \"EHLO\n\twww62.your-server.de\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750908AbdHaLn3 (ORCPT\n\t); Thu, 31 Aug 2017 07:43:29 -0400","from [92.105.166.74] (helo=localhost.localdomain)\n\tby www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-SHA:256)\n\t(Exim 4.85_2) (envelope-from )\n\tid 1dnNsY-0000PF-91; Thu, 31 Aug 2017 13:43:22 +0200"],"Message-ID":"<59A7F658.4020606@iogearbox.net>","Date":"Thu, 31 Aug 2017 13:43:20 +0200","From":"Daniel Borkmann ","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:31.0) Gecko/20100101 Thunderbird/31.7.0","MIME-Version":"1.0","To":"Jesper Dangaard Brouer ,\n\tTariq Toukan ","CC":"\"David S. Miller\" , netdev@vger.kernel.org,\n\tEran Ben Elisha , ys114321@gmail.com,\n\talexei.starovoitov@gmail.com","Subject":"Re: [PATCH net-next] samples/bpf: Fix compilation issue in redirect\n\tdummy program","References":"<1504178199-12410-1-git-send-email-tariqt@mellanox.com>\n\t<20170831132710.3b245a6a@redhat.com>","In-Reply-To":"<20170831132710.3b245a6a@redhat.com>","Content-Type":"text/plain; charset=windows-1252; format=flowed","Content-Transfer-Encoding":"7bit","X-Authenticated-Sender":"daniel@iogearbox.net","X-Virus-Scanned":"Clear (ClamAV 0.99.2/23745/Thu Aug 31 10:37:08 2017)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1760916,"web_url":"http://patchwork.ozlabs.org/comment/1760916/","msgid":"","list_archive_url":null,"date":"2017-08-31T12:29:46","subject":"Re: [PATCH net-next] samples/bpf: Fix compilation issue in redirect\n\tdummy program","submitter":{"id":68926,"url":"http://patchwork.ozlabs.org/api/people/68926/","name":"Tariq Toukan","email":"tariqt@mellanox.com"},"content":"On 31/08/2017 2:43 PM, Daniel Borkmann wrote:\n> On 08/31/2017 01:27 PM, Jesper Dangaard Brouer wrote:\n>> On Thu, 31 Aug 2017 14:16:39 +0300\n>> Tariq Toukan wrote:\n>>\n>>> Fix compilation error below:\n>>>\n>>> $ make samples/bpf/\n>>>\n>>> LLVM ERROR: 'xdp_redirect_dummy' label emitted multiple times to\n>>> assembly file\n>>> make[1]: *** [samples/bpf/xdp_redirect_kern.o] Error 1\n>>> make: *** [samples/bpf/] Error 2\n>>>\n>>> Fixes: 306da4e685b4 (\"samples/bpf: xdp_redirect load XDP dummy prog \n>>> on TX device\")\n>>> Signed-off-by: Tariq Toukan \n>>> ---\n>>\n>> Acked-by: Jesper Dangaard Brouer \n> \n> Acked-by: Daniel Borkmann \n> \n>> What LLVM/clang version do you use?\n\nclang version 3.8.0 (tags/RELEASE_380/final)\n\n>>\n>> I don't see this compile error, and I have:\n>>   $ clang --version\n>>   clang version 3.9.1 (tags/RELEA\n> \n> I'm seeing the error as well with a fairly recent LLVM from git\n> tree (6.0.0git-2d810c2).\n> \n> Looks like the llvm error is triggered when section name and\n> the function name for XDP prog is the same. Changing either the\n> function or the section name right above resolves the issue. If\n> such error didn't trigger on older versions, people could be\n> using such naming scheme as done here, so seems to me like a\n> regression on LLVM side we might need to look at ...\nAgreed.\n> \n> In any case, patch here is fine, thanks!\n\nThank you.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=Mellanox.com header.i=@Mellanox.com\n\theader.b=\"MAaiVdoV\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=tariqt@mellanox.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjhY61s0hz9sMN\n\tfor ;\n\tThu, 31 Aug 2017 22:30:34 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751415AbdHaMac (ORCPT );\n\tThu, 31 Aug 2017 08:30:32 -0400","from mail-db5eur01on0067.outbound.protection.outlook.com\n\t([104.47.2.67]:50891\n\t\"EHLO EUR01-DB5-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1750938AbdHaMaa (ORCPT );\n\tThu, 31 Aug 2017 08:30:30 -0400","from [10.8.2.253] (193.47.165.251) by\n\tVI1PR05MB1805.eurprd05.prod.outlook.com (2a01:111:e400:7a60::15) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10;\n\tThu, 31 Aug 2017 12:29:55 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=4DdFWhaYI8x2g9v79JPlvRK8EmxUTUjFPwrN73bOT10=;\n\tb=MAaiVdoVjB0gUhZMI9Y0krD7dBxaBE49sWYUaei0PjJY3IsHXSu118WHb/dZ1izWbTnGH28hO8VQz6UDFG6ipA6DLUAJoSkNlrIHfckDNDliGpXPVC9zgplVk8Ys+DgBOo1Sd5HPug1umLt+LE3+yiie1/1O4kmvhyr3vQIxBsc=","Subject":"Re: [PATCH net-next] samples/bpf: Fix compilation issue in redirect\n\tdummy program","To":"Daniel Borkmann ,\n\tJesper Dangaard Brouer ,\n\tTariq Toukan ","Cc":"\"David S. Miller\" , netdev@vger.kernel.org,\n\tEran Ben Elisha , ys114321@gmail.com,\n\talexei.starovoitov@gmail.com","References":"<1504178199-12410-1-git-send-email-tariqt@mellanox.com>\n\t<20170831132710.3b245a6a@redhat.com> <59A7F658.4020606@iogearbox.net>","From":"Tariq Toukan ","Message-ID":"","Date":"Thu, 31 Aug 2017 15:29:46 +0300","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<59A7F658.4020606@iogearbox.net>","Content-Type":"text/plain; charset=windows-1252; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-Originating-IP":"[193.47.165.251]","X-ClientProxiedBy":"VI1P18901CA0015.EURP189.PROD.OUTLOOK.COM\n\t(2603:10a6:801::25) To VI1PR05MB1805.eurprd05.prod.outlook.com\n\t(2a01:111:e400:7a60::15)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"21d8e7dd-3446-4569-0cdc-08d4f06bfcda","X-MS-Office365-Filtering-HT":"Tenant","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:VI1PR05MB1805; ","X-Microsoft-Exchange-Diagnostics":["1; VI1PR05MB1805;\n\t3:MK0N6NjAw4Csp8YDNHdG0JvI3KjWM/j3FZK/W8nWgu5ryyaWiD1PJBJqnGOYuuj2e5E5bdIFEXz5GID9yfXWMqVvqNJAmYHlRHiFgVneCaElvwOpOIvnKIpio1BHuLdM7GvKJBUPk5rA1mavRLy1+CVkEnCr4rw62iecsyUQ7tQfPtssdGcXkUjm+L4YpkFRUh8cbyVqP71IZm9N8Ll3AGFi+rom8/x53ShWf/l+ncnuCCGxHDbd5Fa5ZXDKqRjJ;\n\t25:d50bRGcnMu0iLohN4cwYDa2sct9HED8+oyzC0Z9Fys2nGjSIsm0ianyiCE4MKTeEcaGfZ5xKzcapBtlluVW+LRg79M76TThgemAVH0T+xQ65+PhcQGTuS//lRNnBAT5VCwb4upzVeTPlnCD8G07g7z/pZymmRirlK4+OGQpX21bawEAE4VxPCti82Z9R8eFNHGS7oqXbPd2oFNAjeCI4f542IyhZ9XPgZn9nIDqHHGguAlJM5sL9AWKJBDNDVAi9iSW3JBBAwr8ESRvyGOiTGD3z0y7t0yFc//1a/lYKh5MTkovyEkE29EoSIuciSWKXyoPbY3y/O0Sty3rODAgZCw==;\n\t31:JuIREIcmXR62CaNKR6apiTvpvAzhKOw2/FNnJXjujuUt5WV66CvwrWBHOEykLBPMBhKePw4UL0kPjc93xl/hYn41Fets8dk3Plrf+kDihyTv35RJCWXsb1n2vVm29uc72K0ZLlbi4S7at6ar2rPLOtCOkvgtYJ8p4BEuagi4G/tFR2rod3bEAfx6vQGDk96Sd5KmWVuDOqOiQ4Ev+qWJ1CoC5dDhLHJBBRzJRYif4NY=","1; VI1PR05MB1805;\n\t20:WgJg+qxNMSjvpRsWOpsNywvW/s7XzfIEz2nawx4kxGKQEyS0pB5AIeeavT51EHSTkR1btdWrwZooe+XczJwg9Th/C4QFpoy8RGp6XLNYJgwxDNLaiWrW3pQJswsxKqUCoBnJNqbLXideQd8ezZCzNMPkvEnROv9WJrY9wYeWu48dGi6Y3n1PWF5RmXk8a2of18EVIjAeXRdbybJ1xfTS2YxjiXREqoA9Lsik46v2LvgJjgLX0EDpEdD05tI4/hqdx4alA0wrAVHXqGyKKz4WhYKVoRsFBsEbEK2OEa0kHO+SA/eQ2hoDnK/h3PQBIm1a6WQUjZHLh0+iTnfDZl/MtE48lw1pn0vfzy6F9YEKMpfGrzkezviivn6SULvJHBe+0v0Mv5UcVgvS7/Ou8t0w/MbIY8IaI9/cX8m0Lv7eazmW9LCWB746rfRkC2IQ2o//qSX1HJdJ30bmSJC5N8qdU0oXY/pxJteaX9h1/kDujyJgHc6CtJ5TSymwcA157Au1;\n\t4:0DXLtVdyh73Jc65O6w6fxcDu0jEnSojx5gghU1TSHjzwrpPoUaW5LRPodj7RoSEcGYun9wHEhi+4mrcM4lU2vn/4CSa9SPYWz1fS2PuYAvvchxF9w/Q0TOhWmARLzd3MQJ/sYA5ulXUUEuqdSzJR8Oqc2nX1UY9kcCJADhT/UTapZmURv8kJAHGVVo/iRad+YpRBP5o42CUlD7dxwLIleHU3iJ6M66DyQp2ONGSKsG2onnMY8blDvloAJEpvfbTz","=?windows-1252?q?1=3BVI1PR05MB1805=3B23?=\n\t=?windows-1252?q?=3Aa0SbEQY8bgjTa19nuAPvQhoHqVgummO5rMnUa1pizqhEQy?=\n\t=?windows-1252?q?3aazp3mr8ZsJnJN8jZ+COaPe/Pt5DCTmk0QTahN9fFAQgMOvW?=\n\t=?windows-1252?q?ROhoBQPOs0q/WGuoSUxVjvp+ExDoDwamSSflud2cJAL0qz4Ck?=\n\t=?windows-1252?q?ugVy1T8oWE0ZkNU4VvbdH6jma+umWm9fO2plILQJFofSC3z1a?=\n\t=?windows-1252?q?VSUhD95sLZDLzLFKgN2PQrfBtM0tk/zYK90hNlO32WsWSQLIa?=\n\t=?windows-1252?q?u0Mqzmagojw+ipO5feqwBQcnUJCItbvkvRuN/LbeR5+mEG5i+?=\n\t=?windows-1252?q?LI6c3HAHy+Y4v/mZDWVV2WmghIKwZwohnAPtIeuIV7LGacSiO?=\n\t=?windows-1252?q?T8L0YQZnOWv2lUGsxmaO7olrGRInKpana8QAp3tYCuz0be6K/?=\n\t=?windows-1252?q?8i4NuUTQ9DK/ISpK9Y6nHNAR3xgEIYbw2inqzNX29ekJgJ5ki?=\n\t=?windows-1252?q?GeoXtj844CqOUE0h1PgRW+NFsx6JRTi3aLxtF7icNHtEWSYpW?=\n\t=?windows-1252?q?acswguKuGRRjmFB21Gh+lKi5AUA9wjNw/sBMqmeVqE/Q1gjWx?=\n\t=?windows-1252?q?Cl+Zbg5caNRFwUHbbcpcVVDyESSxwuPWqrkLOFDNeG9IaiGIw?=\n\t=?windows-1252?q?ig1A715z2isy9Duu1hyw9TTk/yuNKeIhE5lxs46MxKxGV44hn?=\n\t=?windows-1252?q?V/tNesv5HoD4+AMCBdY4fxMuv6BEDsOxkdoVW8AyNcQ9cc6pE?=\n\t=?windows-1252?q?W5YYc/N+qTZtB0/XdML7JQa5fSUc6Qz2q2wgjU5N+5I/XcPRZ?=\n\t=?windows-1252?q?XfA8YZohyYYHy62mwSqlOrjE9DPR81+bMc7Ya+tLdE6F/kPld?=\n\t=?windows-1252?q?OTvm/3wiCwOSfJTZLwAhT23luLXGNU4AMUJzfyMIM65BBmINr?=\n\t=?windows-1252?q?05W3CE4Cp4q1YSi3EWr1jwDpV2zISMDo8O8QIsJO7ko309HcR?=\n\t=?windows-1252?q?+rCF7JtSi3IgSS6JTgNkIqf+vrOqseYIDnN7sRwPQR4J7M5dE?=\n\t=?windows-1252?q?4Yb4mqrO9ss7rNsBCRHsJROgLE0mueAXCS0mOwChk0pym9ieL?=\n\t=?windows-1252?q?lEUog/FrDRm7OVds6MSc3rjxYXVoEkGJTiUJYWHxYpeAucGzb?=\n\t=?windows-1252?q?uouWE5bthMfRz9k0ARzXnnCxQncuxCIPM8SjB6yBwzJfu4Vvw?=\n\t=?windows-1252?q?WIS+j+TDBCwmM6OM7zvdlEo80X8SHFmECjQbSc0q6KzpOlCSR?=\n\t=?windows-1252?q?jgvxDR1qnJOH/2+Wrelxhws3gnEnQhLcY3K3eH8e300aeCZ6n?=\n\t=?windows-1252?q?oHRYo+wQfp0szeav7VJbef7Qu9Rcx4jDc+dvRqZ3Xastfbdfw?=\n\t=?windows-1252?q?8e4JwmXLPcjiJHDT9fsmQkXiEwM+gzl1KiSHMXC0xZJt9dJ09?=\n\t=?windows-1252?q?W06TnmmB6xUhmHEA0K4sD7MT+PAkhNgswaXQj7MQHmXlz4HV8?=\n\t=?windows-1252?q?RPPR2c1oVpmYquEbfkzTFdh9u/vpKmz7xNn722sPps1g3dqnp?=\n\t=?windows-1252?q?ecqogJoMdBvUQkGPD4=3D?=","1; VI1PR05MB1805;\n\t6:n7oAEVBDixkbxLstKK6jGpUSeqDFIVBtg3vTvk3A/+rm5uAz3j5QKVa2dkudwrBCUqYpd6XGaF15W/kI7Zg5KrZUze5/9/X+EzI/vvQnVO+meBlzsXiJ7Q/TPPp0jpI9Wj6XLXXZOkoUHMIfVC4Lf9OkepL/AJk6Ykj+OHayMfOx/aDJ+EIBSHRt4+SB8JrRzSeV8CDxjFjMkT7vHRZxyylCgut3vjLjHgTisaTks/mWWyOowdWDU+h4UhHoQkgwMZreOUzOsNBhxGNtjSp56zZNxGW10ZT5Kcq0rJ3Hs9jeKZRPsex6wjdBPc6ePWTnq594DmTvM0apJ0+bEdH49w==;\n\t5:XYfDVQRotXZMBALTRlfCLRRB1dzc+rosM9RI8DsgnUjtV5b6+PIy2EwtlIWcvmAXTaXLUALBuGH+IfytJ4KU23Y/6E8XUx7VPJn3dtMO2u5JpTL/UP4b0lyZmIKi54pZUknsYO1OJXodnQzyHyZhBA==;\n\t24:56D7BCk9sH0tgW3wwlzU0RWCLcuuX/QLjmfz9xkVp/yzRGNCHnrBIefMZGLrrAwG81z6JebIyx46fV1s8wL5qg8KG3TxySk4sOZRc8kkIf4=;\n\t7:ssxSehiYZy8/b6nWwgUf7eSheBRBou3nUZRyl1M4h4e0bwVsJyNnfmXhN0LIkgtp8rQX95qR9a3xk1/Voz08CbwVOJFPSl4MVH+nb2kiwNFvIpxjpR4zJZzWmaWi33Sx9K373LrPvtevzYHqyULTMZBW1V+swQ0kYdhnWZfh4k3cGtWCR45sacY+b+x2ZT25lZ+ZY9ODJAIcCloWPcsp4OBABAJzOv8QRc0TuT7lfAI="],"X-MS-TrafficTypeDiagnostic":"VI1PR05MB1805:","X-Exchange-Antispam-Report-Test":"UriScan:;","X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(100000703101)(100105400095)(6055026)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123558100)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:VI1PR05MB1805; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:VI1PR05MB1805; ","X-Forefront-PRVS":"04163EF38A","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10009020)(7370300001)(4630300001)(6009001)(6049001)(39860400002)(377454003)(199003)(24454002)(189002)(101416001)(2906002)(106356001)(105586002)(23746002)(6246003)(7350300001)(50986999)(54356999)(33646002)(76176999)(65826007)(5660300001)(97736004)(54906002)(4001350100001)(189998001)(2950100002)(31686004)(53936002)(6486002)(77096006)(83506001)(25786009)(6666003)(229853002)(42186005)(31696002)(4326008)(36756003)(65806001)(65956001)(81166006)(81156014)(86362001)(8676002)(66066001)(47776003)(478600001)(7736002)(64126003)(305945005)(6116002)(3846002)(53546010)(50466002)(2870700001)(68736007);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1805; H:[10.8.2.253];\n\tFPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"Mellanox.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"31 Aug 2017 12:29:55.1647\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VI1PR05MB1805","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1761137,"web_url":"http://patchwork.ozlabs.org/comment/1761137/","msgid":"","list_archive_url":null,"date":"2017-08-31T15:54:26","subject":"Re: [PATCH net-next] samples/bpf: Fix compilation issue in redirect\n\tdummy program","submitter":{"id":72106,"url":"http://patchwork.ozlabs.org/api/people/72106/","name":"Y Song","email":"ys114321@gmail.com"},"content":"On Thu, Aug 31, 2017 at 4:43 AM, Daniel Borkmann wrote:\n> On 08/31/2017 01:27 PM, Jesper Dangaard Brouer wrote:\n>>\n>> On Thu, 31 Aug 2017 14:16:39 +0300\n>> Tariq Toukan wrote:\n>>\n>>> Fix compilation error below:\n>>>\n>>> $ make samples/bpf/\n>>>\n>>> LLVM ERROR: 'xdp_redirect_dummy' label emitted multiple times to\n>>> assembly file\n>>> make[1]: *** [samples/bpf/xdp_redirect_kern.o] Error 1\n>>> make: *** [samples/bpf/] Error 2\n>>>\n>>> Fixes: 306da4e685b4 (\"samples/bpf: xdp_redirect load XDP dummy prog on TX\n>>> device\")\n>>> Signed-off-by: Tariq Toukan \n>>> ---\n>>\n>>\n>> Acked-by: Jesper Dangaard Brouer \n>\n>\n> Acked-by: Daniel Borkmann \n>\n>> What LLVM/clang version do you use?\n>>\n>> I don't see this compile error, and I have:\n>> $ clang --version\n>> clang version 3.9.1 (tags/RELEA\n>\n>\n> I'm seeing the error as well with a fairly recent LLVM from git\n> tree (6.0.0git-2d810c2).\n>\n> Looks like the llvm error is triggered when section name and\n> the function name for XDP prog is the same. Changing either the\n> function or the section name right above resolves the issue. If\n> such error didn't trigger on older versions, people could be\n> using such naming scheme as done here, so seems to me like a\n> regression on LLVM side we might need to look at ...\n\nMartin fixed a similar bug earlier:\n=====\ncommit a2e8bbd2ef5457485f00b6b947bbbfa2778e5b1e\nAuthor: Martin KaFai Lau \nDate: Thu Jun 8 22:30:17 2017 -0700\n\n bpf: Fix test_obj_id.c for llvm 5.0\n\n llvm 5.0 does not like the section name and the function name\n to be the same:\n...\n=====\n\ngcc also has this behavior. Section name is treated as global\nand hence cannot collide with a function name...","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"BZ+w1ZRq\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjn5T2Rysz9sD9\n\tfor ;\n\tFri, 1 Sep 2017 01:55:25 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752038AbdHaPzW (ORCPT );\n\tThu, 31 Aug 2017 11:55:22 -0400","from mail-ua0-f177.google.com ([209.85.217.177]:36659 \"EHLO\n\tmail-ua0-f177.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751610AbdHaPzH (ORCPT\n\t); Thu, 31 Aug 2017 11:55:07 -0400","by mail-ua0-f177.google.com with SMTP id 105so101152uad.3\n\tfor ; Thu, 31 Aug 2017 08:55:07 -0700 (PDT)","by 10.103.136.6 with HTTP; Thu, 31 Aug 2017 08:54:26 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=/hFq/XZGnx8cK8VA3GtrJAxNUYMsNivE880SmDQn6lM=;\n\tb=BZ+w1ZRq3EVLv1GkjQKLlyhbhIfnJTaw+57b6QvJq+xQHL9gplLs5McwGnB7W/Z3W7\n\tB/6J/ImxECxD1ayFKluXPDeCr+bIKmi8mURdh6Gw7UcI2HUL9kCRLOmXogQoqcd4Xg5C\n\tD+nTAosZsaDY0/oe/+zq7wvzXxvyVwhB7MztFdw+hc59iJsMA9xskbR/Oe44ZV2/2cV1\n\tYPLski/Y2HHQbibG+QaxDfu4W+o8gx23WZXqODmJD6ysQ3hXr0pLdUjMMQBpAhA651aa\n\tZ4qmSdQko7RGX29XdsBBzDQsRNG9pu+zHnEPdyOtBgS4UjAOFUfOCLk6XAE0ortzIwSx\n\tIy8Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=/hFq/XZGnx8cK8VA3GtrJAxNUYMsNivE880SmDQn6lM=;\n\tb=fUtlyKwlpiBLARPaoh2/mIiUhvsUyA1Gde3utohktGkfRZMM85U3g6gOBIQkmz74FT\n\tEUXDUbYDVt1kf5FQ7CmWMcK5fsXhFuWJkbt4eGAq5rd0D5QR2vmKmvLqQmgrYHWbLhG9\n\tu08jMGcWzfEdvwYg55PqRBefgtYUPouFqYCeNhxN54JAup1ST5vxC1z96BMaIWw0pd9g\n\ty4SNwfPRlH+vm2sJRrOaeAad1/bPl7Hg6bszSI/W8bh26qaafpgFO991aPslltHqj5ov\n\tWDrQdRUEXgtwVyEdGHh5v2GGXXRQQAi+z5tY29DV2W3XUD+lqmJ7WzkdJ2+kBqQI5tJn\n\tUSLw==","X-Gm-Message-State":"AHYfb5iXp7hxshGdf+caDFsDc0GXshYknjFVQuUw3YQ9VXXKurrBAzVO\n\t5+N4DRr11L2JIa5jUIlXTsZTWDMGuQ==","X-Google-Smtp-Source":"ADKCNb5AC4aA1Txt+TlqLlQ87h3pgR0/pdKYy2w1d2DVBRGVtq9cHxN4nl97+ZymVc86Ku9szC3KdVEWQdmuPSRcd9s=","X-Received":"by 10.159.55.75 with SMTP id a11mr4040616uae.146.1504194906527; \n\tThu, 31 Aug 2017 08:55:06 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<59A7F658.4020606@iogearbox.net>","References":"<1504178199-12410-1-git-send-email-tariqt@mellanox.com>\n\t<20170831132710.3b245a6a@redhat.com> <59A7F658.4020606@iogearbox.net>","From":"Y Song ","Date":"Thu, 31 Aug 2017 08:54:26 -0700","Message-ID":"","Subject":"Re: [PATCH net-next] samples/bpf: Fix compilation issue in redirect\n\tdummy program","To":"Daniel Borkmann ","Cc":"Jesper Dangaard Brouer ,\n\tTariq Toukan ,\n\t\"David S. Miller\" , netdev ,\n\tEran Ben Elisha ,\n\tAlexei Starovoitov ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1761163,"web_url":"http://patchwork.ozlabs.org/comment/1761163/","msgid":"<59A83767.6020801@iogearbox.net>","list_archive_url":null,"date":"2017-08-31T16:20:55","subject":"Re: [PATCH net-next] samples/bpf: Fix compilation issue in redirect\n\tdummy program","submitter":{"id":65705,"url":"http://patchwork.ozlabs.org/api/people/65705/","name":"Daniel Borkmann","email":"daniel@iogearbox.net"},"content":"On 08/31/2017 05:54 PM, Y Song wrote:\n> On Thu, Aug 31, 2017 at 4:43 AM, Daniel Borkmann wrote:\n>> On 08/31/2017 01:27 PM, Jesper Dangaard Brouer wrote:\n>>> On Thu, 31 Aug 2017 14:16:39 +0300\n>>> Tariq Toukan wrote:\n>>>\n>>>> Fix compilation error below:\n>>>>\n>>>> $ make samples/bpf/\n>>>>\n>>>> LLVM ERROR: 'xdp_redirect_dummy' label emitted multiple times to\n>>>> assembly file\n>>>> make[1]: *** [samples/bpf/xdp_redirect_kern.o] Error 1\n>>>> make: *** [samples/bpf/] Error 2\n>>>>\n>>>> Fixes: 306da4e685b4 (\"samples/bpf: xdp_redirect load XDP dummy prog on TX\n>>>> device\")\n>>>> Signed-off-by: Tariq Toukan \n>>>> ---\n>>>\n>>> Acked-by: Jesper Dangaard Brouer \n>>\n>> Acked-by: Daniel Borkmann \n>>\n>>> What LLVM/clang version do you use?\n>>>\n>>> I don't see this compile error, and I have:\n>>> $ clang --version\n>>> clang version 3.9.1 (tags/RELEA\n>>\n>> I'm seeing the error as well with a fairly recent LLVM from git\n>> tree (6.0.0git-2d810c2).\n>>\n>> Looks like the llvm error is triggered when section name and\n>> the function name for XDP prog is the same. Changing either the\n>> function or the section name right above resolves the issue. If\n>> such error didn't trigger on older versions, people could be\n>> using such naming scheme as done here, so seems to me like a\n>> regression on LLVM side we might need to look at ...\n>\n> Martin fixed a similar bug earlier:\n> =====\n> commit a2e8bbd2ef5457485f00b6b947bbbfa2778e5b1e\n> Author: Martin KaFai Lau \n> Date: Thu Jun 8 22:30:17 2017 -0700\n>\n> bpf: Fix test_obj_id.c for llvm 5.0\n>\n> llvm 5.0 does not like the section name and the function name\n> to be the same:\n> ...\n> =====\n\nYeah indeed.\n\n> gcc also has this behavior. Section name is treated as global\n> and hence cannot collide with a function name...\n\nOkay, so seems at least 3.9.1 treated this slightly different then\nwhere it didn't cause a collision.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjngK3c56z9ryk\n\tfor ;\n\tFri, 1 Sep 2017 02:21:17 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751778AbdHaQVP (ORCPT );\n\tThu, 31 Aug 2017 12:21:15 -0400","from www62.your-server.de ([213.133.104.62]:46669 \"EHLO\n\twww62.your-server.de\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751693AbdHaQVO (ORCPT\n\t); Thu, 31 Aug 2017 12:21:14 -0400","from [92.105.166.74] (helo=localhost.localdomain)\n\tby www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-SHA:256)\n\t(Exim 4.85_2) (envelope-from )\n\tid 1dnSDI-00027M-Jc; Thu, 31 Aug 2017 18:21:04 +0200"],"Message-ID":"<59A83767.6020801@iogearbox.net>","Date":"Thu, 31 Aug 2017 18:20:55 +0200","From":"Daniel Borkmann ","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:31.0) Gecko/20100101 Thunderbird/31.7.0","MIME-Version":"1.0","To":"Y Song ","CC":"Jesper Dangaard Brouer ,\n\tTariq Toukan ,\n\t\"David S. Miller\" , netdev ,\n\tEran Ben Elisha ,\n\tAlexei Starovoitov ","Subject":"Re: [PATCH net-next] samples/bpf: Fix compilation issue in redirect\n\tdummy program","References":"<1504178199-12410-1-git-send-email-tariqt@mellanox.com>\n\t<20170831132710.3b245a6a@redhat.com>\n\t<59A7F658.4020606@iogearbox.net>\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","X-Authenticated-Sender":"daniel@iogearbox.net","X-Virus-Scanned":"Clear (ClamAV 0.99.2/23746/Thu Aug 31 14:35:48 2017)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1761266,"web_url":"http://patchwork.ozlabs.org/comment/1761266/","msgid":"<20170831.115807.699861430358386392.davem@davemloft.net>","list_archive_url":null,"date":"2017-08-31T18:58:07","subject":"Re: [PATCH net-next] samples/bpf: Fix compilation issue in\n\tredirect dummy program","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Tariq Toukan \nDate: Thu, 31 Aug 2017 14:16:39 +0300\n\n> Fix compilation error below:\n> \n> $ make samples/bpf/\n> \n> LLVM ERROR: 'xdp_redirect_dummy' label emitted multiple times to\n> assembly file\n> make[1]: *** [samples/bpf/xdp_redirect_kern.o] Error 1\n> make: *** [samples/bpf/] Error 2\n> \n> Fixes: 306da4e685b4 (\"samples/bpf: xdp_redirect load XDP dummy prog on TX device\")\n> Signed-off-by: Tariq Toukan \n\nApplied.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjs8N0DMMz9s7f\n\tfor ;\n\tFri, 1 Sep 2017 04:58:12 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751740AbdHaS6I (ORCPT );\n\tThu, 31 Aug 2017 14:58:08 -0400","from shards.monkeyblade.net ([184.105.139.130]:55964 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751727AbdHaS6H (ORCPT\n\t); Thu, 31 Aug 2017 14:58:07 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 711A712537446;\n\tThu, 31 Aug 2017 11:58:07 -0700 (PDT)"],"Date":"Thu, 31 Aug 2017 11:58:07 -0700 (PDT)","Message-Id":"<20170831.115807.699861430358386392.davem@davemloft.net>","To":"tariqt@mellanox.com","Cc":"netdev@vger.kernel.org, eranbe@mellanox.com, brouer@redhat.com","Subject":"Re: [PATCH net-next] samples/bpf: Fix compilation issue in\n\tredirect dummy program","From":"David Miller ","In-Reply-To":"<1504178199-12410-1-git-send-email-tariqt@mellanox.com>","References":"<1504178199-12410-1-git-send-email-tariqt@mellanox.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Thu, 31 Aug 2017 11:58:07 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]