[{"id":1763540,"web_url":"http://patchwork.ozlabs.org/comment/1763540/","msgid":"","list_archive_url":null,"date":"2017-09-05T17:55:06","subject":"Re: [Qemu-devel] [PULL 24/29] kvm: use DIV_ROUND_UP","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 31 August 2017 at 11:34, Marc-André Lureau\n wrote:\n> I used the clang-tidy qemu-round check to generate the fix:\n> https://github.com/elmarco/clang-tools-extra\n>\n> Signed-off-by: Marc-André Lureau \n> Reviewed-by: Richard Henderson \n> ---\n> linux-headers/asm-x86/kvm.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/linux-headers/asm-x86/kvm.h b/linux-headers/asm-x86/kvm.h\n> index c2824d02ba..1930b95bcb 100644\n> --- a/linux-headers/asm-x86/kvm.h\n> +++ b/linux-headers/asm-x86/kvm.h\n> @@ -153,7 +153,7 @@ struct kvm_sregs {\n> __u64 cr0, cr2, cr3, cr4, cr8;\n> __u64 efer;\n> __u64 apic_base;\n> - __u64 interrupt_bitmap[(KVM_NR_INTERRUPTS + 63) / 64];\n> + __u64 interrupt_bitmap[DIV_ROUND_UP(KVM_NR_INTERRUPTS, 64)];\n> };\n>\n> /* for KVM_GET_FPU and KVM_SET_FPU */\n\nHi -- I just noticed that this commit makes a change to linux-headers/.\nThis directory is for kernel headers which we keep in sync with the\nupstream kernel via scripts/update-linux-headers.sh, so we shouldn't\nbe applying our code cleanups to it.\n\nI'm going to revert it (206a0fc75d5f54886c1b3f3a65782a75e36b6b97).\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"I0NSPbnP\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmvXV1bHHz9s7g\n\tfor ;\n\tWed, 6 Sep 2017 03:56:09 +1000 (AEST)","from localhost ([::1]:60426 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpI52-00015k-2B\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 13:56:08 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58311)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpI4S-00014S-O3\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 13:55:37 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpI4O-0001Ch-0G\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 13:55:32 -0400","from mail-wr0-x22b.google.com ([2a00:1450:400c:c0c::22b]:33511)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpI4N-0001C2-M0\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 13:55:27 -0400","by mail-wr0-x22b.google.com with SMTP id a43so10227119wrc.0\n\tfor ; Tue, 05 Sep 2017 10:55:27 -0700 (PDT)","by 10.223.159.68 with HTTP; Tue, 5 Sep 2017 10:55:06 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=UaOx/Ow5eZIHuYgzsSWaBlVNdj2laG2MyLR75bR9rbo=;\n\tb=I0NSPbnPn3folEHUoAeH6CWgMv1ndsKYb0XujHFfp6dlYXKNf3FtIVsBRxksvC06sU\n\t84LXfSY5Yl/w+48iwtq3rzbbaf7pqW+kmu4dKxnA3z9NvdkF1i5wIzgATWT37xCqivva\n\ta5Uvm1/7JBB4pvGA2jvmxL0rFGRvRdHZiccpE=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=UaOx/Ow5eZIHuYgzsSWaBlVNdj2laG2MyLR75bR9rbo=;\n\tb=QloHJhANISqcvgBe6775hdkXbl51QjnMBgQzJSlvreWDNhchM1WTNsfrS6tZRCPCHj\n\tKB3/u1j7JCQAtf/j6+ATg0ZHj59H+h1HONDvh3RB8lowXS62ryphIMVkeWhRWt+9MU2l\n\t1CEAIXCoPxr0JtMRO4M25x0iqazs6wdeb38cCavdjH3RNHoMBUR7FO5gM2o4qhk3TKVG\n\tQsbqOIDWPRggxxKjjDwoVjEuYgePX/rizdRqvuYVsM2/URddnMAE2nmqaJ4DblxgRUn7\n\tJVsSmGtmychVxBIAmkXYQR/IBrfKjAZT0xcYFgSpdokgY783JMVj6ALwjqTV7sqRYqci\n\tXzhQ==","X-Gm-Message-State":"AHPjjUhbZRGY1moEZqKmI7Yv51xgDM3jbC15IHaI+IbpkR60FSu31svF\n\tuSi+QWJvUyBpUUA86pJQQgrVw71NmlX/","X-Google-Smtp-Source":"ADKCNb7w2Ta8B2kclVaXyiUi5du3FhG5twwXCwqEsQYQURTfx32mTv+EEWj/hcB6LS/wMFuq20URy/KagZjyV1A0oMU=","X-Received":"by 10.223.130.21 with SMTP id 21mr2801630wrb.196.1504634126517; \n\tTue, 05 Sep 2017 10:55:26 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170831103432.6007-25-marcandre.lureau@redhat.com>","References":"<20170831103432.6007-1-marcandre.lureau@redhat.com>\n\t<20170831103432.6007-25-marcandre.lureau@redhat.com>","From":"Peter Maydell ","Date":"Tue, 5 Sep 2017 18:55:06 +0100","Message-ID":"","To":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c0c::22b","Subject":"Re: [Qemu-devel] [PULL 24/29] kvm: use DIV_ROUND_UP","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"QEMU Trivial ,\n\tQEMU Developers ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]