[{"id":1760886,"web_url":"http://patchwork.ozlabs.org/comment/1760886/","msgid":"<150418066169.135.15852304113006184698@b5667b65043c>","list_archive_url":null,"date":"2017-08-31T11:57:43","subject":"Re: [Qemu-devel] [PULL 00/29] Code cleanup patches","submitter":{"id":69632,"url":"http://patchwork.ozlabs.org/api/people/69632/","name":null,"email":"no-reply@patchew.org"},"content":"Hi,\n\nThis series seems to have some coding style problems. See output below for\nmore information:\n\nMessage-id: 20170831103432.6007-1-marcandre.lureau@redhat.com\nSubject: [Qemu-devel] [PULL 00/29] Code cleanup patches\nType: series\n\n=== TEST SCRIPT BEGIN ===\n#!/bin/bash\n\nBASE=base\nn=1\ntotal=$(git log --oneline $BASE.. | wc -l)\nfailed=0\n\ngit config --local diff.renamelimit 0\ngit config --local diff.renames True\n\ncommits=\"$(git log --format=%H --reverse $BASE..)\"\nfor c in $commits; do\n echo \"Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)...\"\n if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then\n failed=1\n echo\n fi\n n=$((n+1))\ndone\n\nexit $failed\n=== TEST SCRIPT END ===\n\nUpdating 3c8cf5a9c21ff8782164d1def7f44bd888713384\nSwitched to a new branch 'test'\nbfdcbc576e eepro100: replace g_malloc()+memcpy() with g_memdup()\na1c4854e8b test-iov: replace g_malloc()+memcpy() with g_memdup()\n2c77608691 i386: replace g_malloc()+memcpy() with g_memdup()\n93d9646914 i386: introduce ELF_NOTE_SIZE macro\nfbd21c5829 decnumber: use DIV_ROUND_UP\n56f4d8fdf8 kvm: use DIV_ROUND_UP\nb4d3b684fb i386/dump: use DIV_ROUND_UP\n8226995a17 ppc: use DIV_ROUND_UP\nd9362c2ee8 msix: use DIV_ROUND_UP\ndd7f3bcb7b usb-hub: use DIV_ROUND_UP\nd536c67324 q35: use DIV_ROUND_UP\n18d0153d19 piix: use DIV_ROUND_UP\n46fbd728ce virtio-serial: use DIV_ROUND_UP\nf1d2d54e80 console: use DIV_ROUND_UP\nd04feeb2a5 monitor: use DIV_ROUND_UP\n04b7e3bd97 virtio-gpu: use DIV_ROUND_UP\na8cb44a57c vga: use DIV_ROUND_UP\n8967c4cb15 ui: use DIV_ROUND_UP\n86f1a7ca7c vnc: use DIV_ROUND_UP\n0c3d5b7afd vvfat: use DIV_ROUND_UP\n44a6bcbec7 vpc: use DIV_ROUND_UP\n92af37ca5c qcow2: use DIV_ROUND_UP\nee4f5642d9 dmg: use DIV_ROUND_UP\nbb6aafe639 pcspk: use QEMU_ALIGN_DOWN\n342d4c3f03 i8254: use QEMU_ALIGN_DOWN\nbaabc85bab vhost: use QEMU_ALIGN_DOWN\n9cd8dfdb10 vhdx: use QEMU_ALIGN_DOWN\nb4164d6638 vnc: use QEMU_ALIGN_DOWN\n9646df7885 i386: use ROUND_UP macro\n\n=== OUTPUT BEGIN ===\nChecking PATCH 1/29: i386: use ROUND_UP macro...\nChecking PATCH 2/29: vnc: use QEMU_ALIGN_DOWN...\nChecking PATCH 3/29: vhdx: use QEMU_ALIGN_DOWN...\nChecking PATCH 4/29: vhost: use QEMU_ALIGN_DOWN...\nChecking PATCH 5/29: i8254: use QEMU_ALIGN_DOWN...\nChecking PATCH 6/29: pcspk: use QEMU_ALIGN_DOWN...\nERROR: line over 90 characters\n#25: FILE: hw/audio/pcspk.c:72:\n+ s->samples = (QEMU_ALIGN_DOWN(PCSPK_BUF_LEN * PIT_FREQ, m) / (PIT_FREQ >> 1) + 1) >> 1;\n\ntotal: 1 errors, 0 warnings, 8 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\n\nChecking PATCH 7/29: dmg: use DIV_ROUND_UP...\nChecking PATCH 8/29: qcow2: use DIV_ROUND_UP...\nChecking PATCH 9/29: vpc: use DIV_ROUND_UP...\nChecking PATCH 10/29: vvfat: use DIV_ROUND_UP...\nERROR: \"(foo*)\" should be \"(foo *)\"\n#35: FILE: block/vvfat.c:2557:\n+ (uint8_t*)cluster, DIV_ROUND_UP(rest_size, 0x200));\n\ntotal: 1 errors, 0 warnings, 16 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\n\nChecking PATCH 11/29: vnc: use DIV_ROUND_UP...\nWARNING: line over 80 characters\n#38: FILE: ui/vnc.c:2784:\n+ guest_ll = pixman_image_get_width(vd->guest.fb) * (DIV_ROUND_UP(guest_bpp, 8));\n\ntotal: 0 errors, 1 warnings, 16 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\nChecking PATCH 12/29: ui: use DIV_ROUND_UP...\nChecking PATCH 13/29: vga: use DIV_ROUND_UP...\nChecking PATCH 14/29: virtio-gpu: use DIV_ROUND_UP...\nChecking PATCH 15/29: monitor: use DIV_ROUND_UP...\nChecking PATCH 16/29: console: use DIV_ROUND_UP...\nChecking PATCH 17/29: virtio-serial: use DIV_ROUND_UP...\nWARNING: line over 80 characters\n#54: FILE: hw/char/virtio-serial-bus.c:1078:\n+ vser->ports_map = g_malloc0((DIV_ROUND_UP(vser->serial.max_virtserial_ports, 32))\n\ntotal: 0 errors, 1 warnings, 32 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\nChecking PATCH 18/29: piix: use DIV_ROUND_UP...\nChecking PATCH 19/29: q35: use DIV_ROUND_UP...\nChecking PATCH 20/29: usb-hub: use DIV_ROUND_UP...\nChecking PATCH 21/29: msix: use DIV_ROUND_UP...\nChecking PATCH 22/29: ppc: use DIV_ROUND_UP...\nChecking PATCH 23/29: i386/dump: use DIV_ROUND_UP...\nWARNING: line over 80 characters\n#27: FILE: target/i386/arch_dump.c:80:\n+ note_size = (DIV_ROUND_UP(sizeof(Elf64_Nhdr), 4) + DIV_ROUND_UP(name_size, 4) +\n\nWARNING: line over 80 characters\n#38: FILE: target/i386/arch_dump.c:159:\n+ note_size = (DIV_ROUND_UP(sizeof(Elf64_Nhdr), 4) + DIV_ROUND_UP(name_size, 4) +\n\nWARNING: line over 80 characters\n#49: FILE: target/i386/arch_dump.c:214:\n+ note_size = (DIV_ROUND_UP(sizeof(Elf32_Nhdr), 4) + DIV_ROUND_UP(name_size, 4) +\n\nWARNING: line over 80 characters\n#73: FILE: target/i386/arch_dump.c:446:\n+ elf_note_size = (DIV_ROUND_UP(note_head_size, 4) + DIV_ROUND_UP(name_size, 4) +\n\nWARNING: line over 80 characters\n#75: FILE: target/i386/arch_dump.c:448:\n+ qemu_note_size = (DIV_ROUND_UP(note_head_size, 4) + DIV_ROUND_UP(name_size, 4) +\n\ntotal: 0 errors, 5 warnings, 54 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\nChecking PATCH 24/29: kvm: use DIV_ROUND_UP...\nChecking PATCH 25/29: decnumber: use DIV_ROUND_UP...\nERROR: code indent should never use tabs\n#25: FILE: libdecnumber/decNumber.c:4778:\n+^I *(up-1)+=DIV_ROUND_UP(DECDPUNMAX, 2);$\n\nERROR: spaces required around that '-' (ctx:VxV)\n#25: FILE: libdecnumber/decNumber.c:4778:\n+\t *(up-1)+=DIV_ROUND_UP(DECDPUNMAX, 2);\n \t ^\n\nERROR: spaces required around that '+=' (ctx:VxV)\n#25: FILE: libdecnumber/decNumber.c:4778:\n+\t *(up-1)+=DIV_ROUND_UP(DECDPUNMAX, 2);\n \t ^\n\ntotal: 3 errors, 0 warnings, 8 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\n\nChecking PATCH 26/29: i386: introduce ELF_NOTE_SIZE macro...\nChecking PATCH 27/29: i386: replace g_malloc()+memcpy() with g_memdup()...\nChecking PATCH 28/29: test-iov: replace g_malloc()+memcpy() with g_memdup()...\nChecking PATCH 29/29: eepro100: replace g_malloc()+memcpy() with g_memdup()...\n=== OUTPUT END ===\n\nTest command exited with code: 1\n\n\n---\nEmail generated automatically by Patchew [http://patchew.org/].\nPlease send your feedback to patchew-devel@freelists.org","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjgrG2TW1z9t2M\n\tfor ;\n\tThu, 31 Aug 2017 21:58:32 +1000 (AEST)","from localhost ([::1]:55193 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnO7C-00051I-G1\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 07:58:30 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36011)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnO6e-0004xq-13\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 07:57:57 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnO6Z-0001v2-8B\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 07:57:56 -0400","from sender-of-o52.zoho.com ([135.84.80.217]:21410)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnO6Z-0001uT-1Q; Thu, 31 Aug 2017 07:57:51 -0400","from [172.17.0.2] (23.253.156.214 [23.253.156.214]) by\n\tmx.zohomail.com with SMTPS id 1504180663530623.9136827280126;\n\tThu, 31 Aug 2017 04:57:43 -0700 (PDT)"],"Resent-Date":"Thu, 31 Aug 2017 07:57:56 -0400","Resent-Message-Id":"","In-Reply-To":"<20170831103432.6007-1-marcandre.lureau@redhat.com>","Message-ID":"<150418066169.135.15852304113006184698@b5667b65043c>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Resent-From":"","From":"no-reply@patchew.org","To":"marcandre.lureau@redhat.com","Date":"Thu, 31 Aug 2017 04:57:43 -0700 (PDT)","X-ZohoMailClient":"External","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"135.84.80.217","Subject":"Re: [Qemu-devel] [PULL 00/29] Code cleanup patches","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"qemu-devel@nongnu.org","Cc":"qemu-trivial@nongnu.org, peter.maydell@linaro.org, famz@redhat.com,\n\tqemu-devel@nongnu.org, marcandre.lureau@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1761149,"web_url":"http://patchwork.ozlabs.org/comment/1761149/","msgid":"","list_archive_url":null,"date":"2017-08-31T16:08:36","subject":"Re: [Qemu-devel] [PULL 00/29] Code cleanup patches","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 31 August 2017 at 11:34, Marc-André Lureau\n wrote:\n> The following changes since commit 1201d308519f1e915866d7583d5136d03cc1d384:\n>\n> slirp: fix clearing ifq_so from pending packets (2017-08-30 23:14:34 +0100)\n>\n> are available in the git repository at:\n>\n> https://github.com/elmarco/qemu.git tags/tidy-pull-request\n>\n> for you to fetch changes up to e4d67e4f2e06128bc7f07263afe9acc2e2242fdc:\n>\n> eepro100: replace g_malloc()+memcpy() with g_memdup() (2017-08-31 12:29:07 +0200)\n>\n> ----------------------------------------------------------------\n>\n\nApplied, thanks.\n\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=208.118.235.17; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"EG5JMc+V\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [208.118.235.17])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjnQD0ST5z9sD9\n\tfor ;\n\tFri, 1 Sep 2017 02:09:56 +1000 (AEST)","from localhost ([::1]:56589 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnS2T-0000n2-U0\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 12:09:53 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:45791)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnS1f-0000a7-Dv\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 12:09:04 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnS1a-0004CC-GB\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 12:09:03 -0400","from mail-wr0-x231.google.com ([2a00:1450:400c:c0c::231]:37981)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnS1a-0004BH-7i\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 12:08:58 -0400","by mail-wr0-x231.google.com with SMTP id 40so106460wrv.5\n\tfor ; Thu, 31 Aug 2017 09:08:58 -0700 (PDT)","by 10.223.134.54 with HTTP; Thu, 31 Aug 2017 09:08:36 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=9mIUZ6XxUgH1LgQnND+iRl9Ljog/7KeLILy6G//L7FY=;\n\tb=EG5JMc+VN7S8+UvkhZe0dm0vCJCKC2MRvdyNpai2mphf+XSr+d75TEe/AD1J+k+bgo\n\tI5F9tMWhIr+wfmsyWvgLPkj86nKHEiH9SEL84CjM91ov2ZehsmPBSiF6oSbf5tVvia3z\n\tLLiOS9PKWcrIETZi+8JJJx78u8u153O+OjuaU=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=9mIUZ6XxUgH1LgQnND+iRl9Ljog/7KeLILy6G//L7FY=;\n\tb=MnvdCPNBBBDlJv+cPgHYUGmVfdYI1gQt16vL2igCwdgyb8OvsdTPTIdbfEtxDbivTt\n\tHuhM9S4UwjmQUmKtCVQLqxGcIEqYodaNSChYRH2BhEVBFz8mur/7CLZ1749UrFI2jBvc\n\tYSBg7JqroxMxzMKALk/RkLO02MlL0ajw4vZSG4Jj8vAA/Vdn9uk3Yj6ROyuKpL/G47YC\n\tuDGdSPChSOQoHKSYBc1XpFHhg4N00j6XqvcxhfNYCMVUsGdrOetdZpjgYxG2fREp1+yh\n\t5E45FNOF/mVqHMqKSgXXjZijI1OSh+GK/K5b1se7ISB48aefdzf4JQ+1eBYXxgneqZm5\n\t+apg==","X-Gm-Message-State":"AHYfb5hvRG+xGWihYB3xuxuvqregoUbU2lPngA4AgJGYkAFE/910RrnX\n\tVnM0ow0upKhMz2zrgzHCc2u2Vpje0MYX","X-Google-Smtp-Source":"ADKCNb4K1y7PDNLFGHnX+fKejGPGrN9xYwNR7Blc4DN+q5sHZlij+RU5ujX4aTkUOtkEVYv5LE5pzqZ9Z3sZIRlU6A8=","X-Received":"by 10.223.132.98 with SMTP id 89mr3099427wrf.97.1504195737176;\n\tThu, 31 Aug 2017 09:08:57 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170831103432.6007-1-marcandre.lureau@redhat.com>","References":"<20170831103432.6007-1-marcandre.lureau@redhat.com>","From":"Peter Maydell ","Date":"Thu, 31 Aug 2017 17:08:36 +0100","Message-ID":"","To":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c0c::231","Subject":"Re: [Qemu-devel] [PULL 00/29] Code cleanup patches","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"QEMU Trivial ,\n\tQEMU Developers ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]