[{"id":1787654,"web_url":"http://patchwork.ozlabs.org/comment/1787654/","msgid":"","list_archive_url":null,"date":"2017-10-16T18:49:22","subject":"Re: [PATCH] malloc: Do not compile mcheck-init.o as libc module","submitter":{"id":14312,"url":"http://patchwork.ozlabs.org/api/people/14312/","name":"Florian Weimer","email":"fweimer@redhat.com"},"content":"On 08/31/2017 11:42 AM, Florian Weimer wrote:\n> Otherwise, this will lead to a link failure because the reference\n> to mcheck is hidden.\n> \n> 2017-08-31 Florian Weimer \n> \n> \t* malloc/Makefile (others-extras): Set to mcheck-init.o.\n> \n> diff --git a/malloc/Makefile b/malloc/Makefile\n> index 50b487eeb5..52bbce63c0 100644\n> --- a/malloc/Makefile\n> +++ b/malloc/Makefile\n> @@ -99,6 +99,7 @@ LDFLAGS-tst-mallocstate = -rdynamic\n> \n> # These should be removed by `make clean'.\n> extra-objs = mcheck-init.o libmcheck.a\n> +others-extras = mcheck-init.o\n> \n> # Include the cleanup handler.\n> aux := set-freeres thread-freeres\n> \n\nI am going to check this in.\n\nThanks,\nFlorian","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-85900-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"EMydIyB2\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=fweimer@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yG6nB19pyz9s8J\n\tfor ;\n\tTue, 17 Oct 2017 05:49:33 +1100 (AEDT)","(qmail 26372 invoked by alias); 16 Oct 2017 18:49:27 -0000","(qmail 26340 invoked by uid 89); 16 Oct 2017 18:49:26 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=kCJ8rdAs0rGr6TTK\n\tLLlQdbR4MESYLgaBxZPbO3ymZMvUIrp69Shh6EHbJPP4pBYBjSsSNWTN2lJa/eRD\n\tPCt5GlB77CrGsekntbKZoTT7GnjoFyFtd8EF5LOZ+R9LxbRO/aW97PziYq3Oxeb6\n\tdpFPty8kUTAUFKyLYjBfVXOPYBs=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=h4NOuz8+VrpheJT9RY9Ap1\n\tPc4aA=; b=EMydIyB2JHMEH8P3UGF2fgVMgglWksI7VB9Ra1oiUHQV88hWP5yTgN\n\tUMN3BF2vAvZuEQkZkmutaMVpHfPhDlRZ455F0to50MI1CZu3jvNr/BrmX0auDMyk\n\tO9pQIvj48Yhhk4bbKm6TCvvuNyVjJVXiKRzoe5YAiPMECsHODK30g=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-25.9 required=5.0 tests=BAYES_00, GIT_PATCH_0,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3,\n\tKAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com AF89B5AFC7","Subject":"Re: [PATCH] malloc: Do not compile mcheck-init.o as libc module","To":"libc-alpha@sourceware.org","References":"<20170831094259.EA4DD43994318@oldenburg.str.redhat.com>","From":"Florian Weimer ","Message-ID":"","Date":"Mon, 16 Oct 2017 20:49:22 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170831094259.EA4DD43994318@oldenburg.str.redhat.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit"}}]