[{"id":1760775,"web_url":"http://patchwork.ozlabs.org/comment/1760775/","msgid":"","date":"2017-08-31T09:15:29","subject":"Re: [PATCH v2] perf test powerpc: Fix 'Object code reading' test","submitter":{"id":11091,"url":"http://patchwork.ozlabs.org/api/people/11091/","name":"Adrian Hunter","email":"adrian.hunter@intel.com"},"content":"On 31/08/17 12:14, Ravi Bangoria wrote:\n> 'Object code reading' test always fails on powerpc guest. Two reasons\n> for the failure are:\n> \n> 1. When elf section is too big (size beyond 'unsigned int' max value).\n> objdump fails to disassemble from such section. This was fixed with\n> commit 0f6329bd7fc (\"binutils/objdump: Fix disassemble for huge elf\n> sections\") in binutils.\n> \n> 2. When the sample is from hypervisor. Hypervisor symbols can not\n> be resolved within guest and thus thread__find_addr_map() fails for\n> such symbols. Fix this by ignoring hypervisor symbols in the test.\n> \n> Signed-off-by: Ravi Bangoria \n\nAcked-by: Adrian Hunter \n\n> ---\n> Changes in v2:\n> - Add pr_debug()\n> \n> tools/perf/tests/code-reading.c | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/tools/perf/tests/code-reading.c b/tools/perf/tests/code-reading.c\n> index 761c5a4..466a462 100644\n> --- a/tools/perf/tests/code-reading.c\n> +++ b/tools/perf/tests/code-reading.c\n> @@ -237,6 +237,11 @@ static int read_object_code(u64 addr, size_t len, u8 cpumode,\n> \n> \tthread__find_addr_map(thread, cpumode, MAP__FUNCTION, addr, &al);\n> \tif (!al.map || !al.map->dso) {\n> +\t\tif (cpumode == PERF_RECORD_MISC_HYPERVISOR) {\n> +\t\t\tpr_debug(\"Hypervisor address can not be resolved - skipping\\n\");\n> +\t\t\treturn 0;\n> +\t\t}\n> +\n> \t\tpr_debug(\"thread__find_addr_map failed\\n\");\n> \t\treturn -1;\n> \t}\n>","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjcP34jj6z9t2Q\n\tfor ;\n\tThu, 31 Aug 2017 19:23:19 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xjcP33ZWczDqXn\n\tfor ;\n\tThu, 31 Aug 2017 19:23:19 +1000 (AEST)","from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xjcMk0xmnzDqRM\n\tfor ;\n\tThu, 31 Aug 2017 19:22:09 +1000 (AEST)","from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t31 Aug 2017 02:22:03 -0700","from ahunter-desktop.fi.intel.com (HELO [10.237.72.168])\n\t([10.237.72.168])\n\tby FMSMGA003.fm.intel.com with ESMTP; 31 Aug 2017 02:22:00 -0700"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.41,451,1498546800\"; d=\"scan'208\";a=\"895828218\"","Subject":"Re: [PATCH v2] perf test powerpc: Fix 'Object code reading' test","To":"Ravi Bangoria , acme@kernel.org","References":"<1504170896-7876-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com>","From":"Adrian Hunter ","Organization":"Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, \n\tBusiness Identity Code: 0357606 - 4, Domiciled in Helsinki","Message-ID":"","Date":"Thu, 31 Aug 2017 12:15:29 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<1504170896-7876-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"peterz@infradead.org, linux-kernel@vger.kernel.org,\n\talexander.shishkin@linux.intel.com, mingo@redhat.com, jolsa@kernel.org,\n\tnamhyung@kernel.org, linuxppc-dev@lists.ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1761172,"web_url":"http://patchwork.ozlabs.org/comment/1761172/","msgid":"<20170831163146.GE4831@kernel.org>","date":"2017-08-31T16:31:46","subject":"Re: [PATCH v2] perf test powerpc: Fix 'Object code reading' test","submitter":{"id":64111,"url":"http://patchwork.ozlabs.org/api/people/64111/","name":"Arnaldo Carvalho de Melo","email":"acme@kernel.org"},"content":"Em Thu, Aug 31, 2017 at 12:15:29PM +0300, Adrian Hunter escreveu:\n> On 31/08/17 12:14, Ravi Bangoria wrote:\n> > 'Object code reading' test always fails on powerpc guest. Two reasons\n> > for the failure are:\n> > \n> > 1. When elf section is too big (size beyond 'unsigned int' max value).\n> > objdump fails to disassemble from such section. This was fixed with\n> > commit 0f6329bd7fc (\"binutils/objdump: Fix disassemble for huge elf\n> > sections\") in binutils.\n> > \n> > 2. When the sample is from hypervisor. Hypervisor symbols can not\n> > be resolved within guest and thus thread__find_addr_map() fails for\n> > such symbols. Fix this by ignoring hypervisor symbols in the test.\n> > \n> > Signed-off-by: Ravi Bangoria \n> \n> Acked-by: Adrian Hunter \n\nThanks, applied.\n\n- Arnaldo","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjnx23ZYtz9s7M\n\tfor ;\n\tFri, 1 Sep 2017 02:33:10 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xjnx22fQgzDqZq\n\tfor ;\n\tFri, 1 Sep 2017 02:33:10 +1000 (AEST)","from mail.kernel.org (mail.kernel.org [198.145.29.99])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xjnvY1NHSzDq5b\n\tfor ;\n\tFri, 1 Sep 2017 02:31:53 +1000 (AEST)","from jouet.infradead.org (unknown [190.15.121.82])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 0C89721978;\n\tThu, 31 Aug 2017 16:31:51 +0000 (UTC)","by jouet.infradead.org (Postfix, from userid 1000)\n\tid A23F0140DAE; Thu, 31 Aug 2017 13:31:46 -0300 (-03)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 0C89721978","Authentication-Results":["mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=acme@kernel.org"],"Date":"Thu, 31 Aug 2017 13:31:46 -0300","From":"Arnaldo Carvalho de Melo ","To":"Adrian Hunter ","Subject":"Re: [PATCH v2] perf test powerpc: Fix 'Object code reading' test","Message-ID":"<20170831163146.GE4831@kernel.org>","References":"<1504170896-7876-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","X-Url":"http://acmel.wordpress.com","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"peterz@infradead.org, Ravi Bangoria , \n\tlinux-kernel@vger.kernel.org, alexander.shishkin@linux.intel.com,\n\tmingo@redhat.com, jolsa@kernel.org, namhyung@kernel.org,\n\tlinuxppc-dev@lists.ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]