[{"id":1760744,"web_url":"http://patchwork.ozlabs.org/comment/1760744/","msgid":"<150416863243.108.2293421334337226559@b5667b65043c>","list_archive_url":null,"date":"2017-08-31T08:37:14","subject":"Re: [Qemu-devel] [PULL for-2.10 00/15] Block patches","submitter":{"id":69632,"url":"http://patchwork.ozlabs.org/api/people/69632/","name":null,"email":"no-reply@patchew.org"},"content":"Hi,\n\nThis series seems to have some coding style problems. See output below for\nmore information:\n\nMessage-id: 20170831082210.8362-1-stefanha@redhat.com\nSubject: [Qemu-devel] [PULL for-2.10 00/15] Block patches\nType: series\n\n=== TEST SCRIPT BEGIN ===\n#!/bin/bash\n\nBASE=base\nn=1\ntotal=$(git log --oneline $BASE.. | wc -l)\nfailed=0\n\ngit config --local diff.renamelimit 0\ngit config --local diff.renames True\n\ncommits=\"$(git log --format=%H --reverse $BASE..)\"\nfor c in $commits; do\n echo \"Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)...\"\n if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then\n failed=1\n echo\n fi\n n=$((n+1))\ndone\n\nexit $failed\n=== TEST SCRIPT END ===\n\nUpdating 3c8cf5a9c21ff8782164d1def7f44bd888713384\nFrom https://github.com/patchew-project/qemu\n t [tag update] patchew/20170830215523.25278-1-f4bug@amsat.org -> patchew/20170830215523.25278-1-f4bug@amsat.org\n * [new tag] patchew/20170831082210.8362-1-stefanha@redhat.com -> patchew/20170831082210.8362-1-stefanha@redhat.com\nSwitched to a new branch 'test'\neaf80da3e4 qcow2: allocate cluster_cache/cluster_data on demand\nfab9c02727 qemu-doc: Add UUID support in initiator name\n76e70ed0d9 tests: migration/guestperf Python 2.6 argparse compatibility\n316bda7e7b docker.py: Python 2.6 argparse compatibility\n0a7f8a625b scripts: add argparse module for Python 2.6 compatibility\n3e6e26d514 misc: Remove unused Error variables\nf01d195374 oslib-posix: Print errors before aborting on qemu_alloc_stack()\nb2f08be812 throttle: Test the valid range of config values\nf1cd43f5e4 throttle: Make burst_length 64bit and add range checks\n60981818d1 throttle: Make LeakyBucket.avg and LeakyBucket.max integer types\n3032f687f4 throttle: Remove throttle_fix_bucket() / throttle_unfix_bucket()\n73e3d4f547 throttle: Make throttle_is_valid() a bit less verbose\n0ae5ba07ca throttle: Update the throttle_fix_bucket() documentation\n9f52f0ea86 throttle: Fix wrong variable name in the header documentation\n062842b9f2 nvme: Fix get/set number of queues feature, again\n\n=== OUTPUT BEGIN ===\nChecking PATCH 1/15: nvme: Fix get/set number of queues feature, again...\nChecking PATCH 2/15: throttle: Fix wrong variable name in the header documentation...\nChecking PATCH 3/15: throttle: Update the throttle_fix_bucket() documentation...\nChecking PATCH 4/15: throttle: Make throttle_is_valid() a bit less verbose...\nChecking PATCH 5/15: throttle: Remove throttle_fix_bucket() / throttle_unfix_bucket()...\nChecking PATCH 6/15: throttle: Make LeakyBucket.avg and LeakyBucket.max integer types...\nChecking PATCH 7/15: throttle: Make burst_length 64bit and add range checks...\nChecking PATCH 8/15: throttle: Test the valid range of config values...\nChecking PATCH 9/15: oslib-posix: Print errors before aborting on qemu_alloc_stack()...\nChecking PATCH 10/15: misc: Remove unused Error variables...\nChecking PATCH 11/15: scripts: add argparse module for Python 2.6 compatibility...\nERROR: trailing whitespace\n#118: FILE: COPYING.PYTHON:93:\n+Reserved\" are retained in Python alone or in any derivative version $\n\ntotal: 1 errors, 0 warnings, 2676 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\n\nChecking PATCH 12/15: docker.py: Python 2.6 argparse compatibility...\nChecking PATCH 13/15: tests: migration/guestperf Python 2.6 argparse compatibility...\nChecking PATCH 14/15: qemu-doc: Add UUID support in initiator name...\nChecking PATCH 15/15: qcow2: allocate cluster_cache/cluster_data on demand...\n=== OUTPUT END ===\n\nTest command exited with code: 1\n\n\n---\nEmail generated automatically by Patchew [http://patchew.org/].\nPlease send your feedback to patchew-devel@freelists.org","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjbP267THz9s65\n\tfor ;\n\tThu, 31 Aug 2017 18:38:14 +1000 (AEST)","from localhost ([::1]:54532 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnKzM-000860-6n\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 04:38:12 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46290)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnKyj-00083M-P5\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 04:37:34 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnKyg-0002Yd-Fj\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 04:37:33 -0400","from sender-of-o52.zoho.com ([135.84.80.217]:21396)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnKyg-0002Y5-8r\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 04:37:30 -0400","from [172.17.0.2] (23.253.156.214 [23.253.156.214]) by\n\tmx.zohomail.com with SMTPS id 1504168634040784.1250889936628;\n\tThu, 31 Aug 2017 01:37:14 -0700 (PDT)"],"Resent-Date":"Thu, 31 Aug 2017 04:37:33 -0400","Resent-Message-Id":"","In-Reply-To":"<20170831082210.8362-1-stefanha@redhat.com>","Message-ID":"<150416863243.108.2293421334337226559@b5667b65043c>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Resent-From":"","From":"no-reply@patchew.org","To":"stefanha@redhat.com","Date":"Thu, 31 Aug 2017 01:37:14 -0700 (PDT)","X-ZohoMailClient":"External","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"135.84.80.217","Subject":"Re: [Qemu-devel] [PULL for-2.10 00/15] Block patches","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"qemu-devel@nongnu.org","Cc":"peter.maydell@linaro.org, famz@redhat.com, qemu-devel@nongnu.org,\n\tstefanha@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1761014,"web_url":"http://patchwork.ozlabs.org/comment/1761014/","msgid":"<60e1d24c-0e8c-42a1-c625-051b2dc0375a@redhat.com>","list_archive_url":null,"date":"2017-08-31T13:47:49","subject":"Re: [Qemu-devel] [PULL for-2.10 00/15] Block patches","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 08/31/2017 03:21 AM, Stefan Hajnoczi wrote:\n> The following changes since commit 248b23735645f7cbb503d9be6f5bf825f2a603ab:\n\nSubject line should probably say 2.11, not 2.10 :)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjkGy1rSnz9sPt\n\tfor ;\n\tThu, 31 Aug 2017 23:48:24 +1000 (AEST)","from localhost ([::1]:55896 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnPpT-0000jU-Eh\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 09:48:19 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33783)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnPp8-0000jL-TH\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:47:59 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnPp4-0003ba-BY\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:47:58 -0400","from mx1.redhat.com ([209.132.183.28]:40766)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnPp4-0003bO-4q\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:47:54 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 116C0C0587F2;\n\tThu, 31 Aug 2017 13:47:53 +0000 (UTC)","from [10.10.122.186] (ovpn-122-186.rdu2.redhat.com [10.10.122.186])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 1181B77DCE;\n\tThu, 31 Aug 2017 13:47:49 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 116C0C0587F2","To":"Stefan Hajnoczi , qemu-devel@nongnu.org","References":"<20170831082210.8362-1-stefanha@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<60e1d24c-0e8c-42a1-c625-051b2dc0375a@redhat.com>","Date":"Thu, 31 Aug 2017 08:47:49 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170831082210.8362-1-stefanha@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"tsWlX5q6Ha9B41DIRMwR84tPofIcdMKwj\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tThu, 31 Aug 2017 13:47:53 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PULL for-2.10 00/15] Block patches","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1761080,"web_url":"http://patchwork.ozlabs.org/comment/1761080/","msgid":"","list_archive_url":null,"date":"2017-08-31T14:51:30","subject":"Re: [Qemu-devel] [PULL for-2.10 00/15] Block patches","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 31 August 2017 at 09:21, Stefan Hajnoczi wrote:\n> The following changes since commit 248b23735645f7cbb503d9be6f5bf825f2a603ab:\n>\n> Update version for v2.10.0-rc4 release (2017-08-24 17:34:26 +0100)\n>\n> are available in the git repository at:\n>\n> git://github.com/stefanha/qemu.git tags/block-pull-request\n>\n> for you to fetch changes up to 3e4c705212abfe8c9882a00beb2d1466a8a53cec:\n>\n> qcow2: allocate cluster_cache/cluster_data on demand (2017-08-30 18:02:10 +0100)\n>\n> ----------------------------------------------------------------\n>\n> ----------------------------------------------------------------\n\nApplied, thanks.\n\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"YSInahLo\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjlhd3K1gz9s83\n\tfor ;\n\tFri, 1 Sep 2017 00:52:16 +1000 (AEST)","from localhost ([::1]:56183 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnQpJ-0002wo-Nk\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 10:52:13 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52834)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnQoz-0002we-9M\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 10:51:53 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnQoy-0002Mp-Ec\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 10:51:53 -0400","from mail-wm0-x22f.google.com ([2a00:1450:400c:c09::22f]:37757)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnQoy-0002MZ-7u\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 10:51:52 -0400","by mail-wm0-x22f.google.com with SMTP id u26so6070346wma.0\n\tfor ; Thu, 31 Aug 2017 07:51:52 -0700 (PDT)","by 10.223.134.54 with HTTP; Thu, 31 Aug 2017 07:51:30 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=iZKU+ZnHQdLhGJn/ieBDIk5lG5NLBJbSoYNIGCRQA64=;\n\tb=YSInahLoU31/loNGDTTm1prFFpWfeSZHF9gOdr2ycJDQL8URBzMPaFd35+Peh0qE7N\n\tBjIrzCAjnbwCn2uEGb/Ekxdzi8Jg7szJ6RK/mcKPP3Z8HZHcsLu+Xf7vYj44z8g5qOLd\n\tulZ0J06JV0DiOMTy4mF4gCThMJnkWWXeyXTQA=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=iZKU+ZnHQdLhGJn/ieBDIk5lG5NLBJbSoYNIGCRQA64=;\n\tb=WQt+VHWTqBzmNld/F4bhcWiuDpdIJehn8F5Xsv2uTcUqVBk9B/0Omx0bUp9szDRMlU\n\tVeNO8bR2sWAvUmEF+z71daPnBxys2pwPKtHiEAg0kd7N3qZSNClNv6m5suqnIw0kS+Yl\n\tCPKi527zWNLvNCP+QGJpp6VVTVVj2X1jZtgI/avMTlNVIaKlVLSxXtbKEcnhOxKpTOVu\n\tV1U1dNl+tJVwF1s3B4SumVTA7bJqbWJz38cCGA7FxaKoKpCMtWDCGGfM+XmrjZ5/32Rz\n\tyD3z4cO4tVSNzhpskAzGpHOrX05r9M1mKJfgyUvWWwiCALLMzls8k+gcSjw24B9GPryV\n\tX3uQ==","X-Gm-Message-State":"AHPjjUideu+AQkcCSgo1fE7MKSVqJ5j6XduxIslt/478Q+8rwvyCgPCc\n\t0+0xuMnVjv0n/tXHBmwIddd6IYNwAwlr","X-Google-Smtp-Source":"ADKCNb46X4q7uhBe8yS7Uqjs439Nv+FP4i0xjlXPJT7jHxVMgC8IkeijxGtBZjeYz4OAN1yAS5dgVQQOMoFgoLo9Xak=","X-Received":"by 10.28.94.10 with SMTP id s10mr796835wmb.165.1504191111093;\n\tThu, 31 Aug 2017 07:51:51 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170831082210.8362-1-stefanha@redhat.com>","References":"<20170831082210.8362-1-stefanha@redhat.com>","From":"Peter Maydell ","Date":"Thu, 31 Aug 2017 15:51:30 +0100","Message-ID":"","To":"Stefan Hajnoczi ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::22f","Subject":"Re: [Qemu-devel] [PULL for-2.10 00/15] Block patches","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"QEMU Developers ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]