[{"id":1761461,"web_url":"http://patchwork.ozlabs.org/comment/1761461/","msgid":"","list_archive_url":null,"date":"2017-09-01T04:14:42","subject":"Re: [Skiboot] [PATCH v2 4/5] hdata/i2c: ignore the secure window\n\tand physical presence i2c devs","submitter":{"id":68108,"url":"http://patchwork.ozlabs.org/api/people/68108/","name":"Oliver O'Halloran","email":"oohall@gmail.com"},"content":"On Thu, Aug 31, 2017 at 5:12 PM, Claudio Carvalho\n wrote:\n> This ignores the secure window and physical presence i2c devices since\n> they are failing the HDAT parsing and they won't be used for now.\n>\n> In P9, the secure window and physical presence are gpio pins in an i2c\n> gpio expander. In the HDAT the secure window and physical presence are\n> duplicates of the associated i2c gpio expander device, however\n> distinguished by the gpio port. That causes a failure when dt_new_addr()\n> is called because skiboot is not able to distinguish nodes by port.\n>\n> Signed-off-by: Claudio Carvalho \n> ---\n> hdata/i2c.c | 14 ++++++++++++++\n> 1 file changed, 14 insertions(+)\n>\n> diff --git a/hdata/i2c.c b/hdata/i2c.c\n> index 14650b6..8a2e392 100644\n> --- a/hdata/i2c.c\n> +++ b/hdata/i2c.c\n> @@ -259,6 +259,20 @@ int parse_i2c_devs(const struct HDIF_common_hdr *hdr, int idata_index,\n> compat = NULL;\n> }\n>\n> + /*\n> + * TODO: Create devtree entries for the secure window and\n> + * physical presence. In the hdat they are i2c gpio-expander\n> + * devices distinguished only by the port property.\n> + */\n> + if (be32_to_cpu(dev->purpose) == 0xd ||\n> + be32_to_cpu(dev->purpose) == 0xe) {\n> + prlog(PR_INFO, \"HDAT I2C: ignoring e%dp%d - %s@%x \"\n> + \"(port 0x%x) - %s\\n\", dev->i2cm_engine,\n> + dev->i2cm_port, name, i2c_addr, dev->i2c_port,\n> + label);\n> + continue;\n> + }\n> +\n> node = dt_new_addr(bus, name, i2c_addr);\n> if (!node)\n> continue;\n> --\n> 2.7.4\n>\n\nNAK\n\nYou can use dt_find_by_name_addr() to check if that device node exists\nand keep going. We always want the I2C device node to exists so that\nwe know the device exists. For now we can just ignore the port, but we\nwill need to work out how to use that information at some point in the\nfuture.\n\nOliver","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xk5Vd1nChz9sNr\n\tfor ;\n\tFri, 1 Sep 2017 14:14:49 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xk5Vd0ZJbzDqZr\n\tfor ;\n\tFri, 1 Sep 2017 14:14:49 +1000 (AEST)","from mail-qk0-x242.google.com (mail-qk0-x242.google.com\n\t[IPv6:2607:f8b0:400d:c09::242])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xk5VY2FcLzDqY8\n\tfor ; Fri, 1 Sep 2017 14:14:45 +1000 (AEST)","by mail-qk0-x242.google.com with SMTP id o63so1111914qkb.5\n\tfor ; Thu, 31 Aug 2017 21:14:45 -0700 (PDT)","by 10.140.21.10 with HTTP; Thu, 31 Aug 2017 21:14:42 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"FXnPcAlX\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"FXnPcAlX\"; dkim-atps=neutral","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"FXnPcAlX\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=M9HzvqFI8/9Uwmr1asQMiLQummoqhFT7HnhWPupVuPc=;\n\tb=FXnPcAlX5kB02Uk1iWohDVq2pIZfWlnQi60yQNHb1/rbIlPvQcPoxRdX/sToaTp1xF\n\taG4hqv6byNaz4myesrskBo7Jq/iJWh4yZNxINGE/17QGe/5GqBIuUdoyBZ6HeWYi0vup\n\tnB9BSsQCtV0YcYWKxGkl763KaMeXzgLas/vDCDqLyOXTSP1NVcraoUtwcsCuiUaozYZP\n\tI8jG8IflsL1r9ZICElnc9TSdBNWLxc6+iZwFv0OoOxEW/Mnc/aWkVxc4tVUlaxKwQc74\n\tC4FGEt/WnREjjD3CUeKPhvLTdrzd+ieclD3zW7WepgqWXNiqq5EkflRslfINamzL2pAv\n\tzS3A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=M9HzvqFI8/9Uwmr1asQMiLQummoqhFT7HnhWPupVuPc=;\n\tb=YAFKFF1LPfMIFhbhAx4vratdR6RAmGPTz18RZP+h94J+HHC8nakfwrqM+K6CJBj91d\n\t35dOBSwjpbDJb6If2qgEdusa4jT03sVVuPC0MIN0VWnt5q2dp3hJaJ0RGyer3bJjj14J\n\t08rEIdB+0IQJpnw0KZq3wjVcmbTX7fCWvzbDEkWg88YrW7SrvLdRZx8J/N0CUHUvcVUx\n\tDzjuafkl9enOxb1YY6+vPzhv/oGhXy5fY7Ys6aoiYn50LNIPEzor5CNm1ZMCN3n4SYD5\n\tcLi649kWLL93e37bHgOe2xGu1LgP5rLixkXbWnDfraCHTUcMg/o5nnm1Xr01zdu2GqbQ\n\tQ24g==","X-Gm-Message-State":"AHPjjUgGuGWB8R8KqHadjvLHKeO5EoQ6S1sQkGa0K29EFB3LUdSVhl80\n\tF0KL+RddLimLr/pH4dUhxDdgdusWGBaF","X-Google-Smtp-Source":"ADKCNb5KVxfCwkCDLUTSGRpl1OM0Yezu9UK3ASO9vDwyaKRH7SZMJGOwxk7iBOQ59flXUF16lCMEWg8ggd931MSPktU=","X-Received":"by 10.55.75.203 with SMTP id y194mr886105qka.23.1504239283127;\n\tThu, 31 Aug 2017 21:14:43 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1504163557-14432-5-git-send-email-cclaudio@linux.vnet.ibm.com>","References":"<1504163557-14432-1-git-send-email-cclaudio@linux.vnet.ibm.com>\n\t<1504163557-14432-5-git-send-email-cclaudio@linux.vnet.ibm.com>","From":"Oliver ","Date":"Fri, 1 Sep 2017 14:14:42 +1000","Message-ID":"","To":"Claudio Carvalho ","Subject":"Re: [Skiboot] [PATCH v2 4/5] hdata/i2c: ignore the secure window\n\tand physical presence i2c devs","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"skiboot list ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}},{"id":1762717,"web_url":"http://patchwork.ozlabs.org/comment/1762717/","msgid":"<6a1fb04a-b697-3b87-86a2-05f09d94dd4f@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-04T15:04:56","subject":"Re: [Skiboot] [PATCH v2 4/5] hdata/i2c: ignore the secure window\n\tand physical presence i2c devs","submitter":{"id":69305,"url":"http://patchwork.ozlabs.org/api/people/69305/","name":"Claudio Carvalho","email":"cclaudio@linux.vnet.ibm.com"},"content":"On 01/09/2017 01:14, Oliver wrote:\n> On Thu, Aug 31, 2017 at 5:12 PM, Claudio Carvalho\n> wrote:\n>> This ignores the secure window and physical presence i2c devices since\n>> they are failing the HDAT parsing and they won't be used for now.\n>>\n>> In P9, the secure window and physical presence are gpio pins in an i2c\n>> gpio expander. In the HDAT the secure window and physical presence are\n>> duplicates of the associated i2c gpio expander device, however\n>> distinguished by the gpio port. That causes a failure when dt_new_addr()\n>> is called because skiboot is not able to distinguish nodes by port.\n>>\n>> Signed-off-by: Claudio Carvalho \n>> ---\n>> hdata/i2c.c | 14 ++++++++++++++\n>> 1 file changed, 14 insertions(+)\n>>\n>> diff --git a/hdata/i2c.c b/hdata/i2c.c\n>> index 14650b6..8a2e392 100644\n>> --- a/hdata/i2c.c\n>> +++ b/hdata/i2c.c\n>> @@ -259,6 +259,20 @@ int parse_i2c_devs(const struct HDIF_common_hdr *hdr, int idata_index,\n>> compat = NULL;\n>> }\n>>\n>> + /*\n>> + * TODO: Create devtree entries for the secure window and\n>> + * physical presence. In the hdat they are i2c gpio-expander\n>> + * devices distinguished only by the port property.\n>> + */\n>> + if (be32_to_cpu(dev->purpose) == 0xd ||\n>> + be32_to_cpu(dev->purpose) == 0xe) {\n>> + prlog(PR_INFO, \"HDAT I2C: ignoring e%dp%d - %s@%x \"\n>> + \"(port 0x%x) - %s\\n\", dev->i2cm_engine,\n>> + dev->i2cm_port, name, i2c_addr, dev->i2c_port,\n>> + label);\n>> + continue;\n>> + }\n>> +\n>> node = dt_new_addr(bus, name, i2c_addr);\n>> if (!node)\n>> continue;\n>> --\n>> 2.7.4\n>>\n> NAK\n>\n> You can use dt_find_by_name_addr() to check if that device node exists\n> and keep going. We always want the I2C device node to exists so that\n> we know the device exists. For now we can just ignore the port, but we\n> will need to work out how to use that information at some point in the\n> future.\n>\n> Oliver\n>\n\nRight. I will change that. Thanks.\n\nClaudio","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmCng2RKJz9t2W\n\tfor ;\n\tTue, 5 Sep 2017 01:05:11 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xmCng1XDyzDql8\n\tfor ;\n\tTue, 5 Sep 2017 01:05:11 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xmCnY1d6xzDqjv\n\tfor ; Tue, 5 Sep 2017 01:05:04 +1000 (AEST)","from pps.filterd (m0098393.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv84F4GMG022144\n\tfor ; Mon, 4 Sep 2017 11:05:02 -0400","from e33.co.us.ibm.com (e33.co.us.ibm.com [32.97.110.151])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cs6ygqkxk-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Mon, 04 Sep 2017 11:05:02 -0400","from localhost\n\tby e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tMon, 4 Sep 2017 09:05:01 -0600","from b03cxnp08026.gho.boulder.ibm.com (9.17.130.18)\n\tby e33.co.us.ibm.com (192.168.1.133) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tMon, 4 Sep 2017 09:04:59 -0600","from b03ledav006.gho.boulder.ibm.com\n\t(b03ledav006.gho.boulder.ibm.com [9.17.130.237])\n\tby b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v84F4uk864946316; Mon, 4 Sep 2017 08:04:58 -0700","from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id AC78DC6051;\n\tMon, 4 Sep 2017 09:04:58 -0600 (MDT)","from [9.80.192.82] (unknown [9.80.192.82])\n\tby b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP id 85E67C6047;\n\tMon, 4 Sep 2017 09:04:57 -0600 (MDT)"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=cclaudio@linux.vnet.ibm.com; receiver=)","To":"Oliver ","References":"<1504163557-14432-1-git-send-email-cclaudio@linux.vnet.ibm.com>\n\t<1504163557-14432-5-git-send-email-cclaudio@linux.vnet.ibm.com>\n\t","From":"Claudio Carvalho ","Date":"Mon, 4 Sep 2017 12:04:56 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","X-TM-AS-GCONF":"00","x-cbid":"17090415-0008-0000-0000-00000885249F","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007665; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00912159; UDB=6.00457686;\n\tIPR=6.00692422; \n\tBA=6.00005569; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016998;\n\tXFM=3.00000015; UTC=2017-09-04 15:05:00","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17090415-0009-0000-0000-000043D5FAB9","Message-Id":"<6a1fb04a-b697-3b87-86a2-05f09d94dd4f@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-04_09:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709040241","Subject":"Re: [Skiboot] [PATCH v2 4/5] hdata/i2c: ignore the secure window\n\tand physical presence i2c devs","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"skiboot list ","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}}]