[{"id":1761458,"web_url":"http://patchwork.ozlabs.org/comment/1761458/","msgid":"","list_archive_url":null,"date":"2017-09-01T04:03:09","subject":"Re: [Skiboot] [PATCH v2 2/5] hdata/i2c: ignore i2c devs marked as\n\tunknown in the hdat","submitter":{"id":68108,"url":"http://patchwork.ozlabs.org/api/people/68108/","name":"Oliver O'Halloran","email":"oohall@gmail.com"},"content":"On Thu, Aug 31, 2017 at 5:12 PM, Claudio Carvalho\n wrote:\n> Some I2C devices are marked as unknown in the hdat. We don't need to add\n> them to the device tree, so this just log them.\n>\n> Signed-off-by: Claudio Carvalho \n> ---\n> hdata/i2c.c | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n>\n> diff --git a/hdata/i2c.c b/hdata/i2c.c\n> index cc127d5..bfb5b48 100644\n> --- a/hdata/i2c.c\n> +++ b/hdata/i2c.c\n> @@ -226,6 +226,17 @@ int parse_i2c_devs(const struct HDIF_common_hdr *hdr, int idata_index,\n> */\n> i2c_addr = dev->i2c_addr >> 1;\n>\n> + /*\n> + * Some i2c devs are marked as unknown in the hdat.\n> + * Ignoring them.\n> + */\n> + if (dev->type == 0xFF) {\n> + prlog(PR_INFO, \"HDAT I2C: ignoring e%dp%d - unknown@%x \"\n> + \"(port 0x%x)\\n\", dev->i2cm_engine,\n> + dev->i2cm_port, i2c_addr, dev->i2c_port);\n> + continue;\n> + }\n> +\n\nI kept these in the device-tree since I figured that we would want to\nknow about them even if we don't know what they are. I don't have any\nstrong opinions about it though so just logging it is fine with me.\n\n> prlog(PR_TRACE, \"HDAT I2C: found e%dp%d - %x\\n\",\n> dev->i2cm_engine, dev->i2cm_port, i2c_addr);\n>\n> --\n> 2.7.4\n>\n\nReviewed-by: Oliver O'Halloran ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xk5FP3S16z9sNr\n\tfor ;\n\tFri, 1 Sep 2017 14:03:21 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xk5FP2BhbzDqhM\n\tfor ;\n\tFri, 1 Sep 2017 14:03:21 +1000 (AEST)","from mail-qk0-x241.google.com (mail-qk0-x241.google.com\n\t[IPv6:2607:f8b0:400d:c09::241])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xk5FD5NnxzDqZ1\n\tfor ; Fri, 1 Sep 2017 14:03:12 +1000 (AEST)","by mail-qk0-x241.google.com with SMTP id a21so1107810qkg.4\n\tfor ; Thu, 31 Aug 2017 21:03:12 -0700 (PDT)","by 10.140.21.10 with HTTP; Thu, 31 Aug 2017 21:03:09 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ZVmQB76Z\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ZVmQB76Z\"; dkim-atps=neutral","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ZVmQB76Z\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=xmayQFzb5RABGCvVtCD8ypaVf1KL5AMd0L4w8WRR/GI=;\n\tb=ZVmQB76ZTo5kme6yRqW6rVsdg4F1sJBzUUU+rT8m9wBZEhrF46QXDJCT4Ie6ky6Kih\n\tAqw3J2TXxh3BqbLYzTxZK1ff/HidAUF30MbJNC+CLYTDLQvEJ95RTmH1DO/Fr/yX7TDi\n\tYdjPW823RduT1mV9ByRhZXPWBbs94ReJUESaIXt5ZKW//ZQjtbQOPPMPeQWyLMJV01EC\n\tf7GRoICd0LL6GJ5R5CYqpE5cpgeiiE1c7pRQowgBcvSYi2Go9Y7KKZFcVQHmjcv65O2b\n\t9eip9xyWDagH8qzjMBNvVyH5RfHrUCC4nYyrkk6owPbG/5omT8Zk3Pvp0ijl0+EtwsNA\n\twqxQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=xmayQFzb5RABGCvVtCD8ypaVf1KL5AMd0L4w8WRR/GI=;\n\tb=BNL25Dlo5MCv5GreLQSp36WYJIMCH5gWqRACHK4YSZn5ql4K88H2JbB1Oi2oIIZcru\n\tsr2mtnyb4gZzbOxOjEHPCJlnUlfqoi0mEE4KbyPORHJVelyyQYXAZv34gKO/xCduyxgN\n\t9wHw8jAxyWaB8us3t+rs5hI5eN34Zl0hbtcgDugOwjaLy2OEBIziSD75uo2Rk/Piz0Sc\n\t4RUWh779OrZpQ2Ehmxtefvse+l+IruuPlUybwI/qZxdvFHZaGeFQXO6OMTqFiDnZi1kW\n\tszwNrDTy3Nn7JeRhfsBw/UWLvmg7OIj41MmQqFN+KUG0XPuy+lZ1svfR2A/uxQVYcquY\n\tqz6Q==","X-Gm-Message-State":"AHPjjUiO0J2R7wMGJ4jklad2zgK/5Vws22MuFYDkbeVOXW7zqXF81iaW\n\tAU3jTuyqAVD/ExXEFVlIa7TWw2IY9Q==","X-Google-Smtp-Source":"ADKCNb43Cvfrxjqfnw1ASHGIZXStoiF2Ghe2favn15D/x2ux5rU2JRDzOe1ZmtZ3GzIzPjpfzuXasA/sY+asTdakIUM=","X-Received":"by 10.55.75.203 with SMTP id y194mr856002qka.23.1504238590540;\n\tThu, 31 Aug 2017 21:03:10 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1504163557-14432-3-git-send-email-cclaudio@linux.vnet.ibm.com>","References":"<1504163557-14432-1-git-send-email-cclaudio@linux.vnet.ibm.com>\n\t<1504163557-14432-3-git-send-email-cclaudio@linux.vnet.ibm.com>","From":"Oliver ","Date":"Fri, 1 Sep 2017 14:03:09 +1000","Message-ID":"","To":"Claudio Carvalho ","Subject":"Re: [Skiboot] [PATCH v2 2/5] hdata/i2c: ignore i2c devs marked as\n\tunknown in the hdat","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"skiboot list ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}},{"id":1762723,"web_url":"http://patchwork.ozlabs.org/comment/1762723/","msgid":"<34916abf-3d88-655f-2f06-f87b3077f3d0@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-04T15:12:25","subject":"Re: [Skiboot] [PATCH v2 2/5] hdata/i2c: ignore i2c devs marked as\n\tunknown in the hdat","submitter":{"id":69305,"url":"http://patchwork.ozlabs.org/api/people/69305/","name":"Claudio Carvalho","email":"cclaudio@linux.vnet.ibm.com"},"content":"On 01/09/2017 01:03, Oliver wrote:\n> On Thu, Aug 31, 2017 at 5:12 PM, Claudio Carvalho\n> wrote:\n>> Some I2C devices are marked as unknown in the hdat. We don't need to add\n>> them to the device tree, so this just log them.\n>>\n>> Signed-off-by: Claudio Carvalho \n>> ---\n>> hdata/i2c.c | 11 +++++++++++\n>> 1 file changed, 11 insertions(+)\n>>\n>> diff --git a/hdata/i2c.c b/hdata/i2c.c\n>> index cc127d5..bfb5b48 100644\n>> --- a/hdata/i2c.c\n>> +++ b/hdata/i2c.c\n>> @@ -226,6 +226,17 @@ int parse_i2c_devs(const struct HDIF_common_hdr *hdr, int idata_index,\n>> */\n>> i2c_addr = dev->i2c_addr >> 1;\n>>\n>> + /*\n>> + * Some i2c devs are marked as unknown in the hdat.\n>> + * Ignoring them.\n>> + */\n>> + if (dev->type == 0xFF) {\n>> + prlog(PR_INFO, \"HDAT I2C: ignoring e%dp%d - unknown@%x \"\n>> + \"(port 0x%x)\\n\", dev->i2cm_engine,\n>> + dev->i2cm_port, i2c_addr, dev->i2c_port);\n>> + continue;\n>> + }\n>> +\n> I kept these in the device-tree since I figured that we would want to\n> know about them even if we don't know what they are. I don't have any\n> strong opinions about it though so just logging it is fine with me.\n\nI also don't have any strong opinion about that. I proposed this patch \nbecause I don't know if an unknown i2c device like that could cause any \nproblem in the kernel. Probably it would be better to keep them in the \ndevice tree even if firmware knows nothing about them.\n\nI will drop this patch\n\nThanks\n\nClaudio\n\n>\n>> prlog(PR_TRACE, \"HDAT I2C: found e%dp%d - %x\\n\",\n>> dev->i2cm_engine, dev->i2cm_port, i2c_addr);\n>>\n>> --\n>> 2.7.4\n>>\n> Reviewed-by: Oliver O'Halloran \n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmCyR0Q8kz9s72\n\tfor ;\n\tTue, 5 Sep 2017 01:12:47 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xmCyQ6hPKzDqqP\n\tfor ;\n\tTue, 5 Sep 2017 01:12:46 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xmCyJ0pdyzDqjv\n\tfor ; Tue, 5 Sep 2017 01:12:39 +1000 (AEST)","from pps.filterd (m0098394.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv84FBK0i029723\n\tfor ; Mon, 4 Sep 2017 11:12:38 -0400","from e34.co.us.ibm.com (e34.co.us.ibm.com [32.97.110.152])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cs36ue2ac-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Mon, 04 Sep 2017 11:12:37 -0400","from localhost\n\tby e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tMon, 4 Sep 2017 09:12:37 -0600","from b03cxnp07028.gho.boulder.ibm.com (9.17.130.15)\n\tby e34.co.us.ibm.com (192.168.1.134) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tMon, 4 Sep 2017 09:12:33 -0600","from b03ledav006.gho.boulder.ibm.com\n\t(b03ledav006.gho.boulder.ibm.com [9.17.130.237])\n\tby b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v84FCXwu1114532; Mon, 4 Sep 2017 08:12:33 -0700","from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 5330AC603C;\n\tMon, 4 Sep 2017 09:12:33 -0600 (MDT)","from [9.80.192.82] (unknown [9.80.192.82])\n\tby b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP id 80485C6042;\n\tMon, 4 Sep 2017 09:12:32 -0600 (MDT)"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=cclaudio@linux.vnet.ibm.com; receiver=)","To":"Oliver ","References":"<1504163557-14432-1-git-send-email-cclaudio@linux.vnet.ibm.com>\n\t<1504163557-14432-3-git-send-email-cclaudio@linux.vnet.ibm.com>\n\t","From":"Claudio Carvalho ","Date":"Mon, 4 Sep 2017 12:12:25 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","X-TM-AS-GCONF":"00","x-cbid":"17090415-0016-0000-0000-00000776D7A2","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007665; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00912162; UDB=6.00457688;\n\tIPR=6.00692425; \n\tBA=6.00005569; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016998;\n\tXFM=3.00000015; UTC=2017-09-04 15:12:35","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17090415-0017-0000-0000-00003B54DB31","Message-Id":"<34916abf-3d88-655f-2f06-f87b3077f3d0@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-04_09:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709040243","Subject":"Re: [Skiboot] [PATCH v2 2/5] hdata/i2c: ignore i2c devs marked as\n\tunknown in the hdat","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"skiboot list ","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}},{"id":1771579,"web_url":"http://patchwork.ozlabs.org/comment/1771579/","msgid":"<87377hncui.fsf@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-20T05:44:21","subject":"Re: [Skiboot] [PATCH v2 2/5] hdata/i2c: ignore i2c devs marked as\n\tunknown in the hdat","submitter":{"id":48041,"url":"http://patchwork.ozlabs.org/api/people/48041/","name":"Stewart Smith","email":"stewart@linux.vnet.ibm.com"},"content":"Claudio Carvalho writes:\n> On 01/09/2017 01:03, Oliver wrote:\n>> On Thu, Aug 31, 2017 at 5:12 PM, Claudio Carvalho\n>> wrote:\n>>> Some I2C devices are marked as unknown in the hdat. We don't need to add\n>>> them to the device tree, so this just log them.\n>>>\n>>> Signed-off-by: Claudio Carvalho \n>>> ---\n>>> hdata/i2c.c | 11 +++++++++++\n>>> 1 file changed, 11 insertions(+)\n>>>\n>>> diff --git a/hdata/i2c.c b/hdata/i2c.c\n>>> index cc127d5..bfb5b48 100644\n>>> --- a/hdata/i2c.c\n>>> +++ b/hdata/i2c.c\n>>> @@ -226,6 +226,17 @@ int parse_i2c_devs(const struct HDIF_common_hdr *hdr, int idata_index,\n>>> */\n>>> i2c_addr = dev->i2c_addr >> 1;\n>>>\n>>> + /*\n>>> + * Some i2c devs are marked as unknown in the hdat.\n>>> + * Ignoring them.\n>>> + */\n>>> + if (dev->type == 0xFF) {\n>>> + prlog(PR_INFO, \"HDAT I2C: ignoring e%dp%d - unknown@%x \"\n>>> + \"(port 0x%x)\\n\", dev->i2cm_engine,\n>>> + dev->i2cm_port, i2c_addr, dev->i2c_port);\n>>> + continue;\n>>> + }\n>>> +\n>> I kept these in the device-tree since I figured that we would want to\n>> know about them even if we don't know what they are. I don't have any\n>> strong opinions about it though so just logging it is fine with me.\n>\n> I also don't have any strong opinion about that. I proposed this patch \n> because I don't know if an unknown i2c device like that could cause any \n> problem in the kernel. Probably it would be better to keep them in the \n> device tree even if firmware knows nothing about them.\n>\n> I will drop this patch\n\nI don't think we're in a great position to bet on what is and isn't good\nin the HDAT and we'll likely only learn by seeing what's in it and what\nhappens rather than theorising.\n\nWhat I might do is take the patch but just have it PR_WARNING out while\nstill adding the device and just see what shows up for a while.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxpbV08yDz9sBW\n\tfor ;\n\tWed, 20 Sep 2017 15:44:38 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xxpbT5krbzDqTc\n\tfor ;\n\tWed, 20 Sep 2017 15:44:37 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xxpbN3PzyzDqR8\n\tfor ; Wed, 20 Sep 2017 15:44:32 +1000 (AEST)","from pps.filterd (m0098409.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8K5i6LR032461\n\tfor ; Wed, 20 Sep 2017 01:44:30 -0400","from e16.ny.us.ibm.com (e16.ny.us.ibm.com [129.33.205.206])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d3cbnkphh-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Wed, 20 Sep 2017 01:44:29 -0400","from localhost\n\tby e16.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tWed, 20 Sep 2017 01:44:28 -0400","from b01cxnp23034.gho.pok.ibm.com (9.57.198.29)\n\tby e16.ny.us.ibm.com (146.89.104.203) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tWed, 20 Sep 2017 01:44:26 -0400","from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com\n\t[9.57.199.109])\n\tby b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v8K5iQQ939190544; Wed, 20 Sep 2017 05:44:26 GMT","from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 8DD5C112054;\n\tWed, 20 Sep 2017 01:44:06 -0400 (EDT)","from birb.localdomain (unknown [9.185.16.148])\n\tby b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP id 0F2C4112040;\n\tWed, 20 Sep 2017 01:44:06 -0400 (EDT)","by birb.localdomain (Postfix, from userid 1000)\n\tid C5EA14F0F8F; Wed, 20 Sep 2017 15:44:21 +1000 (AEST)"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=stewart@linux.vnet.ibm.com; receiver=)","From":"Stewart Smith ","To":"Claudio Carvalho , Oliver ","In-Reply-To":"<34916abf-3d88-655f-2f06-f87b3077f3d0@linux.vnet.ibm.com>","References":"<1504163557-14432-1-git-send-email-cclaudio@linux.vnet.ibm.com>\n\t<1504163557-14432-3-git-send-email-cclaudio@linux.vnet.ibm.com>\n\t\n\t<34916abf-3d88-655f-2f06-f87b3077f3d0@linux.vnet.ibm.com>","Date":"Wed, 20 Sep 2017 15:44:21 +1000","MIME-Version":"1.0","X-TM-AS-GCONF":"00","x-cbid":"17092005-0024-0000-0000-000002D4FA18","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007766; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000230; SDB=6.00919609; UDB=6.00462017;\n\tIPR=6.00699835; \n\tBA=6.00005598; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017218;\n\tXFM=3.00000015; UTC=2017-09-20 05:44:28","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092005-0025-0000-0000-0000457B704E","Message-Id":"<87377hncui.fsf@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-20_01:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709200079","Subject":"Re: [Skiboot] [PATCH v2 2/5] hdata/i2c: ignore i2c devs marked as\n\tunknown in the hdat","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"skiboot list ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}},{"id":1776634,"web_url":"http://patchwork.ozlabs.org/comment/1776634/","msgid":"","list_archive_url":null,"date":"2017-09-27T21:43:54","subject":"Re: [Skiboot] [PATCH v2 2/5] hdata/i2c: ignore i2c devs marked as\n\tunknown in the hdat","submitter":{"id":69305,"url":"http://patchwork.ozlabs.org/api/people/69305/","name":"Claudio Carvalho","email":"cclaudio@linux.vnet.ibm.com"},"content":"On 20/09/2017 02:44, Stewart Smith wrote:\n> Claudio Carvalho writes:\n>> On 01/09/2017 01:03, Oliver wrote:\n>>> On Thu, Aug 31, 2017 at 5:12 PM, Claudio Carvalho\n>>> wrote:\n>>>> Some I2C devices are marked as unknown in the hdat. We don't need to add\n>>>> them to the device tree, so this just log them.\n>>>>\n>>>> Signed-off-by: Claudio Carvalho \n>>>> ---\n>>>> hdata/i2c.c | 11 +++++++++++\n>>>> 1 file changed, 11 insertions(+)\n>>>>\n>>>> diff --git a/hdata/i2c.c b/hdata/i2c.c\n>>>> index cc127d5..bfb5b48 100644\n>>>> --- a/hdata/i2c.c\n>>>> +++ b/hdata/i2c.c\n>>>> @@ -226,6 +226,17 @@ int parse_i2c_devs(const struct HDIF_common_hdr *hdr, int idata_index,\n>>>> */\n>>>> i2c_addr = dev->i2c_addr >> 1;\n>>>>\n>>>> + /*\n>>>> + * Some i2c devs are marked as unknown in the hdat.\n>>>> + * Ignoring them.\n>>>> + */\n>>>> + if (dev->type == 0xFF) {\n>>>> + prlog(PR_INFO, \"HDAT I2C: ignoring e%dp%d - unknown@%x \"\n>>>> + \"(port 0x%x)\\n\", dev->i2cm_engine,\n>>>> + dev->i2cm_port, i2c_addr, dev->i2c_port);\n>>>> + continue;\n>>>> + }\n>>>> +\n>>> I kept these in the device-tree since I figured that we would want to\n>>> know about them even if we don't know what they are. I don't have any\n>>> strong opinions about it though so just logging it is fine with me.\n>> I also don't have any strong opinion about that. I proposed this patch\n>> because I don't know if an unknown i2c device like that could cause any\n>> problem in the kernel. Probably it would be better to keep them in the\n>> device tree even if firmware knows nothing about them.\n>>\n>> I will drop this patch\n> I don't think we're in a great position to bet on what is and isn't good\n> in the HDAT and we'll likely only learn by seeing what's in it and what\n> happens rather than theorising.\n>\n> What I might do is take the patch but just have it PR_WARNING out while\n> still adding the device and just see what shows up for a while.\n\nYeah, sounds good. I will update the patch.\n\nThanks,\n\nClaudio","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2WYQ2CPkz9t67\n\tfor ;\n\tThu, 28 Sep 2017 07:44:10 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3y2WYQ1K7kzDsPd\n\tfor ;\n\tThu, 28 Sep 2017 07:44:10 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3y2WYF68dfzDsPT\n\tfor ; Thu, 28 Sep 2017 07:44:01 +1000 (AEST)","from pps.filterd (m0098393.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8RLhUN6120167\n\tfor ; Wed, 27 Sep 2017 17:43:59 -0400","from e31.co.us.ibm.com (e31.co.us.ibm.com [32.97.110.149])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d8cv2htw5-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Wed, 27 Sep 2017 17:43:59 -0400","from localhost\n\tby e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tWed, 27 Sep 2017 15:43:58 -0600","from b03cxnp08028.gho.boulder.ibm.com (9.17.130.20)\n\tby e31.co.us.ibm.com (192.168.1.131) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tWed, 27 Sep 2017 15:43:57 -0600","from b03ledav006.gho.boulder.ibm.com\n\t(b03ledav006.gho.boulder.ibm.com [9.17.130.237])\n\tby b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8RLhufl31326340; Wed, 27 Sep 2017 14:43:56 -0700","from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id B5905C6037;\n\tWed, 27 Sep 2017 15:43:56 -0600 (MDT)","from [9.85.192.5] (unknown [9.85.192.5])\n\tby b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP id BC5DFC603E;\n\tWed, 27 Sep 2017 15:43:55 -0600 (MDT)"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=cclaudio@linux.vnet.ibm.com; receiver=)","To":"Stewart Smith , Oliver ","References":"<1504163557-14432-1-git-send-email-cclaudio@linux.vnet.ibm.com>\n\t<1504163557-14432-3-git-send-email-cclaudio@linux.vnet.ibm.com>\n\t\n\t<34916abf-3d88-655f-2f06-f87b3077f3d0@linux.vnet.ibm.com>\n\t<87377hncui.fsf@linux.vnet.ibm.com>","From":"Claudio Carvalho ","Date":"Wed, 27 Sep 2017 18:43:54 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<87377hncui.fsf@linux.vnet.ibm.com>","Content-Language":"en-US","X-TM-AS-GCONF":"00","x-cbid":"17092721-8235-0000-0000-00000C550E55","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007801; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000232; SDB=6.00923281; UDB=6.00464140;\n\tIPR=6.00703423; \n\tBA=6.00005609; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017295;\n\tXFM=3.00000015; UTC=2017-09-27 21:43:57","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092721-8236-0000-0000-00003DD22123","Message-Id":"","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-27_08:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709270302","Subject":"Re: [Skiboot] [PATCH v2 2/5] hdata/i2c: ignore i2c devs marked as\n\tunknown in the hdat","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"skiboot list ","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}}]