[{"id":1761012,"web_url":"http://patchwork.ozlabs.org/comment/1761012/","msgid":"<20170831134724.GO22289@lunn.ch>","list_archive_url":null,"date":"2017-08-31T13:47:24","subject":"Re: [PATCH net-next 2/3] net: mvpp2: use the GoP interrupt for link\n\tstatus changes","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Thu, Aug 31, 2017 at 09:12:55AM +0200, Antoine Tenart wrote:\n> +static void mvpp22_gop_unmask_irq(struct mvpp2_port *port)\n> +{\n> +\tu32 val;\n> +\n> +\tif (port->phy_interface == PHY_INTERFACE_MODE_RGMII ||\n> +\t port->phy_interface == PHY_INTERFACE_MODE_RGMII_ID ||\n> +\t port->phy_interface == PHY_INTERFACE_MODE_RGMII_RXID ||\n> +\t port->phy_interface == PHY_INTERFACE_MODE_RGMII_TXID ||\n\nHi Antoine\n\nphy_interface_mode_is_rgmii()\n\n\tAndrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjkGB6pS6z9sPt\n\tfor ;\n\tThu, 31 Aug 2017 23:47:46 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751346AbdHaNrf (ORCPT );\n\tThu, 31 Aug 2017 09:47:35 -0400","from vps0.lunn.ch ([178.209.37.122]:46630 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750911AbdHaNre (ORCPT );\n\tThu, 31 Aug 2017 09:47:34 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dnPoa-00029s-Pd; Thu, 31 Aug 2017 15:47:24 +0200"],"Date":"Thu, 31 Aug 2017 15:47:24 +0200","From":"Andrew Lunn ","To":"Antoine Tenart ","Cc":"davem@davemloft.net, gregory.clement@free-electrons.com,\n\tthomas.petazzoni@free-electrons.com, nadavh@marvell.com,\n\tlinux@armlinux.org.uk, linux-kernel@vger.kernel.org,\n\tmw@semihalf.com, stefanc@marvell.com,\n\tmiquel.raynal@free-electrons.com, netdev@vger.kernel.org","Subject":"Re: [PATCH net-next 2/3] net: mvpp2: use the GoP interrupt for link\n\tstatus changes","Message-ID":"<20170831134724.GO22289@lunn.ch>","References":"<20170831071256.18416-1-antoine.tenart@free-electrons.com>\n\t<20170831071256.18416-3-antoine.tenart@free-electrons.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170831071256.18416-3-antoine.tenart@free-electrons.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1761020,"web_url":"http://patchwork.ozlabs.org/comment/1761020/","msgid":"<20170831135255.GA26758@kwain>","list_archive_url":null,"date":"2017-08-31T13:52:55","subject":"Re: [PATCH net-next 2/3] net: mvpp2: use the GoP interrupt for link\n\tstatus changes","submitter":{"id":61603,"url":"http://patchwork.ozlabs.org/api/people/61603/","name":"Antoine Tenart","email":"antoine.tenart@free-electrons.com"},"content":"Hi Andrew,\n\nOn Thu, Aug 31, 2017 at 03:47:24PM +0200, Andrew Lunn wrote:\n> On Thu, Aug 31, 2017 at 09:12:55AM +0200, Antoine Tenart wrote:\n> > +static void mvpp22_gop_unmask_irq(struct mvpp2_port *port)\n> > +{\n> > +\tu32 val;\n> > +\n> > +\tif (port->phy_interface == PHY_INTERFACE_MODE_RGMII ||\n> > +\t port->phy_interface == PHY_INTERFACE_MODE_RGMII_ID ||\n> > +\t port->phy_interface == PHY_INTERFACE_MODE_RGMII_RXID ||\n> > +\t port->phy_interface == PHY_INTERFACE_MODE_RGMII_TXID ||\n> \n> phy_interface_mode_is_rgmii()\n\nRight, and you already made that comment before... I'll fix it.\n\nThanks!\nAntoine","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjkP107Kwz9sPm\n\tfor ;\n\tThu, 31 Aug 2017 23:53:41 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751511AbdHaNxJ (ORCPT );\n\tThu, 31 Aug 2017 09:53:09 -0400","from mail.free-electrons.com ([62.4.15.54]:51996 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751034AbdHaNxH (ORCPT\n\t); Thu, 31 Aug 2017 09:53:07 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 842B3209AD; Thu, 31 Aug 2017 15:53:04 +0200 (CEST)","from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 5B6E420816;\n\tThu, 31 Aug 2017 15:52:54 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Thu, 31 Aug 2017 15:52:55 +0200","From":"Antoine Tenart ","To":"Andrew Lunn ","Cc":"Antoine Tenart ,\n\tdavem@davemloft.net, gregory.clement@free-electrons.com,\n\tthomas.petazzoni@free-electrons.com, nadavh@marvell.com,\n\tlinux@armlinux.org.uk, linux-kernel@vger.kernel.org,\n\tmw@semihalf.com, stefanc@marvell.com,\n\tmiquel.raynal@free-electrons.com, netdev@vger.kernel.org","Subject":"Re: [PATCH net-next 2/3] net: mvpp2: use the GoP interrupt for link\n\tstatus changes","Message-ID":"<20170831135255.GA26758@kwain>","References":"<20170831071256.18416-1-antoine.tenart@free-electrons.com>\n\t<20170831071256.18416-3-antoine.tenart@free-electrons.com>\n\t<20170831134724.GO22289@lunn.ch>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"pf9I7BMVVzbSWLtt\"","Content-Disposition":"inline","In-Reply-To":"<20170831134724.GO22289@lunn.ch>","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]