[{"id":1761955,"web_url":"http://patchwork.ozlabs.org/comment/1761955/","msgid":"<2f969c4b-7568-5692-2763-21d1259981e9@amsat.org>","list_archive_url":null,"date":"2017-09-01T19:50:10","subject":"Re: [Qemu-devel] [PATCH v5 05/12] tests: Add ubuntu.i386 image","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"Hi Fam,\n\nOn 08/31/2017 03:42 AM, Fam Zheng wrote:\n> This adds a 32bit guest.\n> \n> The official LTS cloud image is downloaded and initialized with\n> cloud-init.\n> \n> Signed-off-by: Fam Zheng \n> ---\n> tests/vm/ubuntu.i386 | 88 ++++++++++++++++++++++++++++++++++++++++++++++++++++\n> 1 file changed, 88 insertions(+)\n> create mode 100755 tests/vm/ubuntu.i386\n> \n> diff --git a/tests/vm/ubuntu.i386 b/tests/vm/ubuntu.i386\n> new file mode 100755\n> index 0000000000..1a55856d9c\n> --- /dev/null\n> +++ b/tests/vm/ubuntu.i386\n> @@ -0,0 +1,88 @@\n> +#!/usr/bin/env python\n> +#\n> +# Ubuntu i386 image\n> +#\n> +# Copyright (C) 2017 Red Hat Inc.\n> +#\n> +# Authors:\n> +# Fam Zheng \n> +#\n> +# This work is licensed under the terms of the GNU GPL, version 2. See\n> +# the COPYING file in the top-level directory.\n> +#\n> +\n> +import os\n> +import sys\n> +import subprocess\n> +import basevm\n> +import time\n> +\n> +class UbuntuX86VM(basevm.BaseVM):\n> + name = \"ubuntu.i386\"\n> + BUILD_SCRIPT = \"\"\"\n> + set -e;\n> + cd $(mktemp -d);\n> + sudo chmod a+r /dev/vdb;\n> + tar -xf /dev/vdb;\n> + ./configure {configure_opts};\n> + make -j{jobs};\n> + make check;\n> + \"\"\"\n> +\n> + def _gen_cloud_init_iso(self):\n> + cidir = self._tmpdir\n> + mdata = open(os.path.join(cidir, \"meta-data\"), \"w\")\n> + mdata.writelines([\"instance-id: ubuntu-vm-0\\n\",\n> + \"local-hostname: ubuntu-guest\\n\"])\n> + mdata.close()\n> + udata = open(os.path.join(cidir, \"user-data\"), \"w\")\n> + udata.writelines([\"#cloud-config\\n\",\n> + \"chpasswd:\\n\",\n> + \" list: |\\n\",\n> + \" root:%s\\n\" % self.ROOT_PASS,\n> + \" %s:%s\\n\" % (self.GUEST_USER, self.GUEST_PASS),\n> + \" expire: False\\n\",\n> + \"users:\\n\",\n> + \" - name: %s\\n\" % self.GUEST_USER,\n> + \" sudo: ALL=(ALL) NOPASSWD:ALL\\n\",\n> + \" ssh-authorized-keys:\\n\",\n> + \" - %s\\n\" % basevm.SSH_PUB_KEY,\n> + \" - name: root\\n\",\n> + \" ssh-authorized-keys:\\n\",\n> + \" - %s\\n\" % basevm.SSH_PUB_KEY])\n> + udata.close()\n> + subprocess.check_call([\"genisoimage\", \"-output\", \"cloud-init.iso\",\n> + \"-volid\", \"cidata\", \"-joliet\", \"-rock\",\n> + \"user-data\", \"meta-data\"],\n> + cwd=cidir,\n> + stdin=self._devnull, stdout=self._stdout,\n> + stderr=self._stdout)\n> + return os.path.join(cidir, \"cloud-init.iso\")\n> +\n> + def build_image(self, img):\n> + cimg = self._download_with_cache(\"https://cloud-images.ubuntu.com/releases/16.04/release/ubuntu-16.04-server-cloudimg-i386-disk1.img\")\n> + img_tmp = img + \".tmp\"\n> + subprocess.check_call([\"cp\", \"-f\", cimg, img_tmp])\n> + subprocess.check_call([\"qemu-img\", \"resize\", img_tmp, \"50G\"])\n> + self.boot(img_tmp, extra_args = [\"-cdrom\", self._gen_cloud_init_iso()])\n\nI'd rather test a 32bit cpu, not 64bit cpu in 32bit mode.\n\nI first tested with \"-cpu pentium2\" which worked, I then find it easier \nthis way:\n\nif /dev/kvm: \"kvm32\"\nelse: \"qemu32\"\n\nWhat do you think?\n\n> + self.wait_ssh()\n> + self.ssh_root_check(\"touch /etc/cloud/cloud-init.disabled\")\n> + self.ssh_root_check(\"apt-get update\")\n> + self.ssh_root_check(\"apt-get install -y cloud-initramfs-growroot\")\n> + # Don't check the status in case the guest hang up too quickly\n> + self.ssh_root(\"sync && reboot\")\n> + time.sleep(5)\n> + self.wait_ssh()\n> + # The previous update sometimes doesn't survive a reboot, so do it again\n> + self.ssh_root_check(\"apt-get update\")\n> + self.ssh_root_check(\"apt-get build-dep -y qemu\")\n> + self.ssh_root_check(\"apt-get install -y libfdt-dev\")\n> + self.ssh_root(\"poweroff\")\n> + self.wait()\n> + if os.path.exists(img):\n> + os.remove(img)\n> + os.rename(img_tmp, img)\n> + return 0\n> +\n> +if __name__ == \"__main__\":\n> + sys.exit(basevm.main(UbuntuX86VM))\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"lwDzevJK\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkVGh2BTbz9sPt\n\tfor ;\n\tSat, 2 Sep 2017 05:50:52 +1000 (AEST)","from localhost ([::1]:57531 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnrxq-000264-CG\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 15:50:50 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49717)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dnrxM-00020j-I2\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 15:50:25 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dnrxH-0002JF-Qd\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 15:50:19 -0400","from mail-qt0-x231.google.com ([2607:f8b0:400d:c0d::231]:34144)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnrxH-0002IS-Kw\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 15:50:15 -0400","by mail-qt0-x231.google.com with SMTP id u11so5445635qtu.1\n\tfor ; Fri, 01 Sep 2017 12:50:15 -0700 (PDT)","from [192.168.1.10] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\ta186sm7892196qkg.13.2017.09.01.12.50.11\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 01 Sep 2017 12:50:14 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=kViIGdYL8yYpc1uO8qVlJWsmLVV6JrJQyxq7iDys9G8=;\n\tb=lwDzevJKEp/KoaMCUH3CARjEq6Hs99kh7Ql0YWrXNsNzdT/5OIVCuqwFI7Yh1ICwj4\n\tP/06KcGr97pO+QJF7hEnoPNFX5Jkg3qN0bN+jkQ0iWmFoZD+aS/nsUZ9MxlMQ0kmgH7V\n\tfrrzP7YIPcNyQWHRHrlvEF2F7Crle0chzO61JbGGfJJl/tO1YBkV72S4+/E/8TGCGc/9\n\tPCwlBWkXjXrXBLlD6ei30QJIAtl9AZfaIsSEHpFl+0VOLAB3S38m3vQbodOGNlEIJqxv\n\tqVVvyGas46J1hs1MTZCre5s/ElPjQRMm31OHuZFptxMvdk4wfiyE6DWPA+ehrJE/RkCG\n\tLtnA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=kViIGdYL8yYpc1uO8qVlJWsmLVV6JrJQyxq7iDys9G8=;\n\tb=UsDeVeL+rsuHdar87/cgR1Z8X/unRfkF3lJJsba8mupxXl/I8cxsoqv9Qt3MWUFDF0\n\tXZ6FgO0tW4cUkRtDPnZe/u4xRpadpS26T7uCvlu0XrFjKvXY6HUTSVoqgMeX5o7q3FSR\n\tWQpl3q4MN+MzNQU+x7VW9VfBjjK57139/DDzkRhjbDRDnv73PNuXZpHF6xg4ooWxJ83d\n\t7SXPv7szwjEjqKxETzMIhprTkPrgAOknNM4KthjHTKj4W7ka2J+T3iQNVIcy+ohoMFRp\n\tiC61PMNJd5HM4rWM67Plbr3AI9Zq3Fhhj09KYC/zgg9iWh3e77zU2B174Ix9DlZvVs9U\n\tYssQ==","X-Gm-Message-State":"AHPjjUjI011/mF9yyAO9LCb3l+YP85NYvi3dAK+xvV3/WEJQfohf5nVN\n\tPmIRKAbD9e33AA==","X-Google-Smtp-Source":"ADKCNb7/Cv/zHPeVzZl1ZAWTlKpVDquSSZx0thPJAuSng1aUR2jy5lkZ8yD4JaWDo9X5uO00UVtKxw==","X-Received":"by 10.200.27.61 with SMTP id y58mr4336251qtj.192.1504295414814; \n\tFri, 01 Sep 2017 12:50:14 -0700 (PDT)","To":"Fam Zheng , qemu-devel@nongnu.org","References":"<20170831064302.14427-1-famz@redhat.com>\n\t<20170831064302.14427-6-famz@redhat.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"<2f969c4b-7568-5692-2763-21d1259981e9@amsat.org>","Date":"Fri, 1 Sep 2017 16:50:10 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170831064302.14427-6-famz@redhat.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c0d::231","Subject":"Re: [Qemu-devel] [PATCH v5 05/12] tests: Add ubuntu.i386 image","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , Kamil Rytarowski\n\t, stefanha@redhat.com, Cleber Rosa ,\n\tpbonzini@redhat.com, =?utf-8?q?Alex_Benn=C3=A9e?=\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762910,"web_url":"http://patchwork.ozlabs.org/comment/1762910/","msgid":"<20170905020013.GA22515@lemon.lan>","list_archive_url":null,"date":"2017-09-05T02:00:13","subject":"Re: [Qemu-devel] [PATCH v5 05/12] tests: Add ubuntu.i386 image","submitter":{"id":24872,"url":"http://patchwork.ozlabs.org/api/people/24872/","name":"Fam Zheng","email":"famz@redhat.com"},"content":"On Fri, 09/01 16:50, Philippe Mathieu-Daudé wrote:\n> Hi Fam,\n> \n> On 08/31/2017 03:42 AM, Fam Zheng wrote:\n> > This adds a 32bit guest.\n> > \n> > The official LTS cloud image is downloaded and initialized with\n> > cloud-init.\n> > \n> > Signed-off-by: Fam Zheng \n> > ---\n> > tests/vm/ubuntu.i386 | 88 ++++++++++++++++++++++++++++++++++++++++++++++++++++\n> > 1 file changed, 88 insertions(+)\n> > create mode 100755 tests/vm/ubuntu.i386\n> > \n> > diff --git a/tests/vm/ubuntu.i386 b/tests/vm/ubuntu.i386\n> > new file mode 100755\n> > index 0000000000..1a55856d9c\n> > --- /dev/null\n> > +++ b/tests/vm/ubuntu.i386\n> > @@ -0,0 +1,88 @@\n> > +#!/usr/bin/env python\n> > +#\n> > +# Ubuntu i386 image\n> > +#\n> > +# Copyright (C) 2017 Red Hat Inc.\n> > +#\n> > +# Authors:\n> > +# Fam Zheng \n> > +#\n> > +# This work is licensed under the terms of the GNU GPL, version 2. See\n> > +# the COPYING file in the top-level directory.\n> > +#\n> > +\n> > +import os\n> > +import sys\n> > +import subprocess\n> > +import basevm\n> > +import time\n> > +\n> > +class UbuntuX86VM(basevm.BaseVM):\n> > + name = \"ubuntu.i386\"\n> > + BUILD_SCRIPT = \"\"\"\n> > + set -e;\n> > + cd $(mktemp -d);\n> > + sudo chmod a+r /dev/vdb;\n> > + tar -xf /dev/vdb;\n> > + ./configure {configure_opts};\n> > + make -j{jobs};\n> > + make check;\n> > + \"\"\"\n> > +\n> > + def _gen_cloud_init_iso(self):\n> > + cidir = self._tmpdir\n> > + mdata = open(os.path.join(cidir, \"meta-data\"), \"w\")\n> > + mdata.writelines([\"instance-id: ubuntu-vm-0\\n\",\n> > + \"local-hostname: ubuntu-guest\\n\"])\n> > + mdata.close()\n> > + udata = open(os.path.join(cidir, \"user-data\"), \"w\")\n> > + udata.writelines([\"#cloud-config\\n\",\n> > + \"chpasswd:\\n\",\n> > + \" list: |\\n\",\n> > + \" root:%s\\n\" % self.ROOT_PASS,\n> > + \" %s:%s\\n\" % (self.GUEST_USER, self.GUEST_PASS),\n> > + \" expire: False\\n\",\n> > + \"users:\\n\",\n> > + \" - name: %s\\n\" % self.GUEST_USER,\n> > + \" sudo: ALL=(ALL) NOPASSWD:ALL\\n\",\n> > + \" ssh-authorized-keys:\\n\",\n> > + \" - %s\\n\" % basevm.SSH_PUB_KEY,\n> > + \" - name: root\\n\",\n> > + \" ssh-authorized-keys:\\n\",\n> > + \" - %s\\n\" % basevm.SSH_PUB_KEY])\n> > + udata.close()\n> > + subprocess.check_call([\"genisoimage\", \"-output\", \"cloud-init.iso\",\n> > + \"-volid\", \"cidata\", \"-joliet\", \"-rock\",\n> > + \"user-data\", \"meta-data\"],\n> > + cwd=cidir,\n> > + stdin=self._devnull, stdout=self._stdout,\n> > + stderr=self._stdout)\n> > + return os.path.join(cidir, \"cloud-init.iso\")\n> > +\n> > + def build_image(self, img):\n> > + cimg = self._download_with_cache(\"https://cloud-images.ubuntu.com/releases/16.04/release/ubuntu-16.04-server-cloudimg-i386-disk1.img\")\n> > + img_tmp = img + \".tmp\"\n> > + subprocess.check_call([\"cp\", \"-f\", cimg, img_tmp])\n> > + subprocess.check_call([\"qemu-img\", \"resize\", img_tmp, \"50G\"])\n> > + self.boot(img_tmp, extra_args = [\"-cdrom\", self._gen_cloud_init_iso()])\n> \n> I'd rather test a 32bit cpu, not 64bit cpu in 32bit mode.\n> \n> I first tested with \"-cpu pentium2\" which worked, I then find it easier this\n> way:\n> \n> if /dev/kvm: \"kvm32\"\n> else: \"qemu32\"\n> \n> What do you think?\n\nNo, I don't think so, I'm not testing the cpu emulation here. Let's focus on the\ntest subject which is what happens in the guest, not how it is emulated, as long\nas it works.\n\nFam","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=famz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmVLP1g3cz9sNr\n\tfor ;\n\tTue, 5 Sep 2017 12:00:59 +1000 (AEST)","from localhost ([::1]:56375 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dp3Ad-0008Bs-PV\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 22:00:55 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56953)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dp3A8-0008BQ-Bb\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 22:00:29 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dp3A3-0001Pp-I8\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 22:00:24 -0400","from mx1.redhat.com ([209.132.183.28]:51198)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dp3A3-0001PO-8d\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 22:00:19 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C3DAF7EA8F;\n\tTue, 5 Sep 2017 02:00:17 +0000 (UTC)","from localhost (ovpn-12-97.pek2.redhat.com [10.72.12.97])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 2F5D35D722;\n\tTue, 5 Sep 2017 02:00:14 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C3DAF7EA8F","Date":"Tue, 5 Sep 2017 10:00:13 +0800","From":"Fam Zheng ","To":"Philippe =?iso-8859-1?q?Mathieu-Daud=E9?= ","Message-ID":"<20170905020013.GA22515@lemon.lan>","References":"<20170831064302.14427-1-famz@redhat.com>\n\t<20170831064302.14427-6-famz@redhat.com>\n\t<2f969c4b-7568-5692-2763-21d1259981e9@amsat.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","In-Reply-To":"<2f969c4b-7568-5692-2763-21d1259981e9@amsat.org>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tTue, 05 Sep 2017 02:00:18 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v5 05/12] tests: Add ubuntu.i386 image","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , qemu-devel@nongnu.org, Kamil\n\tRytarowski , stefanha@redhat.com, Cleber Rosa\n\t, pbonzini@redhat.com, Alex =?iso-8859-1?q?Benn=E9e?=\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]