[{"id":1761970,"web_url":"http://patchwork.ozlabs.org/comment/1761970/","msgid":"","list_archive_url":null,"date":"2017-09-01T20:32:50","subject":"Re: [Qemu-devel] [PATCH v5 01/12] gitignore: Ignore vm test images","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"On 08/31/2017 03:42 AM, Fam Zheng wrote:\n> Reviewed-by: Stefan Hajnoczi \n> Reviewed-by: Philippe Mathieu-Daudé \n> Signed-off-by: Fam Zheng \n> ---\n> .gitignore | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/.gitignore b/.gitignore\n> index cf65316863..643e23e515 100644\n> --- a/.gitignore\n> +++ b/.gitignore\n> @@ -52,6 +52,8 @@\n> /vscclient\n> /vhost-user-scsi\n> /fsdev/virtfs-proxy-helper\n> +/tests/vm/*.img\n\nThere is a tests/.gitignore, isn't it cleaner to add vm/*.img there?\n\n> +*.tmp\n> *.[1-9]\n> *.a\n> *.aux\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"GRP7VaWN\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkWCh2Cs0z9s7M\n\tfor ;\n\tSat, 2 Sep 2017 06:33:20 +1000 (AEST)","from localhost ([::1]:59246 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnscw-0000Yz-EM\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 16:33:18 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39529)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dnscc-0000Ym-EN\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 16:32:59 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dnscZ-0004g3-Cw\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 16:32:58 -0400","from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242]:32779)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnscZ-0004fl-8k\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 16:32:55 -0400","by mail-qt0-x242.google.com with SMTP id h15so986115qta.0\n\tfor ; Fri, 01 Sep 2017 13:32:55 -0700 (PDT)","from [192.168.1.10] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\t20sm756072qtu.52.2017.09.01.13.32.51\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 01 Sep 2017 13:32:54 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=Cy5WjFg9V/FE0hbgwY+CurbEgPeZHql9yiZm5jYuhHI=;\n\tb=GRP7VaWNENZguVplYHZfwzWjxQM1x9XR9JHMBa0yKDxsrWJiCtCcgScdr3SNN4gQUt\n\tHtOvRS5kk0TLfHRGXukeOwKN+eyMH17QUwSMWyNAbuFYu2f5aU2xWlNH3SblClQEyU+P\n\t8KaxnSST2i8fDC3b7yM/CMLgaHnAuSXb1Vif+J6SblPSIK2RikfnBJJ6BMejvqZeahEO\n\tXQRUir/+TZSnXksboXIE0zbjX8KHZDkRoPhQgat1/ssQPe0xVPcQ3rgjlzATnLFJbF+9\n\t4nkRgecXLvmJSXxyw+ThA1LZvLoGjNFfzz8alOY9mX149owb4OSOsJzD0ICnJxc8ZBS+\n\tIImQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=Cy5WjFg9V/FE0hbgwY+CurbEgPeZHql9yiZm5jYuhHI=;\n\tb=PuE3mnH5DKqjGHYggrOmVkuiUGPFVcdg1YtPNRku7EOvsDofYiUCrGQ9jCh6XW68Av\n\tgqSmahRh0eeVd8RCiQS4Qu1urRNtl85OV3UecY3IoMfIGXK6P2H9XW9ZZ3NKcZlmWdTp\n\tR5CNDFSuV01tnR8CDM/oFi9gcBUzEKedlGyi5bxJFsgtcchRP6sbOPqCR9Ls8lmUP4kc\n\tXz15LDTqoPILxzZvjdG7tSxrCaeBlX7AyFWieP7IFGuIjrJOu3857FggQqvpfNIpmFlL\n\tTHJ0h038ilHUG2TUhoux9876JSJDy8lD5oSoSrQKYVIoM1kV5F/IP9EQ2enXZ4JN1HVi\n\tz02g==","X-Gm-Message-State":"AHPjjUh9hUMhz7a26DONJS0nfrM+/G49O+sHwgsV0BvoPpjLQycQXNMP\n\tUOpGgdyPMIF8AA==","X-Google-Smtp-Source":"ADKCNb5esOS/bBxwO1H77WqbxFtjqWqJmsNk2Al64AiBwQGMMbOEbxeE8fXiIM8QV+BxgUEQSbeT7A==","X-Received":"by 10.200.23.37 with SMTP id w34mr4873208qtj.164.1504297974800; \n\tFri, 01 Sep 2017 13:32:54 -0700 (PDT)","To":"Fam Zheng , qemu-devel@nongnu.org","References":"<20170831064302.14427-1-famz@redhat.com>\n\t<20170831064302.14427-2-famz@redhat.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"","Date":"Fri, 1 Sep 2017 17:32:50 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170831064302.14427-2-famz@redhat.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c0d::242","Subject":"Re: [Qemu-devel] [PATCH v5 01/12] gitignore: Ignore vm test images","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , Kamil Rytarowski\n\t, stefanha@redhat.com, Cleber Rosa ,\n\tpbonzini@redhat.com, =?utf-8?q?Alex_Benn=C3=A9e?=\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762911,"web_url":"http://patchwork.ozlabs.org/comment/1762911/","msgid":"<20170905020108.GB22515@lemon.lan>","list_archive_url":null,"date":"2017-09-05T02:01:08","subject":"Re: [Qemu-devel] [PATCH v5 01/12] gitignore: Ignore vm test images","submitter":{"id":24872,"url":"http://patchwork.ozlabs.org/api/people/24872/","name":"Fam Zheng","email":"famz@redhat.com"},"content":"On Fri, 09/01 17:32, Philippe Mathieu-Daudé wrote:\n> On 08/31/2017 03:42 AM, Fam Zheng wrote:\n> > Reviewed-by: Stefan Hajnoczi \n> > Reviewed-by: Philippe Mathieu-Daudé \n> > Signed-off-by: Fam Zheng \n> > ---\n> > .gitignore | 2 ++\n> > 1 file changed, 2 insertions(+)\n> > \n> > diff --git a/.gitignore b/.gitignore\n> > index cf65316863..643e23e515 100644\n> > --- a/.gitignore\n> > +++ b/.gitignore\n> > @@ -52,6 +52,8 @@\n> > /vscclient\n> > /vhost-user-scsi\n> > /fsdev/virtfs-proxy-helper\n> > +/tests/vm/*.img\n> \n> There is a tests/.gitignore, isn't it cleaner to add vm/*.img there?\n\nYes, probably.\n\nFam\n\n> \n> > +*.tmp\n> > *.[1-9]\n> > *.a\n> > *.aux\n> > \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=famz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmVMR4Vkbz9sNr\n\tfor ;\n\tTue, 5 Sep 2017 12:01:55 +1000 (AEST)","from localhost ([::1]:56380 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dp3BZ-0000Bu-PK\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 22:01:53 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57182)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dp3B1-0000A6-Af\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 22:01:24 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dp3Aw-000247-GW\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 22:01:19 -0400","from mx1.redhat.com ([209.132.183.28]:44174)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dp3Aw-00022v-BE\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 22:01:14 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4CF64552DB;\n\tTue, 5 Sep 2017 02:01:13 +0000 (UTC)","from localhost (ovpn-12-97.pek2.redhat.com [10.72.12.97])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id C0DF97EA61;\n\tTue, 5 Sep 2017 02:01:10 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 4CF64552DB","Date":"Tue, 5 Sep 2017 10:01:08 +0800","From":"Fam Zheng ","To":"Philippe =?iso-8859-1?q?Mathieu-Daud=E9?= ","Message-ID":"<20170905020108.GB22515@lemon.lan>","References":"<20170831064302.14427-1-famz@redhat.com>\n\t<20170831064302.14427-2-famz@redhat.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tTue, 05 Sep 2017 02:01:13 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v5 01/12] gitignore: Ignore vm test images","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , qemu-devel@nongnu.org, Kamil\n\tRytarowski , stefanha@redhat.com, Cleber Rosa\n\t, pbonzini@redhat.com, Alex =?iso-8859-1?q?Benn=E9e?=\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]