[{"id":1760657,"web_url":"http://patchwork.ozlabs.org/comment/1760657/","msgid":"<37014b27-5eaa-dc27-55e5-890a03c3666e@ozlabs.org>","list_archive_url":null,"date":"2017-08-31T05:35:46","subject":"Re: [PATCH] views: Fix \"Add to bundle\" dropdown on patch list view","submitter":{"id":1,"url":"http://patchwork.ozlabs.org/api/people/1/","name":"Jeremy Kerr","email":"jk@ozlabs.org"},"content":"Hi Andrew,\n\n> jk: if you could apply this to ozlabs.org would be much appreciated\n\nSure thing, done.\n\nCheers,\n\n\nJeremy","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","patchwork@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","patchwork@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjWLg2TRQz9s83\n\tfor ;\n\tThu, 31 Aug 2017 15:35:55 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xjWLg1KYKzDqV5\n\tfor ;\n\tThu, 31 Aug 2017 15:35:55 +1000 (AEST)","from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xjWLW5phyzDqGZ\n\tfor ;\n\tThu, 31 Aug 2017 15:35:47 +1000 (AEST)","from authenticated.ozlabs.org (localhost [127.0.0.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPSA id 3xjWLW3Dc8z9s83;\n\tThu, 31 Aug 2017 15:35:47 +1000 (AEST)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tsecure) header.d=ozlabs.org header.i=@ozlabs.org header.b=\"lgigsJpp\";\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tsecure) header.d=ozlabs.org header.i=@ozlabs.org header.b=\"lgigsJpp\";\n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tsecure) header.d=ozlabs.org header.i=@ozlabs.org header.b=\"lgigsJpp\"; \n\tdkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; \n\tt=1504157747; bh=Zx8g2gJfGR2lzhBe+2ERCdB4+08uwTcLQCyxfkalPCM=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=lgigsJppX0aDT0zYb5cAVTaRi4vZq8Q3zQGdenk9hmAKTFS5wE4AkqgMCI30mbyMB\n\t7NLrtZbjiH+iR5bW6IMYbftJCRcooGcBpUzRYJNjDEawUoz7ec2R8Yt+i9iAjAAq5G\n\ty3EF7jbaerjZRJOYlSDCakt2s3EBMJ2r1wutdcdk8TbtBkzQIDCtOgOM7tvdNo/lO9\n\tQq0gm8lG0CE8rGzs+EFkgCJHiBND5KsaKR/Coyvu38vmxi6s35AHXKkqt13bc7l7Bc\n\tzsuW6YbC6iRX2pO7wvtnV5Y22jhjHHTb47b8wgm4Qa1LHfPtP4NfNYOUOBQshc0jza\n\tqi9tlO875HEuA==","Subject":"Re: [PATCH] views: Fix \"Add to bundle\" dropdown on patch list view","To":"Andrew Donnellan ,\n\tpatchwork@lists.ozlabs.org","References":"<20170831043124.1187-1-andrew.donnellan@au1.ibm.com>","From":"Jeremy Kerr ","Message-ID":"<37014b27-5eaa-dc27-55e5-890a03c3666e@ozlabs.org>","Date":"Thu, 31 Aug 2017 13:35:46 +0800","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170831043124.1187-1-andrew.donnellan@au1.ibm.com>","Content-Language":"en-AU","X-BeenThere":"patchwork@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Patchwork development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Patchwork\"\n\t"}},{"id":1760747,"web_url":"http://patchwork.ozlabs.org/comment/1760747/","msgid":"<1504168867.17648.2.camel@that.guru>","list_archive_url":null,"date":"2017-08-31T08:41:07","subject":"Re: [PATCH] views: Fix \"Add to bundle\" dropdown on patch list view","submitter":{"id":69991,"url":"http://patchwork.ozlabs.org/api/people/69991/","name":"Stephen Finucane","email":"stephen@that.guru"},"content":"On Thu, 2017-08-31 at 09:40 +0100, Stephen Finucane wrote:\n> On Thu, 2017-08-31 at 14:31 +1000, Andrew Donnellan wrote:\n> > The \"Add to bundle\" option in the patch list view requires the user's\n> > list of bundles to be added to the context. Before PatchworkRequestContext\n> > was removed, this was done in a context processor. When that was\n> > refactored out, the bundles list was re-added in the patch detail view,\n> > but not in the patch list view.\n> > \n> > Add the bundles list in the patch list view to rectify this.\n> > \n> > Reported-by: David Miller \n> > Reported-by: Michael Ellerman \n> > Reported-by: Paul Mackerras \n> > Suggested-by: Michael Ellerman \n> > Cc: stable\n> > Closes #116 (\"Add to existing bundle drop down has disappeared from bottom\n> > of\n> > patch list page\")\n> > Signed-off-by: Andrew Donnellan \n> \n> Sorry for missing this. Applied to 'master' and backported to 'stable/2.0'.\n> I'll probably get a v2.0.1 release out before the end of the week.\n\nReviewed-by: Stephen Finucane \n\nStephen","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","patchwork@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","patchwork@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjbSd37d0z9sMN\n\tfor ;\n\tThu, 31 Aug 2017 18:41:21 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xjbSd1vybzDqV5\n\tfor ;\n\tThu, 31 Aug 2017 18:41:21 +1000 (AEST)","from camel.maple.relay.mailchannels.net\n\t(camel.maple.relay.mailchannels.net [23.83.214.29])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xjbSW3NJmzDqGZ\n\tfor ;\n\tThu, 31 Aug 2017 18:41:15 +1000 (AEST)","from relay.mailchannels.net (localhost [127.0.0.1])\n\tby relay.mailchannels.net (Postfix) with ESMTP id 104C48A80F1;\n\tThu, 31 Aug 2017 08:41:11 +0000 (UTC)","from one.mxroute.com (unknown [100.96.140.134])\n\t(Authenticated sender: mxroute)\n\tby relay.mailchannels.net (Postfix) with ESMTPA id 62CCA8A7D1E;\n\tThu, 31 Aug 2017 08:41:10 +0000 (UTC)","from one.mxroute.com (one-outgoing.mxroute.com [172.20.104.49])\n\t(using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384)\n\tby 0.0.0.0:2500 (trex/5.9.14); Thu, 31 Aug 2017 08:41:11 +0000"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=that.guru header.i=@that.guru\n\theader.b=\"PuwioKVr\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=that.guru header.i=@that.guru\n\theader.b=\"PuwioKVr\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=that.guru header.i=@that.guru\n\theader.b=\"PuwioKVr\"; dkim-atps=neutral"],"X-Sender-Id":["mxroute|x-authuser|stephen@that.guru","mxroute|x-authuser|stephen@that.guru"],"X-MC-Relay":"Neutral","X-MailChannels-SenderId":"mxroute|x-authuser|stephen@that.guru","X-MailChannels-Auth-Id":"mxroute","X-Chemical-Wipe":"00802dc4019ca7d9_1504168870772_2487959515","X-MC-Loop-Signature":"1504168870771:1316536572","X-MC-Ingress-Time":"1504168870771","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=that.guru;\n\ts=default;\n\th=Content-Transfer-Encoding:Mime-Version:Content-Type:References:\n\tIn-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=2dVUvgmlOVkEkRLR2XHu91FtYxDlBytyai8C58NVvlE=;\n\tb=PuwioKVrWdaXfXyNZhpIWVAosY\n\tGjdYzdE+akkLFluUNsgvkmFXLF2Udb+eDWIao9LHaEBz0X3Vy0PiGLKepcCUT76bs5HVMTiHO1fKQ\n\tsq0WiQsPt/kwK+0THVpQzWpQXLqVa9ttsOterZBnWFr8HkLJEYwa0X4ST5ZXrJrTDDJzVi/NpSo7n\n\tv3ADe4+BEUdOTEl1CKWeMF4IrPPtaGE46dxHWBl78DxFchYskXxn8XpFBWeFvwMXYe7ydePn2cNjP\n\tVh8c279xoO2hkxDnzRdalLbvlu8D/vklvzPgNgzLfa/hWbOY0s6JxLBIeZWb12bbEwp1IRxbR1ocX\n\tvIL196tQ==;","Message-ID":"<1504168867.17648.2.camel@that.guru>","Subject":"Re: [PATCH] views: Fix \"Add to bundle\" dropdown on patch list view","From":"Stephen Finucane ","To":"Andrew Donnellan , \n\tpatchwork@lists.ozlabs.org","Date":"Thu, 31 Aug 2017 09:41:07 +0100","In-Reply-To":"<1504168803.17648.1.camel@that.guru>","References":"<20170831043124.1187-1-andrew.donnellan@au1.ibm.com>\n\t<1504168803.17648.1.camel@that.guru>","X-Mailer":"Evolution 3.24.5 (3.24.5-1.fc26) ","Mime-Version":"1.0","X-AuthUser":"stephen@that.guru","X-BeenThere":"patchwork@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Patchwork development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"jk@ozlabs.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Patchwork\"\n\t"}},{"id":1760755,"web_url":"http://patchwork.ozlabs.org/comment/1760755/","msgid":"<1504168803.17648.1.camel@that.guru>","list_archive_url":null,"date":"2017-08-31T08:40:03","subject":"Re: [PATCH] views: Fix \"Add to bundle\" dropdown on patch list view","submitter":{"id":69991,"url":"http://patchwork.ozlabs.org/api/people/69991/","name":"Stephen Finucane","email":"stephen@that.guru"},"content":"On Thu, 2017-08-31 at 14:31 +1000, Andrew Donnellan wrote:\n> The \"Add to bundle\" option in the patch list view requires the user's\n> list of bundles to be added to the context. Before PatchworkRequestContext\n> was removed, this was done in a context processor. When that was\n> refactored out, the bundles list was re-added in the patch detail view,\n> but not in the patch list view.\n> \n> Add the bundles list in the patch list view to rectify this.\n> \n> Reported-by: David Miller \n> Reported-by: Michael Ellerman \n> Reported-by: Paul Mackerras \n> Suggested-by: Michael Ellerman \n> Cc: stable\n> Closes #116 (\"Add to existing bundle drop down has disappeared from bottom of\n> patch list page\")\n> Signed-off-by: Andrew Donnellan \n\nSorry for missing this. Applied to 'master' and backported to 'stable/2.0'.\nI'll probably get a v2.0.1 release out before the end of the week.\n\nStephen","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","patchwork@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","patchwork@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjbc4730Mz9s3w\n\tfor ;\n\tThu, 31 Aug 2017 18:47:48 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xjbc45sFWzDqV5\n\tfor ;\n\tThu, 31 Aug 2017 18:47:48 +1000 (AEST)","from camel.maple.relay.mailchannels.net\n\t(camel.maple.relay.mailchannels.net [23.83.214.29])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xjbc10wkNzDqGZ\n\tfor ;\n\tThu, 31 Aug 2017 18:47:44 +1000 (AEST)","from relay.mailchannels.net (localhost [127.0.0.1])\n\tby relay.mailchannels.net (Postfix) with ESMTP id C31478A6424;\n\tThu, 31 Aug 2017 08:40:07 +0000 (UTC)","from one.mxroute.com (unknown [100.96.140.134])\n\t(Authenticated sender: mxroute)\n\tby relay.mailchannels.net (Postfix) with ESMTPA id 251628A8F3C;\n\tThu, 31 Aug 2017 08:40:07 +0000 (UTC)","from one.mxroute.com (one-outgoing.mxroute.com [172.20.72.20])\n\t(using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384)\n\tby 0.0.0.0:2500 (trex/5.9.14); Thu, 31 Aug 2017 08:40:07 +0000"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=that.guru header.i=@that.guru\n\theader.b=\"IE03vOv2\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=that.guru header.i=@that.guru\n\theader.b=\"IE03vOv2\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=that.guru header.i=@that.guru\n\theader.b=\"IE03vOv2\"; dkim-atps=neutral"],"X-Sender-Id":["mxroute|x-authuser|stephen@that.guru","mxroute|x-authuser|stephen@that.guru"],"X-MC-Relay":"Neutral","X-MailChannels-SenderId":"mxroute|x-authuser|stephen@that.guru","X-MailChannels-Auth-Id":"mxroute","X-Company-Macabre":"3bb5357f6238a475_1504168807617_1508535511","X-MC-Loop-Signature":"1504168807617:2686105479","X-MC-Ingress-Time":"1504168807617","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=that.guru;\n\ts=default;\n\th=Content-Transfer-Encoding:Mime-Version:Content-Type:References:\n\tIn-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=pNMQ4u89ikm8DyAvh/4V147NHEQb2WqtKGavH3OqoCc=;\n\tb=IE03vOv25IApGXYG+tyuZiawkZ\n\tRQckOdQOwlUbmal0LandZoRAAWA4e25DTqz9GARiTrLh5wC3p0B9SNhneC+r3UukM75SeMMqQCEDZ\n\tV2OT48cVYrNseq35T5CVcFSatgzGbTYiis6IbLAq+3gpkFdb4GpFJ4h/tMAYZWRGyy/ZVetYKkpl7\n\te7wsjGk5H29JfKzfZIkL1y9BZKzuV+JbBNLixLdOp59XCzcIsCHYO8uUOxCAEF0N8Xnhpcvmlk+8I\n\tRChCjkZ5fpiETPi6kfY6kzXzIEMCBrKBlpnFML9TntwfTD8i5w6sCQ/bAJcaSke7eIxpj/8zrWdqt\n\t91UmClJg==;","Message-ID":"<1504168803.17648.1.camel@that.guru>","Subject":"Re: [PATCH] views: Fix \"Add to bundle\" dropdown on patch list view","From":"Stephen Finucane ","To":"Andrew Donnellan , \n\tpatchwork@lists.ozlabs.org","Date":"Thu, 31 Aug 2017 09:40:03 +0100","In-Reply-To":"<20170831043124.1187-1-andrew.donnellan@au1.ibm.com>","References":"<20170831043124.1187-1-andrew.donnellan@au1.ibm.com>","X-Mailer":"Evolution 3.24.5 (3.24.5-1.fc26) ","Mime-Version":"1.0","X-AuthUser":"stephen@that.guru","X-BeenThere":"patchwork@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Patchwork development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"jk@ozlabs.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Patchwork\"\n\t"}}]