[{"id":1760648,"web_url":"http://patchwork.ozlabs.org/comment/1760648/","msgid":"","list_archive_url":null,"date":"2017-08-31T05:19:41","subject":"Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to\n\tuse the null backend when none provided","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 31.08.2017 05:53, Philippe Mathieu-Daudé wrote:\n> Suggested-by: Peter Maydell \n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> include/hw/char/serial.h | 1 +\n> hw/char/serial.c | 13 +++++++++++++\n> 2 files changed, 14 insertions(+)\n> \n> diff --git a/include/hw/char/serial.h b/include/hw/char/serial.h\n> index c4daf11a14..96bccb39e1 100644\n> --- a/include/hw/char/serial.h\n> +++ b/include/hw/char/serial.h\n> @@ -93,6 +93,7 @@ SerialState *serial_mm_init(MemoryRegion *address_space,\n> hwaddr base, int it_shift,\n> qemu_irq irq, int baudbase,\n> Chardev *chr, enum device_endian end);\n> +Chardev *serial_chr_nonnull(Chardev *chr);\n\nWhy do you need the prototype? Please make the function static if\npossible (otherwise please add some rationale in the patch description).\n\n> /* serial-isa.c */\n> #define TYPE_ISA_SERIAL \"isa-serial\"\n> diff --git a/hw/char/serial.c b/hw/char/serial.c\n> index 9aec6c60d8..7a100db107 100644\n> --- a/hw/char/serial.c\n> +++ b/hw/char/serial.c\n> @@ -1025,6 +1025,19 @@ static const MemoryRegionOps serial_mm_ops[3] = {\n> },\n> };\n> \n> +Chardev *serial_chr_nonnull(Chardev *chr)\n> +{\n> + static int serial_id;\n> + char *label;\n> +\n> + label = g_strdup_printf(\"discarding-serial%d\", serial_id++);\n> + chr = qemu_chr_new(label, \"null\");\n\nThat looks wrong - you're ignoring the input parameter and always open\nthe \"null\" device? Shouldn't there be a \"if (chr) return chr;\" in front\nof this?\n\n> + assert(chr);\n> + g_free(label);\n> +\n> + return chr;\n> +}\n\n Thomas\n\nPS: I think you should also merge the two patches together, they are\nsmall enough.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjW0j3z5Lz9s4q\n\tfor ;\n\tThu, 31 Aug 2017 15:20:18 +1000 (AEST)","from localhost ([::1]:53970 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnHtn-0001D5-8H\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 01:20:15 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39959)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnHtT-0001Cz-3t\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 01:19:55 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnHtO-00015D-MJ\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 01:19:55 -0400","from mx1.redhat.com ([209.132.183.28]:50682)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnHtO-00014k-Fg\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 01:19:50 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id AAAD15F7B5;\n\tThu, 31 Aug 2017 05:19:48 +0000 (UTC)","from [10.36.116.27] (ovpn-116-27.ams2.redhat.com [10.36.116.27])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 21F478B2B0;\n\tThu, 31 Aug 2017 05:19:42 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com AAAD15F7B5","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n\tPaolo Bonzini ,\n\tPeter Maydell , =?utf-8?q?Marc-Andr=C3=A9_L?=\n\t=?utf-8?q?ureau?= \t","References":"<20170831035306.29170-1-f4bug@amsat.org>\n\t<20170831035306.29170-2-f4bug@amsat.org>","From":"Thomas Huth ","Message-ID":"","Date":"Thu, 31 Aug 2017 07:19:41 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170831035306.29170-2-f4bug@amsat.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tThu, 31 Aug 2017 05:19:48 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to\n\tuse the null backend when none provided","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, \"Michael S. Tsirkin\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1760785,"web_url":"http://patchwork.ozlabs.org/comment/1760785/","msgid":"","list_archive_url":null,"date":"2017-08-31T09:36:39","subject":"Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to\n\tuse the null backend when none provided","submitter":{"id":6442,"url":"http://patchwork.ozlabs.org/api/people/6442/","name":"Marc-André Lureau","email":"marcandre.lureau@gmail.com"},"content":"Hi\n\nOn Thu, Aug 31, 2017 at 7:20 AM Thomas Huth wrote:\n\n> On 31.08.2017 05:53, Philippe Mathieu-Daudé wrote:\n> > Suggested-by: Peter Maydell \n> > Signed-off-by: Philippe Mathieu-Daudé \n> > ---\n> > include/hw/char/serial.h | 1 +\n> > hw/char/serial.c | 13 +++++++++++++\n> > 2 files changed, 14 insertions(+)\n> >\n> > diff --git a/include/hw/char/serial.h b/include/hw/char/serial.h\n> > index c4daf11a14..96bccb39e1 100644\n> > --- a/include/hw/char/serial.h\n> > +++ b/include/hw/char/serial.h\n> > @@ -93,6 +93,7 @@ SerialState *serial_mm_init(MemoryRegion\n> *address_space,\n> > hwaddr base, int it_shift,\n> > qemu_irq irq, int baudbase,\n> > Chardev *chr, enum device_endian end);\n> > +Chardev *serial_chr_nonnull(Chardev *chr);\n>\n> Why do you need the prototype? Please make the function static if\n> possible (otherwise please add some rationale in the patch description).\n>\n\nIt's being used from other units in following patches\n\n\n> > /* serial-isa.c */\n> > #define TYPE_ISA_SERIAL \"isa-serial\"\n> > diff --git a/hw/char/serial.c b/hw/char/serial.c\n> > index 9aec6c60d8..7a100db107 100644\n> > --- a/hw/char/serial.c\n> > +++ b/hw/char/serial.c\n> > @@ -1025,6 +1025,19 @@ static const MemoryRegionOps serial_mm_ops[3] = {\n> > },\n> > };\n> >\n> > +Chardev *serial_chr_nonnull(Chardev *chr)\n> > +{\n> > + static int serial_id;\n> > + char *label;\n> > +\n> > + label = g_strdup_printf(\"discarding-serial%d\", serial_id++);\n> > + chr = qemu_chr_new(label, \"null\");\n>\n> That looks wrong - you're ignoring the input parameter and always open\n> the \"null\" device? Shouldn't there be a \"if (chr) return chr;\" in front\n> of this?\n>\n\nI think its missing too.\n\nThe function name and usage isn't obvious. I would rather see the caller\nuse \"chr ?: serial_chr_null()\" rather than \"serial_chr_nonnull(chr)\".","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"nmW8O5O4\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjcj85QLNz9s83\n\tfor ;\n\tThu, 31 Aug 2017 19:37:16 +1000 (AEST)","from localhost ([::1]:54670 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnLuU-00014H-TK\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 05:37:14 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57092)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnLu8-00013y-13\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 05:36:53 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnLu6-0008Lq-Ue\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 05:36:52 -0400","from mail-vk0-x243.google.com ([2607:f8b0:400c:c05::243]:33927)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnLu6-0008Li-P4\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 05:36:50 -0400","by mail-vk0-x243.google.com with SMTP id x85so60099vkx.1\n\tfor ; Thu, 31 Aug 2017 02:36:50 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=o5FTMlnxdbUSyDv7cRD1u8yM0FG8nUrlb98iODjZrK8=;\n\tb=nmW8O5O4qqE0sta7+2J9SWi5qsuyavXkrpiAqrcsxXElXAeysSpc6HbVRHuIIYsxLg\n\t4pshC4dQOACcvOysqEiyYEFiLurv9ie6rTYmqU+bwium5CAiJZ6SX5vxAsh+bJCol+LE\n\tRltV3mznWUrGdiFv35fW5DtP2GEzm+3bYhMKcemY13UUA6gr7e8pHRp1wZO0fRp3ha/c\n\tASi3p4fYtC+TsWnLNs9WlpqylwzWDYpRBpdMldkdWzd8VN4WJ6O8MO1Y2QeJup0HB7id\n\tHH6iGUaW5INV6S0exDGd4XEPHjEWDlCGlUymRgK9n8pQuLRfHQ5pIuOZOdJ9VPC18TEB\n\tuQ+w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=o5FTMlnxdbUSyDv7cRD1u8yM0FG8nUrlb98iODjZrK8=;\n\tb=HcLrw8D9W4gv0Kp79fqHxK8GfJ0GAZP/yGbZsxwpFS8I3zgsO3nK+ko7jsSDK8MC71\n\t7Ww50bMjXeyXNO2NRxfhsAYc4q6j6cvDX/shNyb5ejyDdaaw3vzbp4dB4hUhucFXUah1\n\ts0oeGNQ3W9MPt+gcE+aYoZS9jDGGY+JREGpd3icnQw8a4cnFV+HOYGNm5jjaRfVNbhHy\n\tcu8v56yENE/3hBRGX4TSh8sKJjQeXW/M83CbD9y+V4szE7SYtjvnPyYrLvNAXXP8hIcO\n\tHk7Z/u3R9R/58H7n4J52eo59+TdUa5LzCYQY0NQFMXc5ffKmLQh7trETqyQmIhQ2NSI6\n\t5InQ==","X-Gm-Message-State":"AHYfb5hGz29/bYSUpuV2iZtTYyxMP4ENriZtxhR7WuJ/uZvR5T/+OGnD\n\tgHG1E1wK570rifpzoDlHslJLqcv9Ww==","X-Google-Smtp-Source":"ADKCNb47PcfLF7fbI0pYdd3i5OmXDcoJxyf0Iz5Xt18G+2EKVs9AO92tLt64Am3fStXgfZsaTX2lMEORvTmcoaxGVO4=","X-Received":"by 10.31.213.131 with SMTP id m125mr2810796vkg.50.1504172210062; \n\tThu, 31 Aug 2017 02:36:50 -0700 (PDT)","MIME-Version":"1.0","References":"<20170831035306.29170-1-f4bug@amsat.org>\n\t<20170831035306.29170-2-f4bug@amsat.org>\n\t","In-Reply-To":"","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Thu, 31 Aug 2017 09:36:39 +0000","Message-ID":"","To":"Thomas Huth , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?=\n\t, \tPaolo Bonzini , Peter Maydell\n\t","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400c:c05::243","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to\n\tuse the null backend when none provided","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, \"Michael S. Tsirkin\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1760791,"web_url":"http://patchwork.ozlabs.org/comment/1760791/","msgid":"<6847dc61-6097-33b4-b3af-5b8da52442d1@redhat.com>","list_archive_url":null,"date":"2017-08-31T09:43:32","subject":"Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to\n\tuse the null backend when none provided","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 31.08.2017 11:36, Marc-André Lureau wrote:\n> Hi\n> \n> On Thu, Aug 31, 2017 at 7:20 AM Thomas Huth > wrote:\n> \n> On 31.08.2017 05:53, Philippe Mathieu-Daudé wrote:\n> > Suggested-by: Peter Maydell >\n> > Signed-off-by: Philippe Mathieu-Daudé >\n> > ---\n> >  include/hw/char/serial.h |  1 +\n> >  hw/char/serial.c         | 13 +++++++++++++\n> >  2 files changed, 14 insertions(+)\n> >\n> > diff --git a/include/hw/char/serial.h b/include/hw/char/serial.h\n> > index c4daf11a14..96bccb39e1 100644\n> > --- a/include/hw/char/serial.h\n> > +++ b/include/hw/char/serial.h\n> > @@ -93,6 +93,7 @@ SerialState *serial_mm_init(MemoryRegion\n> *address_space,\n> >                              hwaddr base, int it_shift,\n> >                              qemu_irq irq, int baudbase,\n> >                              Chardev *chr, enum device_endian end);\n> > +Chardev *serial_chr_nonnull(Chardev *chr);\n> \n> Why do you need the prototype? Please make the function static if\n> possible (otherwise please add some rationale in the patch description).\n> \n> It's being used from other units in following patches\n\nAh, well, right. I was only on CC: in the first two patches, so I missed\nthe other ones at the first glance. So never mind my comment, the\nprototype is fine here.\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjcs23bD3z9s7c\n\tfor ;\n\tThu, 31 Aug 2017 19:44:04 +1000 (AEST)","from localhost ([::1]:54684 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnM13-0002wT-UF\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 05:44:01 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58777)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnM0l-0002wD-6s\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 05:43:44 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnM0i-0001sp-35\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 05:43:43 -0400","from mx1.redhat.com ([209.132.183.28]:46954)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnM0h-0001sM-T5\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 05:43:40 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 7E2D585542;\n\tThu, 31 Aug 2017 09:43:38 +0000 (UTC)","from [10.36.116.27] (ovpn-116-27.ams2.redhat.com [10.36.116.27])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id CFC6758859;\n\tThu, 31 Aug 2017 09:43:34 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 7E2D585542","To":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n\tPaolo Bonzini , Peter Maydell\n\t","References":"<20170831035306.29170-1-f4bug@amsat.org>\n\t<20170831035306.29170-2-f4bug@amsat.org>\n\t\n\t","From":"Thomas Huth ","Message-ID":"<6847dc61-6097-33b4-b3af-5b8da52442d1@redhat.com>","Date":"Thu, 31 Aug 2017 11:43:32 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tThu, 31 Aug 2017 09:43:38 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to\n\tuse the null backend when none provided","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, \"Michael S. Tsirkin\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1760816,"web_url":"http://patchwork.ozlabs.org/comment/1760816/","msgid":"","list_archive_url":null,"date":"2017-08-31T10:28:58","subject":"Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to\n\tuse the null backend when none provided","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 31 August 2017 at 04:53, Philippe Mathieu-Daudé wrote:\n> Suggested-by: Peter Maydell \n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> include/hw/char/serial.h | 1 +\n> hw/char/serial.c | 13 +++++++++++++\n> 2 files changed, 14 insertions(+)\n>\n> diff --git a/include/hw/char/serial.h b/include/hw/char/serial.h\n> index c4daf11a14..96bccb39e1 100644\n> --- a/include/hw/char/serial.h\n> +++ b/include/hw/char/serial.h\n> @@ -93,6 +93,7 @@ SerialState *serial_mm_init(MemoryRegion *address_space,\n> hwaddr base, int it_shift,\n> qemu_irq irq, int baudbase,\n> Chardev *chr, enum device_endian end);\n> +Chardev *serial_chr_nonnull(Chardev *chr);\n\nFor new globally-visible function declarations, can we\nhave a doc-comment form comment that documents the\nfunction, please?\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"kdbkVbN5\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjdsf2wwJz9sPt\n\tfor ;\n\tThu, 31 Aug 2017 20:29:42 +1000 (AEST)","from localhost ([::1]:54823 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnMjE-0008NU-I6\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 06:29:40 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39114)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnMiv-0008ND-4E\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 06:29:21 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnMiu-0003JX-4O\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 06:29:21 -0400","from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]:35885)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnMit-0003JO-Up\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 06:29:20 -0400","by mail-wm0-x232.google.com with SMTP id f127so1825922wmf.1\n\tfor ; Thu, 31 Aug 2017 03:29:19 -0700 (PDT)","by 10.223.134.54 with HTTP; Thu, 31 Aug 2017 03:28:58 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=OtdnONbGEKC6xX6gHTKe7rVgOfEJ00FdFTudJT/1eLE=;\n\tb=kdbkVbN5laQ7GW/HbHrazkbThTF0ZDNA2+vrLofz91yOjmyAP5B4yyAkV5+7gftLgq\n\tj3bTxPdwFDcYmAMSIZ4mcMmb9YBzKJi1iHa4YWEZarNu71i3vqKg8U0o64/66Wx/7OqC\n\t3Xr9jjAdL6mlXtCSSWBpwrdLFNcV51218EfiM=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=OtdnONbGEKC6xX6gHTKe7rVgOfEJ00FdFTudJT/1eLE=;\n\tb=LzMqe601XL9ezfe6rRdFSaOKAIiT9jD0t/aM8YM4N8tujP8/yEW+5aG8i1AWMVXxFF\n\tjcnpYFrGSi2naRZDiNo4oSx8TaokgNc5mW9fzLHTpuImq3vgJrXBpM4WBTg7Mkj5M8ob\n\tI7Vf7/LWFUoKqDRMURa9xAge7QzJuqMt5vqlu2ME8HD62LRcf28lkJYgnYuyCwkwBbcb\n\tzSJEYT7CP1Q7xa7XYfmLI4Y6JHxLH5HgAnsP6A4PIPNSgJ+tqUsEJFpJ2vQMgyAEKhtr\n\t7OoxZMuYZXw8RCp8C24gDD3xOZ/dxZLuLerxYQe4ELdJeQhF7EGLEPMFpVYLV0PxBn2S\n\t01Ig==","X-Gm-Message-State":"AHPjjUhE+5NtPLGBXBVjRw+c/0pvPetTrZGdOdwzXqhm7KZDiKbe70pw\n\tW4e+Bp9cyNEfl5t8eCA/+zY7+ksaEVmN","X-Google-Smtp-Source":"ADKCNb5aYBN3W6AO+reL3gfGv9mo3Kr5BouC34UQA1/6QaP0a03GWhKer1IuJvFxlgY5Vbhe9c2SMo9Nu0Ogzbwwr6s=","X-Received":"by 10.28.71.24 with SMTP id u24mr172292wma.95.1504175358878; Thu,\n\t31 Aug 2017 03:29:18 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170831035306.29170-2-f4bug@amsat.org>","References":"<20170831035306.29170-1-f4bug@amsat.org>\n\t<20170831035306.29170-2-f4bug@amsat.org>","From":"Peter Maydell ","Date":"Thu, 31 Aug 2017 11:28:58 +0100","Message-ID":"","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::232","Subject":"Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to\n\tuse the null backend when none provided","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Thomas Huth , \"Michael S. Tsirkin\" ,\n\tQEMU Developers , =?utf-8?q?Marc-Andr=C3=A9_Lu?=\n\t=?utf-8?q?reau?= ,\n\tPaolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1761101,"web_url":"http://patchwork.ozlabs.org/comment/1761101/","msgid":"<63de867f-2cff-10b7-f056-864fd05f1665@amsat.org>","list_archive_url":null,"date":"2017-08-31T15:17:32","subject":"Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to\n\tuse the null backend when none provided","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"On 08/31/2017 07:28 AM, Peter Maydell wrote:\n> On 31 August 2017 at 04:53, Philippe Mathieu-Daudé wrote:\n>> Suggested-by: Peter Maydell \n>> Signed-off-by: Philippe Mathieu-Daudé \n>> ---\n>> include/hw/char/serial.h | 1 +\n>> hw/char/serial.c | 13 +++++++++++++\n>> 2 files changed, 14 insertions(+)\n>>\n>> diff --git a/include/hw/char/serial.h b/include/hw/char/serial.h\n>> index c4daf11a14..96bccb39e1 100644\n>> --- a/include/hw/char/serial.h\n>> +++ b/include/hw/char/serial.h\n>> @@ -93,6 +93,7 @@ SerialState *serial_mm_init(MemoryRegion *address_space,\n>> hwaddr base, int it_shift,\n>> qemu_irq irq, int baudbase,\n>> Chardev *chr, enum device_endian end);\n>> +Chardev *serial_chr_nonnull(Chardev *chr);\n> \n> For new globally-visible function declarations, can we\n> have a doc-comment form comment that documents the\n> function, please?\n\nI was afraid someone asked that, but since this file has no other \ncomment I tried :p\n\nGood to know for future contributions, someone fluent with English \nshould add this to CODING_STYLE.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"R6byruKj\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjmGY6g9pz9s7c\n\tfor ;\n\tFri, 1 Sep 2017 01:18:11 +1000 (AEST)","from localhost ([::1]:56280 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnREP-0003rp-3z\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 11:18:09 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60746)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dnRDx-0003rW-EQ\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 11:17:46 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dnRDt-0005eQ-Fz\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 11:17:41 -0400","from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:37804)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnRDt-0005d8-B4\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 11:17:37 -0400","by mail-qt0-x244.google.com with SMTP id g13so722553qta.4\n\tfor ; Thu, 31 Aug 2017 08:17:36 -0700 (PDT)","from [192.168.1.124] ([190.177.172.146])\n\tby smtp.gmail.com with ESMTPSA id\n\tl6sm5797156qki.31.2017.08.31.08.17.32\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 31 Aug 2017 08:17:35 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=DRhlh7R7Crk/O6+gQ5SULeogSskHD0g/ppIPorcKANY=;\n\tb=R6byruKjPrsxKhE11OJYDiXYXGDZ2jqbS9FVjCUBF8rUMD3cmcMwAacI7z8JM838XB\n\twWtZVKsaH0xpGS67eq9BbZNXJTkxPQW4cDsxAWdEDuPSLl9eevnWy6kEBotzXL4IBf/c\n\tv1djcJxZ/lhHl+0tqy6xjKcRViOHw2mfhwHw3Dhn81VdVBoD1vuCTCRBfkHxjoCfyXSy\n\tJKigFcOFnwVBkBJv3EYCLgZGoxUcAtDLjoP/J3JTgF/d00q8NENmaSe6jEH7voBJZiX1\n\thr4pIApcbsJxBynmVyi4CFrxl2V8aqDqJts3apG2sIdgsg8SwoQdgnmAnlcjsIiT1scp\n\tqy6w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=DRhlh7R7Crk/O6+gQ5SULeogSskHD0g/ppIPorcKANY=;\n\tb=kK3NvivIFHZYoKzVg/5p/0YZ0ivEixgvq6w5CXdpaJSlxfHENUw5Bk4ZAA3uAx8aTo\n\t/S8rB85uiQj1gdfytIPTDVSecJZcd1jUllBcfO7V0BnGmGlKzGrtcKW3zmjPsB4oBt/f\n\tjwy6M+s6ZF5+96P6eG1ytNB8uZcnNCRSxKWzx+xGb2Y7ujGHLqKBHi4UougnHQByRt0M\n\t5LuYfEgP/Xtz6mX4qwoAXDScCVyFWSJiG7IvxU6o4MtB1OP/124No5i3ooTT7A0MOfD3\n\twAx7TS7YqpCM0S34xJ6BJMDCB2T87Dvjtc1AsVBjR/xfPkSCC2Ya43M8kIKo6uo8oEAc\n\tZP9w==","X-Gm-Message-State":"AHYfb5joaZHwMZfiKKVLYXIH2NUUTq7hUcISBPSJp0EI2h5SFO5FEmss\n\tn6ZbmXu3Fp83sg==","X-Google-Smtp-Source":"ADKCNb5Lly56Qsd+5s6rOtOjBSQB9x8JhB2AZy9nSZEasGI9KFISJf6fs9wWCn7QgEl9BberJ40Svw==","X-Received":"by 10.200.52.34 with SMTP id u31mr8586152qtb.136.1504192656130; \n\tThu, 31 Aug 2017 08:17:36 -0700 (PDT)","To":"Peter Maydell ","References":"<20170831035306.29170-1-f4bug@amsat.org>\n\t<20170831035306.29170-2-f4bug@amsat.org>\n\t","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"<63de867f-2cff-10b7-f056-864fd05f1665@amsat.org>","Date":"Thu, 31 Aug 2017 12:17:32 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c0d::244","Subject":"Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to\n\tuse the null backend when none provided","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Thomas Huth , \"Michael S. Tsirkin\" ,\n\tQEMU Developers , =?utf-8?q?Marc-Andr=C3=A9_Lu?=\n\t=?utf-8?q?reau?= ,\n\tPaolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1761105,"web_url":"http://patchwork.ozlabs.org/comment/1761105/","msgid":"<800abf63-db3f-78c7-0580-8d86479fdf5a@amsat.org>","list_archive_url":null,"date":"2017-08-31T15:20:53","subject":"Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to\n\tuse the null backend when none provided","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"On 08/31/2017 02:19 AM, Thomas Huth wrote:\n> On 31.08.2017 05:53, Philippe Mathieu-Daudé wrote:\n[...]>> +Chardev *serial_chr_nonnull(Chardev *chr)\n>> +{\n>> + static int serial_id;\n>> + char *label;\n>> +\n>> + label = g_strdup_printf(\"discarding-serial%d\", serial_id++);\n>> + chr = qemu_chr_new(label, \"null\");\n> \n> That looks wrong - you're ignoring the input parameter and always open\n> the \"null\" device? Shouldn't there be a \"if (chr) return chr;\" in front\n> of this?\n\nYou right. I had this correct in my first patch when this code was \nembedded, I then failed at extracting as another function :/\n\n> \n>> + assert(chr);\n>> + g_free(label);\n>> +\n>> + return chr;\n>> +}\n> \n> Thomas\n> \n> PS: I think you should also merge the two patches together, they are\n> small enough.\n\nOk.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"dCi51uNY\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjmLH4xj7z9s83\n\tfor ;\n\tFri, 1 Sep 2017 01:21:27 +1000 (AEST)","from localhost ([::1]:56296 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnRHZ-00067x-RA\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 11:21:25 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33427)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dnRHB-00066g-S2\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 11:21:02 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dnRH7-0006zK-UE\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 11:21:01 -0400","from mail-qk0-x233.google.com ([2607:f8b0:400d:c09::233]:33080)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnRH7-0006zE-PU\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 11:20:57 -0400","by mail-qk0-x233.google.com with SMTP id l65so4233573qkc.0\n\tfor ; Thu, 31 Aug 2017 08:20:57 -0700 (PDT)","from [192.168.1.124] ([190.177.172.146])\n\tby smtp.gmail.com with ESMTPSA id\n\tu22sm5674531qth.44.2017.08.31.08.20.53\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 31 Aug 2017 08:20:56 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=TtKox9XUDDD5QJTFMHg5ZvY0IgIdn/f/C8P4qkksnMg=;\n\tb=dCi51uNYt+ljZiSdao2L4SRHF5zkuJVrPxUK6Epo9F7bL3Z/R3z2VsTRVUwrAV7m7z\n\taomXRQDEbQyHhGNHLSVc2qCn8FcGoZUdNhpt570UoiqH06V6c+COGZ9lVjleUJ0zqi6F\n\t5WgwAeUO0h6rj6AuZ3adzzXzmL1Qr5mGiwudk9AtqpiBKi+N+6KncANOk42mCxuoKt3a\n\twWPHcQjj2ck9ZAcezc00EhPSugNZ09yMO1YKl26toJED/8Erm1tPQc7kaeAjv0yy4Boo\n\tagzHo8iI+dd5nZnLVvm3vfbZch3z9lu4ERzJpcK6PG4XRHyM4uwkUGHjwXLZmJ+hHqNW\n\tSQdg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=TtKox9XUDDD5QJTFMHg5ZvY0IgIdn/f/C8P4qkksnMg=;\n\tb=ORBTFeMOE+Qsk4Pr7pHjNGPbZFJbJqmi30A2W3fFGX49juBaQC2LYgGS79T7sdMAEy\n\tM8L6IyxtI7DjsjwFbjIs8pPyBGbNrBFyLbucKhHW7RlTfYBBd8K7u+ZSTN4exvFqakwb\n\tTHgL1z8Mg2AapE679x+s4Dz5uKkMFuQgZPfGQcUq83X4IccZn+nFaGFWCbPHjoBptF6g\n\tf/vMDytaBQTTO+er3cDzcLR8m66HovvcbVP5XPl6ISd4dFcYI/UhaDAYnyLxB9HLI3AH\n\tBLqc8z60vMgvoGG8q57vBkeTIXc27ZRRUqVDieSzZHszAGnIOT1SsLz5sktO3xMOEHNN\n\trk3Q==","X-Gm-Message-State":"AHYfb5gol2KOQON/1MK6e6kuDVaLNTkeRVGSWosIQvOfhc5WpYl7VOF3\n\tydz6RPGW54atlQ==","X-Google-Smtp-Source":"ADKCNb7X19xtkQvi6zJaaLrucGBMJHIeVk9J0+MTKOVArPB0KNXxQfYc6610lrdlCjujnj4KH7u/JA==","X-Received":"by 10.55.154.149 with SMTP id c143mr4489307qke.346.1504192857186;\n\tThu, 31 Aug 2017 08:20:57 -0700 (PDT)","To":"Thomas Huth , Paolo Bonzini ,\n\tPeter Maydell , =?utf-8?q?Marc-Andr=C3=A9_L?=\n\t=?utf-8?q?ureau?= ","References":"<20170831035306.29170-1-f4bug@amsat.org>\n\t<20170831035306.29170-2-f4bug@amsat.org>\n\t","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"<800abf63-db3f-78c7-0580-8d86479fdf5a@amsat.org>","Date":"Thu, 31 Aug 2017 12:20:53 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c09::233","Subject":"Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to\n\tuse the null backend when none provided","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, \"Michael S. Tsirkin\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1761112,"web_url":"http://patchwork.ozlabs.org/comment/1761112/","msgid":"<5c9b4445-4870-a99f-058b-6de82959b302@redhat.com>","list_archive_url":null,"date":"2017-08-31T15:23:55","subject":"Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to\n\tuse the null backend when none provided","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 31.08.2017 17:20, Philippe Mathieu-Daudé wrote:\n> On 08/31/2017 02:19 AM, Thomas Huth wrote:\n>> On 31.08.2017 05:53, Philippe Mathieu-Daudé wrote:\n> [...]>> +Chardev *serial_chr_nonnull(Chardev *chr)\n>>> +{\n>>> +    static int serial_id;\n>>> +    char *label;\n>>> +\n>>> +    label = g_strdup_printf(\"discarding-serial%d\", serial_id++);\n>>> +    chr = qemu_chr_new(label, \"null\");\n>>\n>> That looks wrong - you're ignoring the input parameter and always open\n>> the \"null\" device? Shouldn't there be a \"if (chr) return chr;\" in front\n>> of this?\n> \n> You right. I had this correct in my first patch when this code was\n> embedded, I then failed at extracting as another function :/\n> \n>>\n>>> +    assert(chr);\n>>> +    g_free(label);\n>>> +\n>>> +    return chr;\n>>> +}\n>>\n>>   Thomas\n>>\n>> PS: I think you should also merge the two patches together, they are\n>> small enough.\n> \n> Ok.\n\nWell, I wrote that comment about merging the two patches together when I\nwas thinking that your series consists of only two patches (since I've\nonly been CC:-ed on the first two patches). So please simply ignore that\nsuggestion :-)\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjmQ64LyRz9s83\n\tfor ;\n\tFri, 1 Sep 2017 01:24:46 +1000 (AEST)","from localhost ([::1]:56307 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnRKm-0007jW-LR\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 11:24:44 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34489)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnRKH-0007i5-6t\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 11:24:14 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnRKD-0007zk-8Y\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 11:24:13 -0400","from mx1.redhat.com ([209.132.183.28]:45290)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnRKD-0007zE-1S\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 11:24:09 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id EB4C35F7AD;\n\tThu, 31 Aug 2017 15:24:07 +0000 (UTC)","from [10.36.116.27] (ovpn-116-27.ams2.redhat.com [10.36.116.27])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id CDB2592D12;\n\tThu, 31 Aug 2017 15:23:56 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com EB4C35F7AD","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n\tPaolo Bonzini ,\n\tPeter Maydell , =?utf-8?q?Marc-Andr=C3=A9_L?=\n\t=?utf-8?q?ureau?= \t","References":"<20170831035306.29170-1-f4bug@amsat.org>\n\t<20170831035306.29170-2-f4bug@amsat.org>\n\t\n\t<800abf63-db3f-78c7-0580-8d86479fdf5a@amsat.org>","From":"Thomas Huth ","Message-ID":"<5c9b4445-4870-a99f-058b-6de82959b302@redhat.com>","Date":"Thu, 31 Aug 2017 17:23:55 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<800abf63-db3f-78c7-0580-8d86479fdf5a@amsat.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tThu, 31 Aug 2017 15:24:08 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to\n\tuse the null backend when none provided","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, \"Michael S. Tsirkin\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1761113,"web_url":"http://patchwork.ozlabs.org/comment/1761113/","msgid":"","list_archive_url":null,"date":"2017-08-31T15:24:01","subject":"Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to\n\tuse the null backend when none provided","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"On 08/31/2017 06:43 AM, Thomas Huth wrote:\n> On 31.08.2017 11:36, Marc-André Lureau wrote:\n>> Hi\n>>\n>> On Thu, Aug 31, 2017 at 7:20 AM Thomas Huth > > wrote:\n>>\n>> On 31.08.2017 05:53, Philippe Mathieu-Daudé wrote:\n>> > Suggested-by: Peter Maydell > >\n>> > Signed-off-by: Philippe Mathieu-Daudé > >\n>> > ---\n>> >  include/hw/char/serial.h |  1 +\n>> >  hw/char/serial.c         | 13 +++++++++++++\n>> >  2 files changed, 14 insertions(+)\n>> >\n>> > diff --git a/include/hw/char/serial.h b/include/hw/char/serial.h\n>> > index c4daf11a14..96bccb39e1 100644\n>> > --- a/include/hw/char/serial.h\n>> > +++ b/include/hw/char/serial.h\n>> > @@ -93,6 +93,7 @@ SerialState *serial_mm_init(MemoryRegion\n>> *address_space,\n>> >                              hwaddr base, int it_shift,\n>> >                              qemu_irq irq, int baudbase,\n>> >                              Chardev *chr, enum device_endian end);\n>> > +Chardev *serial_chr_nonnull(Chardev *chr);\n>>\n>> Why do you need the prototype? Please make the function static if\n>> possible (otherwise please add some rationale in the patch description).\n>>\n>> It's being used from other units in following patches\n> \n> Ah, well, right. I was only on CC: in the first two patches, so I missed\n> the other ones at the first glance. So never mind my comment, the\n> prototype is fine here.\n\nIs it better/easier to use the same list for the cover and all the patches?\nI try to shorten the it to help overloaded reviewer to focus on the \npatches I think they can help. But this case show it's not that useful.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"DGThrCQA\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjmQV25cmz9s83\n\tfor ;\n\tFri, 1 Sep 2017 01:25:06 +1000 (AEST)","from localhost ([::1]:56309 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnRL6-0007vv-CZ\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 11:25:04 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34453)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dnRKD-0007f5-7c\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 11:24:10 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dnRK9-0007y5-9c\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 11:24:09 -0400","from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:36781)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnRK9-0007xx-4T\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 11:24:05 -0400","by mail-qk0-x244.google.com with SMTP id l65so734272qkc.3\n\tfor ; Thu, 31 Aug 2017 08:24:05 -0700 (PDT)","from [192.168.1.124] ([190.177.172.146])\n\tby smtp.gmail.com with ESMTPSA id\n\ta63sm5663540qkb.45.2017.08.31.08.24.01\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 31 Aug 2017 08:24:03 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=CZzsBNxhMOaOw+FqOVht/w2C8GtfrJziAT7cXVDyO/w=;\n\tb=DGThrCQAuV1BfTXKCJJ9kFqzAOjYnDMqUT2l1/olCnSXZR/qgGIHO7wHrJRgauNBO0\n\twhpLUNpD0YnNn03+Jj1S2nEK6ocAnd1LVcCVS9W4mxii39UaBEY1RQEwiXf+SBJRG7gc\n\tz96CmJfmtkCQilzMQTTVbSvZ/tVJ6F1ZsXm3bGDy59+/iYxm5uxh+bq7PTmj5hnC0gv/\n\t1CneMiMFAN1SCHY/pNjQVdyPgnZeqKO2Taw35q8GtD5FlfVePxBK/ZgO0yySU4VOyfLa\n\t2iYE8kNaxsm4WEsBzOpuFymKhae6jp3uitJbiRvp2WtPULaG0S3BUabgEIE7rQEFbLGa\n\tIPgA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=CZzsBNxhMOaOw+FqOVht/w2C8GtfrJziAT7cXVDyO/w=;\n\tb=L+D1Qn4QjtboeviCy3g6XT8h7BvNe07tM/pVzWfFwcQqomQ2wMqH1CiJapDCdig4I+\n\t9QNz8cQATAXgouf+kNjWFIKbU6+28p9RxGcKiG+NEgttt93aBoWHb05PZx6zhmUByXVL\n\tHSoLoBtlvpw0YieuAzcFmzSFuFcqqT4P0lKHbD0o2G1K6L75HlY60+2OGqgsNRQcecHp\n\tp0+Mnhgv0maA9CImlBre15cN34uVPgn3MBsOydGnx4NmtsMYDuJJkZ7ZgGogxgranVl9\n\t3MT2r6tLHw6rRunrDz+/CBoNGGyaVrGefa1ofHLnc19y7aHcBroQaDHllCXlB3pF2TKc\n\to32A==","X-Gm-Message-State":"AHPjjUg5z+mI2IqM77V/iqXTUe9JQoJNn3WauYPZU+FUGmAn4MRypreT\n\tC8v5lipfmvQaiA==","X-Google-Smtp-Source":"ADKCNb4FO5zKmPVjMPL8Hhz80HmjIQiQrBpnVS/VP1yNKt1eQPalC0kQ2INMNFwauPRzwqqPycPOsA==","X-Received":"by 10.55.20.204 with SMTP id 73mr3608895qku.11.1504193044575;\n\tThu, 31 Aug 2017 08:24:04 -0700 (PDT)","To":"Thomas Huth , =?utf-8?q?Marc-Andr=C3=A9_Lureau?=\n\t, \tPaolo Bonzini ,\n\tPeter Maydell ","References":"<20170831035306.29170-1-f4bug@amsat.org>\n\t<20170831035306.29170-2-f4bug@amsat.org>\n\t\n\t\n\t<6847dc61-6097-33b4-b3af-5b8da52442d1@redhat.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"","Date":"Thu, 31 Aug 2017 12:24:01 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<6847dc61-6097-33b4-b3af-5b8da52442d1@redhat.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c09::244","Subject":"Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to\n\tuse the null backend when none provided","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, \"Michael S. Tsirkin\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1761533,"web_url":"http://patchwork.ozlabs.org/comment/1761533/","msgid":"<87k21idbq6.fsf@dusky.pond.sub.org>","list_archive_url":null,"date":"2017-09-01T09:12:01","subject":"Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to\n\tuse the null backend when none provided","submitter":{"id":2645,"url":"http://patchwork.ozlabs.org/api/people/2645/","name":"Markus Armbruster","email":"armbru@redhat.com"},"content":"Philippe Mathieu-Daudé writes:\n\n> On 08/31/2017 06:43 AM, Thomas Huth wrote:\n>> On 31.08.2017 11:36, Marc-André Lureau wrote:\n>>> Hi\n>>>\n>>> On Thu, Aug 31, 2017 at 7:20 AM Thomas Huth >> > wrote:\n>>>\n>>> On 31.08.2017 05:53, Philippe Mathieu-Daudé wrote:\n>>> > Suggested-by: Peter Maydell >> >\n>>> > Signed-off-by: Philippe Mathieu-Daudé >> >\n>>> > ---\n>>> >  include/hw/char/serial.h |  1 +\n>>> >  hw/char/serial.c         | 13 +++++++++++++\n>>> >  2 files changed, 14 insertions(+)\n>>> >\n>>> > diff --git a/include/hw/char/serial.h b/include/hw/char/serial.h\n>>> > index c4daf11a14..96bccb39e1 100644\n>>> > --- a/include/hw/char/serial.h\n>>> > +++ b/include/hw/char/serial.h\n>>> > @@ -93,6 +93,7 @@ SerialState *serial_mm_init(MemoryRegion\n>>> *address_space,\n>>> >                              hwaddr base, int it_shift,\n>>> >                              qemu_irq irq, int baudbase,\n>>> >                              Chardev *chr, enum device_endian end);\n>>> > +Chardev *serial_chr_nonnull(Chardev *chr);\n>>>\n>>> Why do you need the prototype? Please make the function static if\n>>> possible (otherwise please add some rationale in the patch description).\n>>>\n>>> It's being used from other units in following patches\n>>\n>> Ah, well, right. I was only on CC: in the first two patches, so I missed\n>> the other ones at the first glance. So never mind my comment, the\n>> prototype is fine here.\n>\n> Is it better/easier to use the same list for the cover and all the patches?\n> I try to shorten the it to help overloaded reviewer to focus on the\n> patches I think they can help. But this case show it's not that\n> useful.\n\nClear an unequivocal answer: it depends :)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=armbru@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkD6M66q4z9t32\n\tfor ;\n\tFri, 1 Sep 2017 19:12:42 +1000 (AEST)","from localhost ([::1]:59806 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dni0F-0000Gw-LL\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 05:12:39 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56455)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnhzm-0000Cb-Kj\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 05:12:15 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnhzi-0005df-8G\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 05:12:10 -0400","from mx1.redhat.com ([209.132.183.28]:46884)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnhzh-0005dT-WB\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 05:12:06 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1FC0513A5C;\n\tFri, 1 Sep 2017 09:12:05 +0000 (UTC)","from blackfin.pond.sub.org (ovpn-116-75.ams2.redhat.com\n\t[10.36.116.75])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 0CCA8779D6;\n\tFri, 1 Sep 2017 09:12:03 +0000 (UTC)","by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid C92641138662; Fri, 1 Sep 2017 11:12:01 +0200 (CEST)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 1FC0513A5C","From":"Markus Armbruster ","To":"Philippe =?utf-8?q?Mathieu-Daud=C3=A9?= ","References":"<20170831035306.29170-1-f4bug@amsat.org>\n\t<20170831035306.29170-2-f4bug@amsat.org>\n\t\n\t\n\t<6847dc61-6097-33b4-b3af-5b8da52442d1@redhat.com>\n\t","Date":"Fri, 01 Sep 2017 11:12:01 +0200","In-Reply-To":" (\"Philippe\n\t=?utf-8?b?TWF0aGlldS1EYXVkw6kiJ3M=?= message of \"Thu,\n\t31 Aug 2017 12:24:01 -0300\")","Message-ID":"<87k21idbq6.fsf@dusky.pond.sub.org>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tFri, 01 Sep 2017 09:12:05 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to\n\tuse the null backend when none provided","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , Thomas Huth ,\n\t\"Michael S. Tsirkin\" , qemu-devel@nongnu.org,\n\t=?utf-8?q?Marc-Andr=C3=A9?= Lureau ,\n\tPaolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]