[{"id":1760625,"web_url":"http://patchwork.ozlabs.org/comment/1760625/","msgid":"<6D0042A3-C029-4CAC-86B1-F570E541D8C0@gmail.com>","list_archive_url":null,"date":"2017-08-31T03:59:55","subject":"Re: [PATCH net-next] net/ncsi: Define {add,\n\tkill}_vid callbacks for !CONFIG_NET_NCSI","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On August 30, 2017 8:38:46 PM PDT, Samuel Mendoza-Jonas wrote:\n>Patch \"net/ncsi: Configure VLAN tag filter\" defined two new callback\n>functions in include/net/ncsi.h, but neglected the !CONFIG_NET_NCSI\n>case. This can cause a build error if these are referenced elsewhere\n>without NCSI enabled, for example in ftgmac100:\n>\n>>>> ERROR: \"ncsi_vlan_rx_kill_vid\"\n>[drivers/net/ethernet/faraday/ftgmac100.ko] undefined!\n>>>> ERROR: \"ncsi_vlan_rx_add_vid\"\n>[drivers/net/ethernet/faraday/ftgmac100.ko] undefined!\n>\n>Add definitions for !CONFIG_NET_NCSI to bring it into line with the\n>rest\n>of ncsi.h\n>\n>Signed-off-by: Samuel Mendoza-Jonas \n>---\n> include/net/ncsi.h | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n>\n>diff --git a/include/net/ncsi.h b/include/net/ncsi.h\n>index 1f96af46df49..2b13b6b91a4d 100644\n>--- a/include/net/ncsi.h\n>+++ b/include/net/ncsi.h\n>@@ -36,6 +36,14 @@ int ncsi_start_dev(struct ncsi_dev *nd);\n> void ncsi_stop_dev(struct ncsi_dev *nd);\n> void ncsi_unregister_dev(struct ncsi_dev *nd);\n> #else /* !CONFIG_NET_NCSI */\n>+int ncsi_vlan_rx_add_vid(struct net_device *dev, __be16 proto, u16\n>vid)\n>+{\n>+\treturn -ENOTTY;\n\nReturning -EOPNOTSUPP would probably be more correct here.\n\n>+}\n>+int ncsi_vlan_rx_kill_vid(struct net_device *dev, __be16 proto, u16\n>vid)\n>+{\n>+\treturn -ENOTTY;\n\nLikewise.\n\n>+}\n>static inline struct ncsi_dev *ncsi_register_dev(struct net_device\n>*dev,\n> \t\t\t\t\tvoid (*notifier)(struct ncsi_dev *nd))\n> {","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"fTSxr493\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjTDH6kDQz9sNc\n\tfor ;\n\tThu, 31 Aug 2017 14:00:15 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750781AbdHaEAC (ORCPT );\n\tThu, 31 Aug 2017 00:00:02 -0400","from mail-oi0-f67.google.com ([209.85.218.67]:34691 \"EHLO\n\tmail-oi0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751001AbdHaEAA (ORCPT\n\t); Thu, 31 Aug 2017 00:00:00 -0400","by mail-oi0-f67.google.com with SMTP id w10so7260462oie.1;\n\tWed, 30 Aug 2017 21:00:00 -0700 (PDT)","from ?IPv6:2001:470:d:73f:10ca:f176:623b:9249?\n\t([2001:470:d:73f:10ca:f176:623b:9249])\n\tby smtp.gmail.com with ESMTPSA id\n\tm3sm7833903oif.17.2017.08.30.20.59.58\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 30 Aug 2017 20:59:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:subject:to:cc:from:message-id;\n\tbh=uaxoGPM+1BmnC9oJLP/82CLGBze5aO0tiLEphLVN4xE=;\n\tb=fTSxr493wzaR2jSfl+lnCpwsmkUsfScm//HrVl9rmQyZWeTbdvvOAk84g2wkpe1jyH\n\tDfSeKuKajJg2WmGc0npQLkkgNU2FuYnkVc6OlYYP5qwee7Boqt9ON+XHwSR/YftAIm7Z\n\tp0BJ3xXpmHg1B2txvl4XDbf8BX7JqUekm8z8Qv32f3J3FUQFbriV/vovCEILIZk+A0Cp\n\tcfDm7CojZzz2KD33E+iaTy2Mau7jGIKPb69J51TPHUH/AAcbtz21PpxVQFUMZ/08FoyS\n\t/o8aUqc3jYR95TlfEhtUNuYiTNW+d33+TNQO7brpi4msrWYsmuyB6N+ybFWinHhdT6yr\n\tqMjw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:user-agent:in-reply-to:references\n\t:mime-version:content-transfer-encoding:subject:to:cc:from\n\t:message-id;\n\tbh=uaxoGPM+1BmnC9oJLP/82CLGBze5aO0tiLEphLVN4xE=;\n\tb=Vcmh/KRHRb/otl2qfsWavdh/q2a4pmKBZIcAtnV2izuKtjCYPyqF72slKcf1CEbMWI\n\tK2qham1asVx+Cau3AfkbBViTJvgqura0Vr1etqKxTS11Xrr7Uskz6aQ2mpmrsl9OGwER\n\tWsIK8tBCXsItKWrGlMLCtkggKvMjlJgSbvcbpYGUcTaipHz7boDwJq9CKteCSU7qZ7xD\n\tmWPg0tna47mn85YKadg+gGDLDmxpjNowjM7f+L5AoF7V0yqdhVqt6vRbOxmOHHxlENDr\n\tEcIYiIW/hwA22iwqcCVxyqfp0D/tgpFg9GKbYGVYQTqEjv1tcy6LwaWzUUchTWl6nk+V\n\txbHA==","X-Gm-Message-State":"AHYfb5jHM8qErQHImDZpqmI3cbJx88jNK7yBxBm0kwF1gfyEMXVtfY7n\n\tO5FMLXzPMPQSRZuQuEU=","X-Received":"by 10.202.4.6 with SMTP id 6mr3425822oie.114.1504152000245;\n\tWed, 30 Aug 2017 21:00:00 -0700 (PDT)","Date":"Wed, 30 Aug 2017 20:59:55 -0700","User-Agent":"K-9 Mail for Android","In-Reply-To":"<20170831033846.23538-1-sam@mendozajonas.com>","References":"<20170831033846.23538-1-sam@mendozajonas.com>","MIME-Version":"1.0","Content-Type":"text/plain;\n charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [PATCH net-next] net/ncsi: Define {add,\n\tkill}_vid callbacks for !CONFIG_NET_NCSI","To":"Samuel Mendoza-Jonas ,\n\t\"David S . Miller\" , netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, OpenBMC Maillist ","CC":"Joel Stanley ,\n\tBenjamin Herrenschmidt ,\n\tGavin Shan ","From":"Florian Fainelli ","Message-ID":"<6D0042A3-C029-4CAC-86B1-F570E541D8C0@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1761111,"web_url":"http://patchwork.ozlabs.org/comment/1761111/","msgid":"<20170831152414.GB69617@mauery>","list_archive_url":null,"date":"2017-08-31T15:24:14","subject":"Re: [PATCH net-next] net/ncsi: Define {add, kill}_vid callbacks for\n\t!CONFIG_NET_NCSI","submitter":{"id":72266,"url":"http://patchwork.ozlabs.org/api/people/72266/","name":"Vernon Mauery","email":"vernon.mauery@linux.intel.com"},"content":"On 31-Aug-2017 01:38 PM, Samuel Mendoza-Jonas wrote:\n> Patch \"net/ncsi: Configure VLAN tag filter\" defined two new callback\n> functions in include/net/ncsi.h, but neglected the !CONFIG_NET_NCSI\n> case. This can cause a build error if these are referenced elsewhere\n> without NCSI enabled, for example in ftgmac100:\n> \n> >>> ERROR: \"ncsi_vlan_rx_kill_vid\" [drivers/net/ethernet/faraday/ftgmac100.ko] undefined!\n> >>> ERROR: \"ncsi_vlan_rx_add_vid\" [drivers/net/ethernet/faraday/ftgmac100.ko] undefined!\n> \n> Add definitions for !CONFIG_NET_NCSI to bring it into line with the rest\n> of ncsi.h\n> \n> Signed-off-by: Samuel Mendoza-Jonas \n> ---\n> include/net/ncsi.h | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n> \n> diff --git a/include/net/ncsi.h b/include/net/ncsi.h\n> index 1f96af46df49..2b13b6b91a4d 100644\n> --- a/include/net/ncsi.h\n> +++ b/include/net/ncsi.h\n> @@ -36,6 +36,14 @@ int ncsi_start_dev(struct ncsi_dev *nd);\n> void ncsi_stop_dev(struct ncsi_dev *nd);\n> void ncsi_unregister_dev(struct ncsi_dev *nd);\n> #else /* !CONFIG_NET_NCSI */\n> +int ncsi_vlan_rx_add_vid(struct net_device *dev, __be16 proto, u16 vid)\n> +{\n> +\treturn -ENOTTY;\n> +}\n> +int ncsi_vlan_rx_kill_vid(struct net_device *dev, __be16 proto, u16 vid)\n> +{\n> +\treturn -ENOTTY;\n> +}\n\nThese should be static functions because they are defined in the header \nfile or you will get multiple symbol definitions.\n\n--Vernon\n\n> static inline struct ncsi_dev *ncsi_register_dev(struct net_device *dev,\n> \t\t\t\t\tvoid (*notifier)(struct ncsi_dev *nd))\n> {\n> -- \n> 2.14.1\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjmPn3Qt9z9s2G\n\tfor ;\n\tFri, 1 Sep 2017 01:24:29 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751550AbdHaPYQ (ORCPT );\n\tThu, 31 Aug 2017 11:24:16 -0400","from mga06.intel.com ([134.134.136.31]:57165 \"EHLO mga06.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751276AbdHaPYP (ORCPT );\n\tThu, 31 Aug 2017 11:24:15 -0400","from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga104.jf.intel.com with ESMTP; 31 Aug 2017 08:24:14 -0700","from mauery.jf.intel.com (HELO mauery) ([10.7.150.85])\n\tby orsmga003.jf.intel.com with ESMTP; 31 Aug 2017 08:24:14 -0700"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.41,453,1498546800\"; d=\"scan'208\";a=\"1009689937\"","Date":"Thu, 31 Aug 2017 08:24:14 -0700","From":"Vernon Mauery ","To":"Samuel Mendoza-Jonas ","Cc":"\"David S . Miller\" , netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tOpenBMC Maillist ,\n\tGavin Shan ","Subject":"Re: [PATCH net-next] net/ncsi: Define {add, kill}_vid callbacks for\n\t!CONFIG_NET_NCSI","Message-ID":"<20170831152414.GB69617@mauery>","References":"<20170831033846.23538-1-sam@mendozajonas.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170831033846.23538-1-sam@mendozajonas.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1761335,"web_url":"http://patchwork.ozlabs.org/comment/1761335/","msgid":"<1504214050.4974.52.camel@kernel.crashing.org>","list_archive_url":null,"date":"2017-08-31T21:14:10","subject":"Re: [PATCH net-next] net/ncsi: Define {add, kill}_vid callbacks for\n\t!CONFIG_NET_NCSI","submitter":{"id":38,"url":"http://patchwork.ozlabs.org/api/people/38/","name":"Benjamin Herrenschmidt","email":"benh@kernel.crashing.org"},"content":"On Thu, 2017-08-31 at 08:24 -0700, Vernon Mauery wrote:\n> +int ncsi_vlan_rx_add_vid(struct net_device *dev, __be16 proto, u16 vid)\n> > +{\n> > + return -ENOTTY;\n> > +}\n> > +int ncsi_vlan_rx_kill_vid(struct net_device *dev, __be16 proto, u16 vid)\n> > +{\n> > + return -ENOTTY;\n> > +}\n> \n> These should be static functions because they are defined in the header \n> file or you will get multiple symbol definitions.\n\nstatic inline even or you'll get warning about them being unused iirc.\n\nCheers,\nBen.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjwk80frnz9s81\n\tfor ;\n\tFri, 1 Sep 2017 07:39:12 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751803AbdHaVjB (ORCPT );\n\tThu, 31 Aug 2017 17:39:01 -0400","from gate.crashing.org ([63.228.1.57]:41394 \"EHLO\n\tgate.crashing.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751355AbdHaVi7 (ORCPT );\n\tThu, 31 Aug 2017 17:38:59 -0400","from localhost (localhost.localdomain [127.0.0.1])\n\tby gate.crashing.org (8.14.1/8.13.8) with ESMTP id v7VLEA48029281;\n\tThu, 31 Aug 2017 16:14:18 -0500"],"Message-ID":"<1504214050.4974.52.camel@kernel.crashing.org>","Subject":"Re: [PATCH net-next] net/ncsi: Define {add, kill}_vid callbacks for\n\t!CONFIG_NET_NCSI","From":"Benjamin Herrenschmidt ","To":"Vernon Mauery ,\n\tSamuel Mendoza-Jonas ","Cc":"\"David S . Miller\" , netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tOpenBMC Maillist ,\n\tGavin Shan ","Date":"Fri, 01 Sep 2017 07:14:10 +1000","In-Reply-To":"<20170831152414.GB69617@mauery>","References":"<20170831033846.23538-1-sam@mendozajonas.com>\n\t<20170831152414.GB69617@mauery>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.24.5 (3.24.5-1.fc26) ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]