[{"id":1760565,"web_url":"http://patchwork.ozlabs.org/comment/1760565/","msgid":"<BY2PR0501MB21191DA8399901503FB8DAB9A29C0@BY2PR0501MB2119.namprd05.prod.outlook.com>","list_archive_url":null,"date":"2017-08-30T23:11:55","subject":"Re: [ovs-dev] [PATCH] datapath-windows: Remove unnecessary call\n\tto\tOvsInitForwardingCtx","submitter":{"id":69910,"url":"http://patchwork.ozlabs.org/api/people/69910/","name":"Shashank Ram","email":"rams@vmware.com"},"content":"Subject: [ovs-dev] [PATCH] datapath-windows: Remove unnecessary call to OvsInitForwardingCtx\n\nOnly curNbl in the forwarding context needs to be updated with\nfragmented NBL.\n\nSigned-off-by: Anand Kumar <kumaranand@vmware.com>","headers":{"Return-Path":"<ovs-dev-bounces@openvswitch.org>","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"JFuBPd07\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=rams@vmware.com; "],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjLql4mCDz9s7M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 09:12:03 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 42E9BAF0;\n\tWed, 30 Aug 2017 23:12:00 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id BC4CF8A5\n\tfor <dev@openvswitch.org>; Wed, 30 Aug 2017 23:11:58 +0000 (UTC)","from NAM01-SN1-obe.outbound.protection.outlook.com\n\t(mail-sn1nam01on0058.outbound.protection.outlook.com [104.47.32.58])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 27EE51D7\n\tfor <dev@openvswitch.org>; Wed, 30 Aug 2017 23:11:58 +0000 (UTC)","from BY2PR0501MB2119.namprd05.prod.outlook.com (10.163.198.17) by\n\tBY2PR0501MB1734.namprd05.prod.outlook.com (10.163.154.20) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.13.2; Wed, 30 Aug 2017 23:11:56 +0000","from BY2PR0501MB2119.namprd05.prod.outlook.com ([10.163.198.17]) by\n\tBY2PR0501MB2119.namprd05.prod.outlook.com ([10.163.198.17]) with\n\tmapi id 15.20.0013.011; Wed, 30 Aug 2017 23:11:55 +0000"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=onevmw.onmicrosoft.com; s=selector1-vmware-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=6o4XiLPod4wtas8u6N3G/aVEXhTKnBXQsD8z25jIohI=;\n\tb=JFuBPd07HRxdS/ryHCGe8ZWS9XwECJwH9SV9zQkG15kdQTad3SiidIg4s4JzywkupZoZAteZXgJ6vl4Hv0Tnm+65KV2oi7vGyFlImHpRAqiGOU2EupBKwsSypIOIBfgDvvCvVLxmPDGjsG0VCYAkDdakg5wX96XEx4u+OHmjMlk=","From":"Shashank Ram <rams@vmware.com>","To":"Anand Kumar <kumaranand@vmware.com>, \"dev@openvswitch.org\"\n\t<dev@openvswitch.org>","Thread-Topic":"[ovs-dev] [PATCH] datapath-windows: Remove unnecessary call to\n\tOvsInitForwardingCtx","Thread-Index":"AQHTIeRXD99qa9vw3kyFOdfa1a/IJaKdhqff","Date":"Wed, 30 Aug 2017 23:11:55 +0000","Message-ID":"<BY2PR0501MB21191DA8399901503FB8DAB9A29C0@BY2PR0501MB2119.namprd05.prod.outlook.com>","References":"<20170830230357.5440-1-kumaranand@vmware.com>","In-Reply-To":"<20170830230357.5440-1-kumaranand@vmware.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"JFuBPd07\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=rams@vmware.com; "],"x-originating-ip":"[208.91.1.34]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; BY2PR0501MB1734;\n\t20:6g4caM5kQGbBrH/Hae+4Z8NYl/DMFl9wIbFTLCNAi3M8sNJKo7q4GsxvV09ApFifefPmFikNs16mIBFzWNDA7KIaB+Pauq7DXG1j3Lz7vDNJmUyDG6EB5zGZe3XO0sPRA3SaNhH41Ui3u4qWNZY20EQoHXHWRg89TBTeDqoN2LM=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;SSOR;","x-forefront-antispam-report":"SFV:SKI; SCL:-1; SFV:NSPM;\n\tSFS:(10009020)(6009001)(39860400002)(199003)(189002)(77096006)(558084003)(97736004)(189998001)(33656002)(105586002)(6506006)(2900100001)(478600001)(6436002)(50986999)(2501003)(101416001)(25786009)(54356999)(76176999)(53936002)(106356001)(74316002)(81156014)(5660300001)(8936002)(81166006)(7696004)(229853002)(305945005)(2950100002)(7736002)(6116002)(3846002)(102836003)(2906002)(3660700001)(3280700002)(86362001)(66066001)(99286003)(68736007)(55016002)(9686003)(6246003)(14454004);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0501MB1734;\n\tH:BY2PR0501MB2119.namprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","x-ms-office365-filtering-correlation-id":"f7e975ff-2116-4f83-d7c2-08d4effc8214","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:BY2PR0501MB1734; ","x-ms-traffictypediagnostic":"BY2PR0501MB1734:","x-exchange-antispam-report-test":"UriScan:(61668805478150);","x-microsoft-antispam-prvs":"<BY2PR0501MB17343758C4DA4970E7CEE1A6A29C0@BY2PR0501MB1734.namprd05.prod.outlook.com>","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:BY2PR0501MB1734; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:BY2PR0501MB1734; ","x-forefront-prvs":"041517DFAB","received-spf":"None (protection.outlook.com: vmware.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","MIME-Version":"1.0","X-OriginatorOrg":"vmware.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"30 Aug 2017 23:11:55.7721\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"BY2PR0501MB1734","X-Spam-Status":"No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH] datapath-windows: Remove unnecessary call\n\tto\tOvsInitForwardingCtx","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"<ovs-dev.openvswitch.org>","List-Unsubscribe":"<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>","List-Archive":"<http://mail.openvswitch.org/pipermail/ovs-dev/>","List-Post":"<mailto:ovs-dev@openvswitch.org>","List-Help":"<mailto:ovs-dev-request@openvswitch.org?subject=help>","List-Subscribe":"<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1761185,"web_url":"http://patchwork.ozlabs.org/comment/1761185/","msgid":"<DD1DF7F2-B1A4-431F-8B9D-189A175F026E@vmware.com>","list_archive_url":null,"date":"2017-08-31T16:48:49","subject":"Re: [ovs-dev] [PATCH] datapath-windows: Remove unnecessary call to\n\tOvsInitForwardingCtx","submitter":{"id":67182,"url":"http://patchwork.ozlabs.org/api/people/67182/","name":"Sairam Venugopal","email":"vsairam@vmware.com"},"content":"Good catch.\n\nAcked-by: Sairam Venugopal <vsairam@vmware.com>\n\n\n\n\n\nOn 8/30/17, 4:03 PM, \"ovs-dev-bounces@openvswitch.org on behalf of Anand Kumar\" <ovs-dev-bounces@openvswitch.org on behalf of kumaranand@vmware.com> wrote:\n\n>Only curNbl in the forwarding context needs to be updated with\n>fragmented NBL.\n>\n>Signed-off-by: Anand Kumar <kumaranand@vmware.com>\n>---\n> datapath-windows/ovsext/Actions.c | 9 +--------\n> 1 file changed, 1 insertion(+), 8 deletions(-)\n>\n>diff --git a/datapath-windows/ovsext/Actions.c b/datapath-windows/ovsext/Actions.c\n>index 684b316..41d1c7b 100644\n>--- a/datapath-windows/ovsext/Actions.c\n>+++ b/datapath-windows/ovsext/Actions.c\n>@@ -160,14 +160,7 @@ OvsDoFragmentNbl(OvsForwardingContext *ovsFwdCtx, UINT16 mru)\n> \n>    if (fragNbl != NULL) {\n>         OvsCompleteNBL(ovsFwdCtx->switchContext, ovsFwdCtx->curNbl, TRUE);\n>-        OvsInitForwardingCtx(ovsFwdCtx,\n>-                            ovsFwdCtx->switchContext,\n>-                             fragNbl,\n>-                             ovsFwdCtx->srcVportNo,\n>-                             ovsFwdCtx->sendFlags,\n>-                             NET_BUFFER_LIST_SWITCH_FORWARDING_DETAIL(fragNbl),\n>-                             ovsFwdCtx->completionList,\n>-                             &ovsFwdCtx->layers, FALSE);\n>+        ovsFwdCtx->curNbl = fragNbl;\n>     } else {\n>         OVS_LOG_INFO(\"Fragment NBL failed for MRU = %u\", mru);\n>     }\n>-- \n>2.9.3.windows.1\n>\n>_______________________________________________\n>dev mailing list\n>dev@openvswitch.org\n>https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=Z6vowHUOjP5ysP_g372c49Nqc1vEKqHKNBkR5Q5Z7uo&m=Blm4rRbJawNtVUIwJBOWdpXZXYoC5m1pWTeIwnTXzrw&s=nFm5w0cTb7IN2ZR5CyOtAHQq6desheZnbuNYTFg0SYc&e=","headers":{"Return-Path":"<ovs-dev-bounces@openvswitch.org>","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"Yjxh3+pB\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=vsairam@vmware.com; "],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjpHD6XDYz9s7F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  1 Sep 2017 02:48:56 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 720D6B35;\n\tThu, 31 Aug 2017 16:48:54 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 42A57B08\n\tfor <dev@openvswitch.org>; Thu, 31 Aug 2017 16:48:53 +0000 (UTC)","from NAM01-SN1-obe.outbound.protection.outlook.com\n\t(mail-sn1nam01on0087.outbound.protection.outlook.com [104.47.32.87])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 9E409D3\n\tfor <dev@openvswitch.org>; Thu, 31 Aug 2017 16:48:52 +0000 (UTC)","from CO2PR0501MB823.namprd05.prod.outlook.com (10.141.244.145) by\n\tCO2PR0501MB1062.namprd05.prod.outlook.com (10.160.7.19) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.13.2; Thu, 31 Aug 2017 16:48:50 +0000","from CO2PR0501MB823.namprd05.prod.outlook.com ([10.141.244.145]) by\n\tCO2PR0501MB823.namprd05.prod.outlook.com ([10.141.244.145]) with\n\tmapi id 15.20.0013.012; Thu, 31 Aug 2017 16:48:49 +0000"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=onevmw.onmicrosoft.com; s=selector1-vmware-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=Ld7aymYizMemQY9sRpPBf3JK8zFTBQKK7R1rhwSJyb4=;\n\tb=Yjxh3+pBmlLN099UOmoDWCitZL8LzXoBa1ZxWnHc08hPVjDAl4xCaSCdDKUOdywCKE8EyYlJE2la0o7Auwx/fguM6YPptqFQTc51zvxW5ixYh3SNvJQgRm1RYQWY9y4rTVqAkav9GfRl72acWWvFD+dds/xzq+QcQ/Vm5esbMY8=","From":"Sairam Venugopal <vsairam@vmware.com>","To":"Anand Kumar <kumaranand@vmware.com>, \"dev@openvswitch.org\"\n\t<dev@openvswitch.org>","Thread-Topic":"[ovs-dev] [PATCH] datapath-windows: Remove unnecessary call to\n\tOvsInitForwardingCtx","Thread-Index":"AQHTInkFncIiYgTW0kuS5l2CYeToTA==","Date":"Thu, 31 Aug 2017 16:48:49 +0000","Message-ID":"<DD1DF7F2-B1A4-431F-8B9D-189A175F026E@vmware.com>","References":"<20170830230357.5440-1-kumaranand@vmware.com>","In-Reply-To":"<20170830230357.5440-1-kumaranand@vmware.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"Yjxh3+pB\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=vsairam@vmware.com; "],"x-originating-ip":"[208.91.1.34]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; CO2PR0501MB1062;\n\t20:s7XJfohY3YAgP4pu/8zwmAJZccAW2XWvDJwC3oqH739shLE1HeC0B9zjaU0FNxOIjl0w6ILiFRY+Ll6pUGj/VKMX4ElBDHYz8aBhkhRPp/8RH8Qi6oJX8pUOt6epJ6d4zfnXSInkkx1znypaxpSas10Mx5I3QDmf3pPmW2JcCn0=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;SSOR;","x-forefront-antispam-report":"SFV:SKI; SCL:-1; SFV:NSPM;\n\tSFS:(10009020)(6009001)(377454003)(189002)(24454002)(199003)(6246003)(8936002)(6512007)(2906002)(3660700001)(5660300001)(2900100001)(83716003)(14454004)(6436002)(3280700002)(33656002)(6306002)(2950100002)(25786009)(53936002)(86362001)(575784001)(99286003)(68736007)(229853002)(189998001)(77096006)(6486002)(305945005)(6506006)(2501003)(7736002)(53546010)(3846002)(105586002)(76176999)(6116002)(106356001)(102836003)(101416001)(81166006)(81156014)(97736004)(50986999)(8676002)(478600001)(82746002)(66066001)(36756003)(54356999);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR0501MB1062;\n\tH:CO2PR0501MB823.namprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ","x-ms-office365-filtering-correlation-id":"99b4ca1a-6ae8-4824-f5e8-08d4f09027c5","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:CO2PR0501MB1062; ","x-ms-traffictypediagnostic":"CO2PR0501MB1062:","x-exchange-antispam-report-test":"UriScan:(61668805478150)(10436049006162)(216315784871565); ","x-microsoft-antispam-prvs":"<CO2PR0501MB106247906884E9BB77CCFEB7DC9D0@CO2PR0501MB1062.namprd05.prod.outlook.com>","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(6041248)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:CO2PR0501MB1062; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:CO2PR0501MB1062; ","x-forefront-prvs":"04163EF38A","received-spf":"None (protection.outlook.com: vmware.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-ID":"<930F9AD89FFA0C48BE6C4B33A25AE29D@namprd05.prod.outlook.com>","MIME-Version":"1.0","X-OriginatorOrg":"vmware.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"31 Aug 2017 16:48:49.7293\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CO2PR0501MB1062","X-Spam-Status":"No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH] datapath-windows: Remove unnecessary call to\n\tOvsInitForwardingCtx","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"<ovs-dev.openvswitch.org>","List-Unsubscribe":"<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>","List-Archive":"<http://mail.openvswitch.org/pipermail/ovs-dev/>","List-Post":"<mailto:ovs-dev@openvswitch.org>","List-Help":"<mailto:ovs-dev-request@openvswitch.org?subject=help>","List-Subscribe":"<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1762667,"web_url":"http://patchwork.ozlabs.org/comment/1762667/","msgid":"<6FDA0CACF4BC624BBE12167875D71C9B40A5D165@CBSEX1.cloudbase.local>","list_archive_url":null,"date":"2017-09-04T14:07:27","subject":"Re: [ovs-dev] [PATCH] datapath-windows: Remove unnecessary call\n\tto\tOvsInitForwardingCtx","submitter":{"id":67146,"url":"http://patchwork.ozlabs.org/api/people/67146/","name":"Alin Serdean","email":"aserdean@cloudbasesolutions.com"},"content":"I also tested with an Openstack environment with two nodes.\n\nAcked-by: Alin Gabriel Serdean <aserdean@ovn.org>\n\n\n> -----Original Message-----\n> From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\n> bounces@openvswitch.org] On Behalf Of Anand Kumar\n> Sent: Thursday, August 31, 2017 2:04 AM\n> To: dev@openvswitch.org\n> Subject: [ovs-dev] [PATCH] datapath-windows: Remove unnecessary call to\n> OvsInitForwardingCtx\n> \n> Only curNbl in the forwarding context needs to be updated with fragmented\n> NBL.\n> \n> Signed-off-by: Anand Kumar <kumaranand@vmware.com>\n> ---\n>  datapath-windows/ovsext/Actions.c | 9 +--------\n>  1 file changed, 1 insertion(+), 8 deletions(-)\n> \n> diff --git a/datapath-windows/ovsext/Actions.c b/datapath-\n> windows/ovsext/Actions.c\n> index 684b316..41d1c7b 100644\n> --- a/datapath-windows/ovsext/Actions.c\n> +++ b/datapath-windows/ovsext/Actions.c\n> @@ -160,14 +160,7 @@ OvsDoFragmentNbl(OvsForwardingContext\n> *ovsFwdCtx, UINT16 mru)\n> \n>     if (fragNbl != NULL) {\n>          OvsCompleteNBL(ovsFwdCtx->switchContext, ovsFwdCtx->curNbl,\n> TRUE);\n> -        OvsInitForwardingCtx(ovsFwdCtx,\n> -                            ovsFwdCtx->switchContext,\n> -                             fragNbl,\n> -                             ovsFwdCtx->srcVportNo,\n> -                             ovsFwdCtx->sendFlags,\n> -                             NET_BUFFER_LIST_SWITCH_FORWARDING_DETAIL(fragNbl),\n> -                             ovsFwdCtx->completionList,\n> -                             &ovsFwdCtx->layers, FALSE);\n> +        ovsFwdCtx->curNbl = fragNbl;\n>      } else {\n>          OVS_LOG_INFO(\"Fragment NBL failed for MRU = %u\", mru);\n>      }\n> --\n> 2.9.3.windows.1\n> \n> _______________________________________________\n> dev mailing list\n> dev@openvswitch.org\n> https://mail.openvswitch.org/mailman/listinfo/ovs-dev","headers":{"Return-Path":"<ovs-dev-bounces@openvswitch.org>","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmBWG0g14z9s75\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue,  5 Sep 2017 00:07:37 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 78188ACA;\n\tMon,  4 Sep 2017 14:07:33 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id D0D33AB2\n\tfor <dev@openvswitch.org>; Mon,  4 Sep 2017 14:07:31 +0000 (UTC)","from mail.cloudbasesolutions.com (mail.cloudbasesolutions.com\n\t[91.232.152.5])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTP id 3F2111E8\n\tfor <dev@openvswitch.org>; Mon,  4 Sep 2017 14:07:31 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby mail.cloudbasesolutions.com (Postfix) with ESMTP id 593AB4335E;\n\tMon,  4 Sep 2017 17:07:29 +0300 (EEST)","from mail.cloudbasesolutions.com ([127.0.0.1])\n\tby localhost (mail.cloudbasesolutions.com [127.0.0.1]) (amavisd-new, \n\tport 10024)\n\twith ESMTP id L3TyEQ2p4M0k; Mon,  4 Sep 2017 17:07:28 +0300 (EEST)","from mail.cloudbasesolutions.com (unknown [10.77.78.3])\n\tby mail.cloudbasesolutions.com (Postfix) with ESMTP id A1FA44180E;\n\tMon,  4 Sep 2017 17:07:28 +0300 (EEST)","from CBSEX1.cloudbase.local ([10.77.78.3]) by\n\tCBSEX1.cloudbase.local ([10.77.78.3]) with mapi id 14.03.0361.001;\n\tMon, 4 Sep 2017 16:07:28 +0200"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Virus-Scanned":"amavisd-new at cloudbasesolutions.com","From":"Alin Serdean <aserdean@cloudbasesolutions.com>","To":"Anand Kumar <kumaranand@vmware.com>, \"dev@openvswitch.org\"\n\t<dev@openvswitch.org>","Thread-Topic":"[ovs-dev] [PATCH] datapath-windows: Remove unnecessary call to\n\tOvsInitForwardingCtx","Thread-Index":"AQHTIeRPYu0Zcctkd0azRNd/tgjlMaKkyi3w","Date":"Mon, 4 Sep 2017 14:07:27 +0000","Message-ID":"<6FDA0CACF4BC624BBE12167875D71C9B40A5D165@CBSEX1.cloudbase.local>","References":"<20170830230357.5440-1-kumaranand@vmware.com>","In-Reply-To":"<20170830230357.5440-1-kumaranand@vmware.com>","Accept-Language":"en-US, it-IT","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[10.77.78.1]","MIME-Version":"1.0","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RP_MATCHES_RCVD\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH] datapath-windows: Remove unnecessary call\n\tto\tOvsInitForwardingCtx","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"<ovs-dev.openvswitch.org>","List-Unsubscribe":"<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>","List-Archive":"<http://mail.openvswitch.org/pipermail/ovs-dev/>","List-Post":"<mailto:ovs-dev@openvswitch.org>","List-Help":"<mailto:ovs-dev-request@openvswitch.org?subject=help>","List-Subscribe":"<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1762670,"web_url":"http://patchwork.ozlabs.org/comment/1762670/","msgid":"<003801d32587$3b7e6c30$b27b4490$@ovn.org>","list_archive_url":null,"date":"2017-09-04T14:08:06","subject":"Re: [ovs-dev] [PATCH] datapath-windows: Remove unnecessary call\n\tto\tOvsInitForwardingCtx","submitter":{"id":72181,"url":"http://patchwork.ozlabs.org/api/people/72181/","name":"Alin-Gabriel Serdean","email":"aserdean@ovn.org"},"content":"I applied this on master and branch-2.8.\n\nThanks,\nAlin.\n\n> -----Original Message-----\n> From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\n> bounces@openvswitch.org] On Behalf Of Anand Kumar\n> Sent: Thursday, August 31, 2017 2:04 AM\n> To: dev@openvswitch.org\n> Subject: [ovs-dev] [PATCH] datapath-windows: Remove unnecessary call to\n> OvsInitForwardingCtx\n> \n> Only curNbl in the forwarding context needs to be updated with fragmented\n> NBL.\n> \n> Signed-off-by: Anand Kumar <kumaranand@vmware.com>\n> ---\n>  datapath-windows/ovsext/Actions.c | 9 +--------\n>  1 file changed, 1 insertion(+), 8 deletions(-)\n> \n> diff --git a/datapath-windows/ovsext/Actions.c b/datapath-\n> windows/ovsext/Actions.c\n> index 684b316..41d1c7b 100644\n> --- a/datapath-windows/ovsext/Actions.c\n> +++ b/datapath-windows/ovsext/Actions.c\n> @@ -160,14 +160,7 @@ OvsDoFragmentNbl(OvsForwardingContext\n> *ovsFwdCtx, UINT16 mru)\n> \n>     if (fragNbl != NULL) {\n>          OvsCompleteNBL(ovsFwdCtx->switchContext, ovsFwdCtx->curNbl,\n> TRUE);\n> -        OvsInitForwardingCtx(ovsFwdCtx,\n> -                            ovsFwdCtx->switchContext,\n> -                             fragNbl,\n> -                             ovsFwdCtx->srcVportNo,\n> -                             ovsFwdCtx->sendFlags,\n> -\nNET_BUFFER_LIST_SWITCH_FORWARDING_DETAIL(fragNbl),\n> -                             ovsFwdCtx->completionList,\n> -                             &ovsFwdCtx->layers, FALSE);\n> +        ovsFwdCtx->curNbl = fragNbl;\n>      } else {\n>          OVS_LOG_INFO(\"Fragment NBL failed for MRU = %u\", mru);\n>      }\n> --\n> 2.9.3.windows.1\n> \n> _______________________________________________\n> dev mailing list\n> dev@openvswitch.org\n> https://mail.openvswitch.org/mailman/listinfo/ovs-dev","headers":{"Return-Path":"<ovs-dev-bounces@openvswitch.org>","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmBXh01NFz9s75\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue,  5 Sep 2017 00:08:51 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id EE854B09;\n\tMon,  4 Sep 2017 14:08:11 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 1DD97AF4\n\tfor <dev@openvswitch.org>; Mon,  4 Sep 2017 14:08:10 +0000 (UTC)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id CC4351F0\n\tfor <dev@openvswitch.org>; Mon,  4 Sep 2017 14:08:08 +0000 (UTC)","from cloudbasealin (unknown [79.114.121.216])\n\t(Authenticated sender: aserdean@ovn.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id E2531C5A91;\n\tMon,  4 Sep 2017 16:08:06 +0200 (CEST)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"79.114.121.216","From":"<aserdean@ovn.org>","To":"\"'Anand Kumar'\" <kumaranand@vmware.com>,\n\t<dev@openvswitch.org>","References":"<20170830230357.5440-1-kumaranand@vmware.com>","In-Reply-To":"<20170830230357.5440-1-kumaranand@vmware.com>","Date":"Mon, 4 Sep 2017 17:08:06 +0300","Message-ID":"<003801d32587$3b7e6c30$b27b4490$@ovn.org>","MIME-Version":"1.0","X-Mailer":"Microsoft Outlook 16.0","thread-index":"AQHTIeRPYu0Zcctkd0azRNd/tgjlMaKkypLw","Content-Language":"ro","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH] datapath-windows: Remove unnecessary call\n\tto\tOvsInitForwardingCtx","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"<ovs-dev.openvswitch.org>","List-Unsubscribe":"<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>","List-Archive":"<http://mail.openvswitch.org/pipermail/ovs-dev/>","List-Post":"<mailto:ovs-dev@openvswitch.org>","List-Help":"<mailto:ovs-dev-request@openvswitch.org?subject=help>","List-Subscribe":"<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]