[{"id":1760694,"web_url":"http://patchwork.ozlabs.org/comment/1760694/","msgid":"<2582851.YOQyMPGCfH@new-mexico>","list_archive_url":null,"date":"2017-08-31T07:05:40","subject":"Re: [Skiboot] [PATCH 1/3] npu2: hw-procedures: Add comments\n\tdenoting procedure number","submitter":{"id":24781,"url":"http://patchwork.ozlabs.org/api/people/24781/","name":"Alistair Popple","email":"alistair@popple.id.au"},"content":"Thanks.\n\nAcked-By: Alistair Popple \n\nOn Wed, 30 Aug 2017 05:38:25 PM Reza Arbab wrote:\n> There are comments in this file to indicate where each numbered\n> procedure from the programming guide is implemented, for easy searching.\n> \n> Add a couple which were missing.\n> \n> Signed-off-by: Reza Arbab \n> ---\n> hw/npu2-hw-procedures.c | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/hw/npu2-hw-procedures.c b/hw/npu2-hw-procedures.c\n> index c9e7673..ac5c919 100644\n> --- a/hw/npu2-hw-procedures.c\n> +++ b/hw/npu2-hw-procedures.c\n> @@ -312,6 +312,7 @@ static uint32_t phy_reset_complete(struct npu2_dev *ndev)\n> }\n> DEFINE_PROCEDURE(phy_reset, phy_reset_wait, phy_reset_complete);\n> \n> +/* Procedure 1.2.6 - I/O PHY Tx Impedance Calibration */\n> static uint32_t phy_tx_zcal(struct npu2_dev *ndev)\n> {\n> \tif (ndev->npu->tx_zcal_complete[ndev->index > 2])\n> @@ -502,6 +503,7 @@ static uint32_t phy_enable_tx_rxcal(struct npu2_dev *ndev)\n> }\n> DEFINE_PROCEDURE(phy_enable_tx_rxcal);\n> \n> +/* Procedure 1.2.9 - Disable Downstream Link Training */\n> static uint32_t phy_disable_tx_rxcal(struct npu2_dev *ndev)\n> {\n> \tint lane;\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjYLz2k4bz9s7F\n\tfor ;\n\tThu, 31 Aug 2017 17:06:19 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xjYLz16zszDqYN\n\tfor ;\n\tThu, 31 Aug 2017 17:06:19 +1000 (AEST)","from ipmail06.adl6.internode.on.net (ipmail06.adl6.internode.on.net\n\t[150.101.137.145])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xjYLs314RzDqGZ\n\tfor ; Thu, 31 Aug 2017 17:06:13 +1000 (AEST)","from static-82-10.transact.net.au (HELO new-mexico.localnet)\n\t([122.99.82.10]) by ipmail06.adl6.internode.on.net with ESMTP;\n\t31 Aug 2017 16:35:41 +0930"],"X-IronPort-Anti-Spam-Filtered":"true","X-IronPort-Anti-Spam-Result":"A2BcBQDJtKdZ/wpSY3peHQEFAQsBhVOFVok1kRuYOYVHAoUCAQIBAQEBAQJrKIUZAQUnEz8QCxgJFRAPAUcGExyKFLEUOotDAQEBAQYCASWDKohbimkFmC6IPpVBkXmWRVeBDRwWGAkIGBmHdi42AYozAQEB","From":"Alistair Popple ","To":"Reza Arbab ","Date":"Thu, 31 Aug 2017 17:05:40 +1000","Message-ID":"<2582851.YOQyMPGCfH@new-mexico>","User-Agent":"KMail/4.14.1 (Linux/4.2.0-0.bpo.1-amd64; KDE/4.14.2; x86_64; ; )","In-Reply-To":"<1504132707-10406-2-git-send-email-arbab@linux.vnet.ibm.com>","References":"<1504132707-10406-1-git-send-email-arbab@linux.vnet.ibm.com>\n\t<1504132707-10406-2-git-send-email-arbab@linux.vnet.ibm.com>","MIME-Version":"1.0","Subject":"Re: [Skiboot] [PATCH 1/3] npu2: hw-procedures: Add comments\n\tdenoting procedure number","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"skiboot@lists.ozlabs.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}}]