[{"id":1760609,"web_url":"http://patchwork.ozlabs.org/comment/1760609/","msgid":"","list_archive_url":null,"date":"2017-08-31T03:11:30","subject":"Re: [Skiboot] [PATCH 3/3] npu2: hw-procedures: Update PHY DC\n\tcalibration procedure","submitter":{"id":66955,"url":"http://patchwork.ozlabs.org/api/people/66955/","name":"Andrew Donnellan","email":"andrew.donnellan@au1.ibm.com"},"content":"On 31/08/17 08:38, Reza Arbab wrote:\n> Per the updated programming guide (procedure 1.2.4), set\n> rx_pr_edge_track_cntl and rx_pr_fw_off appropriately before and after\n> calibration.\n> \n> Signed-off-by: Reza Arbab \n\nThis matches what we've been doing internally for OpenCAPI bringup.\n\nReviewed-by: Andrew Donnellan \n\n> ---\n> hw/npu2-hw-procedures.c | 10 +++++++++-\n> 1 file changed, 9 insertions(+), 1 deletion(-)\n> \n> diff --git a/hw/npu2-hw-procedures.c b/hw/npu2-hw-procedures.c\n> index 5ccc1a0..a140aed 100644\n> --- a/hw/npu2-hw-procedures.c\n> +++ b/hw/npu2-hw-procedures.c\n> @@ -59,6 +59,8 @@ struct npu2_phy_reg NPU2_PHY_TX_UNLOAD_CLK_DISABLE\t= {0x103, 56, 1};\n> struct npu2_phy_reg NPU2_PHY_TX_FIFO_INIT\t\t= {0x105, 53, 1};\n> struct npu2_phy_reg NPU2_PHY_TX_RXCAL\t\t\t= {0x103, 57, 1};\n> struct npu2_phy_reg NPU2_PHY_RX_INIT_DONE\t\t= {0x0ca, 48, 1};\n> +struct npu2_phy_reg NPU2_PHY_RX_PR_EDGE_TRACK_CNTL\t= {0x092, 48, 2};\n> +struct npu2_phy_reg NPU2_PHY_RX_PR_FW_OFF\t\t= {0x08a, 56, 1};\n> \n> /* These registers are per-PHY, not per lane */\n> struct npu2_phy_reg NPU2_PHY_TX_ZCAL_SWO_EN\t\t= {0x3c9, 48, 1};\n> @@ -521,6 +523,9 @@ static uint32_t phy_rx_dccal(struct npu2_dev *ndev)\n> \tint lane;\n> \n> \tFOR_EACH_LANE(ndev, lane)\n> +\t\tphy_write_lane(ndev, &NPU2_PHY_RX_PR_FW_OFF, lane, 1);\n> +\n> +\tFOR_EACH_LANE(ndev, lane)\n> \t\tphy_write_lane(ndev, &NPU2_PHY_RX_RUN_DCCAL, lane, 1);\n\nCould probably put these in the same FOR_EACH_LANE block?\n\n> \n> \treturn PROCEDURE_NEXT;\n> @@ -537,8 +542,11 @@ static uint32_t phy_rx_dccal_complete(struct npu2_dev *ndev)\n> \tFOR_EACH_LANE(ndev, lane)\n> \t\tphy_write_lane(ndev, &NPU2_PHY_RX_RUN_DCCAL, lane, 0);\n> \n> -\tFOR_EACH_LANE(ndev, lane)\n> +\tFOR_EACH_LANE(ndev, lane) {\n> \t\tphy_write_lane(ndev, &NPU2_PHY_RX_B_BANK_CONTROLS, lane, 0);\n> +\t\tphy_write_lane(ndev, &NPU2_PHY_RX_PR_EDGE_TRACK_CNTL, lane, 0);\n> +\t\tphy_write_lane(ndev, &NPU2_PHY_RX_PR_FW_OFF, lane, 0);\n> +\t}\n> \n> \treturn PROCEDURE_NEXT;\n> }\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjS8P1RRtz9s83\n\tfor ;\n\tThu, 31 Aug 2017 13:11:49 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xjS8P0SLszDqYQ\n\tfor ;\n\tThu, 31 Aug 2017 13:11:49 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xjS8D3djlzDqF4\n\tfor ; Thu, 31 Aug 2017 13:11:40 +1000 (AEST)","from pps.filterd (m0098414.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7V38ZUs077870\n\tfor ; Wed, 30 Aug 2017 23:11:37 -0400","from e23smtp02.au.ibm.com (e23smtp02.au.ibm.com [202.81.31.144])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2cp6scu3xy-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Wed, 30 Aug 2017 23:11:37 -0400","from localhost\n\tby e23smtp02.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tThu, 31 Aug 2017 13:11:34 +1000","from d23relay10.au.ibm.com (202.81.31.229)\n\tby e23smtp02.au.ibm.com (202.81.31.208) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tThu, 31 Aug 2017 13:11:32 +1000","from d23av06.au.ibm.com (d23av06.au.ibm.com [9.190.235.151])\n\tby d23relay10.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv7V3BVqx41812218\n\tfor ; Thu, 31 Aug 2017 13:11:31 +1000","from d23av06.au.ibm.com (localhost [127.0.0.1])\n\tby d23av06.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv7V3BV73006188\n\tfor ; Thu, 31 Aug 2017 13:11:31 +1000","from ozlabs.au.ibm.com (ozlabs.au.ibm.com [9.192.253.14])\n\tby d23av06.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tv7V3BVqk006184; Thu, 31 Aug 2017 13:11:31 +1000","from [10.61.2.125] (haven.au.ibm.com [9.192.254.114])\n\t(using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits))\n\t(No client certificate requested)\n\tby ozlabs.au.ibm.com (Postfix) with ESMTPSA id EC75FA038E;\n\tThu, 31 Aug 2017 13:11:30 +1000 (AEST)"],"To":"Reza Arbab , skiboot@lists.ozlabs.org","References":"<1504132707-10406-1-git-send-email-arbab@linux.vnet.ibm.com>\n\t<1504132707-10406-4-git-send-email-arbab@linux.vnet.ibm.com>","From":"Andrew Donnellan ","Date":"Thu, 31 Aug 2017 13:11:30 +1000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<1504132707-10406-4-git-send-email-arbab@linux.vnet.ibm.com>","Content-Language":"en-AU","X-TM-AS-MML":"disable","x-cbid":"17083103-0004-0000-0000-0000022BB96B","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17083103-0005-0000-0000-00005E12C0AD","Message-Id":"","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-30_10:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708310045","Subject":"Re: [Skiboot] [PATCH 3/3] npu2: hw-procedures: Update PHY DC\n\tcalibration procedure","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Alistair Popple ","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}},{"id":1761122,"web_url":"http://patchwork.ozlabs.org/comment/1761122/","msgid":"<20170831153018.rceo56cjpzwluaq4@arbab-laptop.localdomain>","list_archive_url":null,"date":"2017-08-31T15:30:19","subject":"Re: [Skiboot] [PATCH 3/3] npu2: hw-procedures: Update PHY DC\n\tcalibration procedure","submitter":{"id":69358,"url":"http://patchwork.ozlabs.org/api/people/69358/","name":"Reza Arbab","email":"arbab@linux.vnet.ibm.com"},"content":"On Thu, Aug 31, 2017 at 01:11:30PM +1000, Andrew Donnellan wrote:\n>On 31/08/17 08:38, Reza Arbab wrote: \n>>@@ -521,6 +523,9 @@ static uint32_t phy_rx_dccal(struct npu2_dev *ndev)\n>> \tint lane;\n>> \tFOR_EACH_LANE(ndev, lane)\n>>+\t\tphy_write_lane(ndev, &NPU2_PHY_RX_PR_FW_OFF, lane, 1);\n>>+\n>>+\tFOR_EACH_LANE(ndev, lane)\n>> \t\tphy_write_lane(ndev, &NPU2_PHY_RX_RUN_DCCAL, lane, 1);\n>\n>Could probably put these in the same FOR_EACH_LANE block?\n\nWell, the pseudocode in the programming guide does separate loops for \neach item like this. Maybe I'm cargo culting, but it seems significant \nbecause right below, it does three items in the same loop:\n\n>>@@ -537,8 +542,11 @@ static uint32_t phy_rx_dccal_complete(struct npu2_dev *ndev)\n>> \tFOR_EACH_LANE(ndev, lane)\n>> \t\tphy_write_lane(ndev, &NPU2_PHY_RX_RUN_DCCAL, lane, 0);\n>>-\tFOR_EACH_LANE(ndev, lane)\n>>+\tFOR_EACH_LANE(ndev, lane) {\n>> \t\tphy_write_lane(ndev, &NPU2_PHY_RX_B_BANK_CONTROLS, lane, 0);\n>>+\t\tphy_write_lane(ndev, &NPU2_PHY_RX_PR_EDGE_TRACK_CNTL, lane, 0);\n>>+\t\tphy_write_lane(ndev, &NPU2_PHY_RX_PR_FW_OFF, lane, 0);\n>>+\t}\n>> \treturn PROCEDURE_NEXT;\n>> }","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjmXr4Jyjz9s83\n\tfor ;\n\tFri, 1 Sep 2017 01:30:36 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xjmXr3LR1zDqYK\n\tfor ;\n\tFri, 1 Sep 2017 01:30:36 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xjmXg4G5FzDqF4\n\tfor ; Fri, 1 Sep 2017 01:30:27 +1000 (AEST)","from pps.filterd (m0098399.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7VFU0sI142863\n\tfor ; Thu, 31 Aug 2017 11:30:25 -0400","from e36.co.us.ibm.com (e36.co.us.ibm.com [32.97.110.154])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cpfgpmpue-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Thu, 31 Aug 2017 11:30:24 -0400","from localhost\n\tby e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tThu, 31 Aug 2017 09:30:24 -0600","from b03cxnp08027.gho.boulder.ibm.com (9.17.130.19)\n\tby e36.co.us.ibm.com (192.168.1.136) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tThu, 31 Aug 2017 09:30:22 -0600","from b03ledav005.gho.boulder.ibm.com\n\t(b03ledav005.gho.boulder.ibm.com [9.17.130.236])\n\tby b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v7VFUHlM64028764; Thu, 31 Aug 2017 08:30:20 -0700","from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 7C21BBE038;\n\tThu, 31 Aug 2017 09:30:20 -0600 (MDT)","from arbab-laptop.localdomain (unknown [9.53.92.213])\n\tby b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP id 6DDF6BE04C;\n\tThu, 31 Aug 2017 09:30:20 -0600 (MDT)","from arbab-laptop.localdomain (localhost.localdomain [IPv6:::1])\n\tby arbab-laptop.localdomain (Postfix) with ESMTP id 10E124605D9;\n\tThu, 31 Aug 2017 10:30:19 -0500 (CDT)"],"Date":"Thu, 31 Aug 2017 10:30:19 -0500","From":"Reza Arbab ","To":"Andrew Donnellan ","References":"<1504132707-10406-1-git-send-email-arbab@linux.vnet.ibm.com>\n\t<1504132707-10406-4-git-send-email-arbab@linux.vnet.ibm.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Organization":"IBM Linux Technology Center","User-Agent":"NeoMutt/20170714 (1.8.3)","X-TM-AS-GCONF":"00","x-cbid":"17083115-0020-0000-0000-00000CA4A93A","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007642; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00910259; UDB=6.00456608;\n\tIPR=6.00690540; \n\tBA=6.00005563; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016945;\n\tXFM=3.00000015; UTC=2017-08-31 15:30:24","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17083115-0021-0000-0000-00005DF1FDE3","Message-Id":"<20170831153018.rceo56cjpzwluaq4@arbab-laptop.localdomain>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-31_05:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708310228","Subject":"Re: [Skiboot] [PATCH 3/3] npu2: hw-procedures: Update PHY DC\n\tcalibration procedure","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"skiboot@lists.ozlabs.org, Alistair Popple ","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}}]