[{"id":1761104,"web_url":"http://patchwork.ozlabs.org/comment/1761104/","msgid":"<59A8291E.2060205@arm.com>","list_archive_url":null,"date":"2017-08-31T15:19:58","subject":"Re: [PATCH][aarch64] Fix hpwcap argument passed to ifunc resolvers","submitter":{"id":65667,"url":"http://patchwork.ozlabs.org/api/people/65667/","name":"Szabolcs Nagy","email":"szabolcs.nagy@arm.com"},"content":"On 30/08/17 23:35, Steve Ellcey wrote:\n> I submitted a patch to gcc to use IFUNCs in libatomic.\n> \n> https://gcc.gnu.org/ml/gcc-patches/2017-08/msg00545.html\n> \n> While addressing some of the comments to that patch I\n> realized I needed some changes to glibc in order to\n> enable the functionality correctly.  This patch has\n> those changes.  In elf_ifunc_invoke I changed the\n> argument type passed to the ifunc resolver function\n> from 'unsigned long int' to 'uint64_t'.  This doesn't\n> matter until we do ILP32 but I would like to change\n> it now so that I can check in the gcc patch with a \n> matching type and not have to change it later.  The\n> other change here is to use hwcap_mask to mask out\n> the hwcap value passed to the resolver function.  This\n> means that ifunc resolvers that use the hwcap argument\n> to check for hardware capabilities will be affected\n> by LD_HWCAP_MASK in the same way that glibc resolver\n> functions are.\n> \n\ni'm not yet convinced that LD_HWCAP_MASK should be\napplied to ifunc resolvers: glibc might be interested\nin different hwcap flags than external users and the\nimportant hwcaps mask has other effect in glibc that\ni need to review.\n\nplease do the type change and the masking in separate\npatches (the libatomic change should work without masking\nit's just not possible to opt out using an envvar).","headers":{"Return-Path":"<libc-alpha-return-83924-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-83924-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"bXuG/++P\"; dkim-atps=neutral","sourceware.org; auth=none","spf=none (sender IP is )\n\tsmtp.mailfrom=Szabolcs.Nagy@arm.com; "],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjmK312xHz9s83\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  1 Sep 2017 01:20:22 +1000 (AEST)","(qmail 36494 invoked by alias); 31 Aug 2017 15:20:16 -0000","(qmail 36484 invoked by uid 89); 31 Aug 2017 15:20:16 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:message-id:date:from:mime-version:to:cc\n\t:subject:references:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=aV75dxNwIjS1ay0w\n\tlr4kmxCDD8zzwFycuS+JxiEl63IMbfHA3LHTV+up5H4AAb3HYOth2GBWtJIJDmB1\n\txIrGZqipcjrBMl/WvEsK0o2k8kqJkAiG2yUISYKu1E9MiFoJzPjqQKoHLz3sK0Du\n\t6S0cywkPB6yiqzGu8NMtkw15sX0=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:message-id:date:from:mime-version:to:cc\n\t:subject:references:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=cxo88kadRUJvk9bs3JkZZJ\n\tpT7tI=; b=bXuG/++Pq0jiA3Qx55+lqkCH+LVCnfOB87OfYOS2xRSBWiBz+ZwxI7\n\t0QNdKPO1jYaW4G0StzJ9R+PQox/yLplkjX4xYmlrrIwwzlyXFmAfArprozXwh1IW\n\tcdp/Iy3CRntbSBJq9qkdg/SJMXPLnPGfdp6ORJl9xO41810qoKAXU=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.1 required=5.0 tests=AWL, BAYES_00,\n\tRCVD_IN_DNSWL_NONE, SPF_HELO_PASS,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"EUR03-AM5-obe.outbound.protection.outlook.com","Message-ID":"<59A8291E.2060205@arm.com>","Date":"Thu, 31 Aug 2017 16:19:58 +0100","From":"Szabolcs Nagy <szabolcs.nagy@arm.com>","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:31.0) Gecko/20100101 Thunderbird/31.8.0","MIME-Version":"1.0","To":"sellcey@cavium.com, libc-alpha <libc-alpha@sourceware.org>","CC":"nd@arm.com","Subject":"Re: [PATCH][aarch64] Fix hpwcap argument passed to ifunc resolvers","References":"<1504132534.3182.4.camel@cavium.com>","In-Reply-To":"<1504132534.3182.4.camel@cavium.com>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"AM4PR0101CA0069.eurprd01.prod.exchangelabs.com\n\t(2603:10a6:200:41::37) To AM5PR0802MB2483.eurprd08.prod.outlook.com\n\t(2603:10a6:203:9b::22)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"20c91c4d-62dc-46ee-2836-08d4f083c02f","X-MS-Office365-Filtering-HT":"Tenant","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(48565401081)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:AM5PR0802MB2483; ","X-Microsoft-Exchange-Diagnostics":["1; AM5PR0802MB2483;\n\t3:ih4zATz4YMqOtMZWWwp6KZvaE2Biq5CvzINo3L2Z98NWz/JUuo8xFybdnUadPYDoAPqDXTkB97DcGqNRiQX2J7m7GZaHLFlJ7WReMLGReyHPosjdLczr8oLa6f+mqlyGRwOTpkVygS13LZ+pdm64snxgAeyTR2BBxSTNkEQVMVQtmoCaX9eVVV9nfaLCVmmGwFi42FLSSmULRtPq/cdG4/0vtEalMQK86uJJcCQzQkChVgf1Kohgf7iwCXeRiymP;\n\t25:j3zEtv8v2gwNFbP6lsvBW1BEpgcWKaMcBZ3OGT0P6frqleJoit1tOwNbsjgEkq1FGgUBU1MCIY8EsApKZmTb3ex4xB3uYfXtzffzRPzTYzsExpP2KGT3OazAeQgWIYxzfdNLBGolKv8KUYeqSACG343QUx638uLaXPfY9dvULYcKmzthIsT2d8q1Btt0O2arp3aeh38dKzA8OSsWjJ7olJlthk7swPNCJ8JW2dJBlGo8y9NDxDWn+z1I0L6cOsZPMNW4n2KzM2evUw0H9D+E/IddelLh2oVIuEgxnBY6LwDG/t7TD4+ZVEfh5iSBQlYrdPgM7gRI6cQPFZCjEgz74A==;\n\t31:yMB6ZFdM9ekM79EtFLBMRE790+jjnKE9Qq7N2RLCj/74/WNt8iZEy8ePNIfWbn9tG39W4eJ5wBTN2AqJxovY73tDPdJhuBWtRB/oBm9d2e7qb29rAg/JJuK/f1r8Gh91BA0y7GB9sIB5Dhrd1Ou0mI7ZDcTNfxL/e4kqUfi7Z7TdOWbUGMjDux3lDmBKhlhT4qsJ0GXzCfESnkIR1Z9azlcW3r8Q4Zd7/QR56MmkQHQ=","1; AM5PR0802MB2483;\n\t20:90T2TPpIVjg5ZvpWhiueU+p9kf02BQC0lsADSA9sNMdR19IbsGXA88eX4ID3LUPE7X0TZHyBOrWyHrTtrXp7b+FedeK/50y6k2xhCB9q4+aw3x73WOZjSs+0X5rxFyipjUtxSubf7soIEKMaOJVwVzhjd/N7tiZEK9rp+RLFpEs=;\n\t4:PPXdDZtgvubDoHCSeWUr2gCLadgNtecTtKhf3MXhNR6iKMv6XUYABbuuKcafQTXdfcpDGGoAaMLfmabf/e1agtdigZhyyb8fNG4FN/Ntm2rTG5TyPPT6BwMPuvSPoEB785zgqMP9cXirAWDgi0fEMg59pLZLMqcDHd47hs/7sVbqgY95M+wgkeY1TOlkmMu7OBffMCwyDBDwL6ZfWRXtXJ3eFmKtg4nfBfyNORvlU4ZY6twb9kJIrb80YOkN5VWa18Bg0t9nt3tq6apKqlBg0/RaP6gFpDaK7j2IxBY9v0pYqsfh8rRsBn6yL8RU3wbO9/B9oGZ1KTppSLL9fPF7DA==","=?utf-8?q?1=3BAM5PR0802MB2483=3B23=3AQ1?=\n\t=?utf-8?q?BBrRr1wwL1BN+Ouixsv3EOVIIqaiB/PfOrG10zuP1eKSqtfvL8EGksmO?=\n\t=?utf-8?q?71KBCccLfEvX3Vv2pED4qF/jIHLJFTX5jAeWsCQWv5B9SVYZ/tWGhety?=\n\t=?utf-8?q?1eW16csiCqvKrQ5sige1xeTx8HqWvpk+eDLRFvW+vE1vSMoSKoPSwntK?=\n\t=?utf-8?q?5wkCjzTPd4f/FSR1XkMpHZ3DddmgxQtV2nf1/aA3riA3cIxX/erxTOXr?=\n\t=?utf-8?q?e6vuK6T8iYNxELwExBTuOpOXTILQHwcrT5EHaAAn5ju0Esz2WA1webde?=\n\t=?utf-8?q?58dzNE9og20tk+R6mx4N0lR8skWxvfEvVoEiIvaY1Ol/FfOV8gU+QhSY?=\n\t=?utf-8?q?Lb+tCYOm9hIQoCGvSNXVbEuYCGw4kU4usUctMqswfOMA7vsq1Sjrfmvu?=\n\t=?utf-8?q?nGv35UDHDSF/U3Iik8WAmH/5M+6oKQOdz294S+cy0ziC4FVUHx7ZQan2?=\n\t=?utf-8?q?P6FlvRbJhOHLzA1DAL5U1a1np2IGQbaiEU7t7MPBLc40u116vmtkiMH1?=\n\t=?utf-8?q?NxQJ5l8sHNkit1tTD0kY/geMhp3Zszdwuw9jgSM9LBth3UARYN3v81M3?=\n\t=?utf-8?q?c7xQ7M21LnieobBM8tWBIE4xfpMADvp/cMOSKjLfS5cVLjH2l0zZJN1w?=\n\t=?utf-8?q?R4NmxTZef7924dEBmE0HV+iYT60d1TVLdKTcky4Q+6u48A9A7xOsh3Sy?=\n\t=?utf-8?q?lddc2RhlLA5I0Cu5M9F4I0aLT/oa631PS2Zf9z6Lp2s3alQ6b3ZmuJ4A?=\n\t=?utf-8?q?zAzTR5A6UpQTKsc7cYjylntGrLTjsYrwknGJX1l+Jwj8eTjT0FA8/l1c?=\n\t=?utf-8?q?Gm+0aVeQ7/buWNUx0bChRbqPlInutI0wBSqy9aAAUK0bXHIu63BnXeeb?=\n\t=?utf-8?q?b82rhMA3EMy73mNOUPwgmofc0jICG7jhUAj0/yeixwD0YsahLFNOgqKt?=\n\t=?utf-8?q?tGxU6g9GC0ZvNg6GKcwxC7EzdvydEGLd5y698tKtnt0cNRDcH1wLCC4c?=\n\t=?utf-8?q?sQoOeDE38Lw2TjJW1xxxV3D+13EWAPkxUGsmVT8FDkTbNcj/Wkobqo26?=\n\t=?utf-8?q?RRdK8IjaUK25tzvO+0m4DSEPKGeZzTW6/DDdM3kLvwyRvc3wgib/FjX9?=\n\t=?utf-8?q?YZUQPvL/ocpSRL3ylUuzzqefPIKQGQWgZTdz3swNSTPo2GKbfRciikkU?=\n\t=?utf-8?q?HyCLfg3b48pzVwJESFQ3mBAYk/PYIfdakaCUDTLMp94H/wWdiB99gYry?=\n\t=?utf-8?q?4O4OS/Y6NGsRNYVG95FbMTpBJhAMu/9g8lOV6kDZBjeYZHOapgwcmWCZ?=\n\t=?utf-8?q?azZk4o6zxg3ABOfoBgWpMF3/8u4OqIsKhwf/05jKNthmkDLZ7tfCXfd/?=\n\t=?utf-8?q?UycPNNm20rwnnPi3Mlo+SoVp16UD0P43Xch1QniHd2uH00WygMRW26O0?=\n\t=?utf-8?q?RtllTDNOt+i6NuxcfEzYWJjVPsPvzmi83W7bzE0q+C88R5LwtexrR0lN?=\n\t=?utf-8?q?M/XKJ4C5FVw5nIUEXuwTcjyPbR5wfljUNDk1elIQb32nyKGdg=3D?=","1; AM5PR0802MB2483;\n\t6:SjB8e9E1/yld2jwYEMSqgsJXAx2zyQvcBG8gzzciGx9FcEh7h0F48VUJjsjyg97d5h3XB9/86sXc8+DTZuMqm0VbkiSUJ6WyZNLUyA7fIAnXG7CLjFI7z7Z2UR0DgPAtncARV8pZvwpJbIdtBTKUxH8DHIFAKoHD4GJmEMglZ3pWw4d8Q8cfFtZoYikUcFhMXf0BI73N9A193BAnL0H0c8L3JMKOpeFk+uEjvMJR5DXOu0sVvPXBmvnwKf0ui7vwh4G74UpCv9X8UyHnSK9r5a3C4kDr76M0I+wX3/T/SVQCZ3JIXpwA9aH3LqQOB9Xk23Fqwb4t0MQOPR7JTXvmlA==;\n\t5:SePO5vVVR9Cfd68LW1yVLkvCv68xzCZ71ztLbIrCCJy/TN/jRphycJJUNHQhYGu2ZwrTJYU8MbQpMg4fqjfoTzGKmFWmhZeuzW0r5uBMdxgIkd27HiJTbAh6RiPUh5131be/sZDTgFIPbla4ddCHRw==;\n\t24:yMFyrz70xUsyhKvNwBWklDDJ0n0okM7qu51UfEQR9nsii8hGIWEZswyY8tpPu/Zrxbr0ex7nW4ikP7usDsuzNKW33saFFOj75T/AAJduEog=;\n\t7:OYkhcs0EjRBQ16EZKU3xL5lRxWZ8C0/RqMbzW0J8dMLBRN5SwxmXugdpk251RiiNiSgrx8ldtvrmNEAfqASaoUXzRLJKjDCQ3tY6a4gAKlpGWkY1hl+Yxy59DoZwKJnyuOtezKsu1c3MmQk7EI0GvKrixgj5YbBYfnkaAu4rSHU/Ma2JIGFeg9a5xLega6EVSLuRnxz0qUn45puSQm09UO+XNPr23W/a5dAX8UfDqjs="],"X-MS-TrafficTypeDiagnostic":"AM5PR0802MB2483:","NoDisclaimer":"True","X-Exchange-Antispam-Report-Test":"UriScan:(22074186197030)(183786458502308);","X-Microsoft-Antispam-PRVS":"<AM5PR0802MB24839613696F22D161AB512CED9D0@AM5PR0802MB2483.eurprd08.prod.outlook.com>","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(20161123564025)(20161123562025)(20161123558100)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:AM5PR0802MB2483; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:AM5PR0802MB2483; ","X-Forefront-PRVS":"04163EF38A","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10009020)(7370300001)(4630300001)(6049001)(6009001)(39860400002)(199003)(189002)(24454002)(53546010)(478600001)(6916009)(77096006)(50466002)(59896002)(6246003)(5660300001)(87266999)(110136004)(66066001)(80316001)(47776003)(229853002)(3846002)(106356001)(33656002)(189998001)(7350300001)(6306002)(86362001)(81156014)(53936002)(65806001)(4326008)(7736002)(97736004)(65956001)(25786009)(65816999)(2950100002)(50986999)(101416001)(305945005)(68736007)(72206003)(6116002)(6486002)(36756003)(966005)(8676002)(230700001)(42186005)(81166006)(105586002)(83506001)(23676002)(2906002)(6666003)(64126003)(54356999)(76176999)(4001350100001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0802MB2483;\n\tH:[10.2.206.69]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1;\n\tLANG:en; ","Received-SPF":"None (protection.outlook.com: arm.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"arm.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"31 Aug 2017 15:20:01.8342\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AM5PR0802MB2483"}},{"id":1761154,"web_url":"http://patchwork.ozlabs.org/comment/1761154/","msgid":"<1504195926.3182.20.camel@cavium.com>","list_archive_url":null,"date":"2017-08-31T16:12:06","subject":"Re: [PATCH][aarch64] Fix hpwcap argument passed to ifunc resolvers","submitter":{"id":70332,"url":"http://patchwork.ozlabs.org/api/people/70332/","name":"Steve Ellcey","email":"sellcey@cavium.com"},"content":"On Thu, 2017-08-31 at 16:19 +0100, Szabolcs Nagy wrote:\n> \n> i'm not yet convinced that LD_HWCAP_MASK should be\n> applied to ifunc resolvers: glibc might be interested\n> in different hwcap flags than external users and the\n> important hwcaps mask has other effect in glibc that\n> i need to review.\n\nPersonally, I like the idea that LD_HWCAP_MASK can affect ifunc\nresolvers.  It gives users a single method to turn off some hardware\ncapability across all libraries.  I can see where finer grain control\nmight also be useful but I think that in general we are going to have\nsituations where a particular hardware capability is just not working\nthe way it should and so we want to turn off its use everywhere in an\nexecutable.\n\n> please do the type change and the masking in separate\n> patches (the libatomic change should work without masking\n> it's just not possible to opt out using an envvar).\n\nOK, I have sent this off in a seperate thread.\n\nhttps://sourceware.org/ml/libc-alpha/2017-08/msg01355.html\n\nSteve Ellcey\nsellcey@cavium.com","headers":{"Return-Path":"<libc-alpha-return-83943-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-83943-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"DQhwfWwF\"; dkim-atps=neutral","sourceware.org; auth=none","spf=none (sender IP is )\n\tsmtp.mailfrom=Steve.Ellcey@cavium.com; "],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjnTC22l6z9sNr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  1 Sep 2017 02:12:31 +1000 (AEST)","(qmail 89271 invoked by alias); 31 Aug 2017 16:12:24 -0000","(qmail 89259 invoked by uid 89); 31 Aug 2017 16:12:23 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:message-id:subject:from:reply-to:to:cc:date\n\t:in-reply-to:references:content-type:mime-version\n\t:content-transfer-encoding; q=dns; s=default; b=YPxiejA5+FtliCfH\n\tI6O1r9uh9RfQaNdWI+unRcafxnGwaQU0G12BNJJq9136JJFfIZjtWRMc29taLJyx\n\t1BlqXXeLchCuG5MCR+8KiHT9lbTc6WRjNjtAfelwMy/DuDhDNcglqyo8anHuNbNt\n\tMrHKdFNheT1T67w93OLQTNOSr8k=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:message-id:subject:from:reply-to:to:cc:date\n\t:in-reply-to:references:content-type:mime-version\n\t:content-transfer-encoding; s=default; bh=/1n8jLKbBQmU1N9KIxtn/1\n\t6tm90=; b=DQhwfWwF/82+P0E/Jaysi7QMDFpLhicaJ8Nu5ZxC21EK/OYIhtN4nP\n\t9b2cP6ewcjEx8onSs2TlGvTU5ovt7WoiAB+t2h1uBukTuap6ln8LEAHv6SHJZkCZ\n\tU+H13w2NYkn+TtcUclmKT1/fSHNgMhjgQw9tYcNlMYLApUYkDHqYc=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.7 required=5.0 tests=AWL, BAYES_00,\n\tRCVD_IN_DNSWL_NONE,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2 spammy=finer,\n\tH*r:sk:mail-co, H*r:sk:NAM03-C, H*r:104.47.40","X-HELO":"NAM03-CO1-obe.outbound.protection.outlook.com","Message-ID":"<1504195926.3182.20.camel@cavium.com>","Subject":"Re: [PATCH][aarch64] Fix hpwcap argument passed to ifunc resolvers","From":"Steve Ellcey <sellcey@cavium.com>","Reply-To":"sellcey@cavium.com","To":"Szabolcs Nagy <szabolcs.nagy@arm.com>, libc-alpha\n\t<libc-alpha@sourceware.org>","Cc":"nd@arm.com","Date":"Thu, 31 Aug 2017 09:12:06 -0700","In-Reply-To":"<59A8291E.2060205@arm.com>","References":"<1504132534.3182.4.camel@cavium.com> <59A8291E.2060205@arm.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Mime-Version":"1.0","Content-Transfer-Encoding":"8bit","X-ClientProxiedBy":"MWHPR1401CA0023.namprd14.prod.outlook.com (10.174.253.161)\n\tTo BN6PR07MB3537.namprd07.prod.outlook.com (10.161.153.139)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"fabfe62d-b96a-4933-77b8-08d4f08b08d4","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:BN6PR07MB3537; ","X-Microsoft-Exchange-Diagnostics":["1; BN6PR07MB3537;\n\t3:iRQL5QztZIp1KDCs1FSSJFWNCKtnTmcGEEosdLPvBbIasn0n4QDlAIh99AvChnh3d56bhB59TLwBT7jUpRHwzQbpyc104Jhs4Ce95IWrWVSp45PJduyTwXiA7pXUK1K5hDFeGSTPyH/i33fMfaCkQsK2gY6qGu6E8RtroSxYzWm3P2kSmSr2gsIPWlsfKK9feg1X8GhxksmMNDUCGCYIegaEkY7TammPeLu/R5MqvxxUgCmMGdsK/oLO8hVaJa5n;\n\t25:jEDOhTTD7Km1N6Fv39kCKdN1xn2+j95dQQA1r/H1LSN0VbnrsvDTRvgJXe84SCCk6fbrBeFMELx4sr458zvhOz7NkgvYt72vXWH5Ro9gCEDOVcCUlmOkEoYQS/X2zvURe4vaJc6FUyBVz59FsAWs/Q1qHj8Coodu9hw0U0uQR7+NWBbreegyvVUoNqigpKJMQPaETaqqb/9XP0KdxM253uVTrlswdKLWcmSExZ7AmnPKJtJDpoAerDZqjmnk5yRV1Rv1ya9s4aQkgs55VROrASVa8Wt4gYdoluq65SA76j0junTagjeT+SeGZCj+CmpPABBedA3cjkKgAIZAT2OMQw==;\n\t31:gZ9j8Y/5cuvvX1fmpneOWzm9y1Ufy/NtoMQrGe4Nnnmb+ctYO9l5wBlP4PnNJNugXGini/k11cFJ50/gugeljXjdXhhvYph74L5Hqd9KanFnubw9OR3DAgC90OwWgOkWHSayO5LiW7U3wMSNnTwTyRrgV8ExXsoBryabonZXqtTavssCOxh6z03NU7FVzA04yhKmTIB+hy980c4TObrxOcdxuXxq4dARP8GUcI/5Mwg=","1; BN6PR07MB3537;\n\t20:bSDKzpeNdTKVszkteSw8+b70rtGD5Sb9AeTrXp7sTJ0hyfTYnovHBrUmwtswDLEwnlRGxZBB07qFq2oPy1NOppWwrpZLW8LzhDEm6iIQquwHJmyj+13d8aqhEhdIWcSEa/w1xY22PurKwzQeDsfO3Fr4Slp0FvtLLIY/jQibwyOm/F2kyz2nQzYOvqZI4mPLYWL4ThKRmM0Rd6xJthohQkZ3S8RdEmp7SiGoLqME5dESuQlpCq8DLPDpL/QOpaEcL8+S8FCW39V9Naw3kpXI/so6vAwePTH8LEoXY9Nje3M7AIQ4dcsv51+Kn7fCrCFOA6tEzwZNRNC023NFN9/RbYpFd7srgCXn/WVD8wUlpOoD0QzhU/NT0nE24mqClhJD9uoTMSu6bxy//pV6likjUEqZ4CTOmgQeV1xhQCz3i+++JOFDuTBLqir4ZT7XCcEVyWDRKbbmm+6Uy/fVeLh7QXnwf4O+EScxoG8pxci9U+A/WJ1GSGPTUsupPEkXIgpA;\n\t4:+mY4OX/O+wbaxkMVWZRbYfKAN4krfdol0YeVZ4rPj7MxJnoYM4MBrDoBaIEPTLnQPFgsZ8ECm675A0yqyPQfUe0LdI4AJn13fLCAfFjAAb0Jtq3yv/UdoTPKe6M5yEiY4c0WmoTnxZCp55RvPZFXw2mYosfTYfLJUvMCpK5RV6fzydiyrbFLpnPX0ajV2/q4oLfO+YYqqndBlCEofgJtQw0ebLIOfnuEeQS/77urKril5hukgR3bSLNjjE9FS6AH","=?utf-8?q?1=3BBN6PR07MB3537=3B23=3AIYby?=\n\t=?utf-8?q?cNH7s6SVK1UoxbFCl4t8nYTvbZYx4k7EA+KAY1BW+Zn3EbLp7b2ItyRn?=\n\t=?utf-8?q?FNv3pdWgHTSDh2KGAcrapyEp8avDzJ8rfaradkyJcA4dMy6ZHJFRoDeD?=\n\t=?utf-8?q?+K6MSW8uLiR+84BOT7ZylLL7UJlEQZ8ImSeZKj0grvpdD5ZpZFTWXrjJ?=\n\t=?utf-8?q?nUbZ2uT9C4eUNEmCNokNg7WlbogxcRJxgPN2SpGIDM749AQvtTcCcm2O?=\n\t=?utf-8?q?Fxe2/LXYdJRD+zj+UAIraJPBVn5lrUDnyn+F4iR4CPeCZDN1dSLzl+Ej?=\n\t=?utf-8?q?qCsDIVGv8/8QgmxWzHv2Eghk4WFS9hvVHj6w5qis0fPSjEaWoWnBfKVt?=\n\t=?utf-8?q?Zv2vhJeRjwVSz158sA1VsR07TD/slQ6ZJX8bbN4XsbeIqNov0fOLZpVv?=\n\t=?utf-8?q?ijVcDY/StVWHV+CLIVTkwX3/kI9GkyjEDKC+VmwVVzKorUow84PM2unA?=\n\t=?utf-8?q?qpOlhW22/OxXEAgfOFJxqUJlPnIPlRrAw+Wo0QWnt0bHKUwmHcHzri1s?=\n\t=?utf-8?q?XliuMtg/NAVJVVtGcPt3TeOnzTQyRAQbNUWAUSdcPibznZcRtLvzT0sR?=\n\t=?utf-8?q?z3fP70mspdvs6slQo6xnurwLYSV8WrvhqFZlC/4Fj1GuR0/vk72tTtdW?=\n\t=?utf-8?q?WuHEpSm5VJtwNBteJNkwaRYwv007vCZqkMVtG8W5XEy/pdfUju99cea9?=\n\t=?utf-8?q?fLqH93HC/4lQirXPXEaJz+Eh72LXDFwi7A2bPik7LFNKZGOEojOFDioQ?=\n\t=?utf-8?q?gCaKnRmx93llgS6ozXWVQwHWVdClNQnvouojwihBArWvNKw8DwadxI9k?=\n\t=?utf-8?q?AKFtJWGfHNOtONgOJgyCNlXfeylZMX/HIXBpKjLW9E7sBlqhmYgmBm2p?=\n\t=?utf-8?q?YJcpN/3qotObCcbNqksSWBGYyqIkkBRoqQCLhfRum//E9Il6ogPrA/TU?=\n\t=?utf-8?q?sb5UEaSPx23pYwLMEpm3TsV+1qJY8sVEF/KbV+4IrFMcwlJAjqfDM4HC?=\n\t=?utf-8?q?kcA7g0E8xTGepHo28K2P6Q9Wiok9djmyJcQ5pBqWweeYkQzdze/iJFEO?=\n\t=?utf-8?q?h9qt2dYfrsuhgQ9Q+Ql14n6Z/z2MdDr/QD/KuD3gu/oiI4pd8HCHrNux?=\n\t=?utf-8?q?Eo/ZpHb5Y8WqPzrOZMtCKffKLnyypzgXauV6pzpRHYjQ1tOyi0IcIG2i?=\n\t=?utf-8?q?o9kBOunGJX/uHAYEEp4MNjdtH14AlzIlmH3Me148faObDWm01HWXVhVX?=\n\t=?utf-8?q?rRE/YE4NN7wFlwpc0+pRCGPNFFGuiM92wwB2IilJupw1dEqqFxhAsLPk?=\n\t=?utf-8?q?O4PrsCTzndZeMei8x8XTNiMM9InsxTKLcHyos6m805RK?=","1; BN6PR07MB3537;\n\t6:UJybLDoEFFRpu03lmj4fbeRubJyrM8VurZbG7qhKMn8BCuvWd5qCJcIjQUsWvY90sFSsQEreOrqCf9QUUVtSvxGmWJ1VjCx01fP979zJUyYtDKrv/qhjwOqdTBPoKCUBYq+WPuH6PblVdyClyvng6pLUaTlXmj4wHQdBqbQ1Gq0VIbbUZys6ogUxzw/aBA/SCg2uPrx0qHSMwcAs/8fAvlVY6R3j84tCzuRncwu5EcWbkKxJmKUdBX9A5jvoBLJydVy8p78KrdxT6+qYaTOSeiEHHOusXz4RY4JkuZmcqe55JfcJl5hkn6RnW+q9LhATRL9PPyjvAzxfiaCYbzxk7Q==;\n\t5:5fpuO19J/m1l1LGlXxuoEQg6laSQbXJ6lbb92tHXAysPLMREh5LZ58oQ+A7FSnKo9cHtUp8e5wyOrr0Wa3B9tDEeceEsoYZp30bkvidrpf9GMcYt8/WnQWfZAM8JUErNN0XtF81XK+VXV5Ad6fo21A==;\n\t24:P1TyJy0fCsbIL0VweKcwig7qj0MKx142yor/zE2YzJWInR6Y1aQhJAmaeomXsAR0kP/Qd5AZ6w6PYvYSZQA2EWLU8CL5ZIx4kJlYwHgEZYQ=;\n\t7:PU5WtndNBI6EsFR0+oDuvZBc6BiXq4+3HKbUJCVI7GBlRgtXLabt9wmp0LkFmRR4sB/u4I/RqBJR8YKE72tgNSoMDZ5KMXSzNBrIwNRefI32SPHfRHfo3Y33/H6bvSHrR7z98fNxNycWlwNgBsFC8SfJbgnL++LbiC3pUSIij/4jRzc8CD5GN+OHMrUPBmngQADADBjqnoj4PYd2nsbGYpXUYyxgDbizxt5x/6E5GO0="],"X-MS-TrafficTypeDiagnostic":"BN6PR07MB3537:","X-Exchange-Antispam-Report-Test":"UriScan:;","X-Microsoft-Antispam-PRVS":"<BN6PR07MB35375966BC6FAEC35B6DC497F59D0@BN6PR07MB3537.namprd07.prod.outlook.com>","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(10201501046)(93006095)(93001095)(6041248)(20161123560025)(20161123555025)(20161123564025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:BN6PR07MB3537; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:BN6PR07MB3537; ","X-Forefront-PRVS":"04163EF38A","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(51444003)(199003)(24454002)(189002)(377424004)(2870700001)(3450700001)(2906002)(966005)(25786009)(4326008)(5660300001)(3846002)(6666003)(6486002)(2950100002)(6506006)(69596002)(6116002)(229853002)(76176999)(50986999)(97736004)(101416001)(43066003)(478600001)(36756003)(189998001)(305945005)(50466002)(50226002)(6246003)(7736002)(8936002)(5820100001)(105586002)(53936002)(66066001)(6512007)(47776003)(106356001)(42186005)(53416004)(103116003)(8676002)(81156014)(33646002)(81166006)(68736007)(23676002)(72206003)(6306002)(99106002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR07MB3537;\n\tH:sellcey-dt.caveonetworks.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: cavium.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"cavium.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"31 Aug 2017 16:12:10.0344\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"711e4ccf-2e9b-4bcf-a551-4094005b6194","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"BN6PR07MB3537"}},{"id":1761389,"web_url":"http://patchwork.ozlabs.org/comment/1761389/","msgid":"<0a36b77d-d8b2-14cb-2ff3-2d61b206f856@redhat.com>","list_archive_url":null,"date":"2017-08-31T23:59:40","subject":"Re: [PATCH][aarch64] Fix hpwcap argument passed to ifunc resolvers","submitter":{"id":22438,"url":"http://patchwork.ozlabs.org/api/people/22438/","name":"Carlos O'Donell","email":"carlos@redhat.com"},"content":"On 08/31/2017 11:12 AM, Steve Ellcey wrote:\n> On Thu, 2017-08-31 at 16:19 +0100, Szabolcs Nagy wrote:\n>>  \n>> i'm not yet convinced that LD_HWCAP_MASK should be\n>> applied to ifunc resolvers: glibc might be interested\n>> in different hwcap flags than external users and the\n>> important hwcaps mask has other effect in glibc that\n>> i need to review.\n> \n> Personally, I like the idea that LD_HWCAP_MASK can affect ifunc\n> resolvers.  It gives users a single method to turn off some hardware\n> capability across all libraries.  I can see where finer grain control\n> might also be useful but I think that in general we are going to have\n> situations where a particular hardware capability is just not working\n> the way it should and so we want to turn off its use everywhere in an\n> executable.\n\nI agree with Szabolcs.\n\nThe use of LD_HWCAP_MASK is a bit of mess in glibc.\n\nProblems:\n\n* We have one LD_HWCAP_MASK, but two HWCAPs e.g. AT_HWCAP, AT_HWCAP2.\n\n* LD_HWCAP_MASK is used for multiple things:\n\n  * As a filter for ld.so.cache results.\n\n  * As a filter for multilib directory selection.\n\n* We already have sysdeps/aarch64/dl-tunables.list to select\n  glibc.tune.cpu.type.\n\nI'd just use the tunables.","headers":{"Return-Path":"<libc-alpha-return-84001-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84001-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"mSsxADAs\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjzrW2RrYz9s7p\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  1 Sep 2017 09:59:55 +1000 (AEST)","(qmail 96663 invoked by alias); 31 Aug 2017 23:59:48 -0000","(qmail 96649 invoked by uid 89); 31 Aug 2017 23:59:48 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=Co2oUUPVlCAN1YSz\n\tdYuhtNB3VyFcq+dGeEsS5X9oOA/Du58qxFr0bUDaLka1vZ36kfh1YRqAQ3RItCgr\n\tho5tsOYGsbocmUzb7T6ms5omCt2jUwwNXDzrg6FnW5Qkl+rhtBkXED+1YL8i+RPV\n\tgiyQQB9yFFgsxhs75vf/eSCuKJk=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=IKBpz0ftal/hYO3+naOwn+\n\tNLkUI=; b=mSsxADAsz2+I757YItSfEDUCR9pveOYDTefWPMHBHDN/tlXduRn1tb\n\t0OSi2YOdDz4s3vP2ySxRUl+Cgf9uqjw67J4B/ovxz8Vt2x3rW0l7afVQJYs8zWVi\n\tikRxq98gy4mvT2fANEdNGHqpvrZBOpMnjKLYYV9oO3WZUE2YOLSYg=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.3 required=5.0 tests=AWL, BAYES_00,\n\tRCVD_IN_DNSWL_LOW,\n\tRCVD_IN_SORBS_SPAM autolearn=ham version=3.3.2 spammy=H*M:2ff3,\n\tH*M:d8b2, H*M:14cb","X-HELO":"mail-qt0-f180.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:organization\n\t:message-id:date:user-agent:mime-version:in-reply-to\n\t:content-language:content-transfer-encoding;\n\tbh=2BLx6poolshY9sfW4UnT2G825vskop8XD7ZuhsgsTLk=;\n\tb=lexAfd/LPrb4ANjdrQQ9bYg6j4SdU0PhSxF4irXy9KF71YAn/ZYVvlspXotc2ya45o\n\tC2S7f8E2SPUFbX9jkWCUM+0NuRkV6jHHqqbW5GTon7udqgYl5UAsUM/FD3AFmAGNKnPT\n\tym36OXP52N8mVEhSf3yXB57fnUKmfGQJOXl7AeCASbHANEcmLeXRV9gcKilvBDtmxbBc\n\tr9zapDud2jnCioPxjleI72DWK/vaJll2jsqI/wyrA2dp8+wNlFp5dRd0oB0BqY7I7sJ8\n\tPNQmQjEjqVgzA9jdHZIIfKZ4Yw5nbswrlHwdVUUsxV8moibzwm2epAsDBl1b42Q+FAtP\n\t0mtA==","X-Gm-Message-State":"AHPjjUgJp4kvDqKTE16CsYtELnxTWtc18eHgZnhHPyZ3PtAdV9JRXE85\n\tJAK3zjXljtT6nuOl","X-Google-Smtp-Source":"ADKCNb5Hk9f43muxhXYIk72iznOQNPg0i2hPTjcFvc9iTHC4gNeYMauXGLyAzri9T+CREufKZpuTWQ==","X-Received":"by 10.200.25.120 with SMTP id g53mr218272qtk.323.1504223985701; \n\tThu, 31 Aug 2017 16:59:45 -0700 (PDT)","Subject":"Re: [PATCH][aarch64] Fix hpwcap argument passed to ifunc resolvers","To":"sellcey@cavium.com, Szabolcs Nagy <szabolcs.nagy@arm.com>,\n\tlibc-alpha <libc-alpha@sourceware.org>","Cc":"nd@arm.com","References":"<1504132534.3182.4.camel@cavium.com> <59A8291E.2060205@arm.com>\n\t<1504195926.3182.20.camel@cavium.com>","From":"Carlos O'Donell <carlos@redhat.com>","Message-ID":"<0a36b77d-d8b2-14cb-2ff3-2d61b206f856@redhat.com>","Date":"Thu, 31 Aug 2017 18:59:40 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<1504195926.3182.20.camel@cavium.com>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}},{"id":1761858,"web_url":"http://patchwork.ozlabs.org/comment/1761858/","msgid":"<1504286544.3182.61.camel@cavium.com>","list_archive_url":null,"date":"2017-09-01T17:22:24","subject":"Re: [PATCH][aarch64] Fix hwcap argument passed to ifunc resolvers","submitter":{"id":70332,"url":"http://patchwork.ozlabs.org/api/people/70332/","name":"Steve Ellcey","email":"sellcey@cavium.com"},"content":"On Thu, 2017-08-31 at 18:59 -0500, Carlos O'Donell wrote:\n\n> I'd just use the tunables.\n\nOK, I think using tunables is reasonable.  I seem to be having some\ntrouble with it though, maybe you can tell me if I am doing something\nwrong.\n\nOn a thunderx box I run a program that calls memcpy, which is an ifunc.\nIt then calls __memcpy_thunderx the way I think it should.\n\nThen, in the debugger, I run:\n\nset environment GLIBC_TUNABLES=glibc.tune.cpu=generic\n\nI rerun my test program and instead of calling __memcpy_generic (which\nit should) or __memcpy_thunderx (which it did before), it calls\n__memcpy_falkor, which is totally wrong.  Am I setting the variable\nincorrectly?  I don't see any problems with the IS_FALKOR macro so I\nthink the problem may be in tunable_is_name unless I am just messing\nup how GLIBC_TUNABLES is supposed to be set.\n\nSteve Ellcey\nsellcey@cavium.com","headers":{"Return-Path":"<libc-alpha-return-84037-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84037-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"ELqQfT8n\"; dkim-atps=neutral","sourceware.org; auth=none","spf=none (sender IP is )\n\tsmtp.mailfrom=Steve.Ellcey@cavium.com; "],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkQzg6WKfz9t2x\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat,  2 Sep 2017 03:22:39 +1000 (AEST)","(qmail 106512 invoked by alias); 1 Sep 2017 17:22:34 -0000","(qmail 106500 invoked by uid 89); 1 Sep 2017 17:22:33 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:message-id:subject:from:reply-to:to:cc:date\n\t:in-reply-to:references:content-type:mime-version\n\t:content-transfer-encoding; q=dns; s=default; b=ctWIh0vN3wrQSYzr\n\tltpZISYiaG2fF/Zy9GFNGhQfNRmszaNbwG/6tT6ioT79sCaUifceZnl4vYqaSGCI\n\taJ4OhnLEYFYKkvlJLLoqcUd7dMyxRtL7fhKNeSUKgITVQ5IaoPgDL79V2edWyudf\n\tSpona2k1leBOrj7Mr+wCyJJukNI=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:message-id:subject:from:reply-to:to:cc:date\n\t:in-reply-to:references:content-type:mime-version\n\t:content-transfer-encoding; s=default; bh=7n5GRhc/Ff02Dp5zZDua9J\n\tR4avk=; b=ELqQfT8ne8eJQ0BH7r4sg4uV6P04kaiMBqicE1FAu2eUYMjlN6zBRl\n\tZYbpSV4MF546lKaJnZoHUlqFWyolLWvuMPKmJN5aWooyhOZEihJ9sEhcq34s2I6u\n\tc652PbJimCnpwKNzdxRuutJxHyjKlanL5mX89MX1idJ43+jWL0Rvw=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.7 required=5.0 tests=AWL, BAYES_00,\n\tRCVD_IN_DNSWL_NONE,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"NAM02-BL2-obe.outbound.protection.outlook.com","Message-ID":"<1504286544.3182.61.camel@cavium.com>","Subject":"Re: [PATCH][aarch64] Fix hwcap argument passed to ifunc resolvers","From":"Steve Ellcey <sellcey@cavium.com>","Reply-To":"sellcey@cavium.com","To":"Carlos O'Donell <carlos@redhat.com>, Szabolcs Nagy\n\t<szabolcs.nagy@arm.com>,  libc-alpha <libc-alpha@sourceware.org>","Cc":"nd@arm.com","Date":"Fri, 01 Sep 2017 10:22:24 -0700","In-Reply-To":"<0a36b77d-d8b2-14cb-2ff3-2d61b206f856@redhat.com>","References":"<1504132534.3182.4.camel@cavium.com> <59A8291E.2060205@arm.com>\n\t<1504195926.3182.20.camel@cavium.com>\n\t<0a36b77d-d8b2-14cb-2ff3-2d61b206f856@redhat.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Mime-Version":"1.0","Content-Transfer-Encoding":"8bit","X-ClientProxiedBy":"MWHPR1601CA0020.namprd16.prod.outlook.com (10.172.93.30)\n\tTo\n\tMWHPR07MB3549.namprd07.prod.outlook.com (10.164.192.138)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"e0c6ecaa-0016-455a-fb20-08d4f15e04e0","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:MWHPR07MB3549; ","X-Microsoft-Exchange-Diagnostics":["1; MWHPR07MB3549;\n\t3:3eikATDFZz740TeK3jeXG7YkIFhw2wBiK8MkhLuMwB5ex3HdNOFLBRSGScYUHp4a/HaFk9w4inBHN+RY+T9trnKHZZ3X91N8mGqU07A+acHwIgHSxQX8COdHYXC5xFw6We27VpM0G5zTLvsqEQuznAtCSUW9cdDXM3ejb5cxbPxmw8vigpeEij/sKo9SK3hVK0VvpzCU3lV7MOBI5de7rTp5drAxiXJW/l5UOWhnGz14dC5oyyNPhatWQtslGHh8;\n\t25:zEox6sL3ph7MOxRpO4oFzDGThkZifxArG6vvOGRDwBHLRkqN7kiKeAPZdMhiHBnhCDpeGbNngQpm6z7/4jhtDWLxv5ojvmxI5pGV4w/Kn8JgdAo3UiATSWFjz5DCErC2mRXdaP+cW+cVQMn5vfAoLNjJikqm7yWOThhc4Uar4OMHeFizPiYEU7qNIWupk8G0AiyoE5Ri6eyeJqkRwQZw2VvZkzvXStBwC2AFFRv48lmKYRJKfiOfKVXPc9liyLieYM/1SMKHbRCpdgJlTzsMg0TQiz2G3Lm7t4Nrfb7gG1oKLIdOG21oRHzREsqZLGd0S94iGKZbuteIayYVf6QpUg==;\n\t31:IYtcz+rHFROBiUubcC9AGvljJ+u2J+3KZD4V6laerTUs0hBSpaVFEIzGTXlfbGoNFtw+Lu8JhiBmpI3wEETv/NK6DkEmT5VklbS8mNBgo9UiQGs8v8zPHJ9fYr/XX5Je1UWadVCnYB5hSuTAiTbf7RGYbG1CHO5OTDLQzYM6L7Tt37eeUNONRkrfH2k0Ei46StizhjU6MtDs6Mmo/cukXP04Y8X2kCsu+AZyNkd7Q+M=","1; MWHPR07MB3549;\n\t20:/tvgm0ICup6avpy60Gi9CeGSyu0OCYCXcGtZOXyovUb8ow0XQkjsqTVqqXsFR4Rb/XG0fXxrAYhkA9l2e1D0/YV9DM4Vwd8gTMv4XdLALHhox7ou6eCU89Sz5Q2YuJSllBV+l2P7aiHYPG5eTN3hq8vy9nla2FtPtSWR0ICnfUYVPKqVF27Syf1o5CAxQ/nRweYWg5+WIGtFymPmqGPNeji9Nj+reLNCBrDRw6Q3iJXx6vABzjMtyJ2AtcKYtyS9rrX8iu5MAdHWZ8mevMpGOWkO5V/awPdiBfNQbJqBgukKipt1TqMCrh4ng/+kPbdGQDzWvkrh17YTAnBDerPuds5ea+97+uUXujJ8r+2bD34XSktduYFJa2AsssktIxcMJsheEmSb1RyIvHqWpaHN5QaCZi8KG+aECTSm/k/5ekp4gvSQv+vaG+iHPrtITiwgKzDKLwdsL1VfNupCq56l0coP4/tUaIjqNxN+Wdy4O414GcjPntoBe7baPi4+dWE8;\n\t4:0edQWWazcWmh/zWeoeC8eJ2oTQvp6l7zzobcO41ew+byZbt19Dae0yHyzq1hGiHzuMK0Z6oYMUwWHkmAkXRWkPWlMmr/cdB2a7T1eddV9YqyLRnVB/PlPf3Jgt/w5/Q1LzhQb51jaFBjWIacvb4gYm88q/joi9Gbmikj8Nw2qD4tQRV4ATj4XzLZqoiuUJu8cQR7unBHyhvBmE5Pvc8okCdqB8TffSWtbu41JWY+M4xElB/86GpA3C9DAj6XzPP8","=?utf-8?q?1=3BMWHPR07MB3549=3B23=3AGEn5?=\n\t=?utf-8?q?xd648DG8rohAvPr7CSyqDr+6/v5JGV8nXC/3CgoY3iPdvw5kquMTvtYe?=\n\t=?utf-8?q?vVJP7qPyHh0pqD0zAcI8nrNUlC9l9MO8FH5qCBAMAsAwjRQxkiU4IYre?=\n\t=?utf-8?q?s7pj3yVmn0Gzak9fen7vGYmtUnw6GRXqxgVKpYRecW3E+hGTNsoCE7xd?=\n\t=?utf-8?q?FVZOco26ytwyX31e1VMPFpVBz9dKSQboNdaXiIrXVjWRjEehAkyrNm3U?=\n\t=?utf-8?q?816+hzE+v3zmrGYXUAIri8nwXlYQwRqA7cekYWg5+K3hlikKsGKEbZ9y?=\n\t=?utf-8?q?YGsyZjHtZzDm/CUrkDC2cBF58/Zd2a5ox6M3Ot0MKDnupKYyXAD5h3Md?=\n\t=?utf-8?q?vpZwrSeTjNv5KG3f03imu0ePiTyyCbcMBBwZ+XP5QauyNgNR32N0805M?=\n\t=?utf-8?q?6HhfBTkcjubA7NWDiZlOgSRfpqGrrg2tOs22qNC6XkJlrQy26AmT/7xy?=\n\t=?utf-8?q?vGLJ/ts8vjTIdM/VousO/ADF1UkEXwfuAJLvGoR2lRzhCbtrZgHxEq/+?=\n\t=?utf-8?q?HNEzMBtdmfR///xGNrBeeDnPrRd96+mn5UVq7LmmgHbH8Ax+jgpEkqs/?=\n\t=?utf-8?q?pvg6wtbM7HGOPGnrimhaed3GeINaQMXs48U6GUPC2yQkxxG1RuaVess+?=\n\t=?utf-8?q?OC+50z2ZOKvIkorPTgY7Jw2xKYd8WJPz7fbr6AEoohaGssK71iuXbJHv?=\n\t=?utf-8?q?rpPFHGj8BvCe33Fvo2YhmMIDwcZrs79qXbLVTbOmug6tZEx8XNKr7SKK?=\n\t=?utf-8?q?r+EZ/wLvL2hRreV7ifeBoBSm9Hnv2bVm2R61dxJX08siKzlihKKErgBT?=\n\t=?utf-8?q?zM3QG9j87yHs096QgjC7tyWrONQU4FcQQuyOpto9JMqFxhMCVKUmYXKW?=\n\t=?utf-8?q?X6Mr5RIdwkHe3pTc5TXZBJFBHgEX3Q3rXYtQut6mxIQXwvqMwfoWg+ZY?=\n\t=?utf-8?q?PBBh/WCvESLg5GX+P+1qP3xBm/ChiT/7nlcp5eFC22vRsWCznovmKQV9?=\n\t=?utf-8?q?ndB9KrTuVbNDJPV3suO21QKqJ0dta6CLeS/IbYck6aqEtpAXDvLvn1oy?=\n\t=?utf-8?q?vy8sCJU3dRTOVLdF7kzgar3BXP6vxf/xBkpOckRnbxZL8j43i/twjxLU?=\n\t=?utf-8?q?hRpOU2CxmkJbs0IgLRC8IbTn4vxt9fGH0QDdWJMF1s33I64CeunoQnth?=\n\t=?utf-8?q?ITovo+rmDs1vi9H7i3djmFmAXfOUa8ep+wbQUNrJQakh+4uE5Q20vQ4U?=\n\t=?utf-8?q?NUeDVpEA4VOxf1m1sqs5bDQ3i0hxv4KGdF9tOmtWOAg2awFQChpNOzhE?=\n\t=?utf-8?q?TA=3D=3D?=","1; MWHPR07MB3549;\n\t6:JuZQzBLfKX5iDvjNTHC6lhJWJ8bFg6U7lSCKRh/rn2r7qWGco/Udh1OeBnTAUkrHR5akb6drOqLCuBVIQnJ/fXhh/neBa2+kUibBs5fP4rq1b9SZ/18gCOEtgs5ho32NhrfJCbXf0jfDZIPfD0EOPDGEJ2qabyBlEpgopt4qSEsz9c70Qa0WsrNabSHDvSoFKK3Y7UT2LeqJd+8KPdCfTJoadKgTLFQjmnIzV1Gg8GuC7pDDiWkW3JeDoWj2hvSdryV93RXDlOma+Q+R/jeUZWIDnU/KtwU3cfW5kEumpFbkqAPPQTfZ9wKw5UrHg0YmwOZN7e/7gcAeNIOY2rknXw==;\n\t5:368Y9xMajYd8C8Fp7D0mzrGg8Yb5l58zFS1sRa7AxsrYEi59oJsIXHB7ewWvY7sv8tx0x6MagbJGVUbtugaQlNAgHgkARQM9X8DSSngkCMANUpAxCQUxXomeMBTlf2UapczcksQFkqq7eTCw4ROs6g==;\n\t24:GXWSsBUkev6XHKWSRp79orPmyUkzlfKxa98JbI1WkmnBCY/9H/WzdjTRPinmLVzlmJOcxi7QXrWfyYSZ6STD6LKvkH58n81vLQQhdvmCQwM=;\n\t7:kll1y7vRQni0w355728w0JijBxe7l7W5/CHjjBr55zfnGIeaKJNBQHDpa132FjPgLzCjpqKwAQWT9bWeFPc2EqhSeysg1fyAyoRVZaTWBwEiDrFBQyduU3i3Hww5xkz6ooD/SDDUHooOElq7EdlgFLuLBCMYkNDKBc8+YLYXzFrA7LJcssIsHfIl3uTUDlLM6gx0KRkw3Ykr2CU4hzkcOSMEOFn/fZX5V1eeB3Xp9VY="],"X-MS-TrafficTypeDiagnostic":"MWHPR07MB3549:","X-Exchange-Antispam-Report-Test":"UriScan:;","X-Microsoft-Antispam-PRVS":"<MWHPR07MB354992F1C8AAC662EC110C91F5920@MWHPR07MB3549.namprd07.prod.outlook.com>","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6041248)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:MWHPR07MB3549; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:MWHPR07MB3549; ","X-Forefront-PRVS":"0417A3FFD2","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(189002)(377424004)(199003)(24454002)(7736002)(5660300001)(23676002)(53416004)(5820100001)(97736004)(8936002)(42186005)(8676002)(6512007)(3450700001)(305945005)(69596002)(93886005)(478600001)(4326008)(50226002)(53936002)(229853002)(72206003)(33646002)(2870700001)(6246003)(47776003)(2950100002)(66066001)(2906002)(25786009)(6506006)(6486002)(103116003)(189998001)(50986999)(76176999)(36756003)(81156014)(6666003)(68736007)(106356001)(81166006)(43066003)(105586002)(101416001)(50466002)(6116002)(3846002)(99106002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR07MB3549;\n\tH:sellcey-dt.caveonetworks.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: cavium.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"cavium.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"01 Sep 2017 17:22:27.5280\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"711e4ccf-2e9b-4bcf-a551-4094005b6194","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"MWHPR07MB3549"}},{"id":1761863,"web_url":"http://patchwork.ozlabs.org/comment/1761863/","msgid":"<1504287041.3182.63.camel@cavium.com>","list_archive_url":null,"date":"2017-09-01T17:30:41","subject":"Re: [PATCH][aarch64] Fix hwcap argument passed to ifunc resolvers","submitter":{"id":70332,"url":"http://patchwork.ozlabs.org/api/people/70332/","name":"Steve Ellcey","email":"sellcey@cavium.com"},"content":"I think I found my problem,  tunable_is_name returns true if it matches\nand false if it does not but the use of it\nin sysdeps/unix/sysv/linux/aarch64/cpu-features.c is:\n\nif (tunable_is_name (mcpu, cpu_list[i].name) == 0)\n\nIt should just be:\n\nif (tunable_is_name (mcpu, cpu_list[i].name))\n\nI will send a patch for this once I have tested it.\n\nSteve Ellcey\nsellcey@cavium.com\n\n\n\nOn Fri, 2017-09-01 at 10:22 -0700, Steve Ellcey wrote:\n> On Thu, 2017-08-31 at 18:59 -0500, Carlos O'Donell wrote:\n> \n> > \n> > I'd just use the tunables.\n> OK, I think using tunables is reasonable.  I seem to be having some\n> trouble with it though, maybe you can tell me if I am doing something\n> wrong.\n> \n> On a thunderx box I run a program that calls memcpy, which is an\n> ifunc.\n> It then calls __memcpy_thunderx the way I think it should.\n> \n> Then, in the debugger, I run:\n> \n> set environment GLIBC_TUNABLES=glibc.tune.cpu=generic\n> \n> I rerun my test program and instead of calling __memcpy_generic\n> (which\n> it should) or __memcpy_thunderx (which it did before), it calls\n> __memcpy_falkor, which is totally wrong.  Am I setting the variable\n> incorrectly?  I don't see any problems with the IS_FALKOR macro so I\n> think the problem may be in tunable_is_name unless I am just messing\n> up how GLIBC_TUNABLES is supposed to be set.\n> \n> Steve Ellcey\n> sellcey@cavium.com","headers":{"Return-Path":"<libc-alpha-return-84039-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84039-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"uION4gG/\"; dkim-atps=neutral","sourceware.org; auth=none","spf=none (sender IP is )\n\tsmtp.mailfrom=Steve.Ellcey@cavium.com; "],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkR9G15RGz9t32\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat,  2 Sep 2017 03:30:57 +1000 (AEST)","(qmail 21233 invoked by alias); 1 Sep 2017 17:30:52 -0000","(qmail 21223 invoked by uid 89); 1 Sep 2017 17:30:52 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:message-id:subject:from:reply-to:to:cc:date\n\t:in-reply-to:references:content-type:mime-version\n\t:content-transfer-encoding; q=dns; s=default; b=O2VXD3uhXQ5A+lqX\n\t1re9d3zVeYbahNnW+OKrgEhKbfsZ3G5sB0TaM46RuFEZXMj++3ZIeAOHjpsOS7Fh\n\tUF/2oEFC9qcCkjOZ6iUVwBq0NbDhRMV8iySaRc5dUMofjymp77McBqps2J9G5FdR\n\tnyNI2hOesKCpDFcddjqBVP9hRgE=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:message-id:subject:from:reply-to:to:cc:date\n\t:in-reply-to:references:content-type:mime-version\n\t:content-transfer-encoding; s=default; bh=3LJ2tR4+WNs982Oh3qmlMa\n\tcukx4=; b=uION4gG/XEG+ygijiWPmJejF/YffU4EStvWY9LgCxr+JCqbuY4jtE7\n\tKGJywdW7kNJ5HXtra93juuJCiYKRDLeL1V/o3ABUIpVjMpYCshqpK9KMONig6Hsp\n\tI9W/r+5h7VyQsuL9RLfgmNU7PV74xTmFPGiOay65m77QOdMofRQe8=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.7 required=5.0 tests=AWL, BAYES_00,\n\tRCVD_IN_DNSWL_NONE,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2\n\tspammy=Hx-languages-length:1422","X-HELO":"NAM02-SN1-obe.outbound.protection.outlook.com","Message-ID":"<1504287041.3182.63.camel@cavium.com>","Subject":"Re: [PATCH][aarch64] Fix hwcap argument passed to ifunc resolvers","From":"Steve Ellcey <sellcey@cavium.com>","Reply-To":"sellcey@cavium.com","To":"Carlos O'Donell <carlos@redhat.com>, Szabolcs Nagy\n\t<szabolcs.nagy@arm.com>,  libc-alpha <libc-alpha@sourceware.org>","Cc":"nd@arm.com","Date":"Fri, 01 Sep 2017 10:30:41 -0700","In-Reply-To":"<1504286544.3182.61.camel@cavium.com>","References":"<1504132534.3182.4.camel@cavium.com> <59A8291E.2060205@arm.com>\n\t<1504195926.3182.20.camel@cavium.com>\n\t<0a36b77d-d8b2-14cb-2ff3-2d61b206f856@redhat.com>\n\t<1504286544.3182.61.camel@cavium.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Mime-Version":"1.0","Content-Transfer-Encoding":"8bit","X-ClientProxiedBy":"MWHPR22CA0040.namprd22.prod.outlook.com (10.168.250.154)\n\tTo\n\tDM5PR07MB3548.namprd07.prod.outlook.com (10.164.153.146)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"725c26db-92fc-410a-270f-08d4f15f2d41","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:DM5PR07MB3548; ","X-Microsoft-Exchange-Diagnostics":["1; DM5PR07MB3548;\n\t3:Htvhvh5lIhTMvXRSkXh/0LDc/yEnDb9+086H7wDz/jFNX86m1bfpQqKdxBSsjOr9M7apA+0tpwtTcSFELy3GBoM471tO3Es+nd+TS3kDMOSI8A5ofUhKxFLBavf/v2CVmeg5mM1TtLMspm+UIfx/MX/MjYYf0hA2yS++bKHn0unJ+8UtGhLqdnTGC5sUavf4Mlab3NbmdHgSl4lsmXaU9EXtp8fieMUej9h8mKm+0zrGSvM6zNi5Af1WtY8ATiHi;\n\t25:pzRPQtVZst9m6dFV8VZuuT+80tvEtwX6Pb71K7MLz7XF91MN4Cm9OI3dKpky6h4PsIhgK3GEbCJd9aftzMdUxDzvH8KzCY1F0bzvTccBvZ9YM2dX/25l7ZPnDisdnLIjRd+JGrXZU11A6rcI5y3UICnefj7M3AS+JIhPgwMVGauGimF3E8d9VfaPAYEF+lrqH6A3iBB50iDfcTFhsdav5BYQSYKhpGnUunc6m10VN6jYER/BgjhXNvLVT9TCL+TF8tf2qyI7krwHdhY07qao1MocsK1lyU8eF6evALIPJ9fOAYhWIMsgVz1IY0MujWQ9O6U3F3khqnFstZxlMXKrOA==;\n\t31:ARyS4adMVGVFXd/+KwFf+kWakQ3Ab/xOrB1+JNb4vQzHjul7fgaJSIPVIeXPd6NaZm4HQsMeRnkv7H/Fhd/1CvRYKf6D8SoLqsqMZhHvE/XLLQ+1WiSdn3d+hVkl5J+aee6TTSIgu2XVHMj4IYmOmedXProVhE7VA8ZtaVZKQzgi9gQKwVlSBbnn1jVZPQ8dMRnP6a+4JkKO1ze+O1e0hK1UQAijGM+ER3n9HM34S2g=","1; DM5PR07MB3548;\n\t20:Cv862u3VrwIyGqNs3zVIDn10Cs8ZZt/uZiJEXQ2/UEAwIEpykvmpJ24/rcAX+jvF8pdCMBJx99IH8sWBHSQ1j15uFBNZWtrMpM8bCeDg9LRhK+8A1txB2Mhbxco3YfVihCwTJKi10EmEnXUNp2mBTax8s0MAu4pd9j0eKwQBZd98Qy4EHEWhwV2qMySH/Z9Uyul0TsiEjCHYUVfOkmkuQeDe9+MLim/OfQoxMQXqTszZtZ9EpFLehThNM/TvK1LzlcJXEwpmy0YUOCmVHNU4BgvvWZca3Jgojoq3KGhooSxrnrhEP/t9wYAlOEdUKkmrinTlkXypCeWpkZf1nPT9+dsN9cc7i3++Dl3688rHV/QHq6YwOnFU3jMiXkFJnFNq1oF5iFZ0jndRcCdMIPWgmulMi/x64syMqXnpq6nELEeCC1ET26pVXIbdzmfh5zqW4N6lz944cqSlBTA6hiTm1cmOaaydLSuBiZRApvWzZJjioeSl82XrVDL6bKDmitLV;\n\t4:SKD6aAeDXHuCmI8g0qe0i3LpB4UFb4jISwKgrKM8Z/iPh/6V7geVU6ib+StrcGwVwcW0bLfizvjjVbRr0LXoZP7zcqlXc2SBYIdNwtLrjc2ufDcRCD7npsZdBCvGWWHeZ232l5jmaB/n1tFx/IT/4ued7EO0JAUhX456m/qSl0vSxGApYu1/ICn9t41cA3dNiYuB1HSfeiV4S2kOgq1kqW6Lh2AZu3c+bnnwUDUqiGszv5rFxtRXhiKlvA1xxwm8","=?utf-8?q?1=3BDM5PR07MB3548=3B23=3AWnYI?=\n\t=?utf-8?q?bTbDs4b3zhaJ9RRePAcfhuvtp58hfcPM3O02XS4y7t5pk5XuKA+2k0FL?=\n\t=?utf-8?q?ZRWhzP5tBT2wFSz/mAQ0FWimZeJjo9lSbWwgEcxDGI7vQsP91kVDiuT5?=\n\t=?utf-8?q?n1pb8rao96PQADyMxZvwwqxD5D+XalYCvPCgbaccSDht+mRfPHORqjU2?=\n\t=?utf-8?q?pu54znqFvi4XSn4vvRqoItukOtFnM/WTGj8Oo6UwaQrxgZlab4sQTfJY?=\n\t=?utf-8?q?Y5Ngg3TiDoOSEJLsbAn74BEyvSKye07n3HczmQ+iO4lSX5oGUAfsgwId?=\n\t=?utf-8?q?SdnHqJepN/WYnDio2PVkRhw4vfNjuLXlIZjSeueVkdSx5HCiMz+mRDyB?=\n\t=?utf-8?q?Jel9o16JltJgVmaqmgm23bsXrwS+VdcL2kIXov5LWpk57uFQ3ITXNzhn?=\n\t=?utf-8?q?28cTypsDz3Yaur6CWCXPCKtfLB4BSE3OYW8GiKmHAdFnD2NRTpUHK7OR?=\n\t=?utf-8?q?d4AdfD1hQSuYvVkdcalcIEK0PIFXh6hE9/eSm2uG38e7Z2w793PoCWR5?=\n\t=?utf-8?q?1O3myYPsDai6N6LtqstQGAbIcO3YMXPcoamcDMg2TfaVXY77XZs4gEdk?=\n\t=?utf-8?q?QtlkHUU8GqTDkADizlO57l1S71JYlM+5dD4lvJRMYlzSRpYlRUNRkwHI?=\n\t=?utf-8?q?3LgqLx3FctjTUQHcEC/jxRf3ATtyCzq3MRgT2pA+BXsyv9RY3F/QmVB7?=\n\t=?utf-8?q?L6j9tIdWh7rz9dcF4XASzhn0aE11iPMa+dF/jbDtV3AtpURh5c2fgzTr?=\n\t=?utf-8?q?HmsD/km9XHij9wGg9tAxvN2Cq0o5IYUtmCVFvX29prk4zkD5FBSjLNYC?=\n\t=?utf-8?q?qXs1fen+BTWIBvDelTdDxuRO/UsTFBdn5IE2VSXQC+Ze21o3P4hWBWSf?=\n\t=?utf-8?q?Cn2tCg5RCjlg+I5GlUGrVpZeFP5wHXl06J2RY2Pb2BdLojLIVY4fyS41?=\n\t=?utf-8?q?XXBWoNnUBlaVmy9meFSo3uTlvZi2hajkIrUcxN0Z90shH/1fz23zQjSj?=\n\t=?utf-8?q?M6s3IgIg8QDc0zTL+YkW3xSquRPmb758TbjmS9dsbIHPu/Ap477IQlNU?=\n\t=?utf-8?q?M7D58tdg4UCGaV+dcUOwr/LiTEJ7JQkQrHr4Ux6VzwE7lReXkFqiBr90?=\n\t=?utf-8?q?FxchJ0+H7EnfMfWxNN4yejoyDmzgcdLWP4UMxDOWanwK5ZOXY/KgioD7?=\n\t=?utf-8?q?EfxWDloK0mz4HmsGFAWQKEHugquaJOXl8Nu3YFGjCgDOrkCUkMxtbUfm?=\n\t=?utf-8?q?ia7dsdUoY+IwCbkqDu4MlJ+w8/M9Z9TTyiqxnX8fdErSxElpjNjDZsFy?=\n\t=?utf-8?q?LA=3D=3D?=","1; DM5PR07MB3548;\n\t6:o1V1NHhVIrOBlVv/gmeo3lP8q0+DUB2Ll2LFpd1t99Yhqrg91QLXKV8ZhrrThJ9WEOT7X4A45THpvns9mza+B2x6h3AEgaZuql9GxQrk2oMEQSRR9gdgl1SJ58bA/K7Kwg5gFcKubmJFUiIOWh+c0RBaYUp47f/2TAtQHq34QydjjH1N7tzvMPXmg4rc6piwgDuKSFmhgq8hPhdQxyATrP1wJcAcii+Zep0sOEvKh3b1s6tK60AtP6WLD5nt5Cr1cHrI9JDi00Zx14Z3I6F46y3NbeQ8XeBP2bppyKy57vbPuvzaOBUKjRvA7NoZ2YPgaEiApVZUaXat4gNjhwOyMw==;\n\t5:1HbZyAB1IBJp0DiniN+8uy3GPHk+LiLCaDFa+tI86jzHjhDZ93lFR8UYalx0DRzKaSvAGkkMtTLpwQ4p6vjfqmUXvblgODZXlkLGIiarYFXKY6XJd+1ybdUaH8AApbBt5vE7xkAML39Fi+xUsgRIGQ==;\n\t24:B1hplMV22WGizJvtyzQgUhFEORBKesODO2yzt/9ZA7X4R6uO6hAztlJoOUhCxYBaGPmZ7peK94+ZA/15jRAbtCcWxg6yrGw3s9Tz6csvhV8=;\n\t7:gajltl9DvlPjxh463OE2bv6nMKLAvz67EzQl14sZots1qevQShsIp4FDTx8nztB39OA/wQT32ym2gg1fjSsmpc2MoPm9VVtWIf07dOTd4Nrado6Y5f36UwvbkOWbUYqCjkjPynAmg6rk3m1RtMHVECZaTcPLnSwzAysshU+2tNGWpQR+ely6oLINCv4A4I1CPzWyo5Shjad8O4eINQDuUEVePlNx3Jk+imXcaaRCdQ4="],"X-MS-TrafficTypeDiagnostic":"DM5PR07MB3548:","X-Exchange-Antispam-Report-Test":"UriScan:;","X-Microsoft-Antispam-PRVS":"<DM5PR07MB35485A4A7ACACB390C9F1D6BF5920@DM5PR07MB3548.namprd07.prod.outlook.com>","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6041248)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:DM5PR07MB3548; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:DM5PR07MB3548; ","X-Forefront-PRVS":"0417A3FFD2","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(24454002)(377424004)(199003)(189002)(93886005)(81166006)(25786009)(97736004)(81156014)(33646002)(8936002)(2906002)(3450700001)(68736007)(50226002)(5660300001)(2870700001)(101416001)(229853002)(6486002)(2950100002)(69596002)(6666003)(8676002)(43066003)(72206003)(6506006)(478600001)(36756003)(4326008)(6512007)(50466002)(5820100001)(7736002)(23676002)(305945005)(6246003)(189998001)(6116002)(106356001)(42186005)(53416004)(105586002)(103116003)(47776003)(53936002)(66066001)(76176999)(3846002)(50986999)(99106002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3548;\n\tH:sellcey-dt.caveonetworks.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: cavium.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"cavium.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"01 Sep 2017 17:30:44.5607\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"711e4ccf-2e9b-4bcf-a551-4094005b6194","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DM5PR07MB3548"}},{"id":1761917,"web_url":"http://patchwork.ozlabs.org/comment/1761917/","msgid":"<a8ce671a-717f-2589-f472-1827530e854f@redhat.com>","list_archive_url":null,"date":"2017-09-01T18:55:16","subject":"Re: [PATCH][aarch64] Fix hwcap argument passed to ifunc resolvers","submitter":{"id":22438,"url":"http://patchwork.ozlabs.org/api/people/22438/","name":"Carlos O'Donell","email":"carlos@redhat.com"},"content":"On 09/01/2017 12:22 PM, Steve Ellcey wrote:\n> On Thu, 2017-08-31 at 18:59 -0500, Carlos O'Donell wrote:\n> \n>> I'd just use the tunables.\n> \n> OK, I think using tunables is reasonable.  I seem to be having some\n> trouble with it though, maybe you can tell me if I am doing something\n> wrong.\n> \n> On a thunderx box I run a program that calls memcpy, which is an ifunc.\n> It then calls __memcpy_thunderx the way I think it should.\n> \n> Then, in the debugger, I run:\n> \n> set environment GLIBC_TUNABLES=glibc.tune.cpu=generic\n> \n> I rerun my test program and instead of calling __memcpy_generic (which\n> it should) or __memcpy_thunderx (which it did before), it calls\n> __memcpy_falkor, which is totally wrong.  Am I setting the variable\n> incorrectly?  I don't see any problems with the IS_FALKOR macro so I\n> think the problem may be in tunable_is_name unless I am just messing\n> up how GLIBC_TUNABLES is supposed to be set.\n\nThat looks right, you'll have to debug this to see what's going on.","headers":{"Return-Path":"<libc-alpha-return-84109-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84109-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"ySveA7k8\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkT2r4zmTz9sPm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat,  2 Sep 2017 04:55:32 +1000 (AEST)","(qmail 36665 invoked by alias); 1 Sep 2017 18:55:23 -0000","(qmail 36653 invoked by uid 89); 1 Sep 2017 18:55:22 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=y3l9LgKMUdtxZ9cD\n\tIgmaMQWgR1GHsG94my89GoNAx1YCydkPCrfFn8p/EcnQl9fBfgbgRJitHidH5Sag\n\tAkU5LE0Eb11pDt06qCzHAvzTmTbUK3Ac1UoGSGV/oY0GqGkfYGy15LCLSaATasvH\n\tv7M/vj4GX28VLvgkKyI3FVFqiZI=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=cAEP3F+TguSjqpmxgpFxmE\n\tJl4tI=; b=ySveA7k8tPZLgGR5Lx9+GH1pL+lSGJpGJ+/jWnabIbdd7T6fUMu4hQ\n\tTE16Y/KMDrNNAW8O/V1YjxgWbXz2mCyQBcOFYSGGVTkCgid37Gni5ybhQfP1BM9h\n\tP1bEpCIH47pGA9ESrjGNl7VOQNHMx1q+AT4+jRSaKDvPJg8zz50PU=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.4 required=5.0 tests=AWL, BAYES_00,\n\tKAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy=","X-HELO":"mail-qt0-f181.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:organization\n\t:message-id:date:user-agent:mime-version:in-reply-to\n\t:content-language:content-transfer-encoding;\n\tbh=x288rzqGx8tLXq2ZRmjV/S8ESkPLmSAbKcgiPN0v7LQ=;\n\tb=q9sRAGrLlBfflZt6mKSTvPAeaqhPG/KAsxJAwgjZxnehtuU7dHcPNvBC++bSLOAtiq\n\t2Wd7h9z1pFb327gXjrehjDnSJFrNq6NB0zhpfj0EZ6CPlBnTRj6Owx6MM4VXQfiJ9l8W\n\tyVy5omSy2neLShb/1X0wPMkNGz8MOSD+1xCgqcsF3fVjlcLdmETnUDMmy7YkxYKzvrFf\n\t4wX5lcyCUFGEuw7iBAS2qkzKEXc8mKL2n6bB+5KYoqLSdHoir9OHIUWpBsStXR4z5nxG\n\tFE5nBBukFQ1HvY0hRIMxwt3Prxp0Q21BdeVtk+sANYVIivEeptaIOgSq0LreUP3wMpZi\n\tDBRQ==","X-Gm-Message-State":"AHPjjUh/13mCrRAnrrYdwFzhTaB0K6cmZjAl0HrrNE4JPc/znZRh1/mG\n\tiJslXvglpDUObhLx","X-Google-Smtp-Source":"ADKCNb6RSaptqcB+fg33NqKDR54cAw+URxJG2DDSeqrLIs5mTTP/vQ/pGv9JcBdIsIqLwvPp8Rgy8w==","X-Received":"by 10.200.23.74 with SMTP id u10mr4549638qtk.128.1504292119981; \n\tFri, 01 Sep 2017 11:55:19 -0700 (PDT)","Subject":"Re: [PATCH][aarch64] Fix hwcap argument passed to ifunc resolvers","To":"sellcey@cavium.com, Szabolcs Nagy <szabolcs.nagy@arm.com>,\n\tlibc-alpha <libc-alpha@sourceware.org>,\n\tSiddhesh Poyarekar <siddhesh@gotplt.org>","Cc":"nd@arm.com","References":"<1504132534.3182.4.camel@cavium.com> <59A8291E.2060205@arm.com>\n\t<1504195926.3182.20.camel@cavium.com>\n\t<0a36b77d-d8b2-14cb-2ff3-2d61b206f856@redhat.com>\n\t<1504286544.3182.61.camel@cavium.com>","From":"Carlos O'Donell <carlos@redhat.com>","Message-ID":"<a8ce671a-717f-2589-f472-1827530e854f@redhat.com>","Date":"Fri, 1 Sep 2017 13:55:16 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<1504286544.3182.61.camel@cavium.com>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}},{"id":1761918,"web_url":"http://patchwork.ozlabs.org/comment/1761918/","msgid":"<af17f8a5-5d87-6879-473a-126b7a1ef339@redhat.com>","list_archive_url":null,"date":"2017-09-01T18:56:42","subject":"Re: [PATCH][aarch64] Fix hwcap argument passed to ifunc resolvers","submitter":{"id":22438,"url":"http://patchwork.ozlabs.org/api/people/22438/","name":"Carlos O'Donell","email":"carlos@redhat.com"},"content":"On 09/01/2017 12:30 PM, Steve Ellcey wrote:\n> I think I found my problem,  tunable_is_name returns true if it matches\n> and false if it does not but the use of it\n> in sysdeps/unix/sysv/linux/aarch64/cpu-features.c is:\n> \n> if (tunable_is_name (mcpu, cpu_list[i].name) == 0)\n> \n> It should just be:\n> \n> if (tunable_is_name (mcpu, cpu_list[i].name))\n> \n> I will send a patch for this once I have tested it.\nThanks. This code is quite new. I expect this was just an oversight of\nusing the new API.","headers":{"Return-Path":"<libc-alpha-return-84110-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84110-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"Q/AW200O\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkT4S3JxZz9sPm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat,  2 Sep 2017 04:56:56 +1000 (AEST)","(qmail 38762 invoked by alias); 1 Sep 2017 18:56:48 -0000","(qmail 38744 invoked by uid 89); 1 Sep 2017 18:56:48 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=OkdMPJ9H5lXAx0Vx\n\tKxnw6TgSKp/ueBCG5VJbQLivBSW2QAYcNN7jtD0WbYPGV5tXqCaJRbP4w4wgnOb0\n\tj1Kmz7YfdiELqGosdm9b8QeiSAKj0R7fEG1F5BaSFSEa7IelKDnUxWChwqE2tST/\n\t1z7jkazaFywe4VlroBYdHxch5rY=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=0hdCfL8fED8ASAszy6gYWg\n\tT9ivU=; b=Q/AW200OFTjcGjNKXUc8gYQk/50FLy4xFuymXKj0A9VR8xpCAkfpzi\n\t1sGYNhbzkVTycLPmKvaY8IvwxYzEFk8CDioxfA3kDvVEx5YQwQwBrEUQgO/dlt7h\n\tyWtNHw69JZSyjPqwRzS6ZhPOjam10Q1iRZB/4ahIArbUYNIEvwgb0=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.7 required=5.0 tests=AWL, BAYES_00,\n\tRCVD_IN_DNSWL_NONE,\n\tRCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy=","X-HELO":"mail-qk0-f169.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:organization\n\t:message-id:date:user-agent:mime-version:in-reply-to\n\t:content-language:content-transfer-encoding;\n\tbh=JsgkuINXsPx9FLqgtY6QOuAIw364bHkGvxFwPUI7Rck=;\n\tb=fMmt0RETiJ+IT9gzg2uYhX/CGoFQYhFS7uBlKqRrClzN5WQB9ZKqH7L07r0TvrE138\n\tr7WJ/0xl9yA7yZXwEyw7LyED2+FC3Sq5jCUgJqDX9glqGl1UWJ2gkM9wrAjbsOgDilpS\n\t952mZ7PtfC2zBxupDwDFk1NP2Fr95HqIQ6aKneNLpwl8BWGEr5WevhXkgBbfKkwoQyb7\n\t6P4zZdLBzxmYLupkQxCaubJa89M+3i1IT5JjCszcW+8M3ABTNWOGwRGv4VvWEmaMpORe\n\tca8qqiG/LW1/dd2fJ0mozwQdiCc40PDGcO4e09OKdFJMBjzNO+AAypj3gvF1jBuQs8JZ\n\t7fqw==","X-Gm-Message-State":"AHPjjUjpB0GyxeKxMjBlWMhuwmaq4mK9z8lACTaHrraq+lavcgDiEr7g\n\ttXkDDwLW2mYxumZM","X-Google-Smtp-Source":"ADKCNb6AyYXqdnwRn0qKamiEJqm8tFZC+IrIqArO4Mat6BGUgjL9Ijj2iLgcOx9NO9laK9Upwso5zg==","X-Received":"by 10.55.27.3 with SMTP id b3mr4120598qkb.328.1504292205126;\n\tFri, 01 Sep 2017 11:56:45 -0700 (PDT)","Subject":"Re: [PATCH][aarch64] Fix hwcap argument passed to ifunc resolvers","To":"sellcey@cavium.com, Szabolcs Nagy <szabolcs.nagy@arm.com>,\n\tlibc-alpha <libc-alpha@sourceware.org>","Cc":"nd@arm.com","References":"<1504132534.3182.4.camel@cavium.com> <59A8291E.2060205@arm.com>\n\t<1504195926.3182.20.camel@cavium.com>\n\t<0a36b77d-d8b2-14cb-2ff3-2d61b206f856@redhat.com>\n\t<1504286544.3182.61.camel@cavium.com>\n\t<1504287041.3182.63.camel@cavium.com>","From":"Carlos O'Donell <carlos@redhat.com>","Message-ID":"<af17f8a5-5d87-6879-473a-126b7a1ef339@redhat.com>","Date":"Fri, 1 Sep 2017 13:56:42 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<1504287041.3182.63.camel@cavium.com>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}}]