[{"id":1765310,"web_url":"http://patchwork.ozlabs.org/comment/1765310/","msgid":"<20170908125102.GH3283@localhost.localdomain>","list_archive_url":null,"date":"2017-09-08T12:51:02","subject":"Re: [Qemu-devel] [PATCH v6 10/18] dirty-bitmap: Change\n\tbdrv_get_dirty_count() to report bytes","submitter":{"id":2714,"url":"http://patchwork.ozlabs.org/api/people/2714/","name":"Kevin Wolf","email":"kwolf@redhat.com"},"content":"Am 30.08.2017 um 23:05 hat Eric Blake geschrieben:\n> Thanks to recent cleanups, all callers were scaling a return value\n> of sectors into bytes; do the scaling internally instead.\n> \n> Signed-off-by: Eric Blake \n> Reviewed-by: John Snow \n> Reviewed-by: Juan Quintela \n\n> diff --git a/block/mirror.c b/block/mirror.c\n> index af13f5d658..cc47e21814 100644\n> --- a/block/mirror.c\n> +++ b/block/mirror.c\n> @@ -811,11 +811,10 @@ static void coroutine_fn mirror_run(void *opaque)\n\nThere is one more place before this one that needs to be converted,\nmirror_iteration() at line 343:\n\n trace_mirror_restart_iter(s, bdrv_get_dirty_count(s->dirty_bitmap) *\n BDRV_SECTOR_SIZE);\n\nKevin","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kwolf@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpcf84rQBz9rxl\n\tfor ;\n\tFri, 8 Sep 2017 22:52:00 +1000 (AEST)","from localhost ([::1]:45311 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqIlK-0004sr-PL\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 08:51:58 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51420)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqIkf-0004oi-Qu\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 08:51:22 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqIkf-0003VL-7b\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 08:51:17 -0400","from mx1.redhat.com ([209.132.183.28]:45534)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dqIkZ-0003Ob-Uv; Fri, 08 Sep 2017 08:51:12 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E0D825AFC8;\n\tFri, 8 Sep 2017 12:51:10 +0000 (UTC)","from localhost.localdomain (ovpn-116-113.ams2.redhat.com\n\t[10.36.116.113])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 92C7C5C8B7;\n\tFri, 8 Sep 2017 12:51:04 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E0D825AFC8","Date":"Fri, 8 Sep 2017 14:51:02 +0200","From":"Kevin Wolf ","To":"Eric Blake ","Message-ID":"<20170908125102.GH3283@localhost.localdomain>","References":"<20170830210542.2153-1-eblake@redhat.com>\n\t<20170830210542.2153-11-eblake@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170830210542.2153-11-eblake@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tFri, 08 Sep 2017 12:51:11 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v6 10/18] dirty-bitmap: Change\n\tbdrv_get_dirty_count() to report bytes","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"vsementsov@virtuozzo.com, Fam Zheng ,\n\tqemu-block@nongnu.org, Juan Quintela ,\n\tJeff Cody , qemu-devel@nongnu.org,\n\tMax Reitz ,\n\tStefan Hajnoczi , jsnow@redhat.com,\n\t\"Dr. David Alan Gilbert\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1765397,"web_url":"http://patchwork.ozlabs.org/comment/1765397/","msgid":"","list_archive_url":null,"date":"2017-09-08T14:05:56","subject":"Re: [Qemu-devel] [PATCH v6 10/18] dirty-bitmap: Change\n\tbdrv_get_dirty_count() to report bytes","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/08/2017 07:51 AM, Kevin Wolf wrote:\n> Am 30.08.2017 um 23:05 hat Eric Blake geschrieben:\n>> Thanks to recent cleanups, all callers were scaling a return value\n>> of sectors into bytes; do the scaling internally instead.\n>>\n>> Signed-off-by: Eric Blake \n>> Reviewed-by: John Snow \n>> Reviewed-by: Juan Quintela \n> \n>> diff --git a/block/mirror.c b/block/mirror.c\n>> index af13f5d658..cc47e21814 100644\n>> --- a/block/mirror.c\n>> +++ b/block/mirror.c\n>> @@ -811,11 +811,10 @@ static void coroutine_fn mirror_run(void *opaque)\n> \n> There is one more place before this one that needs to be converted,\n> mirror_iteration() at line 343:\n> \n> trace_mirror_restart_iter(s, bdrv_get_dirty_count(s->dirty_bitmap) *\n> BDRV_SECTOR_SIZE);\n\nGood catch. (I guess I'm a victim of sitting on a patch for several\nmonths, across several rebases...)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpfK23yvLz9s7G\n\tfor ;\n\tSat, 9 Sep 2017 00:07:18 +1000 (AEST)","from localhost ([::1]:45623 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqJwC-0000Qq-MC\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 10:07:16 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:45699)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqJvU-0008R5-IH\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 10:06:38 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqJvO-0007AF-TY\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 10:06:32 -0400","from mx1.redhat.com ([209.132.183.28]:61964)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dqJvG-00071e-4L; Fri, 08 Sep 2017 10:06:18 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 352715D698;\n\tFri, 8 Sep 2017 14:06:17 +0000 (UTC)","from [10.10.120.228] (ovpn-120-228.rdu2.redhat.com [10.10.120.228])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 9B6E56AD35;\n\tFri, 8 Sep 2017 14:05:57 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 352715D698","To":"Kevin Wolf ","References":"<20170830210542.2153-1-eblake@redhat.com>\n\t<20170830210542.2153-11-eblake@redhat.com>\n\t<20170908125102.GH3283@localhost.localdomain>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"","Date":"Fri, 8 Sep 2017 09:05:56 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170908125102.GH3283@localhost.localdomain>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"f5tQ0AS9i0Gj2OJJQxQQO7Q4djjQJLuBG\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tFri, 08 Sep 2017 14:06:17 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v6 10/18] dirty-bitmap: Change\n\tbdrv_get_dirty_count() to report bytes","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"vsementsov@virtuozzo.com, Fam Zheng ,\n\tqemu-block@nongnu.org, Juan Quintela ,\n\tJeff Cody , qemu-devel@nongnu.org,\n\tMax Reitz ,\n\tStefan Hajnoczi , jsnow@redhat.com,\n\t\"Dr. David Alan Gilbert\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]