[{"id":1760735,"web_url":"http://patchwork.ozlabs.org/comment/1760735/","msgid":"<20170831082427.GE7897@quack2.suse.cz>","list_archive_url":null,"date":"2017-08-31T08:24:27","subject":"Re: [PATCH v3 4/4] ext4: perform dax_device lookup at mount","submitter":{"id":363,"url":"http://patchwork.ozlabs.org/api/people/363/","name":"Jan Kara","email":"jack@suse.cz"},"content":"On Wed 30-08-17 12:44:08, Dan Williams wrote:\n> The ->iomap_begin() operation is a hot path, so cache the\n> fs_dax_get_by_host() result at mount time to avoid the incurring the\n> hash lookup overhead on a per-i/o basis.\n> \n> Cc: \"Theodore Ts'o\" \n> Cc: Andreas Dilger \n> Cc: Jan Kara \n> Reported-by: Christoph Hellwig \n> Signed-off-by: Dan Williams \n\nLooks good to me. You can add:\n\nReviewed-by: Jan Kara \n\nWith the same nit as for ext2:\n\n> diff --git a/fs/ext4/super.c b/fs/ext4/super.c\n> index d61a70e2193a..0b3d94e25efb 100644\n> --- a/fs/ext4/super.c\n> +++ b/fs/ext4/super.c\n> @@ -864,6 +864,7 @@ static inline void ext4_quota_off_umount(struct super_block *sb)\n> static void ext4_put_super(struct super_block *sb)\n> {\n> \tstruct ext4_sb_info *sbi = EXT4_SB(sb);\n> +\tstruct dax_device *dax_dev = sbi->s_daxdev;\n> \tstruct ext4_super_block *es = sbi->s_es;\n> \tint aborted = 0;\n> \tint i, err;\n> @@ -952,6 +953,7 @@ static void ext4_put_super(struct super_block *sb)\n> \t\tcrypto_free_shash(sbi->s_chksum_driver);\n> \tkfree(sbi->s_blockgroup_lock);\n> \tkfree(sbi);\n> +\tfs_put_dax(dax_dev);\n\nJust remove dax_dev local variable...\n\n\t\t\t\t\t\t\t\tHonza","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-ext4-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjb5l43FRz9t16\n\tfor ;\n\tThu, 31 Aug 2017 18:24:59 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750893AbdHaIY6 (ORCPT );\n\tThu, 31 Aug 2017 04:24:58 -0400","from mx2.suse.de ([195.135.220.15]:56249 \"EHLO mx1.suse.de\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1750816AbdHaIY5 (ORCPT );\n\tThu, 31 Aug 2017 04:24:57 -0400","from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx1.suse.de (Postfix) with ESMTP id C00A3ABE4;\n\tThu, 31 Aug 2017 08:24:28 +0000 (UTC)","by quack2.suse.cz (Postfix, from userid 1000)\n\tid 4D80A1E340B; Thu, 31 Aug 2017 10:24:27 +0200 (CEST)"],"X-Virus-Scanned":"by amavisd-new at test-mx.suse.de","Date":"Thu, 31 Aug 2017 10:24:27 +0200","From":"Jan Kara ","To":"Dan Williams ","Cc":"linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org,\n\tJan Kara , linux-nvdimm@lists.01.org,\n\tAndreas Dilger ,\n\tTheodore Ts'o , Christoph Hellwig ","Subject":"Re: [PATCH v3 4/4] ext4: perform dax_device lookup at mount","Message-ID":"<20170831082427.GE7897@quack2.suse.cz>","References":"<150412222686.10177.8031279869867070772.stgit@dwillia2-desk3.amr.corp.intel.com>\n\t<150412224853.10177.6213990706281408829.stgit@dwillia2-desk3.amr.corp.intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<150412224853.10177.6213990706281408829.stgit@dwillia2-desk3.amr.corp.intel.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Sender":"linux-ext4-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-ext4@vger.kernel.org"}}]