[{"id":1787822,"web_url":"http://patchwork.ozlabs.org/comment/1787822/","msgid":"<076fe56a-381c-591e-f5a8-c2438af8cceb@wedev4u.fr>","list_archive_url":null,"date":"2017-10-16T21:58:48","subject":"Re: [PATCH] mtd: spi-nor: add support for is25lp032","submitter":{"id":70551,"url":"http://patchwork.ozlabs.org/api/people/70551/","name":"Cyrille Pitchen","email":"cyrille.pitchen@wedev4u.fr"},"content":"Hi Sean,\n\nLe 30/08/2017 à 21:33, Sean Nyekjaer a écrit :\n> Signed-off-by: Sean Nyekjaer \n> ---\n> drivers/mtd/spi-nor/spi-nor.c | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c\n> index cf1d4a15e10a..a764fe67b59c 100644\n> --- a/drivers/mtd/spi-nor/spi-nor.c\n> +++ b/drivers/mtd/spi-nor/spi-nor.c\n> @@ -1005,6 +1005,7 @@ static const struct flash_info spi_nor_ids[] = {\n> \n> \t/* ISSI */\n> \t{ \"is25cd512\", INFO(0x7f9d20, 0, 32 * 1024, 2, SECT_4K) },\n> +\t{ \"is25lp032\", INFO(0x9d4013, 0, 64 * 1024, 64, SECT_4K) },\n\nI'm reading the IS25LP032 datasheet:\nhttp://www.issi.com/WW/pdf/IS25LP032-064-128.pdf\n\nTable 8.3 Product Identification states that the JEDEC ID should be\n0x9d6016. Is the datasheet wrong or did you make a mistake on the memory\nname ?\n\nBest regards,\n\nCyrille\n\n\n> \n> \t/* Macronix */\n> \t{ \"mx25l512e\", INFO(0xc22010, 0, 64 * 1024, 1, SECT_4K) },\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"B82ZhOXA\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yGC0F57Ylz9sRW\n\tfor ;\n\tTue, 17 Oct 2017 08:59:25 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e4DPn-00037Z-EL; Mon, 16 Oct 2017 21:59:15 +0000","from smtp3-g21.free.fr ([212.27.42.3])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e4DPi-00034g-Qi\n\tfor linux-mtd@lists.infradead.org; Mon, 16 Oct 2017 21:59:13 +0000","from mountainer.wedev4u.int (unknown [82.232.94.13])\n\tby smtp3-g21.free.fr (Postfix) with ESMTP id 81AF913F866;\n\tMon, 16 Oct 2017 23:58:48 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Cc:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=euRqQBT48K69UbKe+x6W8y6j7KGIJdWe6JMfUo0DZtc=;\n\tb=B82ZhOXAovLWzHrlCeMBWdEeKc\n\tYD1+MJAQTUzl6/eQchMsqzjzLTBgMrGIeNKnMrT8JtcRsf7ZyEKBNjTtZMBmG1dcZM5guRP75gN0j\n\tq+M6PRFMz0csffD+olH8eu4EuzuTY9VdYBSev+QA/wpAG+fyXgQHIf0zDWcVKqH05i0bHhE1LfeQE\n\tUbXtJurchY5msMGh5shrYDuFZfDikBWZ9Lu6+SNC7jpqW7znC+QTI/6ijtiHmgwqaU/Lkvr3BWnjC\n\t8awS5p6UOb3u8tL2lKyfiETazwksGAJmlTN6vGprk8owo3Hsm6o/uhWeQKLGrG4q6KYN8jT5c22Pb\n\tmyr8rq8g==;","Subject":"Re: [PATCH] mtd: spi-nor: add support for is25lp032","To":"Sean Nyekjaer , linux-mtd@lists.infradead.org","References":"<20170830193323.14478-1-sean.nyekjaer@prevas.dk>","From":"Cyrille Pitchen ","Message-ID":"<076fe56a-381c-591e-f5a8-c2438af8cceb@wedev4u.fr>","Date":"Mon, 16 Oct 2017 23:58:48 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<20170830193323.14478-1-sean.nyekjaer@prevas.dk>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171016_145911_043854_8117E0E9 ","X-CRM114-Status":"GOOD ( 11.01 )","X-Spam-Score":"-4.7 (----)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-4.7 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow trust [212.27.42.3 listed in list.dnswl.org]\n\t0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)\n\t-2.8 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)\n\t[212.27.42.3 listed in wl.mailspike.net]\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1788004,"web_url":"http://patchwork.ozlabs.org/comment/1788004/","msgid":"","list_archive_url":null,"date":"2017-10-17T06:40:05","subject":"Re: [PATCH] mtd: spi-nor: add support for is25lp032","submitter":{"id":64902,"url":"http://patchwork.ozlabs.org/api/people/64902/","name":"Sean Nyekjær","email":"sean.nyekjaer@prevas.dk"},"content":"Hi\n\nOn 2017-10-16 23:58, Cyrille Pitchen wrote:\n> Hi Sean,\n>\n> Le 30/08/2017 à 21:33, Sean Nyekjaer a écrit :\n>> Signed-off-by: Sean Nyekjaer \n>> ---\n>> drivers/mtd/spi-nor/spi-nor.c | 1 +\n>> 1 file changed, 1 insertion(+)\n>>\n>> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c\n>> index cf1d4a15e10a..a764fe67b59c 100644\n>> --- a/drivers/mtd/spi-nor/spi-nor.c\n>> +++ b/drivers/mtd/spi-nor/spi-nor.c\n>> @@ -1005,6 +1005,7 @@ static const struct flash_info spi_nor_ids[] = {\n>> \n>> \t/* ISSI */\n>> \t{ \"is25cd512\", INFO(0x7f9d20, 0, 32 * 1024, 2, SECT_4K) },\n>> +\t{ \"is25lp032\", INFO(0x9d4013, 0, 64 * 1024, 64, SECT_4K) },\n> I'm reading the IS25LP032 datasheet:\n> http://www.issi.com/WW/pdf/IS25LP032-064-128.pdf\n>\n> Table 8.3 Product Identification states that the JEDEC ID should be\n> 0x9d6016. Is the datasheet wrong or did you make a mistake on the memory\n> name ?\n>\n> Best regards,\n>\n> Cyrille\nI did a mistake in the memory name :-) The device with that ID is \nIS25LQ040B. I'll resubmit a patch with the correct name.\n\nBR\n/Sean\n>\n>\n>> \n>> \t/* Macronix */\n>> \t{ \"mx25l512e\", INFO(0xc22010, 0, 64 * 1024, 1, SECT_4K) },\n>>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"ttE2S49l\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=prevas.dk header.i=@prevas.dk\n\theader.b=\"yUUIi0Ku\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yGQZ875cbz9s7c\n\tfor ;\n\tTue, 17 Oct 2017 17:40:55 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e4LYM-0004OJ-F8; Tue, 17 Oct 2017 06:40:38 +0000","from mail02.prevas.se ([62.95.78.10])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e4LYI-0003ym-Rv\n\tfor linux-mtd@lists.infradead.org; Tue, 17 Oct 2017 06:40:36 +0000","from vmprevas3.prevas.se (HELO smtp.prevas.se) ([172.16.8.103])\n\tby ironport2.prevas.se with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 Oct 2017 08:40:05 +0200","from [172.16.11.15] (172.16.8.31) by smtp.prevas.se (172.16.8.103)\n\twith Microsoft SMTP Server (TLS) id 14.3.361.1;\n\tTue, 17 Oct 2017 08:40:05 +0200"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:\n\tReferences:To:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=OB35hpsJWhCT9KEGbfPyHbMjBSvapFsYZVWGvmCRZCk=;\n\tb=ttE2S49l6merPMi2CNSeHWimW\n\t/au7hd2ytU17SPirKLaNtXyBuajPZqFGFqe9up2bqdqdNcHJUTzWKm24/nwp8fF7KQRUTKPwSxz2w\n\tHzqxsSWpc0SrK2ulKgN6dWjPg2H0bmVlBlwJXC82O6zhXccWMBW41jQo8d1Pk7M87yPNvCQVv7Dsk\n\tW+WTEK2JpG6d7Zj78Wz97T/QyTWiMgL38y9Ri2vURbOzxaYf11BXxK0b1rccP4OiU2RBJDns65kdk\n\tqR11l5ZIqa0EimMhJNvcFjHc4t/8zqGJ/aw17oe3QHMzkePyBsTo9+xZGY8FhmcDLRF2o4uGn3bHJ\n\tpPE5D0SSQ==;","v=1; a=rsa-sha256; c=simple/simple;\n\td=prevas.dk; i=@prevas.dk; l=1241; q=dns/txt;\n\ts=ironport2; t=1508222434; x=1539758434;\n\th=subject:to:references:from:message-id:date:mime-version:\n\tin-reply-to:content-transfer-encoding;\n\tbh=Z5pTsWxihhAfXBMhZ7SF2ZPUmdOlsoeHP6EdbyPCq84=;\n\tb=yUUIi0Ku779N0bXYfG2ZtMy63tRE+cPftI4BnDmUTM4qFzTe/SIk2Ld+\n\tTJRbgow8/yOTVfpsxymJtvplqwtDkI7sNNVcB5CHR4ATkL1cdx9sIrPJ5\n\ttmY2k+qnS4hRzXGCFtTLX/CQbjW1/j6Fjxwa37B7nBIEGsrFoqGMeRBag 8=;"],"X-IronPort-AV":"E=Sophos;i=\"5.43,389,1503352800\"; d=\"scan'208\";a=\"2583543\"","Subject":"Re: [PATCH] mtd: spi-nor: add support for is25lp032","To":"Cyrille Pitchen ,\n\t","References":"<20170830193323.14478-1-sean.nyekjaer@prevas.dk>\n\t<076fe56a-381c-591e-f5a8-c2438af8cceb@wedev4u.fr>","From":"=?utf-8?q?Sean_Nyekj=C3=A6r?= ","Message-ID":"","Date":"Tue, 17 Oct 2017 08:40:05 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<076fe56a-381c-591e-f5a8-c2438af8cceb@wedev4u.fr>","Content-Language":"en-US","X-Originating-IP":"[172.16.8.31]","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171016_234035_265458_C0F7F3A0 ","X-CRM114-Status":"GOOD ( 12.98 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [62.95.78.10 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]