[{"id":1765950,"web_url":"http://patchwork.ozlabs.org/comment/1765950/","msgid":"<20170910154544.1349162b@archlinux>","list_archive_url":null,"date":"2017-09-10T14:45:44","subject":"Re: [PATCH 5/5] lmp92001: mfd: doc: Add support LMP92001","submitter":{"id":20086,"url":"http://patchwork.ozlabs.org/api/people/20086/","name":"Jonathan Cameron","email":"jic23@jic23.retrosnub.co.uk"},"content":"On Thu, 31 Aug 2017 01:25:28 +0700\ns.abhisit@gmail.com wrote:\n\n> From: Abhisit Sangjan \n> \n> TI LMP92001 Analog System Monitor and Controller\n> \n> 8-bit GPIOs.\n> 12 DACs with 12-bit resolution.\n> \n> The GPIOs and DACs are shared port function with Cy function pin to\n> take control the pin suddenly from external hardware.\n> DAC's referance voltage selectable for Internal/External.\n> \n> 16 + 1 ADCs with 12-bit resolution.\n> \n> Built-in internal Temperature Sensor on channel 17.\n> Window Comparator Function is supported on channel 1-3 and 9-11 for\n> monitoring with interrupt signal (pending to implement for interrupt).\n> ADC's referance voltage selectable for Internal/External.\n> \n\nI would break this patch up somewhat. Have a set of DT patches separate\nfrom any sysfs attribute documentation.\n\n> Signed-off-by: Abhisit Sangjan \n> ---\n> Documentation/ABI/testing/sysfs-bus-iio-lmp920001 | 65 ++++++++++++++++++++++\n> .../devicetree/bindings/gpio/gpio-lmp92001.txt | 22 ++++++++\n> .../bindings/iio/adc/ti-lmp92001-adc.txt | 20 +++++++\n> .../bindings/iio/dac/ti-lmp92001-dac.txt | 35 ++++++++++++\n> 4 files changed, 142 insertions(+)\n> create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-lmp920001\n> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-lmp92001.txt\n> create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-lmp92001-adc.txt\n> create mode 100644 Documentation/devicetree/bindings/iio/dac/ti-lmp92001-dac.txt\n> \n> diff --git a/Documentation/ABI/testing/sysfs-bus-iio-lmp920001 b/Documentation/ABI/testing/sysfs-bus-iio-lmp920001\n> new file mode 100644\n> index 000000000000..f0965e7d823f\n> --- /dev/null\n> +++ b/Documentation/ABI/testing/sysfs-bus-iio-lmp920001\n> @@ -0,0 +1,65 @@\n> +What: /sys/bus/iio/devices/iio:deviceX/gang\n> +Date: August 2016\n> +KernelVersion: 4.12\n> +Contact: Abhisit Sangjan \n> +Description:\n> + Controls the association of analog output channels OUTx with\n> + asynchronous control inputs Cy for DAC.\n> + Can be either:\n> + - \"0\"\n> + - \"1\"\n> +\n> + Cy to OUTx Assignment\n> + ----------------------------------\n> + | Cy | CDAC:GANG=0 | CDAC:GANG=1 |\n> + ----------------------------------\n> + | C1 | OUT[1:4] | OUT[1:3] |\n> + ----------------------------------\n> + | C2 | OUT[5:6] | OUT[4:6] |\n> + ----------------------------------\n> + | C3 | OUT[7:8] | OUT[7:9] |\n> + ----------------------------------\n> + | C4 | OUT[9:12] | OUT[10:12] |\n> + ----------------------------------\n> +\n> +What: /sys/bus/iio/devices/iio:deviceX/outx\n> +Date: August 2016\n> +KernelVersion: 4.12\n> +Contact: Abhisit Sangjan \n> +Description:\n> + The pin output mode for DAC.\n> + Can be either:\n> + - \"hiz\" = High impedance state.\n> + - \"dac\" = DAC output.\n> + - \"0\" = Drive it to low.\n> + - \"1\" = Drive it to high.\n\nTwo options here - consider the hiz 0 and 1 to be powerdown\nmodes in which case use the standard interfaces for them, or\ntake the view the 0 1 choice is to allow this device to\nact as a gpio chip and support that explicitly.\n\n> +\n> +What: /sys/bus/iio/devices/iio:deviceX/vref\n> +Date: August 2016\n> +KernelVersion: 4.12\n> +Contact: Abhisit Sangjan \n> +Description:\n> + This is voltage reference source for DACs.\n> + Can be either:\n> + - \"external\"\n> + - \"internal\"\n\nIt is rare for userspace control of this to make sense. Tends to be\nthe case that there is only one right answer for a given piece of\nhardware.\n\n> +\n> +What: /sys/devices/.../iio:deviceX/en\n> +Date: August 2016\n> +KernelVersion: 4.12\n> +Contact: Abhisit Sangjan \n> +Description:\n> + This is ADC Conversion Enable for each channel.\n> + Can be either:\n> + - \"enable\"\n> + - \"disable\"\n\nIf you want this fine control use the buffered interfaces rather\nthan sysfs. I don't want to add this complexity to the sysfs\ninterface. For sysfs if nothing outside sysfs is going on (e.g.\nno buffered capture) it should be read an attribute get the answer\nwithout having to configure other elements manually.\n\nAlso as currently documented, you only have one such file per\niio:device which seems unlikely to be what you were aiming for.\n\n\n> +\n> +What: /sys/devices/.../iio:deviceX/vref\n\nHere twice...\n\n> +Date: August 2016\n> +KernelVersion: 4.12\n> +Contact: Abhisit Sangjan \n> +Description:\n> + This is voltage reference source for ADCs.\n> + Can be either:\n> + - \"external\"\n> + - \"internal\"\n> diff --git a/Documentation/devicetree/bindings/gpio/gpio-lmp92001.txt b/Documentation/devicetree/bindings/gpio/gpio-lmp92001.txt\n> new file mode 100644\n> index 000000000000..f9a18c492145\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/gpio/gpio-lmp92001.txt\n> @@ -0,0 +1,22 @@\n> +* Texas Instruments' LMP92001 GPIOs\n> +\n> +Required properties:\n> + - compatible: Must be set to \"ti,lmp92001-gpio\".\n> + - reg: i2c chip address for the device.\n> + - gpio-controller: Marks the device node as a gpio controller.\n> + - #gpio-cells : Should be two. The first cell is the pin number and the\n> + second cell is used to specify the gpio polarity:\n> + 0 = Active high\n> + 1 = Active low\n> +\n> +Example:\n> +lmp92001@20 {\n> + compatible = \"ti,lmp92001\";\n> + reg = <0x20>;\n> +\n> + gpio-controller {\n> + compatible = \"ti,lmp92001-gpio\";\n> + gpio-controller;\n> + #gpio-cells = <2>;\n> + };\n> +};\n> diff --git a/Documentation/devicetree/bindings/iio/adc/ti-lmp92001-adc.txt b/Documentation/devicetree/bindings/iio/adc/ti-lmp92001-adc.txt\n> new file mode 100644\n> index 000000000000..4565961bf511\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/iio/adc/ti-lmp92001-adc.txt\n> @@ -0,0 +1,20 @@\n> +* Texas Instruments' LMP92001 ADCs\n> +\n> +Required properties:\n> + - compatible: Must be set to \"ti,lmp92001-adc\".\n> + - reg: i2c chip address for the device.\n> + - ti,lmp92001-adc-mask: bit mask for which channel is enable.\n> + 0 = Off\n> + 1 = On\n> +\n> +Example:\n> +lmp92001@20 {\n> + compatible = \"ti,lmp92001\";\n> + reg = <0x20>;\n> +\n> + lmp92001-adc {\n> + compatible = \"ti,lmp92001-adc\";\n> + ti,lmp92001-adc-mode = \"continuous\";\n> + ti,lmp92001-adc-mask = <0x00000079>;\n> + };\n> +};\n> diff --git a/Documentation/devicetree/bindings/iio/dac/ti-lmp92001-dac.txt b/Documentation/devicetree/bindings/iio/dac/ti-lmp92001-dac.txt\n> new file mode 100644\n> index 000000000000..882db9ca92f5\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/iio/dac/ti-lmp92001-dac.txt\n> @@ -0,0 +1,35 @@\n> +* Texas Instruments' LMP92001 DACs\n> +\n> +Required properties:\n> + - compatible: Must be set to \"ti,lmp92001-dac\".\n> + - reg: i2c chip address for the device.\n> + - ti,lmp92001-dac-hiz: hi-impedance control,\n> + 1 = Forces all OUT[1:12] outputs to hi-z, 0 = normal\n\nWhy?\n\n> + - ti,lmp92001-dac-outx:\n> + Cy = 0, 1 = will force associated OUTx outputs to VDD\n> + Cy = 0, 0 = will force associated OUTx outputs to GND\n\nClashes with the above? I'm not sure why you would want these to\nbe device tree bindings at all.\n\n> + - ti,lmp92001-dac-gang: What group of Cy is governed to.\n> + -----------------------------------------\n> + | Cy | CDAC:GANG = 0 | CDAC:GANG = 1 |\n> + -----------------------------------------\n> + | C1 | OUT[1:4] | OUT[1:3] |\n> + -----------------------------------------\n> + | C2 | OUT[5:6] | OUT[4:6] |\n> + -----------------------------------------\n> + | C3 | OUT[7:8] | OUT[7:9] |\n> + -----------------------------------------\n> + | C4 | OUT[9:12] | OUT[10:12] |\n> + -----------------------------------------\n\nThis last one is an ugly bit of hardware, so probably fine\nto have in DT.\n> +\n> +Example:\n> +lmp92001@20 {\n> + compatible = \"ti,lmp92001\";\n> + reg = <0x20>;\n> +\n> + lmp92001-dac {\n> + compatible = \"ti,lmp92001-dac\";\n> + ti,lmp92001-dac-hiz = /bits/ 8 <0>;\n> + ti,lmp92001-dac-outx = /bits/ 8 <0>;\n> + ti,lmp92001-dac-gang = /bits/ 8 <0>;\n> + };\n> +};\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xqv4c2LjGz9s7m\n\tfor ;\n\tMon, 11 Sep 2017 00:45:52 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751804AbdIJOpt (ORCPT\n\t);\n\tSun, 10 Sep 2017 10:45:49 -0400","from saturn.retrosnub.co.uk ([178.18.118.26]:36358 \"EHLO\n\tsaturn.retrosnub.co.uk\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751732AbdIJOps (ORCPT\n\t); Sun, 10 Sep 2017 10:45:48 -0400","from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net\n\t[81.96.234.148]) by saturn.retrosnub.co.uk (Postfix;\n\tRetrosnub mail submission) with ESMTPSA id A6B394066B; \n\tSun, 10 Sep 2017 15:45:45 +0100 (BST)"],"Date":"Sun, 10 Sep 2017 15:45:44 +0100","From":"Jonathan Cameron ","To":"s.abhisit@gmail.com","Cc":"linus.walleij@linaro.org, robh@kernel.org, lee.jones@linaro.org,\n\tJonathan.Cameron@huawei.com, pmeerw@pmeerw.net, jacopo@jmondi.org,\n\tlinux-kernel@vger.kernel.org, knaack.h@gmx.de, lars@metafoo.de,\n\tfabrice.gasnier@st.com, akinobu.mita@gmail.com,\n\tmarek.vasut+renesas@gmail.com, jacopo+renesas@jmondi.org,\n\tmike.looijmans@topic.nl, peda@axentia.se, jeff.dagenais@gmail.com,\n\tlinux-iio@vger.kernel.org, linux-gpio@vger.kernel.org,\n\tmark.rutland@arm.com, devicetree@vger.kernel.org, lukas@wunner.de,\n\tadi.reus@gmail.com","Subject":"Re: [PATCH 5/5] lmp92001: mfd: doc: Add support LMP92001","Message-ID":"<20170910154544.1349162b@archlinux>","In-Reply-To":"<20170830182528.9479-1-s.abhisit@gmail.com>","References":"<20170830182528.9479-1-s.abhisit@gmail.com>","X-Mailer":"Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu)","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1766595,"web_url":"http://patchwork.ozlabs.org/comment/1766595/","msgid":"<20170911215841.jaaipbdcf5hchjck@rob-hp-laptop>","list_archive_url":null,"date":"2017-09-11T21:58:41","subject":"Re: [PATCH 5/5] lmp92001: mfd: doc: Add support LMP92001","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Thu, Aug 31, 2017 at 01:25:28AM +0700, s.abhisit@gmail.com wrote:\n> From: Abhisit Sangjan \n> \n> TI LMP92001 Analog System Monitor and Controller\n> \n> 8-bit GPIOs.\n> 12 DACs with 12-bit resolution.\n> \n> The GPIOs and DACs are shared port function with Cy function pin to\n> take control the pin suddenly from external hardware.\n> DAC's referance voltage selectable for Internal/External.\n> \n> 16 + 1 ADCs with 12-bit resolution.\n> \n> Built-in internal Temperature Sensor on channel 17.\n> Window Comparator Function is supported on channel 1-3 and 9-11 for\n> monitoring with interrupt signal (pending to implement for interrupt).\n> ADC's referance voltage selectable for Internal/External.\n> \n> Signed-off-by: Abhisit Sangjan \n> ---\n> Documentation/ABI/testing/sysfs-bus-iio-lmp920001 | 65 ++++++++++++++++++++++\n> .../devicetree/bindings/gpio/gpio-lmp92001.txt | 22 ++++++++\n\nAs Jonathan said, please split.\n\n> .../bindings/iio/adc/ti-lmp92001-adc.txt | 20 +++++++\n> .../bindings/iio/dac/ti-lmp92001-dac.txt | 35 ++++++++++++\n> 4 files changed, 142 insertions(+)\n> create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-lmp920001\n> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-lmp92001.txt\n> create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-lmp92001-adc.txt\n> create mode 100644 Documentation/devicetree/bindings/iio/dac/ti-lmp92001-dac.txt\n\n[...]\n\n> diff --git a/Documentation/devicetree/bindings/gpio/gpio-lmp92001.txt b/Documentation/devicetree/bindings/gpio/gpio-lmp92001.txt\n> new file mode 100644\n> index 000000000000..f9a18c492145\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/gpio/gpio-lmp92001.txt\n> @@ -0,0 +1,22 @@\n> +* Texas Instruments' LMP92001 GPIOs\n> +\n\nNeed to state what this is a child of and refer to that binding doc. \nSame for the others.\n\n> +Required properties:\n> + - compatible: Must be set to \"ti,lmp92001-gpio\".\n> + - reg: i2c chip address for the device.\n\n? That's for the parent.\n\n> + - gpio-controller: Marks the device node as a gpio controller.\n> + - #gpio-cells : Should be two. The first cell is the pin number and the\n> + second cell is used to specify the gpio polarity:\n> + 0 = Active high\n> + 1 = Active low\n> +\n> +Example:\n> +lmp92001@20 {\n> + compatible = \"ti,lmp92001\";\n> + reg = <0x20>;\n> +\n> + gpio-controller {\n\nShould be \"gpio {\"\n\n> + compatible = \"ti,lmp92001-gpio\";\n> + gpio-controller;\n> + #gpio-cells = <2>;\n> + };\n> +};\n> diff --git a/Documentation/devicetree/bindings/iio/adc/ti-lmp92001-adc.txt b/Documentation/devicetree/bindings/iio/adc/ti-lmp92001-adc.txt\n> new file mode 100644\n> index 000000000000..4565961bf511\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/iio/adc/ti-lmp92001-adc.txt\n> @@ -0,0 +1,20 @@\n> +* Texas Instruments' LMP92001 ADCs\n> +\n> +Required properties:\n> + - compatible: Must be set to \"ti,lmp92001-adc\".\n> + - reg: i2c chip address for the device.\n> + - ti,lmp92001-adc-mask: bit mask for which channel is enable.\n> + 0 = Off\n> + 1 = On\n> +\n> +Example:\n> +lmp92001@20 {\n> + compatible = \"ti,lmp92001\";\n> + reg = <0x20>;\n> +\n> + lmp92001-adc {\n\nadc {\n\n> + compatible = \"ti,lmp92001-adc\";\n> + ti,lmp92001-adc-mode = \"continuous\";\n\nNot documented and I believe we're going to add a common property for \nthis.\n\n> + ti,lmp92001-adc-mask = <0x00000079>;\n> + };\n> +};\n> diff --git a/Documentation/devicetree/bindings/iio/dac/ti-lmp92001-dac.txt b/Documentation/devicetree/bindings/iio/dac/ti-lmp92001-dac.txt\n> new file mode 100644\n> index 000000000000..882db9ca92f5\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/iio/dac/ti-lmp92001-dac.txt\n> @@ -0,0 +1,35 @@\n> +* Texas Instruments' LMP92001 DACs\n> +\n> +Required properties:\n> + - compatible: Must be set to \"ti,lmp92001-dac\".\n> + - reg: i2c chip address for the device.\n> + - ti,lmp92001-dac-hiz: hi-impedance control,\n> + 1 = Forces all OUT[1:12] outputs to hi-z, 0 = normal\n> + - ti,lmp92001-dac-outx:\n> + Cy = 0, 1 = will force associated OUTx outputs to VDD\n> + Cy = 0, 0 = will force associated OUTx outputs to GND\n> + - ti,lmp92001-dac-gang: What group of Cy is governed to.\n> + -----------------------------------------\n> + | Cy | CDAC:GANG = 0 | CDAC:GANG = 1 |\n> + -----------------------------------------\n> + | C1 | OUT[1:4] | OUT[1:3] |\n> + -----------------------------------------\n> + | C2 | OUT[5:6] | OUT[4:6] |\n> + -----------------------------------------\n> + | C3 | OUT[7:8] | OUT[7:9] |\n> + -----------------------------------------\n> + | C4 | OUT[9:12] | OUT[10:12] |\n> + -----------------------------------------\n> +\n> +Example:\n> +lmp92001@20 {\n> + compatible = \"ti,lmp92001\";\n> + reg = <0x20>;\n> +\n> + lmp92001-dac {\n\ndac {\n\n> + compatible = \"ti,lmp92001-dac\";\n> + ti,lmp92001-dac-hiz = /bits/ 8 <0>;\n> + ti,lmp92001-dac-outx = /bits/ 8 <0>;\n> + ti,lmp92001-dac-gang = /bits/ 8 <0>;\n> + };\n> +};\n> -- \n> 2.13.0\n> \n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrhfF3Z9Yz9s7F\n\tfor ;\n\tTue, 12 Sep 2017 07:59:17 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751204AbdIKV6o (ORCPT\n\t);\n\tMon, 11 Sep 2017 17:58:44 -0400","from mail-io0-f195.google.com ([209.85.223.195]:33567 \"EHLO\n\tmail-io0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751049AbdIKV6n (ORCPT\n\t); Mon, 11 Sep 2017 17:58:43 -0400","by mail-io0-f195.google.com with SMTP id y123so7268073iod.0;\n\tMon, 11 Sep 2017 14:58:42 -0700 (PDT)","from localhost (216-188-254-6.dyn.grandenetworks.net.\n\t[216.188.254.6]) by smtp.gmail.com with ESMTPSA id\n\tk144sm9790741oih.45.2017.09.11.14.58.41\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 11 Sep 2017 14:58:41 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=th98W2fXPmRT19H5OtE/FQdecn1+L8mZ29JvpAf4eHQ=;\n\tb=qvBaPZjsc++UQcQ2OLrJ4Sb94tROIwbAoFlAsZRljaDY2aMEjoTXXQB7is8fo+DzYj\n\tddRCOvaV219/8Gc7vHmQAsx9yEMMKbzxQubfZqTGBep9XYZutFXkMNqOP997Sx9mb2By\n\tW7bBQ/DxVwmEcl++OY0b3aJg9EqN6pa/IPjNvtItfJ7rpAXEF1EegkGAri/6JgDbrm4z\n\tEGFiFEeOwXOheFqWNOKjltLzcIJ3Vknqd2jtyFPgs+LU73JvcF1s+3Oqj2E5DdGhECH6\n\tt+OOewX1bU2ctIX0k8aPVze1KVoS7c5AhrImO+rl0rhoPvFuiimbw6hNCmlB/6GDM4eZ\n\t3ZLw==","X-Gm-Message-State":"AHPjjUgUaBw+2W7SQeazOgPtmckTrk/6Jxn55N6RLhNMQO/aISOlBaG4\n\t4zsmaDX/KQL9Lg==","X-Google-Smtp-Source":"AOwi7QCumE/TmfWjkYJkXy1CQ/1puywMJ71bxI9dL5vWkVgr1kf8tEOwt+YlPdt6h5U4dk8+GYi47Q==","X-Received":"by 10.202.193.3 with SMTP id r3mr15089817oif.17.1505167122274;\n\tMon, 11 Sep 2017 14:58:42 -0700 (PDT)","Date":"Mon, 11 Sep 2017 16:58:41 -0500","From":"Rob Herring ","To":"s.abhisit@gmail.com","Cc":"linus.walleij@linaro.org, lee.jones@linaro.org,\n\tJonathan.Cameron@huawei.com, pmeerw@pmeerw.net, jacopo@jmondi.org,\n\tlinux-kernel@vger.kernel.org, knaack.h@gmx.de, lars@metafoo.de,\n\tfabrice.gasnier@st.com, akinobu.mita@gmail.com,\n\tmarek.vasut+renesas@gmail.com, jacopo+renesas@jmondi.org,\n\tmike.looijmans@topic.nl, peda@axentia.se, jeff.dagenais@gmail.com,\n\tlinux-iio@vger.kernel.org, linux-gpio@vger.kernel.org,\n\tmark.rutland@arm.com, devicetree@vger.kernel.org, lukas@wunner.de,\n\tadi.reus@gmail.com","Subject":"Re: [PATCH 5/5] lmp92001: mfd: doc: Add support LMP92001","Message-ID":"<20170911215841.jaaipbdcf5hchjck@rob-hp-laptop>","References":"<20170830182528.9479-1-s.abhisit@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170830182528.9479-1-s.abhisit@gmail.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1766839,"web_url":"http://patchwork.ozlabs.org/comment/1766839/","msgid":"<20170912110923.0f80c116@archlinux>","list_archive_url":null,"date":"2017-09-12T10:09:23","subject":"Re: [PATCH 5/5] lmp92001: mfd: doc: Add support LMP92001","submitter":{"id":10151,"url":"http://patchwork.ozlabs.org/api/people/10151/","name":"Jonathan Cameron","email":"jic23@kernel.org"},"content":"On Mon, 11 Sep 2017 16:58:41 -0500\nRob Herring wrote:\n\n> On Thu, Aug 31, 2017 at 01:25:28AM +0700, s.abhisit@gmail.com wrote:\n> > From: Abhisit Sangjan \n> > \n> > TI LMP92001 Analog System Monitor and Controller\n> > \n> > 8-bit GPIOs.\n> > 12 DACs with 12-bit resolution.\n> > \n> > The GPIOs and DACs are shared port function with Cy function pin to\n> > take control the pin suddenly from external hardware.\n> > DAC's referance voltage selectable for Internal/External.\n> > \n> > 16 + 1 ADCs with 12-bit resolution.\n> > \n> > Built-in internal Temperature Sensor on channel 17.\n> > Window Comparator Function is supported on channel 1-3 and 9-11 for\n> > monitoring with interrupt signal (pending to implement for interrupt).\n> > ADC's referance voltage selectable for Internal/External.\n> > \n> > Signed-off-by: Abhisit Sangjan \n> > ---\n> > Documentation/ABI/testing/sysfs-bus-iio-lmp920001 | 65 ++++++++++++++++++++++\n> > .../devicetree/bindings/gpio/gpio-lmp92001.txt | 22 ++++++++ \n> \n> As Jonathan said, please split.\n> \n> > .../bindings/iio/adc/ti-lmp92001-adc.txt | 20 +++++++\n> > .../bindings/iio/dac/ti-lmp92001-dac.txt | 35 ++++++++++++\n> > 4 files changed, 142 insertions(+)\n> > create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-lmp920001\n> > create mode 100644 Documentation/devicetree/bindings/gpio/gpio-lmp92001.txt\n> > create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-lmp92001-adc.txt\n> > create mode 100644 Documentation/devicetree/bindings/iio/dac/ti-lmp92001-dac.txt \n> \n> [...]\n> \n> > diff --git a/Documentation/devicetree/bindings/gpio/gpio-lmp92001.txt b/Documentation/devicetree/bindings/gpio/gpio-lmp92001.txt\n> > new file mode 100644\n> > index 000000000000..f9a18c492145\n> > --- /dev/null\n> > +++ b/Documentation/devicetree/bindings/gpio/gpio-lmp92001.txt\n> > @@ -0,0 +1,22 @@\n> > +* Texas Instruments' LMP92001 GPIOs\n> > + \n> \n> Need to state what this is a child of and refer to that binding doc. \n> Same for the others.\n> \n> > +Required properties:\n> > + - compatible: Must be set to \"ti,lmp92001-gpio\".\n> > + - reg: i2c chip address for the device. \n> \n> ? That's for the parent.\n> \n> > + - gpio-controller: Marks the device node as a gpio controller.\n> > + - #gpio-cells : Should be two. The first cell is the pin number and the\n> > + second cell is used to specify the gpio polarity:\n> > + 0 = Active high\n> > + 1 = Active low\n> > +\n> > +Example:\n> > +lmp92001@20 {\n> > + compatible = \"ti,lmp92001\";\n> > + reg = <0x20>;\n> > +\n> > + gpio-controller { \n> \n> Should be \"gpio {\"\n> \n> > + compatible = \"ti,lmp92001-gpio\";\n> > + gpio-controller;\n> > + #gpio-cells = <2>;\n> > + };\n> > +};\n> > diff --git a/Documentation/devicetree/bindings/iio/adc/ti-lmp92001-adc.txt b/Documentation/devicetree/bindings/iio/adc/ti-lmp92001-adc.txt\n> > new file mode 100644\n> > index 000000000000..4565961bf511\n> > --- /dev/null\n> > +++ b/Documentation/devicetree/bindings/iio/adc/ti-lmp92001-adc.txt\n> > @@ -0,0 +1,20 @@\n> > +* Texas Instruments' LMP92001 ADCs\n> > +\n> > +Required properties:\n> > + - compatible: Must be set to \"ti,lmp92001-adc\".\n> > + - reg: i2c chip address for the device.\n> > + - ti,lmp92001-adc-mask: bit mask for which channel is enable.\n> > + 0 = Off\n> > + 1 = On\n> > +\n> > +Example:\n> > +lmp92001@20 {\n> > + compatible = \"ti,lmp92001\";\n> > + reg = <0x20>;\n> > +\n> > + lmp92001-adc { \n> \n> adc {\n> \n> > + compatible = \"ti,lmp92001-adc\";\n> > + ti,lmp92001-adc-mode = \"continuous\"; \n> \n> Not documented and I believe we're going to add a common property for \n> this.\n\nPossibly. I'm not keen on it being explicitly controlled in general.\nIt isn't a feature of the hardware in this case (I think) and as userspace\ncontrol it is very hard for userspace to know what to do with it -\nnormally it is better to put sufficient smarts in the driver to handle\nthis transparently from either dt or userspace abi point of view.\n\nAt a rough guess 10-25% of the hardware in IIO has a similar mode (possibly more)\nWe expose it precisely 1 other driver at the moment (and to be honest\nI can't recall why we allowed it in there) There are all sorts of optimizations\nthat can be done in the driver if we don't make this a manual control.\n\nJonathan\n\n> \n> > + ti,lmp92001-adc-mask = <0x00000079>;\n> > + };\n> > +};\n> > diff --git a/Documentation/devicetree/bindings/iio/dac/ti-lmp92001-dac.txt b/Documentation/devicetree/bindings/iio/dac/ti-lmp92001-dac.txt\n> > new file mode 100644\n> > index 000000000000..882db9ca92f5\n> > --- /dev/null\n> > +++ b/Documentation/devicetree/bindings/iio/dac/ti-lmp92001-dac.txt\n> > @@ -0,0 +1,35 @@\n> > +* Texas Instruments' LMP92001 DACs\n> > +\n> > +Required properties:\n> > + - compatible: Must be set to \"ti,lmp92001-dac\".\n> > + - reg: i2c chip address for the device.\n> > + - ti,lmp92001-dac-hiz: hi-impedance control,\n> > + 1 = Forces all OUT[1:12] outputs to hi-z, 0 = normal\n> > + - ti,lmp92001-dac-outx:\n> > + Cy = 0, 1 = will force associated OUTx outputs to VDD\n> > + Cy = 0, 0 = will force associated OUTx outputs to GND\n> > + - ti,lmp92001-dac-gang: What group of Cy is governed to.\n> > + -----------------------------------------\n> > + | Cy | CDAC:GANG = 0 | CDAC:GANG = 1 |\n> > + -----------------------------------------\n> > + | C1 | OUT[1:4] | OUT[1:3] |\n> > + -----------------------------------------\n> > + | C2 | OUT[5:6] | OUT[4:6] |\n> > + -----------------------------------------\n> > + | C3 | OUT[7:8] | OUT[7:9] |\n> > + -----------------------------------------\n> > + | C4 | OUT[9:12] | OUT[10:12] |\n> > + -----------------------------------------\n> > +\n> > +Example:\n> > +lmp92001@20 {\n> > + compatible = \"ti,lmp92001\";\n> > + reg = <0x20>;\n> > +\n> > + lmp92001-dac { \n> \n> dac {\n> \n> > + compatible = \"ti,lmp92001-dac\";\n> > + ti,lmp92001-dac-hiz = /bits/ 8 <0>;\n> > + ti,lmp92001-dac-outx = /bits/ 8 <0>;\n> > + ti,lmp92001-dac-gang = /bits/ 8 <0>;\n> > + };\n> > +};\n> > -- \n> > 2.13.0\n> > \n> --\n> To unsubscribe from this list: send the line \"unsubscribe linux-iio\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=jic23@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs0sB3FwRz9sNV\n\tfor ;\n\tTue, 12 Sep 2017 20:09:50 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751435AbdILKJf (ORCPT\n\t);\n\tTue, 12 Sep 2017 06:09:35 -0400","from mail.kernel.org ([198.145.29.99]:58918 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751385AbdILKJd (ORCPT );\n\tTue, 12 Sep 2017 06:09:33 -0400","from archlinux (unknown [37.205.56.238])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id C1AB72190B;\n\tTue, 12 Sep 2017 10:09:27 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org C1AB72190B","Date":"Tue, 12 Sep 2017 11:09:23 +0100","From":"Jonathan Cameron ","To":"Rob Herring ","Cc":"s.abhisit@gmail.com, linus.walleij@linaro.org,\n\tlee.jones@linaro.org, Jonathan.Cameron@huawei.com,\n\tpmeerw@pmeerw.net, jacopo@jmondi.org, linux-kernel@vger.kernel.org,\n\tknaack.h@gmx.de, lars@metafoo.de, fabrice.gasnier@st.com,\n\takinobu.mita@gmail.com, marek.vasut+renesas@gmail.com,\n\tjacopo+renesas@jmondi.org, mike.looijmans@topic.nl,\n\tpeda@axentia.se, jeff.dagenais@gmail.com,\n\tlinux-iio@vger.kernel.org, linux-gpio@vger.kernel.org,\n\tmark.rutland@arm.com, devicetree@vger.kernel.org, lukas@wunner.de,\n\tadi.reus@gmail.com","Subject":"Re: [PATCH 5/5] lmp92001: mfd: doc: Add support LMP92001","Message-ID":"<20170912110923.0f80c116@archlinux>","In-Reply-To":"<20170911215841.jaaipbdcf5hchjck@rob-hp-laptop>","References":"<20170830182528.9479-1-s.abhisit@gmail.com>\n\t<20170911215841.jaaipbdcf5hchjck@rob-hp-laptop>","X-Mailer":"Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu)","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1767073,"web_url":"http://patchwork.ozlabs.org/comment/1767073/","msgid":"","list_archive_url":null,"date":"2017-09-12T13:45:23","subject":"Re: [PATCH 5/5] lmp92001: mfd: doc: Add support LMP92001","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Tue, Sep 12, 2017 at 5:09 AM, Jonathan Cameron wrote:\n> On Mon, 11 Sep 2017 16:58:41 -0500\n> Rob Herring wrote:\n>\n>> On Thu, Aug 31, 2017 at 01:25:28AM +0700, s.abhisit@gmail.com wrote:\n>> > From: Abhisit Sangjan \n>> >\n>> > TI LMP92001 Analog System Monitor and Controller\n>> >\n>> > 8-bit GPIOs.\n>> > 12 DACs with 12-bit resolution.\n>> >\n>> > The GPIOs and DACs are shared port function with Cy function pin to\n>> > take control the pin suddenly from external hardware.\n>> > DAC's referance voltage selectable for Internal/External.\n>> >\n>> > 16 + 1 ADCs with 12-bit resolution.\n>> >\n>> > Built-in internal Temperature Sensor on channel 17.\n>> > Window Comparator Function is supported on channel 1-3 and 9-11 for\n>> > monitoring with interrupt signal (pending to implement for interrupt).\n>> > ADC's referance voltage selectable for Internal/External.\n>> >\n>> > Signed-off-by: Abhisit Sangjan \n>> > ---\n>> > Documentation/ABI/testing/sysfs-bus-iio-lmp920001 | 65 ++++++++++++++++++++++\n>> > .../devicetree/bindings/gpio/gpio-lmp92001.txt | 22 ++++++++\n>>\n>> As Jonathan said, please split.\n>>\n>> > .../bindings/iio/adc/ti-lmp92001-adc.txt | 20 +++++++\n>> > .../bindings/iio/dac/ti-lmp92001-dac.txt | 35 ++++++++++++\n>> > 4 files changed, 142 insertions(+)\n>> > create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-lmp920001\n>> > create mode 100644 Documentation/devicetree/bindings/gpio/gpio-lmp92001.txt\n>> > create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-lmp92001-adc.txt\n>> > create mode 100644 Documentation/devicetree/bindings/iio/dac/ti-lmp92001-dac.txt\n>>\n>> [...]\n>>\n>> > diff --git a/Documentation/devicetree/bindings/gpio/gpio-lmp92001.txt b/Documentation/devicetree/bindings/gpio/gpio-lmp92001.txt\n>> > new file mode 100644\n>> > index 000000000000..f9a18c492145\n>> > --- /dev/null\n>> > +++ b/Documentation/devicetree/bindings/gpio/gpio-lmp92001.txt\n>> > @@ -0,0 +1,22 @@\n>> > +* Texas Instruments' LMP92001 GPIOs\n>> > +\n>>\n>> Need to state what this is a child of and refer to that binding doc.\n>> Same for the others.\n>>\n>> > +Required properties:\n>> > + - compatible: Must be set to \"ti,lmp92001-gpio\".\n>> > + - reg: i2c chip address for the device.\n>>\n>> ? That's for the parent.\n>>\n>> > + - gpio-controller: Marks the device node as a gpio controller.\n>> > + - #gpio-cells : Should be two. The first cell is the pin number and the\n>> > + second cell is used to specify the gpio polarity:\n>> > + 0 = Active high\n>> > + 1 = Active low\n>> > +\n>> > +Example:\n>> > +lmp92001@20 {\n>> > + compatible = \"ti,lmp92001\";\n>> > + reg = <0x20>;\n>> > +\n>> > + gpio-controller {\n>>\n>> Should be \"gpio {\"\n>>\n>> > + compatible = \"ti,lmp92001-gpio\";\n>> > + gpio-controller;\n>> > + #gpio-cells = <2>;\n>> > + };\n>> > +};\n>> > diff --git a/Documentation/devicetree/bindings/iio/adc/ti-lmp92001-adc.txt b/Documentation/devicetree/bindings/iio/adc/ti-lmp92001-adc.txt\n>> > new file mode 100644\n>> > index 000000000000..4565961bf511\n>> > --- /dev/null\n>> > +++ b/Documentation/devicetree/bindings/iio/adc/ti-lmp92001-adc.txt\n>> > @@ -0,0 +1,20 @@\n>> > +* Texas Instruments' LMP92001 ADCs\n>> > +\n>> > +Required properties:\n>> > + - compatible: Must be set to \"ti,lmp92001-adc\".\n>> > + - reg: i2c chip address for the device.\n>> > + - ti,lmp92001-adc-mask: bit mask for which channel is enable.\n>> > + 0 = Off\n>> > + 1 = On\n>> > +\n>> > +Example:\n>> > +lmp92001@20 {\n>> > + compatible = \"ti,lmp92001\";\n>> > + reg = <0x20>;\n>> > +\n>> > + lmp92001-adc {\n>>\n>> adc {\n>>\n>> > + compatible = \"ti,lmp92001-adc\";\n>> > + ti,lmp92001-adc-mode = \"continuous\";\n>>\n>> Not documented and I believe we're going to add a common property for\n>> this.\n>\n> Possibly. I'm not keen on it being explicitly controlled in general.\n> It isn't a feature of the hardware in this case (I think) and as userspace\n> control it is very hard for userspace to know what to do with it -\n> normally it is better to put sufficient smarts in the driver to handle\n> this transparently from either dt or userspace abi point of view.\n\nThat certainly makes sense.\n\nNo property or common property. Your choice. :)\n\nRob\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=robh@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs5fQ10c8z9s7C\n\tfor ;\n\tTue, 12 Sep 2017 23:45:50 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751404AbdILNpq (ORCPT\n\t);\n\tTue, 12 Sep 2017 09:45:46 -0400","from mail.kernel.org ([198.145.29.99]:45182 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751366AbdILNpp (ORCPT );\n\tTue, 12 Sep 2017 09:45:45 -0400","from mail-qk0-f180.google.com (mail-qk0-f180.google.com\n\t[209.85.220.180])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id CDE1821E91;\n\tTue, 12 Sep 2017 13:45:44 +0000 (UTC)","by mail-qk0-f180.google.com with SMTP id r141so25087488qke.2;\n\tTue, 12 Sep 2017 06:45:44 -0700 (PDT)","by 10.12.209.75 with HTTP; Tue, 12 Sep 2017 06:45:23 -0700 (PDT)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org CDE1821E91","X-Gm-Message-State":"AHPjjUgqIRaaxxf/4+dBtT4vo9RT4NOMO8v0dd6IXoGqQRGrtyBtWRy5\n\tC423ZonqIkA6HwY00+qxisMcMo/77g==","X-Google-Smtp-Source":"AOwi7QAs4MpezH2CHrAZSTQ4cbJx+wQLBlvzoqUsOnihFtfc9Lc7kL6UIFgXOPGb7Zz6zT3/no8Iw06+764sNEOTnUM=","X-Received":"by 10.55.95.71 with SMTP id t68mr9613444qkb.233.1505223943919;\n\tTue, 12 Sep 2017 06:45:43 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170912110923.0f80c116@archlinux>","References":"<20170830182528.9479-1-s.abhisit@gmail.com>\n\t<20170911215841.jaaipbdcf5hchjck@rob-hp-laptop>\n\t<20170912110923.0f80c116@archlinux>","From":"Rob Herring ","Date":"Tue, 12 Sep 2017 08:45:23 -0500","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH 5/5] lmp92001: mfd: doc: Add support LMP92001","To":"Jonathan Cameron ","Cc":"Abhisit Sangjan , Linus Walleij\n\t, Lee Jones , Jonathan\n\tCameron , Peter Meerwald\n\t, jmondi , \n\t\"linux-kernel@vger.kernel.org\" ,\n\tHartmut Knaack , Lars-Peter Clausen , \n\tFabrice Gasnier , \"akinobu.mita@gmail.com\"\n\t, Marek Vasut ,\n\tJacopo Mondi , \n\tMike Looijmans , Peter Rosin , \n\t=?utf-8?q?Jean-Fran=C3=A7ois_Dagenais?= ,\n\t\"linux-iio@vger.kernel.org\" , \n\t\"linux-gpio@vger.kernel.org\" , \n\tMark Rutland , \"devicetree@vger.kernel.org\"\n\t, Lukas Wunner ,\n\tAdriana Reus ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]