[{"id":1766789,"web_url":"http://patchwork.ozlabs.org/comment/1766789/","msgid":"","list_archive_url":null,"date":"2017-09-12T09:11:06","subject":"Re: [PATCH 4/5] lmp92001: mfd: gpio: Add support LMP92001","submitter":{"id":7055,"url":"http://patchwork.ozlabs.org/api/people/7055/","name":"Linus Walleij","email":"linus.walleij@linaro.org"},"content":"On Wed, Aug 30, 2017 at 8:21 PM, wrote:\n\n> From: Abhisit Sangjan \n>\n> TI LMP92001 Analog System Monitor and Controller\n>\n> 8-bit GPIOs.\n> 12 DACs with 12-bit resolution.\n>\n> The GPIOs and DACs are shared port function with Cy function pin to\n> take control the pin suddenly from external hardware.\n> DAC's referance voltage selectable for Internal/External.\n>\n> 16 + 1 ADCs with 12-bit resolution.\n>\n> Built-in internal Temperature Sensor on channel 17.\n> Window Comparator Function is supported on channel 1-3 and 9-11 for\n> monitoring with interrupt signal (pending to implement for interrupt).\n> ADC's referance voltage selectable for Internal/External.\n>\n> Signed-off-by: Abhisit Sangjan \n\nMaybe you can trim the commit message to only be about\nGPIO on this patch, since it is only about GPIO?\n\n> +config GPIO_LMP92001\n> + tristate \"LMP92001 GPIOs\"\n> + depends on MFD_LMP92001\n\nselect GPIOLIB\n\n> +static int __init lmp92001_gpio_init(void)\n> +{\n> + return platform_driver_register(&lmp92001_gpio_driver);\n> +}\n> +subsys_initcall(lmp92001_gpio_init);\n> +\n> +static void __exit lmp92001_gpio_exit(void)\n> +{\n> + platform_driver_unregister(&lmp92001_gpio_driver);\n> +}\n> +module_exit(lmp92001_gpio_exit);\n\nIs this necessary? Can't you just have module_platform_driver() and be\ndone with it?\n\nYours,\nLinus Walleij\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"GQi2bTCe\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrzZ80f6sz9s81\n\tfor ;\n\tTue, 12 Sep 2017 19:11:44 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751761AbdILJLK (ORCPT );\n\tTue, 12 Sep 2017 05:11:10 -0400","from mail-it0-f54.google.com ([209.85.214.54]:46763 \"EHLO\n\tmail-it0-f54.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751751AbdILJLI (ORCPT\n\t); Tue, 12 Sep 2017 05:11:08 -0400","by mail-it0-f54.google.com with SMTP id 6so21615023itl.1\n\tfor ;\n\tTue, 12 Sep 2017 02:11:07 -0700 (PDT)","by 10.79.164.78 with HTTP; Tue, 12 Sep 2017 02:11:06 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=Xa5w7pmVxmVD71oTtsSTTmDMXIz5MuoL1mtfCybAfHA=;\n\tb=GQi2bTCe7eN4TE5KHiUjE9PKyxJADy7dyiismIuTlbqKIU9rGANrFefPADpbn4k2kD\n\t4cxiogSHp/oPex1CVzgiMoGe4DFQ4NkcQfWc4Arj1lmFQ23CC2p9gCNb3ZeIYgDoCpLo\n\tUE3wKFI0LtdHbf/pjx2K5tB6iZL6UHM3qsVGQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=Xa5w7pmVxmVD71oTtsSTTmDMXIz5MuoL1mtfCybAfHA=;\n\tb=RhynDvZa6OOmNqo5X+/LTebS+k/Oa3NGz0JUeOrwCDCjOMOfoF0d0z6a4cDLXICugt\n\tI9zP6rj6nDJBngSAu641kUghml8f7Lzsre0p2jezwNQZ8GWZhtsuHO7EulWJE4qXugYT\n\tmUXVbE7X5a0HNafSecu7hfvajkURMWQQyu1/7d5DRYc3MCYMmcCd29LE9wI63rLwlUnG\n\tNUZqABxYn7ZB/vCiAYo8qs1TdbW0xvlbPeG7nw/Dpf/6ivV3lDaLO9LMDi+6YWemjtDs\n\t65mGUWyyaP3hJX4fJ67A8DlY5M/fXzQ46xrPGhz6/8t5vwuqGxAilZbAbBd1hcha0Xqd\n\tmscw==","X-Gm-Message-State":"AHPjjUjJivOfg6zlKKyz2CnvqT/YX7lDbsYFXpSE7H7AOz9qNSymvp/5\n\t1incTZo431Q+drxlT5fwbnDzW5KehpKxOFqlukJBhg==","X-Google-Smtp-Source":"AOwi7QCoYi0GgS/yYqiAUhM3D0Pn6Csx9AHp3evKaxOaVQHKTpXfi712znYh2qct4LuMOeRlvtLJGZ09pzoJZuXcCos=","X-Received":"by 10.36.123.200 with SMTP id q191mr61411itc.83.1505207467367;\n\tTue, 12 Sep 2017 02:11:07 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170830182100.9311-1-s.abhisit@gmail.com>","References":"<20170830182100.9311-1-s.abhisit@gmail.com>","From":"Linus Walleij ","Date":"Tue, 12 Sep 2017 11:11:06 +0200","Message-ID":"","Subject":"Re: [PATCH 4/5] lmp92001: mfd: gpio: Add support LMP92001","To":"Abhisit Sangjan ","Cc":"\"linux-kernel@vger.kernel.org\" ,\n\t\"linux-gpio@vger.kernel.org\" ,\n\tPeter Meerwald ,\n\tJonathan Cameron ,\n\tjacopo , Lars-Peter Clausen ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}}]