[{"id":1760786,"web_url":"http://patchwork.ozlabs.org/comment/1760786/","msgid":"<90e51e4d-26d2-ebfd-626f-ec718e6521f3@redhat.com>","list_archive_url":null,"date":"2017-08-31T09:37:04","subject":"Re: [Qemu-devel] [PATCH v1 11/11] target/s390x: use\n\tprogram_interrupt() in per_check_exception()","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 30.08.2017 19:06, David Hildenbrand wrote:\n> I am not sure if we are handling ilen the right way here. ilen should\n> always match the instruction triggering the exception. This is relevant\n> for per exceptions triggered via EXECUTE instructions. The ilen to be\n> indicated has to match the EXECUTE instruction.\n> \n> Clean it up for now but leave ilen as is, we can fix that later.\n> \n> Signed-off-by: David Hildenbrand \n> ---\n> target/s390x/misc_helper.c | 9 +++------\n> 1 file changed, 3 insertions(+), 6 deletions(-)\n> \n> diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c\n> index eb7accc0ce..ac9657f23f 100644\n> --- a/target/s390x/misc_helper.c\n> +++ b/target/s390x/misc_helper.c\n> @@ -445,14 +445,11 @@ void HELPER(chsc)(CPUS390XState *env, uint64_t inst)\n> #ifndef CONFIG_USER_ONLY\n> void HELPER(per_check_exception)(CPUS390XState *env)\n> {\n> - CPUState *cs = CPU(s390_env_get_cpu(env));\n> + uint32_t ilen;\n> \n> if (env->per_perc_atmid) {\n> - env->int_pgm_code = PGM_PER;\n> - env->int_pgm_ilen = get_ilen(cpu_ldub_code(env, env->per_address));\n> -\n> - cs->exception_index = EXCP_PGM;\n> - cpu_loop_exit(cs);\n> + ilen = get_ilen(cpu_ldub_code(env, env->per_address));\n> + program_interrupt(env, PGM_PER, ilen);\n> }\n> }\n\nThe changes basically look fine to me, but may I suggest to\n1) Add a comment to the code about your concerns with ilen\n2) Change the patch description to focus on the work that is actually\ndone here instead of only talking about your ilen concerns?\n\n Thanks,\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjcjl6Bpxz9s83\n\tfor ;\n\tThu, 31 Aug 2017 19:37:47 +1000 (AEST)","from localhost ([::1]:54672 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnLuz-0001Ex-Um\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 05:37:45 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57202)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnLuT-0001Dp-1p\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 05:37:13 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnLuP-0008Os-Uk\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 05:37:13 -0400","from mx1.redhat.com ([209.132.183.28]:54600)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnLuP-0008Od-OI\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 05:37:09 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id CFB3E13A94;\n\tThu, 31 Aug 2017 09:37:08 +0000 (UTC)","from [10.36.116.27] (ovpn-116-27.ams2.redhat.com [10.36.116.27])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 62E3F9C134;\n\tThu, 31 Aug 2017 09:37:05 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com CFB3E13A94","To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170830170601.15855-1-david@redhat.com>\n\t<20170830170601.15855-12-david@redhat.com>","From":"Thomas Huth ","Message-ID":"<90e51e4d-26d2-ebfd-626f-ec718e6521f3@redhat.com>","Date":"Thu, 31 Aug 2017 11:37:04 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170830170601.15855-12-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tThu, 31 Aug 2017 09:37:09 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 11/11] target/s390x: use\n\tprogram_interrupt() in per_check_exception()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"borntraeger@de.ibm.com, cohuck@redhat.com,\n\tRichard Henderson ,\n\tAlexander Graf , Aurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]