[{"id":1760481,"web_url":"http://patchwork.ozlabs.org/comment/1760481/","msgid":"","list_archive_url":null,"date":"2017-08-30T20:45:58","subject":"Re: [Qemu-devel] [PATCH v1 09/11] target/s390x:\n\ttcg_s390_program_interrupt() will never return","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 30.08.2017 19:05, David Hildenbrand wrote:\n> The assert should hold in both scenarios.\n> \n> Signed-off-by: David Hildenbrand \n> ---\n> target/s390x/interrupt.c | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/target/s390x/interrupt.c b/target/s390x/interrupt.c\n> index 058e219fe5..79bab5e2f3 100644\n> --- a/target/s390x/interrupt.c\n> +++ b/target/s390x/interrupt.c\n> @@ -32,9 +32,8 @@ static void tcg_s390_program_interrupt(CPUS390XState *env, uint32_t code,\n> #ifdef CONFIG_TCG\n> trigger_pgm_exception(env, code, ilen);\n> cpu_loop_exit(CPU(s390_env_get_cpu(env)));\n> -#else\n> - g_assert_not_reached();\n> #endif\n> + g_assert_not_reached();\n> }\n\nNot sure if this really makes sense ... cpu_loop_exit() is already\nmarked with QEMU_NORETURN, so a know-it-all new version of GCC might\ncomplain one day if there's other code after this call. I'd better keep\nit the way it is.\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjHbk5wVyz9s7M\n\tfor ;\n\tThu, 31 Aug 2017 06:46:26 +1000 (AEST)","from localhost ([::1]:52605 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn9sW-0002lp-Vy\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 16:46:25 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60536)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn9sE-0002lh-7S\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 16:46:07 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn9sD-0008LK-H0\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 16:46:06 -0400","from mx1.redhat.com ([209.132.183.28]:53832)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dn9sD-0008L0-AR\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 16:46:05 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 3C83A883AE;\n\tWed, 30 Aug 2017 20:46:04 +0000 (UTC)","from [10.36.116.28] (ovpn-116-28.ams2.redhat.com [10.36.116.28])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 34B9F5C7BE;\n\tWed, 30 Aug 2017 20:46:00 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 3C83A883AE","To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170830170601.15855-1-david@redhat.com>\n\t<20170830170601.15855-10-david@redhat.com>","From":"Thomas Huth ","Message-ID":"","Date":"Wed, 30 Aug 2017 22:45:58 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170830170601.15855-10-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tWed, 30 Aug 2017 20:46:04 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 09/11] target/s390x:\n\ttcg_s390_program_interrupt() will never return","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"borntraeger@de.ibm.com, cohuck@redhat.com,\n\tRichard Henderson ,\n\tAlexander Graf , Aurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1760903,"web_url":"http://patchwork.ozlabs.org/comment/1760903/","msgid":"","list_archive_url":null,"date":"2017-08-31T12:14:28","subject":"Re: [Qemu-devel] [PATCH v1 09/11] target/s390x:\n\ttcg_s390_program_interrupt() will never return","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 30.08.2017 22:45, Thomas Huth wrote:\n> On 30.08.2017 19:05, David Hildenbrand wrote:\n>> The assert should hold in both scenarios.\n>>\n>> Signed-off-by: David Hildenbrand \n>> ---\n>> target/s390x/interrupt.c | 3 +--\n>> 1 file changed, 1 insertion(+), 2 deletions(-)\n>>\n>> diff --git a/target/s390x/interrupt.c b/target/s390x/interrupt.c\n>> index 058e219fe5..79bab5e2f3 100644\n>> --- a/target/s390x/interrupt.c\n>> +++ b/target/s390x/interrupt.c\n>> @@ -32,9 +32,8 @@ static void tcg_s390_program_interrupt(CPUS390XState *env, uint32_t code,\n>> #ifdef CONFIG_TCG\n>> trigger_pgm_exception(env, code, ilen);\n>> cpu_loop_exit(CPU(s390_env_get_cpu(env)));\n>> -#else\n>> - g_assert_not_reached();\n>> #endif\n>> + g_assert_not_reached();\n>> }\n> \n> Not sure if this really makes sense ... cpu_loop_exit() is already\n> marked with QEMU_NORETURN, so a know-it-all new version of GCC might\n> complain one day if there's other code after this call. I'd better keep\n> it the way it is.\n\nGood point, I'll drop this patch. Thanks!\n\n> \n> Thomas\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjhCk44y1z9s83\n\tfor ;\n\tThu, 31 Aug 2017 22:15:30 +1000 (AEST)","from localhost ([::1]:55497 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnONb-0005kj-EO\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 08:15:27 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40261)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnOMn-0005WM-Vt\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 08:14:43 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnOMi-0000XD-3R\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 08:14:37 -0400","from mx1.redhat.com ([209.132.183.28]:34776)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnOMh-0000Wr-TK\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 08:14:32 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C806D81DE2;\n\tThu, 31 Aug 2017 12:14:30 +0000 (UTC)","from [10.36.118.11] (unknown [10.36.118.11])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 305EE9351A;\n\tThu, 31 Aug 2017 12:14:29 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C806D81DE2","To":"Thomas Huth , qemu-devel@nongnu.org","References":"<20170830170601.15855-1-david@redhat.com>\n\t<20170830170601.15855-10-david@redhat.com>\n\t","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"","Date":"Thu, 31 Aug 2017 14:14:28 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tThu, 31 Aug 2017 12:14:31 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 09/11] target/s390x:\n\ttcg_s390_program_interrupt() will never return","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"borntraeger@de.ibm.com, cohuck@redhat.com,\n\tRichard Henderson ,\n\tAlexander Graf , Aurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]