[{"id":1761062,"web_url":"http://patchwork.ozlabs.org/comment/1761062/","msgid":"<20170831163513.17c0a963.cohuck@redhat.com>","list_archive_url":null,"date":"2017-08-31T14:35:13","subject":"Re: [Qemu-devel] [PATCH v1 06/11] target/s390x: cleanup cpu\n\tnumber/address handling","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Wed, 30 Aug 2017 19:05:56 +0200\nDavid Hildenbrand wrote:\n\n> Some time ago we discussed that using \"id\" as property name is not the\n> right thing to do, as it is a reserved property for other devices.\n> \n> Switch to the term \"addr\" instead, which matches the definition in the\n> PoP called \"CPU address\". There is no such thing as cpu number, so\n> rename env.cpu_num to env.cpu_addr.\n> \n> We can get rid of cpu->id now. Keep cpu->index and env->cpu_addr in sync.\n> cpu->index was already implicitly used by e.g. cpu_exists(), so keeping\n> both in sync seems to be the right thing to do.\n> \n> cpu->index will now no longer automatically get set via\n> cpu_exec_realizefn(). For now, we were lucky that both implicitly stayed\n> in sync.\n> \n> Our new cpu property \"addr\" can be a static property. Range checks can\n> be avoided by using the correct type and the \"setting after realized\"\n> check is done implicitly.\n> \n> AFAIK, s390x only supports cpu_add and not device_add for cpus. So we\n> should be able to safely rename that property (no the \"id\" property\n> could properly be used for device_add, which needs an artificial id for\n> identification purposes).\n\nI cannot parse the sentence in the brackets...\n\n> \n> Signed-off-by: David Hildenbrand \n> ---\n> hw/s390x/s390-virtio-ccw.c | 2 +-\n> target/s390x/cpu.c | 69 ++++++++++++----------------------------------\n> target/s390x/cpu.h | 5 ++--\n> target/s390x/cpu_models.c | 2 +-\n> target/s390x/excp_helper.c | 2 +-\n> target/s390x/helper.c | 4 +--\n> target/s390x/misc_helper.c | 4 +--\n> target/s390x/translate.c | 5 +---\n> 8 files changed, 28 insertions(+), 65 deletions(-)\n\n...the patch seems fine, though :)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjlL22ycnz9s7G\n\tfor ;\n\tFri, 1 Sep 2017 00:36:10 +1000 (AEST)","from localhost ([::1]:56105 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnQZk-0000YE-IV\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 10:36:08 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47146)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnQZJ-0000W9-1p\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 10:35:42 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnQZE-0003pq-0f\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 10:35:41 -0400","from mx1.redhat.com ([209.132.183.28]:42879)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnQZD-0003nv-RA\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 10:35:35 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id BACFE5F7AD;\n\tThu, 31 Aug 2017 14:35:34 +0000 (UTC)","from gondolin (ovpn-117-247.ams2.redhat.com [10.36.117.247])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 70993C4512;\n\tThu, 31 Aug 2017 14:35:16 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com BACFE5F7AD","Date":"Thu, 31 Aug 2017 16:35:13 +0200","From":"Cornelia Huck ","To":"David Hildenbrand ","Message-ID":"<20170831163513.17c0a963.cohuck@redhat.com>","In-Reply-To":"<20170830170601.15855-7-david@redhat.com>","References":"<20170830170601.15855-1-david@redhat.com>\n\t<20170830170601.15855-7-david@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tThu, 31 Aug 2017 14:35:34 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 06/11] target/s390x: cleanup cpu\n\tnumber/address handling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, Richard Henderson ,\n\tqemu-devel@nongnu.org, Alexander Graf ,\n\tborntraeger@de.ibm.com, Aurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1761072,"web_url":"http://patchwork.ozlabs.org/comment/1761072/","msgid":"<0cada76f-2e43-01db-7c69-ba67e1539aa3@redhat.com>","list_archive_url":null,"date":"2017-08-31T14:41:47","subject":"Re: [Qemu-devel] [PATCH v1 06/11] target/s390x: cleanup cpu\n\tnumber/address handling","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 31.08.2017 16:35, Cornelia Huck wrote:\n> On Wed, 30 Aug 2017 19:05:56 +0200\n> David Hildenbrand wrote:\n> \n>> Some time ago we discussed that using \"id\" as property name is not the\n>> right thing to do, as it is a reserved property for other devices.\n>>\n>> Switch to the term \"addr\" instead, which matches the definition in the\n>> PoP called \"CPU address\". There is no such thing as cpu number, so\n>> rename env.cpu_num to env.cpu_addr.\n>>\n>> We can get rid of cpu->id now. Keep cpu->index and env->cpu_addr in sync.\n>> cpu->index was already implicitly used by e.g. cpu_exists(), so keeping\n>> both in sync seems to be the right thing to do.\n>>\n>> cpu->index will now no longer automatically get set via\n>> cpu_exec_realizefn(). For now, we were lucky that both implicitly stayed\n>> in sync.\n>>\n>> Our new cpu property \"addr\" can be a static property. Range checks can\n>> be avoided by using the correct type and the \"setting after realized\"\n>> check is done implicitly.\n>>\n>> AFAIK, s390x only supports cpu_add and not device_add for cpus. So we\n>> should be able to safely rename that property (no the \"id\" property\n>> could properly be used for device_add, which needs an artificial id for\n>> identification purposes).\n> \n> I cannot parse the sentence in the brackets...\n\nMe too :)\n\n...So we should be able to safely rename that property. device_add will\nlater need the reserved \"id\" property. Hotplugging a CPU would then look\nlike this: \"device_add host-s390-cpu id=cpu2 addr=2\".\n\n> \n>>\n>> Signed-off-by: David Hildenbrand \n>> ---\n>> hw/s390x/s390-virtio-ccw.c | 2 +-\n>> target/s390x/cpu.c | 69 ++++++++++++----------------------------------\n>> target/s390x/cpu.h | 5 ++--\n>> target/s390x/cpu_models.c | 2 +-\n>> target/s390x/excp_helper.c | 2 +-\n>> target/s390x/helper.c | 4 +--\n>> target/s390x/misc_helper.c | 4 +--\n>> target/s390x/translate.c | 5 +---\n>> 8 files changed, 28 insertions(+), 65 deletions(-)\n> \n> ...the patch seems fine, though :)\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjlWD3fD8z9s75\n\tfor ;\n\tFri, 1 Sep 2017 00:44:08 +1000 (AEST)","from localhost ([::1]:56143 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnQhS-0006SJ-Mc\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 10:44:06 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48913)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnQfL-0005J4-Kk\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 10:42:00 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnQfG-0006K1-VF\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 10:41:55 -0400","from mx1.redhat.com ([209.132.183.28]:51202)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnQfG-0006Jk-OD\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 10:41:50 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id A8DFA883CF;\n\tThu, 31 Aug 2017 14:41:49 +0000 (UTC)","from [10.36.118.11] (unknown [10.36.118.11])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id D8BB291848;\n\tThu, 31 Aug 2017 14:41:47 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com A8DFA883CF","To":"Cornelia Huck ","References":"<20170830170601.15855-1-david@redhat.com>\n\t<20170830170601.15855-7-david@redhat.com>\n\t<20170831163513.17c0a963.cohuck@redhat.com>","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"<0cada76f-2e43-01db-7c69-ba67e1539aa3@redhat.com>","Date":"Thu, 31 Aug 2017 16:41:47 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170831163513.17c0a963.cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tThu, 31 Aug 2017 14:41:49 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 06/11] target/s390x: cleanup cpu\n\tnumber/address handling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, Richard Henderson ,\n\tqemu-devel@nongnu.org, Alexander Graf ,\n\tborntraeger@de.ibm.com, Aurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1761077,"web_url":"http://patchwork.ozlabs.org/comment/1761077/","msgid":"<20170831164938.04410ca7.cohuck@redhat.com>","list_archive_url":null,"date":"2017-08-31T14:49:38","subject":"Re: [Qemu-devel] [PATCH v1 06/11] target/s390x: cleanup cpu\n\tnumber/address handling","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Thu, 31 Aug 2017 16:41:47 +0200\nDavid Hildenbrand wrote:\n\n> On 31.08.2017 16:35, Cornelia Huck wrote:\n> > On Wed, 30 Aug 2017 19:05:56 +0200\n> > David Hildenbrand wrote:\n> > \n> >> Some time ago we discussed that using \"id\" as property name is not the\n> >> right thing to do, as it is a reserved property for other devices.\n> >>\n> >> Switch to the term \"addr\" instead, which matches the definition in the\n> >> PoP called \"CPU address\". There is no such thing as cpu number, so\n> >> rename env.cpu_num to env.cpu_addr.\n> >>\n> >> We can get rid of cpu->id now. Keep cpu->index and env->cpu_addr in sync.\n> >> cpu->index was already implicitly used by e.g. cpu_exists(), so keeping\n> >> both in sync seems to be the right thing to do.\n> >>\n> >> cpu->index will now no longer automatically get set via\n> >> cpu_exec_realizefn(). For now, we were lucky that both implicitly stayed\n> >> in sync.\n> >>\n> >> Our new cpu property \"addr\" can be a static property. Range checks can\n> >> be avoided by using the correct type and the \"setting after realized\"\n> >> check is done implicitly.\n> >>\n> >> AFAIK, s390x only supports cpu_add and not device_add for cpus. So we\n> >> should be able to safely rename that property (no the \"id\" property\n> >> could properly be used for device_add, which needs an artificial id for\n> >> identification purposes). \n> > \n> > I cannot parse the sentence in the brackets... \n> \n> Me too :)\n> \n> ...So we should be able to safely rename that property. device_add will\n> later need the reserved \"id\" property. Hotplugging a CPU would then look\n> like this: \"device_add host-s390-cpu id=cpu2 addr=2\".\n\nYup, that's understandable :)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjlfd0pywz9s75\n\tfor ;\n\tFri, 1 Sep 2017 00:50:33 +1000 (AEST)","from localhost ([::1]:56175 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnQnf-0001ia-8c\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 10:50:31 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52222)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnQn9-0001hC-WF\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 10:50:01 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnQn6-00014V-Uj\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 10:50:00 -0400","from mx1.redhat.com ([209.132.183.28]:51796)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnQn6-000148-NY\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 10:49:56 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 939197CB8F;\n\tThu, 31 Aug 2017 14:49:55 +0000 (UTC)","from gondolin (ovpn-117-247.ams2.redhat.com [10.36.117.247])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id D0876A2495;\n\tThu, 31 Aug 2017 14:49:40 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 939197CB8F","Date":"Thu, 31 Aug 2017 16:49:38 +0200","From":"Cornelia Huck ","To":"David Hildenbrand ","Message-ID":"<20170831164938.04410ca7.cohuck@redhat.com>","In-Reply-To":"<0cada76f-2e43-01db-7c69-ba67e1539aa3@redhat.com>","References":"<20170830170601.15855-1-david@redhat.com>\n\t<20170830170601.15855-7-david@redhat.com>\n\t<20170831163513.17c0a963.cohuck@redhat.com>\n\t<0cada76f-2e43-01db-7c69-ba67e1539aa3@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tThu, 31 Aug 2017 14:49:55 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 06/11] target/s390x: cleanup cpu\n\tnumber/address handling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, Richard Henderson ,\n\tqemu-devel@nongnu.org, Alexander Graf ,\n\tborntraeger@de.ibm.com, Aurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1761144,"web_url":"http://patchwork.ozlabs.org/comment/1761144/","msgid":"<20170831180352.7d6e1ecf@nial.brq.redhat.com>","list_archive_url":null,"date":"2017-08-31T16:03:52","subject":"Re: [Qemu-devel] [PATCH v1 06/11] target/s390x: cleanup cpu\n\tnumber/address handling","submitter":{"id":11305,"url":"http://patchwork.ozlabs.org/api/people/11305/","name":"Igor Mammedov","email":"imammedo@redhat.com"},"content":"On Thu, 31 Aug 2017 16:35:13 +0200\nCornelia Huck wrote:\n\n> On Wed, 30 Aug 2017 19:05:56 +0200\n> David Hildenbrand wrote:\n> \n> > Some time ago we discussed that using \"id\" as property name is not the\n> > right thing to do, as it is a reserved property for other devices.\n> > \n> > Switch to the term \"addr\" instead, which matches the definition in the\n> > PoP called \"CPU address\". There is no such thing as cpu number, so\n> > rename env.cpu_num to env.cpu_addr.\n> > \n> > We can get rid of cpu->id now. Keep cpu->index and env->cpu_addr in sync.\n> > cpu->index was already implicitly used by e.g. cpu_exists(), so keeping\n> > both in sync seems to be the right thing to do.\n> > \n> > cpu->index will now no longer automatically get set via\n> > cpu_exec_realizefn(). For now, we were lucky that both implicitly stayed\n> > in sync.\n> > \n> > Our new cpu property \"addr\" can be a static property. Range checks can\n> > be avoided by using the correct type and the \"setting after realized\"\n> > check is done implicitly.\n> > \n> > AFAIK, s390x only supports cpu_add and not device_add for cpus. So we\n> > should be able to safely rename that property (no the \"id\" property\n> > could properly be used for device_add, which needs an artificial id for\n> > identification purposes). \nthis patch seems to somewhat conflicting with\n https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg06505.html\nthat were supposed to go via machine tree and which I've respinned today\nto fix conflicts due just merged pull req.\n\nCornelia,\n\nCould you put/merge it via s390x tree so that David and I work won't clash again?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=imammedo@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjnJX3NFTz9sMN\n\tfor ;\n\tFri, 1 Sep 2017 02:04:59 +1000 (AEST)","from localhost ([::1]:56509 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnRxg-00056a-L9\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 12:04:56 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44212)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnRwp-00050d-4X\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 12:04:09 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnRwl-00021t-6l\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 12:04:03 -0400","from mx1.redhat.com ([209.132.183.28]:34068)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnRwk-00021W-Vo\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 12:03:59 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 02F5F7CDE7;\n\tThu, 31 Aug 2017 16:03:58 +0000 (UTC)","from nial.brq.redhat.com (unknown [10.43.2.241])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id A94855D9CB;\n\tThu, 31 Aug 2017 16:03:53 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 02F5F7CDE7","Date":"Thu, 31 Aug 2017 18:03:52 +0200","From":"Igor Mammedov ","To":"Cornelia Huck ","Message-ID":"<20170831180352.7d6e1ecf@nial.brq.redhat.com>","In-Reply-To":"<20170831163513.17c0a963.cohuck@redhat.com>","References":"<20170830170601.15855-1-david@redhat.com>\n\t<20170830170601.15855-7-david@redhat.com>\n\t<20170831163513.17c0a963.cohuck@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tThu, 31 Aug 2017 16:03:58 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 06/11] target/s390x: cleanup cpu\n\tnumber/address handling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, David Hildenbrand ,\n\tRichard Henderson ,\n\tAlexander Graf , qemu-devel@nongnu.org,\n\tborntraeger@de.ibm.com, Aurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1761150,"web_url":"http://patchwork.ozlabs.org/comment/1761150/","msgid":"<20170831180850.3b00fdcc.cohuck@redhat.com>","list_archive_url":null,"date":"2017-08-31T16:08:50","subject":"Re: [Qemu-devel] [PATCH v1 06/11] target/s390x: cleanup cpu\n\tnumber/address handling","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Thu, 31 Aug 2017 18:03:52 +0200\nIgor Mammedov wrote:\n\n> On Thu, 31 Aug 2017 16:35:13 +0200\n> Cornelia Huck wrote:\n> \n> > On Wed, 30 Aug 2017 19:05:56 +0200\n> > David Hildenbrand wrote:\n> > \n> > > Some time ago we discussed that using \"id\" as property name is not the\n> > > right thing to do, as it is a reserved property for other devices.\n> > > \n> > > Switch to the term \"addr\" instead, which matches the definition in the\n> > > PoP called \"CPU address\". There is no such thing as cpu number, so\n> > > rename env.cpu_num to env.cpu_addr.\n> > > \n> > > We can get rid of cpu->id now. Keep cpu->index and env->cpu_addr in sync.\n> > > cpu->index was already implicitly used by e.g. cpu_exists(), so keeping\n> > > both in sync seems to be the right thing to do.\n> > > \n> > > cpu->index will now no longer automatically get set via\n> > > cpu_exec_realizefn(). For now, we were lucky that both implicitly stayed\n> > > in sync.\n> > > \n> > > Our new cpu property \"addr\" can be a static property. Range checks can\n> > > be avoided by using the correct type and the \"setting after realized\"\n> > > check is done implicitly.\n> > > \n> > > AFAIK, s390x only supports cpu_add and not device_add for cpus. So we\n> > > should be able to safely rename that property (no the \"id\" property\n> > > could properly be used for device_add, which needs an artificial id for\n> > > identification purposes). \n> this patch seems to somewhat conflicting with\n> https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg06505.html\n> that were supposed to go via machine tree and which I've respinned today\n> to fix conflicts due just merged pull req.\n> \n> Cornelia,\n> \n> Could you put/merge it via s390x tree so that David and I work won't clash again?\n\nI can do that, sure. I can put your patch on top of David's.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=208.118.235.17; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [208.118.235.17])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjnR85Lp2z9sNr\n\tfor ;\n\tFri, 1 Sep 2017 02:10:44 +1000 (AEST)","from localhost ([::1]:56596 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnS3G-0001rm-LY\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 12:10:42 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:45825)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnS1j-0000eJ-Sk\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 12:09:11 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnS1e-0004FN-TS\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 12:09:07 -0400","from mx1.redhat.com ([209.132.183.28]:47232)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnS1e-0004Er-Mj\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 12:09:02 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B49EB20B17;\n\tThu, 31 Aug 2017 16:09:01 +0000 (UTC)","from gondolin (ovpn-117-247.ams2.redhat.com [10.36.117.247])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id E1A6492BBA;\n\tThu, 31 Aug 2017 16:08:53 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B49EB20B17","Date":"Thu, 31 Aug 2017 18:08:50 +0200","From":"Cornelia Huck ","To":"Igor Mammedov ","Message-ID":"<20170831180850.3b00fdcc.cohuck@redhat.com>","In-Reply-To":"<20170831180352.7d6e1ecf@nial.brq.redhat.com>","References":"<20170830170601.15855-1-david@redhat.com>\n\t<20170830170601.15855-7-david@redhat.com>\n\t<20170831163513.17c0a963.cohuck@redhat.com>\n\t<20170831180352.7d6e1ecf@nial.brq.redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tThu, 31 Aug 2017 16:09:01 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 06/11] target/s390x: cleanup cpu\n\tnumber/address handling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, David Hildenbrand ,\n\tRichard Henderson ,\n\tAlexander Graf , qemu-devel@nongnu.org,\n\tborntraeger@de.ibm.com, Aurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]