[{"id":1760778,"web_url":"http://patchwork.ozlabs.org/comment/1760778/","msgid":"<98048e5d-fa10-76a3-ce11-36a78212c259@redhat.com>","list_archive_url":null,"date":"2017-08-31T09:29:39","subject":"Re: [Qemu-devel] [PATCH v1 05/11] s390x: rename s390-virtio.h to\n\ts390-virtio-hcall.h","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 30.08.2017 19:05, David Hildenbrand wrote:\n> The only interface left, so let's properly rename it.\n> \n> Signed-off-by: David Hildenbrand \n> ---\n> hw/s390x/s390-virtio-ccw.c | 2 +-\n> hw/s390x/s390-virtio-hcall.c | 2 +-\n> hw/s390x/{s390-virtio.h => s390-virtio-hcall.h} | 2 +-\n> 3 files changed, 3 insertions(+), 3 deletions(-)\n> rename hw/s390x/{s390-virtio.h => s390-virtio-hcall.h} (92%)\n[...]\n> diff --git a/hw/s390x/s390-virtio.h b/hw/s390x/s390-virtio-hcall.h\n> similarity index 92%\n> rename from hw/s390x/s390-virtio.h\n> rename to hw/s390x/s390-virtio-hcall.h\n> index d984cd4115..64c5bbd827 100644\n> --- a/hw/s390x/s390-virtio.h\n> +++ b/hw/s390x/s390-virtio-hcall.h\n> @@ -1,5 +1,5 @@\n> /*\n> - * Virtio interfaces for s390\n> + * Support for virtio hypercalls on s390x\n> *\n> * Copyright 2012 IBM Corp.\n> * Author(s): Cornelia Huck \n> \n\nMaybe also rename the HW_S390_VIRTIO_H header guard? Anyway:\n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjcY535qHz9s7F\n\tfor ;\n\tThu, 31 Aug 2017 19:30:16 +1000 (AEST)","from localhost ([::1]:54641 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnLnh-0006Wl-PB\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 05:30:13 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55540)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnLnK-0006Wd-7b\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 05:29:51 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnLnH-0004v8-3F\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 05:29:50 -0400","from mx1.redhat.com ([209.132.183.28]:33354)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnLnG-0004uh-T9\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 05:29:47 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id A7286C047B61;\n\tThu, 31 Aug 2017 09:29:45 +0000 (UTC)","from [10.36.116.27] (ovpn-116-27.ams2.redhat.com [10.36.116.27])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 875B5B32A3;\n\tThu, 31 Aug 2017 09:29:40 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com A7286C047B61","To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170830170601.15855-1-david@redhat.com>\n\t<20170830170601.15855-6-david@redhat.com>","From":"Thomas Huth ","Message-ID":"<98048e5d-fa10-76a3-ce11-36a78212c259@redhat.com>","Date":"Thu, 31 Aug 2017 11:29:39 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170830170601.15855-6-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tThu, 31 Aug 2017 09:29:45 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 05/11] s390x: rename s390-virtio.h to\n\ts390-virtio-hcall.h","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"borntraeger@de.ibm.com, cohuck@redhat.com,\n\tRichard Henderson ,\n\tAlexander Graf , Aurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1760979,"web_url":"http://patchwork.ozlabs.org/comment/1760979/","msgid":"<21f4d734-8d7c-5ee9-33e2-0cc829d7d8ca@redhat.com>","list_archive_url":null,"date":"2017-08-31T13:18:08","subject":"Re: [Qemu-devel] [PATCH v1 05/11] s390x: rename s390-virtio.h to\n\ts390-virtio-hcall.h","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 31.08.2017 11:29, Thomas Huth wrote:\n> On 30.08.2017 19:05, David Hildenbrand wrote:\n>> The only interface left, so let's properly rename it.\n>>\n>> Signed-off-by: David Hildenbrand \n>> ---\n>> hw/s390x/s390-virtio-ccw.c | 2 +-\n>> hw/s390x/s390-virtio-hcall.c | 2 +-\n>> hw/s390x/{s390-virtio.h => s390-virtio-hcall.h} | 2 +-\n>> 3 files changed, 3 insertions(+), 3 deletions(-)\n>> rename hw/s390x/{s390-virtio.h => s390-virtio-hcall.h} (92%)\n> [...]\n>> diff --git a/hw/s390x/s390-virtio.h b/hw/s390x/s390-virtio-hcall.h\n>> similarity index 92%\n>> rename from hw/s390x/s390-virtio.h\n>> rename to hw/s390x/s390-virtio-hcall.h\n>> index d984cd4115..64c5bbd827 100644\n>> --- a/hw/s390x/s390-virtio.h\n>> +++ b/hw/s390x/s390-virtio-hcall.h\n>> @@ -1,5 +1,5 @@\n>> /*\n>> - * Virtio interfaces for s390\n>> + * Support for virtio hypercalls on s390x\n>> *\n>> * Copyright 2012 IBM Corp.\n>> * Author(s): Cornelia Huck \n>>\n> \n> Maybe also rename the HW_S390_VIRTIO_H header guard? Anyway:\n> \n> Reviewed-by: Thomas Huth \n> \n\nSure, will do. Is HW_S390_VIRTIO_HCALL_H okay?\n\n(HW_S390X_S390_VIRTIO_HCALL_H doesn't sound necessary)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjjcw66c0z9sMN\n\tfor ;\n\tThu, 31 Aug 2017 23:18:55 +1000 (AEST)","from localhost ([::1]:55780 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnPMz-0002p9-CO\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 09:18:53 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:54881)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnPMO-0002m7-7v\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:18:20 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnPMK-0001Mm-3m\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:18:16 -0400","from mx1.redhat.com ([209.132.183.28]:36438)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnPMJ-0001LB-Td\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:18:12 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B5E604E4C3;\n\tThu, 31 Aug 2017 13:18:10 +0000 (UTC)","from [10.36.118.11] (unknown [10.36.118.11])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 4BE779ABBC;\n\tThu, 31 Aug 2017 13:18:09 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B5E604E4C3","To":"Thomas Huth , qemu-devel@nongnu.org","References":"<20170830170601.15855-1-david@redhat.com>\n\t<20170830170601.15855-6-david@redhat.com>\n\t<98048e5d-fa10-76a3-ce11-36a78212c259@redhat.com>","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"<21f4d734-8d7c-5ee9-33e2-0cc829d7d8ca@redhat.com>","Date":"Thu, 31 Aug 2017 15:18:08 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<98048e5d-fa10-76a3-ce11-36a78212c259@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tThu, 31 Aug 2017 13:18:10 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 05/11] s390x: rename s390-virtio.h to\n\ts390-virtio-hcall.h","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"borntraeger@de.ibm.com, cohuck@redhat.com,\n\tRichard Henderson ,\n\tAlexander Graf , Aurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1760981,"web_url":"http://patchwork.ozlabs.org/comment/1760981/","msgid":"","list_archive_url":null,"date":"2017-08-31T13:20:09","subject":"Re: [Qemu-devel] [PATCH v1 05/11] s390x: rename s390-virtio.h to\n\ts390-virtio-hcall.h","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 31.08.2017 15:18, David Hildenbrand wrote:\n> On 31.08.2017 11:29, Thomas Huth wrote:\n>> On 30.08.2017 19:05, David Hildenbrand wrote:\n>>> The only interface left, so let's properly rename it.\n>>>\n>>> Signed-off-by: David Hildenbrand \n>>> ---\n>>> hw/s390x/s390-virtio-ccw.c | 2 +-\n>>> hw/s390x/s390-virtio-hcall.c | 2 +-\n>>> hw/s390x/{s390-virtio.h => s390-virtio-hcall.h} | 2 +-\n>>> 3 files changed, 3 insertions(+), 3 deletions(-)\n>>> rename hw/s390x/{s390-virtio.h => s390-virtio-hcall.h} (92%)\n>> [...]\n>>> diff --git a/hw/s390x/s390-virtio.h b/hw/s390x/s390-virtio-hcall.h\n>>> similarity index 92%\n>>> rename from hw/s390x/s390-virtio.h\n>>> rename to hw/s390x/s390-virtio-hcall.h\n>>> index d984cd4115..64c5bbd827 100644\n>>> --- a/hw/s390x/s390-virtio.h\n>>> +++ b/hw/s390x/s390-virtio-hcall.h\n>>> @@ -1,5 +1,5 @@\n>>> /*\n>>> - * Virtio interfaces for s390\n>>> + * Support for virtio hypercalls on s390x\n>>> *\n>>> * Copyright 2012 IBM Corp.\n>>> * Author(s): Cornelia Huck \n>>>\n>>\n>> Maybe also rename the HW_S390_VIRTIO_H header guard? Anyway:\n>>\n>> Reviewed-by: Thomas Huth \n>>\n> \n> Sure, will do. Is HW_S390_VIRTIO_HCALL_H okay?\n\nSounds fine.\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjjgP6XdSz9sPm\n\tfor ;\n\tThu, 31 Aug 2017 23:21:05 +1000 (AEST)","from localhost ([::1]:55796 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnPP6-0004H3-0V\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 09:21:04 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55581)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnPOP-0004AB-3A\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:20:28 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnPOJ-0002AX-R8\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:20:21 -0400","from mx1.redhat.com ([209.132.183.28]:41242)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnPOJ-0002AP-Jy\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:20:15 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 946D57E447;\n\tThu, 31 Aug 2017 13:20:14 +0000 (UTC)","from [10.36.116.27] (ovpn-116-27.ams2.redhat.com [10.36.116.27])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id BE4ED841D6;\n\tThu, 31 Aug 2017 13:20:10 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 946D57E447","To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170830170601.15855-1-david@redhat.com>\n\t<20170830170601.15855-6-david@redhat.com>\n\t<98048e5d-fa10-76a3-ce11-36a78212c259@redhat.com>\n\t<21f4d734-8d7c-5ee9-33e2-0cc829d7d8ca@redhat.com>","From":"Thomas Huth ","Message-ID":"","Date":"Thu, 31 Aug 2017 15:20:09 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<21f4d734-8d7c-5ee9-33e2-0cc829d7d8ca@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tThu, 31 Aug 2017 13:20:14 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 05/11] s390x: rename s390-virtio.h to\n\ts390-virtio-hcall.h","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"borntraeger@de.ibm.com, cohuck@redhat.com,\n\tRichard Henderson ,\n\tAlexander Graf , Aurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]