[{"id":1761054,"web_url":"http://patchwork.ozlabs.org/comment/1761054/","msgid":"<20170831162302.1826247f.cohuck@redhat.com>","list_archive_url":null,"date":"2017-08-31T14:23:02","subject":"Re: [Qemu-devel] [PATCH v1 02/11] cpu: drop old comments describing\n\tmembers","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Wed, 30 Aug 2017 19:05:52 +0200\nDavid Hildenbrand wrote:\n\n> These comments are obviously stale.\n> \n> Signed-off-by: David Hildenbrand \n> ---\n> include/qom/cpu.h | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/include/qom/cpu.h b/include/qom/cpu.h\n> index 25eefea7ab..6b4b838e8f 100644\n> --- a/include/qom/cpu.h\n> +++ b/include/qom/cpu.h\n> @@ -378,10 +378,10 @@ struct CPUState {\n> DECLARE_BITMAP(trace_dstate, CPU_TRACE_DSTATE_MAX_EVENTS);\n> \n> /* TODO Move common fields from CPUArchState here. */\n> - int cpu_index; /* used by alpha TCG */\n> - uint32_t halted; /* used by alpha, cris, ppc TCG */\n> + int cpu_index;\n> + uint32_t halted;\n> uint32_t can_do_io;\n> - int32_t exception_index; /* used by m68k TCG */\n> + int32_t exception_index;\n> \n> /* shared by kvm, hax and hvf */\n> bool vcpu_dirty;\n\nYup, no need to drag these around. In case I don't take this through\ns390-next:\n\nAcked-by: Cornelia Huck ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjl3v557lz9s83\n\tfor ;\n\tFri, 1 Sep 2017 00:23:55 +1000 (AEST)","from localhost ([::1]:56037 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnQNt-0006rE-R9\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 10:23:53 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42947)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnQNH-0006pt-Ky\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 10:23:16 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnQND-00075p-1b\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 10:23:15 -0400","from mx1.redhat.com ([209.132.183.28]:37979)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnQNC-00075O-RY\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 10:23:10 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id DAAA27EA9C;\n\tThu, 31 Aug 2017 14:23:09 +0000 (UTC)","from gondolin (ovpn-117-247.ams2.redhat.com [10.36.117.247])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id F313A9D7A5;\n\tThu, 31 Aug 2017 14:23:05 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com DAAA27EA9C","Date":"Thu, 31 Aug 2017 16:23:02 +0200","From":"Cornelia Huck ","To":"David Hildenbrand ","Message-ID":"<20170831162302.1826247f.cohuck@redhat.com>","In-Reply-To":"<20170830170601.15855-3-david@redhat.com>","References":"<20170830170601.15855-1-david@redhat.com>\n\t<20170830170601.15855-3-david@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tThu, 31 Aug 2017 14:23:10 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 02/11] cpu: drop old comments describing\n\tmembers","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, Richard Henderson ,\n\tqemu-devel@nongnu.org, Alexander Graf ,\n\tborntraeger@de.ibm.com, Aurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]