[{"id":1760381,"web_url":"http://patchwork.ozlabs.org/comment/1760381/","msgid":"<4FE4EA40-6AED-4C1C-B84F-3D452BE67A80@vmware.com>","list_archive_url":null,"date":"2017-08-30T17:51:15","subject":"Re: [ovs-dev] [PATCH 2/3] dpif-netdev: Fix a couple of coding style\n\tissues.","submitter":{"id":68212,"url":"http://patchwork.ozlabs.org/api/people/68212/","name":"Darrell Ball","email":"dball@vmware.com"},"content":"Thanks Kevin\n\nIt is nice of you to fix a pre-existing coding style issue as part of this patch.\n\nDarrell\n\nOn 8/30/17, 10:45 AM, \"Kevin Traynor\" <ktraynor@redhat.com> wrote:\n\n    A couple of trivial fixes for a ternery operator placement\n    and pointer declaration.\n    \n    Fixes: 655856ef39b9 (\"dpif-netdev: Change rxq_scheduling to use rxq processing cycles.\")\n    Fixes: a2ac666d5265 (\"dpif-netdev: Change definitions of 'idle' & 'processing' cycles\")\n    Cc: ciara.loftus@intel.com\n    Reported-by: Ilya Maximets <i.maximets@samsung.com>\n    Signed-off-by: Kevin Traynor <ktraynor@redhat.com>\n    ---\n     lib/dpif-netdev.c | 11 ++++++-----\n     1 file changed, 6 insertions(+), 5 deletions(-)\n    \n    diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c\n    index 55d5656..1db9f10 100644\n    --- a/lib/dpif-netdev.c\n    +++ b/lib/dpif-netdev.c\n    @@ -3429,6 +3429,6 @@ static int\n     rxq_cycle_sort(const void *a, const void *b)\n     {\n    -    struct dp_netdev_rxq * qa;\n    -    struct dp_netdev_rxq * qb;\n    +    struct dp_netdev_rxq *qa;\n    +    struct dp_netdev_rxq *qb;\n         uint64_t total_qa, total_qb;\n         unsigned i;\n    @@ -3865,7 +3865,8 @@ dpif_netdev_run(struct dpif *dpif)\n                                                        port->rxqs[i].rx,\n                                                        port->port_no);\n    -                    cycles_count_intermediate(non_pmd, NULL, process_packets ?\n    -                                                       PMD_CYCLES_PROCESSING\n    -                                                     : PMD_CYCLES_IDLE);\n    +                    cycles_count_intermediate(non_pmd, NULL,\n    +                                              process_packets\n    +                                              ? PMD_CYCLES_PROCESSING\n    +                                              : PMD_CYCLES_IDLE);\n                     }\n                 }\n    -- \n    1.8.3.1","headers":{"Return-Path":"<ovs-dev-bounces@openvswitch.org>","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"kgTTLQtx\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjCjj5bw0z9sNc\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 03:51:21 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id E09D5C79;\n\tWed, 30 Aug 2017 17:51:19 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 2112CBFD\n\tfor <dev@openvswitch.org>; Wed, 30 Aug 2017 17:51:18 +0000 (UTC)","from NAM01-BN3-obe.outbound.protection.outlook.com\n\t(mail-bn3nam01on0046.outbound.protection.outlook.com [104.47.33.46])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 47E2D41D\n\tfor <dev@openvswitch.org>; Wed, 30 Aug 2017 17:51:17 +0000 (UTC)","from BLUPR05MB611.namprd05.prod.outlook.com (10.141.204.27) by\n\tBLUPR05MB1873.namprd05.prod.outlook.com (10.162.215.147) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.13.2; Wed, 30 Aug 2017 17:51:15 +0000","from BLUPR05MB611.namprd05.prod.outlook.com ([10.141.204.27]) by\n\tBLUPR05MB611.namprd05.prod.outlook.com ([10.141.204.27]) with mapi id\n\t15.20.0013.011; Wed, 30 Aug 2017 17:51:15 +0000"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=onevmw.onmicrosoft.com; s=selector1-vmware-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=4EfxSYEJaoDGIuJiQo8/Q74fOdssns0jGcyyXRIYiRo=;\n\tb=kgTTLQtxoKrkqeU1RI91u+RvGW67A01msFBCNWeLorw1Kb54rbLQejCBLVlzYB2RkSYUiGIqKnqITTO8BWFGycCtOpewYgeuomQ63VU6q3V9bX9Cc4wfWLrYAaXvX7Tx1EtOcqmkPebdgXB98lld+Duee4NTS5S8mxYmI5nJPdM=","From":"Darrell Ball <dball@vmware.com>","To":"Kevin Traynor <ktraynor@redhat.com>, \"dev@openvswitch.org\"\n\t<dev@openvswitch.org>, \"i.maximets@samsung.com\" <i.maximets@samsung.com>","Thread-Topic":"[PATCH 2/3] dpif-netdev: Fix a couple of coding style issues.","Thread-Index":"AQHTIbfaLCSg+Yh8lE6JnsVFkIOn06KcuF2A","Date":"Wed, 30 Aug 2017 17:51:15 +0000","Message-ID":"<4FE4EA40-6AED-4C1C-B84F-3D452BE67A80@vmware.com>","References":"<1504115149-26864-1-git-send-email-ktraynor@redhat.com>\n\t<1504115149-26864-2-git-send-email-ktraynor@redhat.com>","In-Reply-To":"<1504115149-26864-2-git-send-email-ktraynor@redhat.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","user-agent":"Microsoft-MacOutlook/f.23.0.170610","authentication-results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"kgTTLQtx\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"x-originating-ip":"[73.162.236.45]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; BLUPR05MB1873;\n\t20:He/aJEBZRxf+VGCoyYlJJiPme8eC8XieOCR329W4RxxgVCXmIhl61cDV3g/ezfnC68iD3vn60x071f4x3sb23y6jDE/EDcZITNhlgg81PhC5+16WAdjb9fwv/THyDrw8j4r411KBUFHjzXUIbDW/jgxY9gejbrIop0w3244Lb4Y=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"cd5d230b-ac0b-44ae-87c8-08d4efcfb616","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:BLUPR05MB1873; ","x-ms-traffictypediagnostic":"BLUPR05MB1873:","x-exchange-antispam-report-test":"UriScan:(7411616537696)(228905959029699);","x-microsoft-antispam-prvs":"<BLUPR05MB1873288B6305415E4166F43EC89C0@BLUPR05MB1873.namprd05.prod.outlook.com>","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(100000703101)(100105400095)(10201501046)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123560025)(20161123558100)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:BLUPR05MB1873; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:BLUPR05MB1873; ","x-forefront-prvs":"041517DFAB","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(199003)(189002)(24454002)(377454003)(66066001)(4001350100001)(5660300001)(83506001)(53546010)(2906002)(2501003)(82746002)(2950100002)(8936002)(81166006)(8676002)(81156014)(7736002)(2201001)(305945005)(6506006)(14454004)(3280700002)(97736004)(3660700001)(101416001)(6246003)(2900100001)(54356999)(25786009)(50986999)(478600001)(76176999)(4326008)(6512007)(229853002)(106356001)(99286003)(102836003)(3846002)(6116002)(105586002)(68736007)(83716003)(77096006)(6486002)(6436002)(189998001)(53936002)(86362001)(33656002)(36756003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR05MB1873;\n\tH:BLUPR05MB611.namprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","received-spf":"None (protection.outlook.com: vmware.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-ID":"<0DD166F90122A64E94166FE6825DA3DA@namprd05.prod.outlook.com>","MIME-Version":"1.0","X-OriginatorOrg":"vmware.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"30 Aug 2017 17:51:15.7187\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"BLUPR05MB1873","X-Spam-Status":"No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH 2/3] dpif-netdev: Fix a couple of coding style\n\tissues.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"<ovs-dev.openvswitch.org>","List-Unsubscribe":"<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>","List-Archive":"<http://mail.openvswitch.org/pipermail/ovs-dev/>","List-Post":"<mailto:ovs-dev@openvswitch.org>","List-Help":"<mailto:ovs-dev-request@openvswitch.org?subject=help>","List-Subscribe":"<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1761552,"web_url":"http://patchwork.ozlabs.org/comment/1761552/","msgid":"<74F120C019F4A64C9B78E802F6AD4CC278DFFAD5@IRSMSX106.ger.corp.intel.com>","list_archive_url":null,"date":"2017-09-01T09:44:27","subject":"Re: [ovs-dev] [PATCH 2/3] dpif-netdev: Fix a couple of coding style\n\tissues.","submitter":{"id":67255,"url":"http://patchwork.ozlabs.org/api/people/67255/","name":"Ciara Loftus","email":"ciara.loftus@intel.com"},"content":"> \n> A couple of trivial fixes for a ternery operator placement\n> and pointer declaration.\n> \n> Fixes: 655856ef39b9 (\"dpif-netdev: Change rxq_scheduling to use rxq\n> processing cycles.\")\n> Fixes: a2ac666d5265 (\"dpif-netdev: Change definitions of 'idle' & 'processing'\n> cycles\")\n> Cc: ciara.loftus@intel.com\n> Reported-by: Ilya Maximets <i.maximets@samsung.com>\n> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>\n> ---\n>  lib/dpif-netdev.c | 11 ++++++-----\n>  1 file changed, 6 insertions(+), 5 deletions(-)\n> \n> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c\n> index 55d5656..1db9f10 100644\n> --- a/lib/dpif-netdev.c\n> +++ b/lib/dpif-netdev.c\n> @@ -3429,6 +3429,6 @@ static int\n>  rxq_cycle_sort(const void *a, const void *b)\n>  {\n> -    struct dp_netdev_rxq * qa;\n> -    struct dp_netdev_rxq * qb;\n> +    struct dp_netdev_rxq *qa;\n> +    struct dp_netdev_rxq *qb;\n>      uint64_t total_qa, total_qb;\n>      unsigned i;\n> @@ -3865,7 +3865,8 @@ dpif_netdev_run(struct dpif *dpif)\n>                                                     port->rxqs[i].rx,\n>                                                     port->port_no);\n> -                    cycles_count_intermediate(non_pmd, NULL, process_packets ?\n> -                                                       PMD_CYCLES_PROCESSING\n> -                                                     : PMD_CYCLES_IDLE);\n> +                    cycles_count_intermediate(non_pmd, NULL,\n> +                                              process_packets\n> +                                              ? PMD_CYCLES_PROCESSING\n> +                                              : PMD_CYCLES_IDLE);\n>                  }\n>              }\n> --\n> 1.8.3.1\n\nLGTM. Thanks!\n\nAcked-by: Ciara Loftus <ciara.loftus@intel.com>","headers":{"Return-Path":"<ovs-dev-bounces@openvswitch.org>","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkDq8273Dz9sPk\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  1 Sep 2017 19:44:35 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 5B473DF0;\n\tFri,  1 Sep 2017 09:44:33 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id E7124DE3\n\tfor <dev@openvswitch.org>; Fri,  1 Sep 2017 09:44:31 +0000 (UTC)","from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 39A03A1\n\tfor <dev@openvswitch.org>; Fri,  1 Sep 2017 09:44:31 +0000 (UTC)","from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga105.jf.intel.com with ESMTP; 01 Sep 2017 02:44:30 -0700","from irsmsx152.ger.corp.intel.com ([163.33.192.66])\n\tby FMSMGA003.fm.intel.com with ESMTP; 01 Sep 2017 02:44:29 -0700","from irsmsx155.ger.corp.intel.com (163.33.192.3) by\n\tIRSMSX152.ger.corp.intel.com (163.33.192.66) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Fri, 1 Sep 2017 10:44:28 +0100","from irsmsx106.ger.corp.intel.com ([169.254.8.36]) by\n\tirsmsx155.ger.corp.intel.com ([169.254.14.70]) with mapi id\n\t14.03.0319.002; Fri, 1 Sep 2017 10:44:28 +0100"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.41,457,1498546800\"; d=\"scan'208\";a=\"896168477\"","From":"\"Loftus, Ciara\" <ciara.loftus@intel.com>","To":"Kevin Traynor <ktraynor@redhat.com>","Thread-Topic":"[PATCH 2/3] dpif-netdev: Fix a couple of coding style issues.","Thread-Index":"AQHTIbfmO4D5WY++T0Ci1OvUspDJEaKfyacg","Date":"Fri, 1 Sep 2017 09:44:27 +0000","Message-ID":"<74F120C019F4A64C9B78E802F6AD4CC278DFFAD5@IRSMSX106.ger.corp.intel.com>","References":"<1504115149-26864-1-git-send-email-ktraynor@redhat.com>\n\t<1504115149-26864-2-git-send-email-ktraynor@redhat.com>","In-Reply-To":"<1504115149-26864-2-git-send-email-ktraynor@redhat.com>","Accept-Language":"en-GB, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-titus-metadata-40":"eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGQ4NzUyYjAtMWFiMC00MTk2LWI1NTItYmIyYmU3NGY1ZTJhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlBTa04wMlVZeG9rN0dlZmd1N0d0YUZXM0g5RFNRYXdwU3dZQnlhTTNOY2M9In0=","x-ctpclassification":"CTP_IC","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[163.33.239.182]","MIME-Version":"1.0","X-Spam-Status":"No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"\"dev@openvswitch.org\" <dev@openvswitch.org>,\n\t\"i.maximets@samsung.com\" <i.maximets@samsung.com>","Subject":"Re: [ovs-dev] [PATCH 2/3] dpif-netdev: Fix a couple of coding style\n\tissues.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"<ovs-dev.openvswitch.org>","List-Unsubscribe":"<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>","List-Archive":"<http://mail.openvswitch.org/pipermail/ovs-dev/>","List-Post":"<mailto:ovs-dev@openvswitch.org>","List-Help":"<mailto:ovs-dev-request@openvswitch.org?subject=help>","List-Subscribe":"<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1761995,"web_url":"http://patchwork.ozlabs.org/comment/1761995/","msgid":"<772BDFFC-6FA4-4991-A900-38EE5B1C9C1F@vmware.com>","list_archive_url":null,"date":"2017-09-01T21:28:34","subject":"Re: [ovs-dev] [PATCH 2/3] dpif-netdev: Fix a couple of coding style\n\tissues.","submitter":{"id":68212,"url":"http://patchwork.ozlabs.org/api/people/68212/","name":"Darrell Ball","email":"dball@vmware.com"},"content":"I applied the patch to dpdk_merge here\n\nhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_darball_ovs_commits_dpdk-5Fmerge&d=DwIGaQ&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=A2_FCacqbp2moAo3HGFlTuxsjONUGhlN42OBcAuQQ6w&s=b6btPKhgvOFr2GOUYvktND6kaC6jc3fXI-mXfvNgXOU&e=\n\n\nOn 9/1/17, 2:44 AM, \"Loftus, Ciara\" <ciara.loftus@intel.com> wrote:\n\n    > \n    > A couple of trivial fixes for a ternery operator placement\n    > and pointer declaration.\n    > \n    > Fixes: 655856ef39b9 (\"dpif-netdev: Change rxq_scheduling to use rxq\n    > processing cycles.\")\n    > Fixes: a2ac666d5265 (\"dpif-netdev: Change definitions of 'idle' & 'processing'\n    > cycles\")\n    > Cc: ciara.loftus@intel.com\n    > Reported-by: Ilya Maximets <i.maximets@samsung.com>\n    > Signed-off-by: Kevin Traynor <ktraynor@redhat.com>\n    > ---\n    >  lib/dpif-netdev.c | 11 ++++++-----\n    >  1 file changed, 6 insertions(+), 5 deletions(-)\n    > \n    > diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c\n    > index 55d5656..1db9f10 100644\n    > --- a/lib/dpif-netdev.c\n    > +++ b/lib/dpif-netdev.c\n    > @@ -3429,6 +3429,6 @@ static int\n    >  rxq_cycle_sort(const void *a, const void *b)\n    >  {\n    > -    struct dp_netdev_rxq * qa;\n    > -    struct dp_netdev_rxq * qb;\n    > +    struct dp_netdev_rxq *qa;\n    > +    struct dp_netdev_rxq *qb;\n    >      uint64_t total_qa, total_qb;\n    >      unsigned i;\n    > @@ -3865,7 +3865,8 @@ dpif_netdev_run(struct dpif *dpif)\n    >                                                     port->rxqs[i].rx,\n    >                                                     port->port_no);\n    > -                    cycles_count_intermediate(non_pmd, NULL, process_packets ?\n    > -                                                       PMD_CYCLES_PROCESSING\n    > -                                                     : PMD_CYCLES_IDLE);\n    > +                    cycles_count_intermediate(non_pmd, NULL,\n    > +                                              process_packets\n    > +                                              ? PMD_CYCLES_PROCESSING\n    > +                                              : PMD_CYCLES_IDLE);\n    >                  }\n    >              }\n    > --\n    > 1.8.3.1\n    \n    LGTM. Thanks!\n    \n    Acked-by: Ciara Loftus <ciara.loftus@intel.com>","headers":{"Return-Path":"<ovs-dev-bounces@openvswitch.org>","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"FsRwz3NO\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkXTl6W5pz9sQl\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat,  2 Sep 2017 07:30:35 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id E9143E93;\n\tFri,  1 Sep 2017 21:28:38 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 33A36E6D\n\tfor <dev@openvswitch.org>; Fri,  1 Sep 2017 21:28:37 +0000 (UTC)","from NAM03-CO1-obe.outbound.protection.outlook.com\n\t(mail-co1nam03on0040.outbound.protection.outlook.com [104.47.40.40])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id DE854461\n\tfor <dev@openvswitch.org>; Fri,  1 Sep 2017 21:28:35 +0000 (UTC)","from BLUPR05MB611.namprd05.prod.outlook.com (10.141.204.27) by\n\tBLUPR05MB354.namprd05.prod.outlook.com (10.141.25.15) with Microsoft\n\tSMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.35.3; Fri, 1 Sep 2017 21:28:34 +0000","from BLUPR05MB611.namprd05.prod.outlook.com ([10.141.204.27]) by\n\tBLUPR05MB611.namprd05.prod.outlook.com ([10.141.204.27]) with mapi id\n\t15.20.0035.002; Fri, 1 Sep 2017 21:28:34 +0000"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=onevmw.onmicrosoft.com; s=selector1-vmware-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=HTkNgl8u+FQEvrkRlIPBwZcC0P1BB31C5S3xIslc35k=;\n\tb=FsRwz3NOHvCtOrT4I4a0H+PTErkpYj4oTnyFJz+PtdJFMnPEE2JhZByPyMAdAq+tzIseY/R4c8/h5ndaanV96q+tu3XyMrD6Tyecco+YkP8790BUPT80phLSGTPhIEnu4ahzKcOcpDWLQ+/6dOh/h23wT3eJDdZDTencOrRcXjw=","From":"Darrell Ball <dball@vmware.com>","To":"\"Loftus, Ciara\" <ciara.loftus@intel.com>, Kevin Traynor\n\t<ktraynor@redhat.com>","Thread-Topic":"[PATCH 2/3] dpif-netdev: Fix a couple of coding style issues.","Thread-Index":"AQHTIbfaLCSg+Yh8lE6JnsVFkIOn06Kfyl2AgABPYgA=","Date":"Fri, 1 Sep 2017 21:28:34 +0000","Message-ID":"<772BDFFC-6FA4-4991-A900-38EE5B1C9C1F@vmware.com>","References":"<1504115149-26864-1-git-send-email-ktraynor@redhat.com>\n\t<1504115149-26864-2-git-send-email-ktraynor@redhat.com>\n\t<74F120C019F4A64C9B78E802F6AD4CC278DFFAD5@IRSMSX106.ger.corp.intel.com>","In-Reply-To":"<74F120C019F4A64C9B78E802F6AD4CC278DFFAD5@IRSMSX106.ger.corp.intel.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","user-agent":"Microsoft-MacOutlook/f.23.0.170610","x-originating-ip":"[73.162.236.45]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; BLUPR05MB354;\n\t20:6vMU70XK2CqGeNLaVdJgrnhYHhCFJIbIXkMD4zRHWkpWE8r+HRp8kuFQeW7JigE/ueLXnvjZQgXNWo9quuWfdMLLaNFUBcHhz3pSvRfxtalacAxKTgH+H0Q3ZrFLV1NVsIKcynOTrY1J6GHqSo+h6CApJOP0qThzNYLPZCTxSq0=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"2b2f88e3-db87-4231-049e-08d4f180668e","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:BLUPR05MB354; ","x-ms-traffictypediagnostic":"BLUPR05MB354:","authentication-results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"FsRwz3NO\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"x-exchange-antispam-report-test":"UriScan:(10436049006162)(7411616537696)(228905959029699); ","x-microsoft-antispam-prvs":"<BLUPR05MB354A258D3DE07EE24A0976AC8920@BLUPR05MB354.namprd05.prod.outlook.com>","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123564025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:BLUPR05MB354; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:BLUPR05MB354; ","x-forefront-prvs":"0417A3FFD2","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(199003)(377454003)(24454002)(189002)(478600001)(6512007)(83506001)(106356001)(3846002)(102836003)(6116002)(54906002)(99286003)(25786009)(966005)(101416001)(6436002)(86362001)(105586002)(5660300001)(14454004)(4001350100001)(83716003)(36756003)(53546010)(2900100001)(53936002)(68736007)(2950100002)(6246003)(305945005)(229853002)(82746002)(50986999)(76176999)(2906002)(66066001)(77096006)(6486002)(6506006)(54356999)(3280700002)(81166006)(8936002)(81156014)(6306002)(4326008)(97736004)(33656002)(189998001)(3660700001)(8676002)(7736002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR05MB354;\n\tH:BLUPR05MB611.namprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","received-spf":"None (protection.outlook.com: vmware.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-ID":"<8AF2EB81AA01044FBEC0E231BE96E5E7@namprd05.prod.outlook.com>","MIME-Version":"1.0","X-OriginatorOrg":"vmware.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"01 Sep 2017 21:28:34.3836\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"BLUPR05MB354","X-Spam-Status":"No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"\"dev@openvswitch.org\" <dev@openvswitch.org>,\n\t\"i.maximets@samsung.com\" <i.maximets@samsung.com>","Subject":"Re: [ovs-dev] [PATCH 2/3] dpif-netdev: Fix a couple of coding style\n\tissues.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"<ovs-dev.openvswitch.org>","List-Unsubscribe":"<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>","List-Archive":"<http://mail.openvswitch.org/pipermail/ovs-dev/>","List-Post":"<mailto:ovs-dev@openvswitch.org>","List-Help":"<mailto:ovs-dev-request@openvswitch.org?subject=help>","List-Subscribe":"<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]