[{"id":1760379,"web_url":"http://patchwork.ozlabs.org/comment/1760379/","msgid":"<045F7F7E-ADB4-46E3-A237-5FB1F80E836A@vmware.com>","list_archive_url":null,"date":"2017-08-30T17:49:27","subject":"Re: [ovs-dev] [PATCH 1/3] dpif-netdev: Rename rxq_interval.","submitter":{"id":68212,"url":"http://patchwork.ozlabs.org/api/people/68212/","name":"Darrell Ball","email":"dball@vmware.com"},"content":"Thanks Kevin\n\nNaming is hard.\nThe name looks a bit more intuitive and matches closely with the description previously added.\n\nDarrell\n\nOn 8/30/17, 10:45 AM, \"Kevin Traynor\" <ktraynor@redhat.com> wrote:\n\n    rxq_interval was added before there was other #defines\n    and code related to rxq intervals.\n    \n    Rename to rxq_next_cycles_store in order to make it more intuitive.\n    \n    Reported-by: Ilya Maximets <i.maximets@samsung.com>\n    Signed-off-by: Kevin Traynor <ktraynor@redhat.com>\n    ---\n     lib/dpif-netdev.c | 8 ++++----\n     1 file changed, 4 insertions(+), 4 deletions(-)\n    \n    diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c\n    index 071ec14..55d5656 100644\n    --- a/lib/dpif-netdev.c\n    +++ b/lib/dpif-netdev.c\n    @@ -576,5 +576,5 @@ struct dp_netdev_pmd_thread {\n         /* End of the next time interval for which processing cycles\n            are stored for each polled rxq. */\n    -    long long int rxq_interval;\n    +    long long int rxq_next_cycle_store;\n     \n         /* Statistics. */\n    @@ -4507,5 +4507,5 @@ dp_netdev_configure_pmd(struct dp_netdev_pmd_thread *pmd, struct dp_netdev *dp,\n         cmap_init(&pmd->classifiers);\n         pmd->next_optimization = time_msec() + DPCLS_OPTIMIZATION_INTERVAL;\n    -    pmd->rxq_interval = time_msec() + PMD_RXQ_INTERVAL_LEN;\n    +    pmd->rxq_next_cycle_store = time_msec() + PMD_RXQ_INTERVAL_LEN;\n         hmap_init(&pmd->poll_list);\n         hmap_init(&pmd->tx_ports);\n    @@ -5951,5 +5951,5 @@ dp_netdev_pmd_try_optimize(struct dp_netdev_pmd_thread *pmd,\n         long long int now = time_msec();\n     \n    -    if (now > pmd->rxq_interval) {\n    +    if (now > pmd->rxq_next_cycle_store) {\n             /* Get the cycles that were used to process each queue and store. */\n             for (unsigned i = 0; i < poll_cnt; i++) {\n    @@ -5961,5 +5961,5 @@ dp_netdev_pmd_try_optimize(struct dp_netdev_pmd_thread *pmd,\n             }\n             /* Start new measuring interval */\n    -        pmd->rxq_interval = now + PMD_RXQ_INTERVAL_LEN;\n    +        pmd->rxq_next_cycle_store = now + PMD_RXQ_INTERVAL_LEN;\n         }\n     \n    -- \n    1.8.3.1","headers":{"Return-Path":"<ovs-dev-bounces@openvswitch.org>","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"c2PBkpG9\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjCgd1DyXz9sNc\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 03:49:32 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 68688C18;\n\tWed, 30 Aug 2017 17:49:31 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id C62C6BD5\n\tfor <dev@openvswitch.org>; Wed, 30 Aug 2017 17:49:29 +0000 (UTC)","from NAM03-DM3-obe.outbound.protection.outlook.com\n\t(mail-dm3nam03on0070.outbound.protection.outlook.com [104.47.41.70])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 1E1581B3\n\tfor <dev@openvswitch.org>; Wed, 30 Aug 2017 17:49:29 +0000 (UTC)","from BLUPR05MB611.namprd05.prod.outlook.com (10.141.204.27) by\n\tBLUPR05MB258.namprd05.prod.outlook.com (10.141.22.19) with Microsoft\n\tSMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.35.3; Wed, 30 Aug 2017 17:49:27 +0000","from BLUPR05MB611.namprd05.prod.outlook.com ([10.141.204.27]) by\n\tBLUPR05MB611.namprd05.prod.outlook.com ([10.141.204.27]) with mapi id\n\t15.20.0013.011; Wed, 30 Aug 2017 17:49:27 +0000"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=onevmw.onmicrosoft.com; s=selector1-vmware-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=e7FVLRsLbZRbeBxm6KX+Ars4A57aiSDJEnmrbG2s+GQ=;\n\tb=c2PBkpG9TWSeEsyW41/FkAO+v1ac9CMUhK7YldvfatMiT0qfy1r99BakRPyfkVWynDzMS5dvxahDo7LfcVUIaACkAWAndfIE5T8GzE9IWxthxUzVBY9gAa1HYDxEMMijf1oSEL4Jrb6ACw0fJ2rRVfRNFwtwl7S8t2xbPYLIheU=","From":"Darrell Ball <dball@vmware.com>","To":"Kevin Traynor <ktraynor@redhat.com>, \"dev@openvswitch.org\"\n\t<dev@openvswitch.org>, \"i.maximets@samsung.com\" <i.maximets@samsung.com>","Thread-Topic":"[PATCH 1/3] dpif-netdev: Rename rxq_interval.","Thread-Index":"AQHTIbfXuOop/nPGHUqdklCZ612iD6Kct9sA","Date":"Wed, 30 Aug 2017 17:49:27 +0000","Message-ID":"<045F7F7E-ADB4-46E3-A237-5FB1F80E836A@vmware.com>","References":"<1504115149-26864-1-git-send-email-ktraynor@redhat.com>","In-Reply-To":"<1504115149-26864-1-git-send-email-ktraynor@redhat.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","user-agent":"Microsoft-MacOutlook/f.23.0.170610","authentication-results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"c2PBkpG9\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"x-originating-ip":"[73.162.236.45]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; BLUPR05MB258;\n\t20:REpkcGVNOSTgutj8MjfagEYAoSZAG7+LRdUkGut9XcCRZvG+3UamnNQCtD8SL0xBt2VEys05Ulcly/nEeASd/9Vz8eJ5I75rDLKnxgT6Qyq2pWC4/G2bCNQ/XfBqUHGV1lMapYfy5BEDXGDA1EQK1AsjCF0DwVJgf14R57i08rs=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"e3506422-a0e3-48a1-8ab3-08d4efcf754b","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:BLUPR05MB258; ","x-ms-traffictypediagnostic":"BLUPR05MB258:","x-exchange-antispam-report-test":"UriScan:(7411616537696);","x-microsoft-antispam-prvs":"<BLUPR05MB258A8969D0D32D51CA4E725C89C0@BLUPR05MB258.namprd05.prod.outlook.com>","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(6041248)(20161123558100)(20161123560025)(20161123555025)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:BLUPR05MB258; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:BLUPR05MB258; ","x-forefront-prvs":"041517DFAB","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(39860400002)(377454003)(189002)(199003)(24454002)(54356999)(86362001)(66066001)(76176999)(68736007)(53546010)(36756003)(101416001)(50986999)(33656002)(2501003)(2900100001)(106356001)(6246003)(5660300001)(8676002)(8936002)(81166006)(25786009)(305945005)(7736002)(2950100002)(3846002)(102836003)(6116002)(81156014)(6436002)(77096006)(3280700002)(105586002)(14454004)(3660700001)(6506006)(83716003)(478600001)(83506001)(6486002)(82746002)(99286003)(2906002)(97736004)(229853002)(2201001)(53936002)(6512007)(189998001)(4001350100001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR05MB258;\n\tH:BLUPR05MB611.namprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ","received-spf":"None (protection.outlook.com: vmware.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-ID":"<E69B594B5E1C3E4283C3D3E4E4D5FD8B@namprd05.prod.outlook.com>","MIME-Version":"1.0","X-OriginatorOrg":"vmware.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"30 Aug 2017 17:49:27.0298\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"BLUPR05MB258","X-Spam-Status":"No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH 1/3] dpif-netdev: Rename rxq_interval.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"<ovs-dev.openvswitch.org>","List-Unsubscribe":"<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>","List-Archive":"<http://mail.openvswitch.org/pipermail/ovs-dev/>","List-Post":"<mailto:ovs-dev@openvswitch.org>","List-Help":"<mailto:ovs-dev-request@openvswitch.org?subject=help>","List-Subscribe":"<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1773836,"web_url":"http://patchwork.ozlabs.org/comment/1773836/","msgid":"<D8853489-68FE-4E01-9A95-3C97B2F82CD4@vmware.com>","list_archive_url":null,"date":"2017-09-22T19:22:11","subject":"Re: [ovs-dev] [PATCH 1/3] dpif-netdev: Rename rxq_interval.","submitter":{"id":68212,"url":"http://patchwork.ozlabs.org/api/people/68212/","name":"Darrell Ball","email":"dball@vmware.com"},"content":"Are there any other comments?\n\n\n\nOn 8/30/17, 10:49 AM, \"Darrell Ball\" <dball@vmware.com> wrote:\n\n    Thanks Kevin\n    \n    Naming is hard.\n    The name looks a bit more intuitive and matches closely with the description previously added.\n    \n    Darrell\n    \n    On 8/30/17, 10:45 AM, \"Kevin Traynor\" <ktraynor@redhat.com> wrote:\n    \n        rxq_interval was added before there was other #defines\n        and code related to rxq intervals.\n        \n        Rename to rxq_next_cycles_store in order to make it more intuitive.\n        \n        Reported-by: Ilya Maximets <i.maximets@samsung.com>\n        Signed-off-by: Kevin Traynor <ktraynor@redhat.com>\n        ---\n         lib/dpif-netdev.c | 8 ++++----\n         1 file changed, 4 insertions(+), 4 deletions(-)\n        \n        diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c\n        index 071ec14..55d5656 100644\n        --- a/lib/dpif-netdev.c\n        +++ b/lib/dpif-netdev.c\n        @@ -576,5 +576,5 @@ struct dp_netdev_pmd_thread {\n             /* End of the next time interval for which processing cycles\n                are stored for each polled rxq. */\n        -    long long int rxq_interval;\n        +    long long int rxq_next_cycle_store;\n         \n             /* Statistics. */\n        @@ -4507,5 +4507,5 @@ dp_netdev_configure_pmd(struct dp_netdev_pmd_thread *pmd, struct dp_netdev *dp,\n             cmap_init(&pmd->classifiers);\n             pmd->next_optimization = time_msec() + DPCLS_OPTIMIZATION_INTERVAL;\n        -    pmd->rxq_interval = time_msec() + PMD_RXQ_INTERVAL_LEN;\n        +    pmd->rxq_next_cycle_store = time_msec() + PMD_RXQ_INTERVAL_LEN;\n             hmap_init(&pmd->poll_list);\n             hmap_init(&pmd->tx_ports);\n        @@ -5951,5 +5951,5 @@ dp_netdev_pmd_try_optimize(struct dp_netdev_pmd_thread *pmd,\n             long long int now = time_msec();\n         \n        -    if (now > pmd->rxq_interval) {\n        +    if (now > pmd->rxq_next_cycle_store) {\n                 /* Get the cycles that were used to process each queue and store. */\n                 for (unsigned i = 0; i < poll_cnt; i++) {\n        @@ -5961,5 +5961,5 @@ dp_netdev_pmd_try_optimize(struct dp_netdev_pmd_thread *pmd,\n                 }\n                 /* Start new measuring interval */\n        -        pmd->rxq_interval = now + PMD_RXQ_INTERVAL_LEN;\n        +        pmd->rxq_next_cycle_store = now + PMD_RXQ_INTERVAL_LEN;\n             }\n         \n        -- \n        1.8.3.1","headers":{"Return-Path":"<ovs-dev-bounces@openvswitch.org>","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"NYnxzkK3\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzNf21Kvdz9sPr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 23 Sep 2017 05:22:18 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 063A1AF4;\n\tFri, 22 Sep 2017 19:22:16 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id DA29FAA6\n\tfor <dev@openvswitch.org>; Fri, 22 Sep 2017 19:22:14 +0000 (UTC)","from NAM03-CO1-obe.outbound.protection.outlook.com\n\t(mail-co1nam03on0046.outbound.protection.outlook.com [104.47.40.46])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id BB9014CA\n\tfor <dev@openvswitch.org>; Fri, 22 Sep 2017 19:22:13 +0000 (UTC)","from MWHPR05MB3406.namprd05.prod.outlook.com (10.174.175.155) by\n\tMWHPR05MB3405.namprd05.prod.outlook.com (10.174.175.154) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.77.5; Fri, 22 Sep 2017 19:22:12 +0000","from MWHPR05MB3406.namprd05.prod.outlook.com ([10.174.175.155]) by\n\tMWHPR05MB3406.namprd05.prod.outlook.com ([10.174.175.155]) with\n\tmapi id 15.20.0077.007; Fri, 22 Sep 2017 19:22:12 +0000"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=onevmw.onmicrosoft.com; s=selector1-vmware-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=wl+yekR8ZeW+YWeORMr9TQq1MEgFHM5gFx/Kz7Xe6cc=;\n\tb=NYnxzkK3sndcWPpiUZ35KvoGV2zEthWnZt5DbSEjHubOIEj3slNzMKfUHjdpBebDUp2cyjK5DnaF/acynsozD+eRQgY2ggG4lZWePbsij4bbhlcQk0WVFsfokEML5SxHeWKSzgM5TBU76XzfmFyCNLHB/6KKt69xWMuQ2oPHIn8=","From":"Darrell Ball <dball@vmware.com>","To":"Kevin Traynor <ktraynor@redhat.com>, \"dev@openvswitch.org\"\n\t<dev@openvswitch.org>, \"i.maximets@samsung.com\" <i.maximets@samsung.com>","Thread-Topic":"[PATCH 1/3] dpif-netdev: Rename rxq_interval.","Thread-Index":"AQHTIbfXuOop/nPGHUqdklCZ612iD6Kct9sAgCS04oA=","Date":"Fri, 22 Sep 2017 19:22:11 +0000","Message-ID":"<D8853489-68FE-4E01-9A95-3C97B2F82CD4@vmware.com>","References":"<1504115149-26864-1-git-send-email-ktraynor@redhat.com>\n\t<045F7F7E-ADB4-46E3-A237-5FB1F80E836A@vmware.com>","In-Reply-To":"<045F7F7E-ADB4-46E3-A237-5FB1F80E836A@vmware.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","user-agent":"Microsoft-MacOutlook/f.26.0.170902","authentication-results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"NYnxzkK3\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"x-originating-ip":"[73.162.236.45]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; MWHPR05MB3405;\n\t20:46YtjECYt62sthqi/oA71x00cTvz9TbEGyqQ0mGyonLmZVkUUIFHf6KGEwfZKS0rZth7aYW6Fy2G5agNlIrd+3bouMOxYlhbl5PrONupjE+8e+I8iAynBLsGQDlrWkBKqcDyxSYS7GZ356SzBC7L1tR5sr10QXCEzGkGLaLaYM0=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"be2a338e-a763-4382-69cc-08d501ef39bd","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:MWHPR05MB3405; ","x-ms-traffictypediagnostic":"MWHPR05MB3405:","x-exchange-antispam-report-test":"UriScan:(61668805478150)(7411616537696);","x-microsoft-antispam-prvs":"<MWHPR05MB3405453ACF2E996353373CE9C8670@MWHPR05MB3405.namprd05.prod.outlook.com>","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(3002001)(93006095)(93001095)(10201501046)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123560025)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:MWHPR05MB3405; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:MWHPR05MB3405; ","x-forefront-prvs":"0438F90F17","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(376002)(346002)(199003)(24454002)(377454003)(189002)(25786009)(229853002)(2900100001)(36756003)(54356999)(2950100002)(8936002)(6512007)(101416001)(99286003)(189998001)(50986999)(316002)(106356001)(6246003)(2201001)(14454004)(77096006)(53546010)(305945005)(58126008)(7736002)(110136005)(53936002)(2906002)(66066001)(2501003)(33656002)(81166006)(105586002)(83506001)(6486002)(97736004)(6436002)(3660700001)(478600001)(3280700002)(68736007)(83716003)(5660300001)(6116002)(6506006)(81156014)(76176999)(3846002)(8676002)(82746002)(86362001)(102836003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR05MB3405;\n\tH:MWHPR05MB3406.namprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","received-spf":"None (protection.outlook.com: vmware.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-ID":"<85901058C055E64B952BBD68CFDF8A30@namprd05.prod.outlook.com>","MIME-Version":"1.0","X-OriginatorOrg":"vmware.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"22 Sep 2017 19:22:11.9069\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"MWHPR05MB3405","X-Spam-Status":"No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH 1/3] dpif-netdev: Rename rxq_interval.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"<ovs-dev.openvswitch.org>","List-Unsubscribe":"<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>","List-Archive":"<http://mail.openvswitch.org/pipermail/ovs-dev/>","List-Post":"<mailto:ovs-dev@openvswitch.org>","List-Help":"<mailto:ovs-dev-request@openvswitch.org?subject=help>","List-Subscribe":"<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1774819,"web_url":"http://patchwork.ozlabs.org/comment/1774819/","msgid":"<CFF8EF42F1132E4CBE2BF0AB6C21C58D7881804D@ESESSMB107.ericsson.se>","list_archive_url":null,"date":"2017-09-25T15:51:52","subject":"Re: [ovs-dev] [PATCH 1/3] dpif-netdev: Rename rxq_interval.","submitter":{"id":68449,"url":"http://patchwork.ozlabs.org/api/people/68449/","name":"Jan Scheurich","email":"jan.scheurich@ericsson.com"},"content":"I'm fine with the new name.\n/Jan\n\n> -----Original Message-----\n> From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-bounces@openvswitch.org] On Behalf Of Darrell Ball\n> Sent: Friday, 22 September, 2017 21:22\n> To: Kevin Traynor <ktraynor@redhat.com>; dev@openvswitch.org; i.maximets@samsung.com\n> Subject: Re: [ovs-dev] [PATCH 1/3] dpif-netdev: Rename rxq_interval.\n> \n> Are there any other comments?\n> \n> \n> \n> On 8/30/17, 10:49 AM, \"Darrell Ball\" <dball@vmware.com> wrote:\n> \n>     Thanks Kevin\n> \n>     Naming is hard.\n>     The name looks a bit more intuitive and matches closely with the description previously added.\n> \n>     Darrell\n> \n>     On 8/30/17, 10:45 AM, \"Kevin Traynor\" <ktraynor@redhat.com> wrote:\n> \n>         rxq_interval was added before there was other #defines\n>         and code related to rxq intervals.\n> \n>         Rename to rxq_next_cycles_store in order to make it more intuitive.\n> \n>         Reported-by: Ilya Maximets <i.maximets@samsung.com>\n>         Signed-off-by: Kevin Traynor <ktraynor@redhat.com>\n>         ---\n>          lib/dpif-netdev.c | 8 ++++----\n>          1 file changed, 4 insertions(+), 4 deletions(-)\n> \n>         diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c\n>         index 071ec14..55d5656 100644\n>         --- a/lib/dpif-netdev.c\n>         +++ b/lib/dpif-netdev.c\n>         @@ -576,5 +576,5 @@ struct dp_netdev_pmd_thread {\n>              /* End of the next time interval for which processing cycles\n>                 are stored for each polled rxq. */\n>         -    long long int rxq_interval;\n>         +    long long int rxq_next_cycle_store;\n> \n>              /* Statistics. */\n>         @@ -4507,5 +4507,5 @@ dp_netdev_configure_pmd(struct dp_netdev_pmd_thread *pmd, struct dp_netdev *dp,\n>              cmap_init(&pmd->classifiers);\n>              pmd->next_optimization = time_msec() + DPCLS_OPTIMIZATION_INTERVAL;\n>         -    pmd->rxq_interval = time_msec() + PMD_RXQ_INTERVAL_LEN;\n>         +    pmd->rxq_next_cycle_store = time_msec() + PMD_RXQ_INTERVAL_LEN;\n>              hmap_init(&pmd->poll_list);\n>              hmap_init(&pmd->tx_ports);\n>         @@ -5951,5 +5951,5 @@ dp_netdev_pmd_try_optimize(struct dp_netdev_pmd_thread *pmd,\n>              long long int now = time_msec();\n> \n>         -    if (now > pmd->rxq_interval) {\n>         +    if (now > pmd->rxq_next_cycle_store) {\n>                  /* Get the cycles that were used to process each queue and store. */\n>                  for (unsigned i = 0; i < poll_cnt; i++) {\n>         @@ -5961,5 +5961,5 @@ dp_netdev_pmd_try_optimize(struct dp_netdev_pmd_thread *pmd,\n>                  }\n>                  /* Start new measuring interval */\n>         -        pmd->rxq_interval = now + PMD_RXQ_INTERVAL_LEN;\n>         +        pmd->rxq_next_cycle_store = now + PMD_RXQ_INTERVAL_LEN;\n>              }\n> \n>         --\n>         1.8.3.1\n> \n> \n> \n> \n> \n> _______________________________________________\n> dev mailing list\n> dev@openvswitch.org\n> https://mail.openvswitch.org/mailman/listinfo/ovs-dev","headers":{"Return-Path":"<ovs-dev-bounces@openvswitch.org>","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y17r42V8Nz9sP1\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Sep 2017 01:52:03 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 8E5C1BBF;\n\tMon, 25 Sep 2017 15:51:59 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 0C30EB30\n\tfor <dev@openvswitch.org>; Mon, 25 Sep 2017 15:51:58 +0000 (UTC)","from sesbmg22.ericsson.net (sesbmg22.ericsson.net [193.180.251.48])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 9BF5A431\n\tfor <dev@openvswitch.org>; Mon, 25 Sep 2017 15:51:56 +0000 (UTC)","from ESESSHC014.ericsson.se (Unknown_Domain [153.88.183.60])\n\tby sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id\n\tAA.42.06417.A1629C95; Mon, 25 Sep 2017 17:51:54 +0200 (CEST)","from ESESSMB107.ericsson.se ([169.254.7.166]) by\n\tESESSHC014.ericsson.se ([153.88.183.60]) with mapi id 14.03.0352.000; \n\tMon, 25 Sep 2017 17:51:53 +0200"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-AuditID":"c1b4fb30-0adfd9c000001911-e7-59c9261ad503","From":"Jan Scheurich <jan.scheurich@ericsson.com>","To":"Darrell Ball <dball@vmware.com>, Kevin Traynor <ktraynor@redhat.com>,\n\t\"dev@openvswitch.org\" <dev@openvswitch.org>, \"i.maximets@samsung.com\"\n\t<i.maximets@samsung.com>","Thread-Topic":"[PATCH 1/3] dpif-netdev: Rename rxq_interval.","Thread-Index":"AQHTIbhYmtNDVz3LrU62YfG9XBOR9qLBSzWAgASdnmA=","Date":"Mon, 25 Sep 2017 15:51:52 +0000","Message-ID":"<CFF8EF42F1132E4CBE2BF0AB6C21C58D7881804D@ESESSMB107.ericsson.se>","References":"<1504115149-26864-1-git-send-email-ktraynor@redhat.com>\n\t<045F7F7E-ADB4-46E3-A237-5FB1F80E836A@vmware.com>\n\t<D8853489-68FE-4E01-9A95-3C97B2F82CD4@vmware.com>","In-Reply-To":"<D8853489-68FE-4E01-9A95-3C97B2F82CD4@vmware.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[153.88.183.16]","MIME-Version":"1.0","X-Brightmail-Tracker":"H4sIAAAAAAAAA+NgFmplkeLIzCtJLcpLzFFi42KZGbHdRldK7WSkwfkjxhbPXyxktjh6eg+z\n\txZX2n+wWaw99YHdg8Xh28z+jx/t9V9k8+rasYvR4N/8tWwBLFJdNSmpOZllqkb5dAldG+6yl\n\tbAWNkhXnG44xNzB+FOxi5OSQEDCR2L1xFnsXIxeHkMARRolfUztYIJwljBKLHq0BynBwsAkY\n\tSMze7QASFxFYwyhxp3U+M0i3sICVxI6d/ewgtoiAtcTMGztZIWwrie7brSwgNouAqsTky5vA\n\tangFfCVeLtzHBrFgNaPE/1lHwBZwCthJPH2UDVLDKCAm8f3UGiYQm1lAXOLWk/lMEJcKSCzZ\n\tc54ZwhaVePn4HyuErSix82w7M0S9jsSC3Z/YIGxtiWULXzND7BWUODnzCcsERpFZSMbOQtIy\n\tC0nLLCQtCxhZVjGKFqcWJ+WmGxnppRZlJhcX5+fp5aWWbGIERs7BLb8NdjC+fO54iFGAg1GJ\n\th7dK4WSkEGtiWXFl7iFGCQ5mJRHeREWgEG9KYmVValF+fFFpTmrxIUZpDhYlcV7HfRcihATS\n\tE0tSs1NTC1KLYLJMHJxSDYxrah18zzxc4/WBd9lnv6t/PCayaQiWej5lnZots8PP6kT6Lf9X\n\tiqvvLp39WP3poQsB2n4JLIm5IrN2yNwv0ijSNT26JelZM+cl7h/6xV9XZduGnvSLf/s7w5tX\n\t1GKtbyRPy0Mfdc8ODqMevutimT4nXrBdamK+weshHdQ5W1hud+rF5DKH30osxRmJhlrMRcWJ\n\tAC+AB1uYAgAA","X-Spam-Status":"No, score=-1.8 required=5.0 tests=RCVD_IN_DNSWL_MED,\n\tRCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH 1/3] dpif-netdev: Rename rxq_interval.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"<ovs-dev.openvswitch.org>","List-Unsubscribe":"<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>","List-Archive":"<http://mail.openvswitch.org/pipermail/ovs-dev/>","List-Post":"<mailto:ovs-dev@openvswitch.org>","List-Help":"<mailto:ovs-dev-request@openvswitch.org?subject=help>","List-Subscribe":"<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1791312,"web_url":"http://patchwork.ozlabs.org/comment/1791312/","msgid":"<5a2648fa-1e25-2b3d-6fd5-f5358bc289dd@redhat.com>","list_archive_url":null,"date":"2017-10-20T10:37:00","subject":"Re: [ovs-dev] [PATCH 1/3] dpif-netdev: Rename rxq_interval.","submitter":{"id":70482,"url":"http://patchwork.ozlabs.org/api/people/70482/","name":"Kevin Traynor","email":"ktraynor@redhat.com"},"content":"Ping again. This is a simple variable rename that was requested.\n\nOn 09/22/2017 08:22 PM, Darrell Ball wrote:\n> Are there any other comments?\n> \n> \n> \n> On 8/30/17, 10:49 AM, \"Darrell Ball\" <dball@vmware.com> wrote:\n> \n>     Thanks Kevin\n>     \n>     Naming is hard.\n>     The name looks a bit more intuitive and matches closely with the description previously added.\n>     \n>     Darrell\n>     \n>     On 8/30/17, 10:45 AM, \"Kevin Traynor\" <ktraynor@redhat.com> wrote:\n>     \n>         rxq_interval was added before there was other #defines\n>         and code related to rxq intervals.\n>         \n>         Rename to rxq_next_cycles_store in order to make it more intuitive.\n>         \n>         Reported-by: Ilya Maximets <i.maximets@samsung.com>\n>         Signed-off-by: Kevin Traynor <ktraynor@redhat.com>\n>         ---\n>          lib/dpif-netdev.c | 8 ++++----\n>          1 file changed, 4 insertions(+), 4 deletions(-)\n>         \n>         diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c\n>         index 071ec14..55d5656 100644\n>         --- a/lib/dpif-netdev.c\n>         +++ b/lib/dpif-netdev.c\n>         @@ -576,5 +576,5 @@ struct dp_netdev_pmd_thread {\n>              /* End of the next time interval for which processing cycles\n>                 are stored for each polled rxq. */\n>         -    long long int rxq_interval;\n>         +    long long int rxq_next_cycle_store;\n>          \n>              /* Statistics. */\n>         @@ -4507,5 +4507,5 @@ dp_netdev_configure_pmd(struct dp_netdev_pmd_thread *pmd, struct dp_netdev *dp,\n>              cmap_init(&pmd->classifiers);\n>              pmd->next_optimization = time_msec() + DPCLS_OPTIMIZATION_INTERVAL;\n>         -    pmd->rxq_interval = time_msec() + PMD_RXQ_INTERVAL_LEN;\n>         +    pmd->rxq_next_cycle_store = time_msec() + PMD_RXQ_INTERVAL_LEN;\n>              hmap_init(&pmd->poll_list);\n>              hmap_init(&pmd->tx_ports);\n>         @@ -5951,5 +5951,5 @@ dp_netdev_pmd_try_optimize(struct dp_netdev_pmd_thread *pmd,\n>              long long int now = time_msec();\n>          \n>         -    if (now > pmd->rxq_interval) {\n>         +    if (now > pmd->rxq_next_cycle_store) {\n>                  /* Get the cycles that were used to process each queue and store. */\n>                  for (unsigned i = 0; i < poll_cnt; i++) {\n>         @@ -5961,5 +5961,5 @@ dp_netdev_pmd_try_optimize(struct dp_netdev_pmd_thread *pmd,\n>                  }\n>                  /* Start new measuring interval */\n>         -        pmd->rxq_interval = now + PMD_RXQ_INTERVAL_LEN;\n>         +        pmd->rxq_next_cycle_store = now + PMD_RXQ_INTERVAL_LEN;\n>              }\n>          \n>         -- \n>         1.8.3.1\n>         \n>         \n>     \n>     \n>","headers":{"Return-Path":"<ovs-dev-bounces@openvswitch.org>","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ktraynor@redhat.com"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yJMgB5M0sz9t6n\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 20 Oct 2017 21:37:10 +1100 (AEDT)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 5C625BCE;\n\tFri, 20 Oct 2017 10:37:06 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id C7ACDBCA\n\tfor <dev@openvswitch.org>; Fri, 20 Oct 2017 10:37:04 +0000 (UTC)","from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id CF42F4CE\n\tfor <dev@openvswitch.org>; Fri, 20 Oct 2017 10:37:03 +0000 (UTC)","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id F017A60159;\n\tFri, 20 Oct 2017 10:37:02 +0000 (UTC)","from ktraynor.remote.csb (ovpn-116-70.ams2.redhat.com\n\t[10.36.116.70])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 78508600C2;\n\tFri, 20 Oct 2017 10:37:01 +0000 (UTC)"],"X-Greylist":["domain auto-whitelisted by SQLgrey-1.7.6","Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tFri, 20 Oct 2017 10:37:03 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com F017A60159","To":"Darrell Ball <dball@vmware.com>, \"dev@openvswitch.org\"\n\t<dev@openvswitch.org>,\n\t\"i.maximets@samsung.com\" <i.maximets@samsung.com>, \n\tIan Stokes <ian.stokes@intel.com>","References":"<1504115149-26864-1-git-send-email-ktraynor@redhat.com>\n\t<045F7F7E-ADB4-46E3-A237-5FB1F80E836A@vmware.com>\n\t<D8853489-68FE-4E01-9A95-3C97B2F82CD4@vmware.com>","From":"Kevin Traynor <ktraynor@redhat.com>","Organization":"Red Hat","Message-ID":"<5a2648fa-1e25-2b3d-6fd5-f5358bc289dd@redhat.com>","Date":"Fri, 20 Oct 2017 11:37:00 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"<D8853489-68FE-4E01-9A95-3C97B2F82CD4@vmware.com>","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Spam-Status":"No, score=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH 1/3] dpif-netdev: Rename rxq_interval.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"<ovs-dev.openvswitch.org>","List-Unsubscribe":"<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>","List-Archive":"<http://mail.openvswitch.org/pipermail/ovs-dev/>","List-Post":"<mailto:ovs-dev@openvswitch.org>","List-Help":"<mailto:ovs-dev-request@openvswitch.org?subject=help>","List-Subscribe":"<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1793128,"web_url":"http://patchwork.ozlabs.org/comment/1793128/","msgid":"<BCFD2BB875535045A5368D9ADBF296993504DD9E@IRSMSX101.ger.corp.intel.com>","list_archive_url":null,"date":"2017-10-24T10:57:33","subject":"Re: [ovs-dev] [PATCH 1/3] dpif-netdev: Rename rxq_interval.","submitter":{"id":68178,"url":"http://patchwork.ozlabs.org/api/people/68178/","name":"Fischetti, Antonio","email":"antonio.fischetti@intel.com"},"content":"LGTM, makes the code more readable.\n\nAcked-by: Antonio Fischetti <antonio.fischetti@intel.com>\n\n\n> -----Original Message-----\n> From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-bounces@openvswitch.org]\n> On Behalf Of Kevin Traynor\n> Sent: Friday, October 20, 2017 11:37 AM\n> To: Darrell Ball <dball@vmware.com>; dev@openvswitch.org;\n> i.maximets@samsung.com; Stokes, Ian <ian.stokes@intel.com>\n> Subject: Re: [ovs-dev] [PATCH 1/3] dpif-netdev: Rename rxq_interval.\n> \n> Ping again. This is a simple variable rename that was requested.\n> \n> On 09/22/2017 08:22 PM, Darrell Ball wrote:\n> > Are there any other comments?\n> >\n> >\n> >\n> > On 8/30/17, 10:49 AM, \"Darrell Ball\" <dball@vmware.com> wrote:\n> >\n> >     Thanks Kevin\n> >\n> >     Naming is hard.\n> >     The name looks a bit more intuitive and matches closely with the\n> description previously added.\n> >\n> >     Darrell\n> >\n> >     On 8/30/17, 10:45 AM, \"Kevin Traynor\" <ktraynor@redhat.com> wrote:\n> >\n> >         rxq_interval was added before there was other #defines\n> >         and code related to rxq intervals.\n> >\n> >         Rename to rxq_next_cycles_store in order to make it more intuitive.\n> >\n> >         Reported-by: Ilya Maximets <i.maximets@samsung.com>\n> >         Signed-off-by: Kevin Traynor <ktraynor@redhat.com>\n> >         ---\n> >          lib/dpif-netdev.c | 8 ++++----\n> >          1 file changed, 4 insertions(+), 4 deletions(-)\n> >\n> >         diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c\n> >         index 071ec14..55d5656 100644\n> >         --- a/lib/dpif-netdev.c\n> >         +++ b/lib/dpif-netdev.c\n> >         @@ -576,5 +576,5 @@ struct dp_netdev_pmd_thread {\n> >              /* End of the next time interval for which processing cycles\n> >                 are stored for each polled rxq. */\n> >         -    long long int rxq_interval;\n> >         +    long long int rxq_next_cycle_store;\n> >\n> >              /* Statistics. */\n> >         @@ -4507,5 +4507,5 @@ dp_netdev_configure_pmd(struct\n> dp_netdev_pmd_thread *pmd, struct dp_netdev *dp,\n> >              cmap_init(&pmd->classifiers);\n> >              pmd->next_optimization = time_msec() +\n> DPCLS_OPTIMIZATION_INTERVAL;\n> >         -    pmd->rxq_interval = time_msec() + PMD_RXQ_INTERVAL_LEN;\n> >         +    pmd->rxq_next_cycle_store = time_msec() + PMD_RXQ_INTERVAL_LEN;\n> >              hmap_init(&pmd->poll_list);\n> >              hmap_init(&pmd->tx_ports);\n> >         @@ -5951,5 +5951,5 @@ dp_netdev_pmd_try_optimize(struct\n> dp_netdev_pmd_thread *pmd,\n> >              long long int now = time_msec();\n> >\n> >         -    if (now > pmd->rxq_interval) {\n> >         +    if (now > pmd->rxq_next_cycle_store) {\n> >                  /* Get the cycles that were used to process each queue and\n> store. */\n> >                  for (unsigned i = 0; i < poll_cnt; i++) {\n> >         @@ -5961,5 +5961,5 @@ dp_netdev_pmd_try_optimize(struct\n> dp_netdev_pmd_thread *pmd,\n> >                  }\n> >                  /* Start new measuring interval */\n> >         -        pmd->rxq_interval = now + PMD_RXQ_INTERVAL_LEN;\n> >         +        pmd->rxq_next_cycle_store = now + PMD_RXQ_INTERVAL_LEN;\n> >              }\n> >\n> >         --\n> >         1.8.3.1\n> >\n> >\n> >\n> >\n> >\n> \n> _______________________________________________\n> dev mailing list\n> dev@openvswitch.org\n> https://mail.openvswitch.org/mailman/listinfo/ovs-dev","headers":{"Return-Path":"<ovs-dev-bounces@openvswitch.org>","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yLqx33QHdz9sRV\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 24 Oct 2017 21:57:42 +1100 (AEDT)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id B612DA85;\n\tTue, 24 Oct 2017 10:57:38 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id EF6609F8\n\tfor <dev@openvswitch.org>; Tue, 24 Oct 2017 10:57:37 +0000 (UTC)","from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 7D8B718A\n\tfor <dev@openvswitch.org>; Tue, 24 Oct 2017 10:57:36 +0000 (UTC)","from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga105.jf.intel.com with ESMTP; 24 Oct 2017 03:57:35 -0700","from irsmsx154.ger.corp.intel.com ([163.33.192.96])\n\tby fmsmga004.fm.intel.com with ESMTP; 24 Oct 2017 03:57:34 -0700","from irsmsx101.ger.corp.intel.com ([169.254.1.22]) by\n\tIRSMSX154.ger.corp.intel.com ([169.254.12.83]) with mapi id\n\t14.03.0319.002; Tue, 24 Oct 2017 11:57:33 +0100"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.43,427,1503385200\"; d=\"scan'208\";a=\"326991418\"","From":"\"Fischetti, Antonio\" <antonio.fischetti@intel.com>","To":"Kevin Traynor <ktraynor@redhat.com>, Darrell Ball <dball@vmware.com>,\n\t\"dev@openvswitch.org\" <dev@openvswitch.org>, \"i.maximets@samsung.com\"\n\t<i.maximets@samsung.com>, \"Stokes, Ian\" <ian.stokes@intel.com>","Thread-Topic":"[ovs-dev] [PATCH 1/3] dpif-netdev: Rename rxq_interval.","Thread-Index":"AQHTIbhqrbHmw3UWSk2eLKTD7PeN5qLBW/iAgCtujACABl8dAA==","Date":"Tue, 24 Oct 2017 10:57:33 +0000","Message-ID":"<BCFD2BB875535045A5368D9ADBF296993504DD9E@IRSMSX101.ger.corp.intel.com>","References":"<1504115149-26864-1-git-send-email-ktraynor@redhat.com>\n\t<045F7F7E-ADB4-46E3-A237-5FB1F80E836A@vmware.com>\n\t<D8853489-68FE-4E01-9A95-3C97B2F82CD4@vmware.com>\n\t<5a2648fa-1e25-2b3d-6fd5-f5358bc289dd@redhat.com>","In-Reply-To":"<5a2648fa-1e25-2b3d-6fd5-f5358bc289dd@redhat.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-titus-metadata-40":"eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGI4YzFiMDUtMzQ3ZC00YTUyLThkMDgtNDMyYTQzNDNjMGQzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InN5N2xVbEZiS2FXWnFPQ0FIQTc2OVVkTkR4Y01XVFIzTE1xWlBnVFlvczQ9In0=","x-ctpclassification":"CTP_IC","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[163.33.239.182]","MIME-Version":"1.0","X-Spam-Status":"No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH 1/3] dpif-netdev: Rename rxq_interval.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"<ovs-dev.openvswitch.org>","List-Unsubscribe":"<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>","List-Archive":"<http://mail.openvswitch.org/pipermail/ovs-dev/>","List-Post":"<mailto:ovs-dev@openvswitch.org>","List-Help":"<mailto:ovs-dev-request@openvswitch.org?subject=help>","List-Subscribe":"<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]