[{"id":1760385,"web_url":"http://patchwork.ozlabs.org/comment/1760385/","msgid":"<20170830172413.GA9720@localhost.localdomain>","list_archive_url":null,"date":"2017-08-30T17:24:13","subject":"Re: [Qemu-devel] [PATCH v2 2/3] block-jobs: Optionally unregister\n\tlive block operations","submitter":{"id":195,"url":"http://patchwork.ozlabs.org/api/people/195/","name":"Eduardo Habkost","email":"ehabkost@redhat.com"},"content":"On Wed, Aug 30, 2017 at 01:01:41PM -0400, Jeff Cody wrote:\n> From: Jeffrey Cody \n> \n> If configured without live block operations enabled, unregister the\n> live block operation commands.\n> \n> Signed-off-by: Jeff Cody \n> ---\n> monitor.c | 16 ++++++++++++++++\n> 1 file changed, 16 insertions(+)\n> \n> diff --git a/monitor.c b/monitor.c\n> index e0f8801..de0a70e 100644\n> --- a/monitor.c\n> +++ b/monitor.c\n> @@ -998,6 +998,22 @@ static void qmp_unregister_commands_hack(void)\n> && !defined(TARGET_S390X)\n> qmp_unregister_command(&qmp_commands, \"query-cpu-definitions\");\n> #endif\n> +#ifndef CONFIG_LIVE_BLOCK_OPS\n> + qmp_unregister_command(&qmp_commands, \"block-stream\");\n> + qmp_unregister_command(&qmp_commands, \"block-commit\");\n> + qmp_unregister_command(&qmp_commands, \"drive-mirror\");\n> + qmp_unregister_command(&qmp_commands, \"blockdev-mirror\");\n> + qmp_unregister_command(&qmp_commands, \"drive-backup\");\n> + qmp_unregister_command(&qmp_commands, \"blockdev-backup\");\n> + qmp_unregister_command(&qmp_commands, \"blockdev-snapshot\");\n> + qmp_unregister_command(&qmp_commands, \"blockdev-snapshot-sync\");\n> + qmp_unregister_command(&qmp_commands, \"block-job-set-speed\");\n> + qmp_unregister_command(&qmp_commands, \"block-job-cancel\");\n> + qmp_unregister_command(&qmp_commands, \"block-job-pause\");\n> + qmp_unregister_command(&qmp_commands, \"block-job-resume\");\n> + qmp_unregister_command(&qmp_commands, \"block-job-complete\");\n> + qmp_unregister_command(&qmp_commands, \"query-block-jobs\");\n> +#endif\n\nI suggest using the new mechanisms added by:\n\n [PATCH 00/26] qapi: add #if pre-processor conditions to generated code","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ehabkost@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjCvH64Lwz9s7f\n\tfor ;\n\tThu, 31 Aug 2017 03:59:39 +1000 (AEST)","from localhost ([::1]:51972 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn7H7-0003n4-L9\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 13:59:37 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39066)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn6j4-0004si-OT\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 13:24:28 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn6j3-0008Mn-QK\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 13:24:26 -0400","from mx1.redhat.com ([209.132.183.28]:47418)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dn6j1-0008L8-LK; Wed, 30 Aug 2017 13:24:23 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 2EE873B724;\n\tWed, 30 Aug 2017 17:24:21 +0000 (UTC)","from localhost (ovpn-116-66.gru2.redhat.com [10.97.116.66])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 5644560BEB;\n\tWed, 30 Aug 2017 17:24:15 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 2EE873B724","Date":"Wed, 30 Aug 2017 14:24:13 -0300","From":"Eduardo Habkost ","To":"Jeff Cody ","Message-ID":"<20170830172413.GA9720@localhost.localdomain>","References":"\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","X-Fnord":"you can see the fnord","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tWed, 30 Aug 2017 17:24:21 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 2/3] block-jobs: Optionally unregister\n\tlive block operations","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-block@nongnu.org, qemu-devel@nongnu.org, peterx@redhat.com,\n\tdgilbert@redhat.com, =?iso-8859-1?q?Marc-Andr=E9?=\n\tLureau , mrezanin@redhat.com,\n\tjsnow@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1760423,"web_url":"http://patchwork.ozlabs.org/comment/1760423/","msgid":"<4f2efa42-4a81-9890-497f-123c2b9a946c@redhat.com>","list_archive_url":null,"date":"2017-08-30T19:23:33","subject":"Re: [Qemu-devel] [PATCH v2 2/3] block-jobs: Optionally unregister\n\tlive block operations","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 08/30/2017 12:24 PM, Eduardo Habkost wrote:\n> On Wed, Aug 30, 2017 at 01:01:41PM -0400, Jeff Cody wrote:\n>> From: Jeffrey Cody \n>>\n>> If configured without live block operations enabled, unregister the\n>> live block operation commands.\n>>\n>> Signed-off-by: Jeff Cody \n>> ---\n>> monitor.c | 16 ++++++++++++++++\n>> 1 file changed, 16 insertions(+)\n>>\n\n> \n> I suggest using the new mechanisms added by:\n> \n> [PATCH 00/26] qapi: add #if pre-processor conditions to generated code\n\nThose haven't landed yet, but as both series are proposed for 2.11, I\nindeed agree that basing this series on top of that one will be a bit\ncleaner.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjFmz4f1vz9s8P\n\tfor ;\n\tThu, 31 Aug 2017 05:24:17 +1000 (AEST)","from localhost ([::1]:52325 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn8b0-0003jL-LV\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 15:24:14 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42484)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn8ac-0003hn-RS\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 15:23:51 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn8ab-0001mz-Kw\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 15:23:50 -0400","from mx1.redhat.com ([209.132.183.28]:33070)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dn8aV-0001lN-Mb; Wed, 30 Aug 2017 15:23:43 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id BB3D9C058EB4;\n\tWed, 30 Aug 2017 19:23:42 +0000 (UTC)","from [10.10.122.186] (ovpn-122-186.rdu2.redhat.com [10.10.122.186])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id EAD2877557;\n\tWed, 30 Aug 2017 19:23:33 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com BB3D9C058EB4","To":"Eduardo Habkost , Jeff Cody ","References":"\n\t\n\t<20170830172413.GA9720@localhost.localdomain>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<4f2efa42-4a81-9890-497f-123c2b9a946c@redhat.com>","Date":"Wed, 30 Aug 2017 14:23:33 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170830172413.GA9720@localhost.localdomain>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"Hb0KwjtoaDPuMHqPe2qg9vsxVBqqWQeif\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tWed, 30 Aug 2017 19:23:42 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v2 2/3] block-jobs: Optionally unregister\n\tlive block operations","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-block@nongnu.org, qemu-devel@nongnu.org, peterx@redhat.com,\n\tdgilbert@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?=\n\t, \tmrezanin@redhat.com, jsnow@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1760686,"web_url":"http://patchwork.ozlabs.org/comment/1760686/","msgid":"<877exki6az.fsf@dusky.pond.sub.org>","list_archive_url":null,"date":"2017-08-31T06:45:40","subject":"Re: [Qemu-devel] [PATCH v2 2/3] block-jobs: Optionally unregister\n\tlive block operations","submitter":{"id":2645,"url":"http://patchwork.ozlabs.org/api/people/2645/","name":"Markus Armbruster","email":"armbru@redhat.com"},"content":"Eric Blake writes:\n\n> On 08/30/2017 12:24 PM, Eduardo Habkost wrote:\n>> On Wed, Aug 30, 2017 at 01:01:41PM -0400, Jeff Cody wrote:\n>>> From: Jeffrey Cody \n>>>\n>>> If configured without live block operations enabled, unregister the\n>>> live block operation commands.\n>>>\n>>> Signed-off-by: Jeff Cody \n>>> ---\n>>> monitor.c | 16 ++++++++++++++++\n>>> 1 file changed, 16 insertions(+)\n>>>\n>\n>> \n>> I suggest using the new mechanisms added by:\n>> \n>> [PATCH 00/26] qapi: add #if pre-processor conditions to generated code\n>\n> Those haven't landed yet, but as both series are proposed for 2.11, I\n> indeed agree that basing this series on top of that one will be a bit\n> cleaner.\n\nRebasing shouldn't be hard. However, we then have to hold it until the\nQAPI series lands. I don't think holding is necessary, as the conflicts\nbetween the two are obvious, and should be straightforward to resolve.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=armbru@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjY5F59YFz9s7F\n\tfor ;\n\tThu, 31 Aug 2017 16:54:25 +1000 (AEST)","from localhost ([::1]:54198 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnJMt-0007rW-PM\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 02:54:23 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52545)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnJEg-00012X-71\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 02:45:54 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnJEf-0007c1-DC\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 02:45:54 -0400","from mx1.redhat.com ([209.132.183.28]:38338)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnJEa-0007Yl-JZ; Thu, 31 Aug 2017 02:45:49 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 85ED84A6E5;\n\tThu, 31 Aug 2017 06:45:47 +0000 (UTC)","from blackfin.pond.sub.org (ovpn-116-75.ams2.redhat.com\n\t[10.36.116.75])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 1C18E5C890;\n\tThu, 31 Aug 2017 06:45:42 +0000 (UTC)","by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid 9912A1138662; Thu, 31 Aug 2017 08:45:40 +0200 (CEST)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 85ED84A6E5","From":"Markus Armbruster ","To":"Eric Blake ","References":"\n\t\n\t<20170830172413.GA9720@localhost.localdomain>\n\t<4f2efa42-4a81-9890-497f-123c2b9a946c@redhat.com>","Date":"Thu, 31 Aug 2017 08:45:40 +0200","In-Reply-To":"<4f2efa42-4a81-9890-497f-123c2b9a946c@redhat.com> (Eric Blake's\n\tmessage of \"Wed, 30 Aug 2017 14:23:33 -0500\")","Message-ID":"<877exki6az.fsf@dusky.pond.sub.org>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tThu, 31 Aug 2017 06:45:47 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 2/3] block-jobs: Optionally unregister\n\tlive block operations","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Eduardo Habkost , qemu-block@nongnu.org, Jeff Cody\n\t, dgilbert@redhat.com, peterx@redhat.com,\n\tqemu-devel@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9?=\n\tLureau , mrezanin@redhat.com,\n\tjsnow@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764094,"web_url":"http://patchwork.ozlabs.org/comment/1764094/","msgid":"<20170906130041.GI3753@dhcp-200-186.str.redhat.com>","list_archive_url":null,"date":"2017-09-06T13:00:41","subject":"Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/3] block-jobs: Optionally\n\tunregister live block operations","submitter":{"id":2714,"url":"http://patchwork.ozlabs.org/api/people/2714/","name":"Kevin Wolf","email":"kwolf@redhat.com"},"content":"Am 30.08.2017 um 19:01 hat Jeff Cody geschrieben:\n> From: Jeffrey Cody \n> \n> If configured without live block operations enabled, unregister the\n> live block operation commands.\n> \n> Signed-off-by: Jeff Cody \n\nHow sure are we that libvirt will like a qemu that advertises these\ncommands in the schema, but doesn't actually provide them?\n\nKevin","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kwolf@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnNyK6Dbmz9sBd\n\tfor ;\n\tWed, 6 Sep 2017 23:01:45 +1000 (AEST)","from localhost ([::1]:36094 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpZxg-0008RQ-1T\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 09:01:44 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59468)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpZx9-0008K7-KW\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 09:01:20 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpZx5-00027x-6V\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 09:01:11 -0400","from mx1.redhat.com ([209.132.183.28]:47796)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpZwt-000227-AB; Wed, 06 Sep 2017 09:00:55 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 0340A81241;\n\tWed, 6 Sep 2017 13:00:54 +0000 (UTC)","from dhcp-200-186.str.redhat.com (dhcp-200-186.str.redhat.com\n\t[10.33.200.186])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id C09A918C5C;\n\tWed, 6 Sep 2017 13:00:42 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 0340A81241","Date":"Wed, 6 Sep 2017 15:00:41 +0200","From":"Kevin Wolf ","To":"Jeff Cody ","Message-ID":"<20170906130041.GI3753@dhcp-200-186.str.redhat.com>","References":"\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tWed, 06 Sep 2017 13:00:54 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/3] block-jobs: Optionally\n\tunregister live block operations","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"ehabkost@redhat.com, qemu-block@nongnu.org, dgilbert@redhat.com,\n\tpeterx@redhat.com, qemu-devel@nongnu.org, mrezanin@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764184,"web_url":"http://patchwork.ozlabs.org/comment/1764184/","msgid":"<20170906150221.GB7570@localhost.localdomain>","list_archive_url":null,"date":"2017-09-06T15:02:21","subject":"Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/3] block-jobs: Optionally\n\tunregister live block operations","submitter":{"id":195,"url":"http://patchwork.ozlabs.org/api/people/195/","name":"Eduardo Habkost","email":"ehabkost@redhat.com"},"content":"On Wed, Sep 06, 2017 at 03:00:41PM +0200, Kevin Wolf wrote:\n> Am 30.08.2017 um 19:01 hat Jeff Cody geschrieben:\n> > From: Jeffrey Cody \n> > \n> > If configured without live block operations enabled, unregister the\n> > live block operation commands.\n> > \n> > Signed-off-by: Jeff Cody \n> \n> How sure are we that libvirt will like a qemu that advertises these\n> commands in the schema, but doesn't actually provide them?\n\nIf libvirt wants to know if a command is available, it uses\n'query-commands', not 'query-qmp-schema'.\n\nThe only query-qmp-schema elements used by latest libvirt are\ngluster-related blockdev-add options (see\nlibvirt/src/qemu/qemu_capabilities.c:virQEMUCapsQMPSchemaQueries]]).","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ehabkost@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnRq83hfSz9t2R\n\tfor ;\n\tThu, 7 Sep 2017 01:10:44 +1000 (AEST)","from localhost ([::1]:36616 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpbyU-0005O4-D0\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 11:10:42 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46169)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpbqk-0008RX-NE\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 11:02:43 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpbqg-00019Y-1d\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 11:02:42 -0400","from mx1.redhat.com ([209.132.183.28]:37210)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpbqU-0000iq-IR; Wed, 06 Sep 2017 11:02:26 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 6F3745F7B9;\n\tWed, 6 Sep 2017 15:02:25 +0000 (UTC)","from localhost (ovpn-116-45.gru2.redhat.com [10.97.116.45])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 866E36E510;\n\tWed, 6 Sep 2017 15:02:22 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 6F3745F7B9","Date":"Wed, 6 Sep 2017 12:02:21 -0300","From":"Eduardo Habkost ","To":"Kevin Wolf ","Message-ID":"<20170906150221.GB7570@localhost.localdomain>","References":"\n\t\n\t<20170906130041.GI3753@dhcp-200-186.str.redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170906130041.GI3753@dhcp-200-186.str.redhat.com>","X-Fnord":"you can see the fnord","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tWed, 06 Sep 2017 15:02:25 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/3] block-jobs: Optionally\n\tunregister live block operations","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-block@nongnu.org, Jeff Cody ,\n\tqemu-devel@nongnu.org, \n\tpeterx@redhat.com, dgilbert@redhat.com, mrezanin@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764256,"web_url":"http://patchwork.ozlabs.org/comment/1764256/","msgid":"","list_archive_url":null,"date":"2017-09-06T16:42:50","subject":"Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/3] block-jobs: Optionally\n\tunregister live block operations","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/06/2017 10:02 AM, Eduardo Habkost wrote:\n> On Wed, Sep 06, 2017 at 03:00:41PM +0200, Kevin Wolf wrote:\n>> Am 30.08.2017 um 19:01 hat Jeff Cody geschrieben:\n>>> From: Jeffrey Cody \n>>>\n>>> If configured without live block operations enabled, unregister the\n>>> live block operation commands.\n>>>\n>>> Signed-off-by: Jeff Cody \n>>\n>> How sure are we that libvirt will like a qemu that advertises these\n>> commands in the schema, but doesn't actually provide them?\n> \n> If libvirt wants to know if a command is available, it uses\n> 'query-commands', not 'query-qmp-schema'.\n> \n> The only query-qmp-schema elements used by latest libvirt are\n> gluster-related blockdev-add options (see\n> libvirt/src/qemu/qemu_capabilities.c:virQEMUCapsQMPSchemaQueries]]).\n\nIndeed, libvirt is currently just fine with the fact that query-commands\nintrospection hides disabled commands, even if they are still leaked in\nquery-qmp-schema. Besides, Marc-Andre's work on adding #if support to\nQAPI should probably also land in 2.11, at which point the hack goes\naway (because then we ARE properly hiding things from the schema\nintrospection).","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnTwG51HCz9sRV\n\tfor ;\n\tThu, 7 Sep 2017 02:45:18 +1000 (AEST)","from localhost ([::1]:37142 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpdS0-0005h2-HC\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 12:45:16 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:54649)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpdQ4-0004WH-Rf\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 12:43:20 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpdPv-0001KQ-Gg\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 12:43:16 -0400","from mx1.redhat.com ([209.132.183.28]:46316)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpdPk-00019j-3v; Wed, 06 Sep 2017 12:42:56 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id F2C844A6E4;\n\tWed, 6 Sep 2017 16:42:54 +0000 (UTC)","from [10.10.120.228] (ovpn-120-228.rdu2.redhat.com [10.10.120.228])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 53F8A19E9C;\n\tWed, 6 Sep 2017 16:42:51 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com F2C844A6E4","To":"Eduardo Habkost , Kevin Wolf ","References":"\n\t\n\t<20170906130041.GI3753@dhcp-200-186.str.redhat.com>\n\t<20170906150221.GB7570@localhost.localdomain>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"","Date":"Wed, 6 Sep 2017 11:42:50 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170906150221.GB7570@localhost.localdomain>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"7anVeBFRGcUSvcc35oTmLuCgAlMUa75gx\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tWed, 06 Sep 2017 16:42:55 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/3] block-jobs: Optionally\n\tunregister live block operations","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-block@nongnu.org, Jeff Cody ,\n\tqemu-devel@nongnu.org, \n\tpeterx@redhat.com, dgilbert@redhat.com, mrezanin@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]