[{"id":1760410,"web_url":"http://patchwork.ozlabs.org/comment/1760410/","msgid":"<d05eb222-8b39-4ec6-2a2b-34a255becd43@redhat.com>","list_archive_url":null,"date":"2017-08-30T18:55:12","subject":"Re: [Qemu-devel] [PATCH v1 01/11] exec,\n\tdump: don't include exec/exec-all.h explicitly","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 30.08.2017 19:05, David Hildenbrand wrote:\n> All but two, namely exec.c and dump.c, include exec/exec-all.h via\n> cpu.h only. as these files already include cpu.h, let's just drop the\n> additional include.\n> \n> Signed-off-by: David Hildenbrand <david@redhat.com>\n> ---\n>  dump.c | 1 -\n>  exec.c | 1 -\n>  2 files changed, 2 deletions(-)\n> \n> diff --git a/dump.c b/dump.c\n> index d9090a24cc..c00094475c 100644\n> --- a/dump.c\n> +++ b/dump.c\n> @@ -15,7 +15,6 @@\n>  #include \"qemu/cutils.h\"\n>  #include \"elf.h\"\n>  #include \"cpu.h\"\n> -#include \"exec/cpu-all.h\"\n\nThat's cpu-all.h, not exec-all.h ...\n\n>  #include \"exec/hwaddr.h\"\n>  #include \"monitor/monitor.h\"\n>  #include \"sysemu/kvm.h\"\n> diff --git a/exec.c b/exec.c\n> index d20c34ca83..8d8b6a0769 100644\n> --- a/exec.c\n> +++ b/exec.c\n> @@ -23,7 +23,6 @@\n>  \n>  #include \"qemu/cutils.h\"\n>  #include \"cpu.h\"\n> -#include \"exec/exec-all.h\"\n>  #include \"exec/target_page.h\"\n>  #include \"tcg.h\"\n>  #include \"hw/qdev-core.h\"\n\n... and if I do a grep for exec-all.h in the cpu.h files, I hardly get\nany matches. => Your patch description sounds wrong ... I guess you only\nwanted to handle cpu-all.h here?\n\n Thomas","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjF833NXxz9s83\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 04:55:46 +1000 (AEST)","from localhost ([::1]:52221 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dn89P-0007Jr-E5\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 14:55:43 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:35705)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <thuth@redhat.com>) id 1dn893-0007JQ-9L\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 14:55:22 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <thuth@redhat.com>) id 1dn890-00014W-PK\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 14:55:21 -0400","from mx1.redhat.com ([209.132.183.28]:44330)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <thuth@redhat.com>) id 1dn890-00014H-Ia\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 14:55:18 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1C238267C1;\n\tWed, 30 Aug 2017 18:55:17 +0000 (UTC)","from [10.36.116.20] (ovpn-116-20.ams2.redhat.com [10.36.116.20])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 06DE370941;\n\tWed, 30 Aug 2017 18:55:14 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 1C238267C1","To":"David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org","References":"<20170830170601.15855-1-david@redhat.com>\n\t<20170830170601.15855-2-david@redhat.com>","From":"Thomas Huth <thuth@redhat.com>","Message-ID":"<d05eb222-8b39-4ec6-2a2b-34a255becd43@redhat.com>","Date":"Wed, 30 Aug 2017 20:55:12 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170830170601.15855-2-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tWed, 30 Aug 2017 18:55:17 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 01/11] exec,\n\tdump: don't include exec/exec-all.h explicitly","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"borntraeger@de.ibm.com, cohuck@redhat.com,\n\tRichard Henderson <richard.henderson@linaro.org>,\n\tAlexander Graf <agraf@suse.de>, Aurelien Jarno <aurelien@aurel32.net>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1760966,"web_url":"http://patchwork.ozlabs.org/comment/1760966/","msgid":"<8dfd227b-1b56-4db3-4b13-1eb00602e627@redhat.com>","list_archive_url":null,"date":"2017-08-31T13:06:36","subject":"Re: [Qemu-devel] [PATCH v1 01/11] exec,\n\tdump: don't include exec/exec-all.h explicitly","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 30.08.2017 20:55, Thomas Huth wrote:\n> On 30.08.2017 19:05, David Hildenbrand wrote:\n>> All but two, namely exec.c and dump.c, include exec/exec-all.h via\n>> cpu.h only. as these files already include cpu.h, let's just drop the\n>> additional include.\n>>\n>> Signed-off-by: David Hildenbrand <david@redhat.com>\n>> ---\n>>  dump.c | 1 -\n>>  exec.c | 1 -\n>>  2 files changed, 2 deletions(-)\n>>\n>> diff --git a/dump.c b/dump.c\n>> index d9090a24cc..c00094475c 100644\n>> --- a/dump.c\n>> +++ b/dump.c\n>> @@ -15,7 +15,6 @@\n>>  #include \"qemu/cutils.h\"\n>>  #include \"elf.h\"\n>>  #include \"cpu.h\"\n>> -#include \"exec/cpu-all.h\"\n> \n> That's cpu-all.h, not exec-all.h ...\n> \n>>  #include \"exec/hwaddr.h\"\n>>  #include \"monitor/monitor.h\"\n>>  #include \"sysemu/kvm.h\"\n>> diff --git a/exec.c b/exec.c\n>> index d20c34ca83..8d8b6a0769 100644\n>> --- a/exec.c\n>> +++ b/exec.c\n>> @@ -23,7 +23,6 @@\n>>  \n>>  #include \"qemu/cutils.h\"\n>>  #include \"cpu.h\"\n>> -#include \"exec/exec-all.h\"\n>>  #include \"exec/target_page.h\"\n>>  #include \"tcg.h\"\n>>  #include \"hw/qdev-core.h\"\n> \n> ... and if I do a grep for exec-all.h in the cpu.h files, I hardly get\n> any matches. => Your patch description sounds wrong ... I guess you only\n> wanted to handle cpu-all.h here?\n> \n>  Thomas\n> \n\nexec/cpu-all.h it is. Fixed the subject+description.\n\nI'd really love to know what my brain was doing while composing that\nmessage. It will remain a mystery.","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjjMb4FXXz9sMN\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 23:07:21 +1000 (AEST)","from localhost ([::1]:55725 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dnPBm-00063f-82\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 09:07:18 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52011)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dnPBG-00063W-7c\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:06:55 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dnPBA-0005G6-Ir\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:06:46 -0400","from mx1.redhat.com ([209.132.183.28]:53030)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <david@redhat.com>) id 1dnPBA-0005Fi-CK\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:06:40 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 169F920A89;\n\tThu, 31 Aug 2017 13:06:39 +0000 (UTC)","from [10.36.118.11] (unknown [10.36.118.11])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 061909352B;\n\tThu, 31 Aug 2017 13:06:36 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 169F920A89","To":"Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org","References":"<20170830170601.15855-1-david@redhat.com>\n\t<20170830170601.15855-2-david@redhat.com>\n\t<d05eb222-8b39-4ec6-2a2b-34a255becd43@redhat.com>","From":"David Hildenbrand <david@redhat.com>","Organization":"Red Hat GmbH","Message-ID":"<8dfd227b-1b56-4db3-4b13-1eb00602e627@redhat.com>","Date":"Thu, 31 Aug 2017 15:06:36 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<d05eb222-8b39-4ec6-2a2b-34a255becd43@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tThu, 31 Aug 2017 13:06:39 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 01/11] exec,\n\tdump: don't include exec/exec-all.h explicitly","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"borntraeger@de.ibm.com, cohuck@redhat.com,\n\tRichard Henderson <richard.henderson@linaro.org>,\n\tAlexander Graf <agraf@suse.de>, Aurelien Jarno <aurelien@aurel32.net>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1761051,"web_url":"http://patchwork.ozlabs.org/comment/1761051/","msgid":"<20170831162139.2065033c.cohuck@redhat.com>","list_archive_url":null,"date":"2017-08-31T14:21:39","subject":"Re: [Qemu-devel] [PATCH v1 01/11] exec,\n\tdump: don't include exec/exec-all.h explicitly","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Wed, 30 Aug 2017 19:05:51 +0200\nDavid Hildenbrand <david@redhat.com> wrote:\n\n> All but two, namely exec.c and dump.c, include exec/exec-all.h via\n> cpu.h only. as these files already include cpu.h, let's just drop the\n> additional include.\n> \n> Signed-off-by: David Hildenbrand <david@redhat.com>\n> ---\n>  dump.c | 1 -\n>  exec.c | 1 -\n>  2 files changed, 2 deletions(-)\n> \n\nI think there are some more (target/<arch>/arch_dump.c and some i386\nfiles) - do you want to clean up those as well?","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjl2H5K7xz9s83\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  1 Sep 2017 00:22:31 +1000 (AEST)","from localhost ([::1]:56030 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dnQMX-0005qs-OP\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 10:22:29 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42572)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <cohuck@redhat.com>) id 1dnQLv-0005nZ-0n\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 10:21:51 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <cohuck@redhat.com>) id 1dnQLr-0006hg-Qt\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 10:21:50 -0400","from mx1.redhat.com ([209.132.183.28]:49188)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <cohuck@redhat.com>) id 1dnQLr-0006hH-KG\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 10:21:47 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9D7F080C06;\n\tThu, 31 Aug 2017 14:21:46 +0000 (UTC)","from gondolin (ovpn-117-247.ams2.redhat.com [10.36.117.247])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 931C992BA7;\n\tThu, 31 Aug 2017 14:21:42 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 9D7F080C06","Date":"Thu, 31 Aug 2017 16:21:39 +0200","From":"Cornelia Huck <cohuck@redhat.com>","To":"David Hildenbrand <david@redhat.com>","Message-ID":"<20170831162139.2065033c.cohuck@redhat.com>","In-Reply-To":"<20170830170601.15855-2-david@redhat.com>","References":"<20170830170601.15855-1-david@redhat.com>\n\t<20170830170601.15855-2-david@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tThu, 31 Aug 2017 14:21:46 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 01/11] exec,\n\tdump: don't include exec/exec-all.h explicitly","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"thuth@redhat.com, Richard Henderson <richard.henderson@linaro.org>,\n\tqemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>,\n\tborntraeger@de.ibm.com, Aurelien Jarno <aurelien@aurel32.net>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1761761,"web_url":"http://patchwork.ozlabs.org/comment/1761761/","msgid":"<94c0d9f6-1729-cb1b-25fb-1eca664e8c8f@redhat.com>","list_archive_url":null,"date":"2017-09-01T15:18:06","subject":"Re: [Qemu-devel] [PATCH v1 01/11] exec,\n\tdump: don't include exec/exec-all.h explicitly","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 31.08.2017 16:21, Cornelia Huck wrote:\n> On Wed, 30 Aug 2017 19:05:51 +0200\n> David Hildenbrand <david@redhat.com> wrote:\n> \n>> All but two, namely exec.c and dump.c, include exec/exec-all.h via\n>> cpu.h only. as these files already include cpu.h, let's just drop the\n>> additional include.\n>>\n>> Signed-off-by: David Hildenbrand <david@redhat.com>\n>> ---\n>>  dump.c | 1 -\n>>  exec.c | 1 -\n>>  2 files changed, 2 deletions(-)\n>>\n> \n> I think there are some more (target/<arch>/arch_dump.c and some i386\n> files) - do you want to clean up those as well?\n> \n\nWhoops, missed these. Yes, will clean them up, too.","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkNMd1KPTz9t3P\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat,  2 Sep 2017 01:24:45 +1000 (AEST)","from localhost ([::1]:45409 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dnnoI-00030o-LS\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 11:24:42 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:45516)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dnni4-0005ke-8X\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 11:18:19 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dnnhz-0000x1-K9\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 11:18:16 -0400","from mx1.redhat.com ([209.132.183.28]:33280)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <david@redhat.com>) id 1dnnhz-0000w8-Dl\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 11:18:11 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id BB8B6883B4;\n\tFri,  1 Sep 2017 15:18:09 +0000 (UTC)","from [10.36.117.142] (ovpn-117-142.ams2.redhat.com [10.36.117.142])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 53F306E8E5;\n\tFri,  1 Sep 2017 15:18:07 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com BB8B6883B4","To":"Cornelia Huck <cohuck@redhat.com>","References":"<20170830170601.15855-1-david@redhat.com>\n\t<20170830170601.15855-2-david@redhat.com>\n\t<20170831162139.2065033c.cohuck@redhat.com>","From":"David Hildenbrand <david@redhat.com>","Organization":"Red Hat GmbH","Message-ID":"<94c0d9f6-1729-cb1b-25fb-1eca664e8c8f@redhat.com>","Date":"Fri, 1 Sep 2017 17:18:06 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170831162139.2065033c.cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tFri, 01 Sep 2017 15:18:09 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 01/11] exec,\n\tdump: don't include exec/exec-all.h explicitly","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"thuth@redhat.com, Richard Henderson <richard.henderson@linaro.org>,\n\tqemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>,\n\tborntraeger@de.ibm.com, Aurelien Jarno <aurelien@aurel32.net>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}}]