[{"id":1760440,"web_url":"http://patchwork.ozlabs.org/comment/1760440/","msgid":"","list_archive_url":null,"date":"2017-08-30T19:48:40","subject":"Re: [Qemu-devel] [PATCH v2 4/7] block/sheepdog: code beautification","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 08/30/2017 11:57 AM, Jeff Cody wrote:\n> No functional changes, just whitespace manipulation.\n> \n> Signed-off-by: Jeff Cody \n> ---\n> block/sheepdog.c | 162 +++++++++++++++++++++++++++----------------------------\n> 1 file changed, 81 insertions(+), 81 deletions(-)\n> \n\n> static BlockDriver bdrv_sheepdog = {\n> - .format_name = \"sheepdog\",\n> - .protocol_name = \"sheepdog\",\n> - .instance_size = sizeof(BDRVSheepdogState),\n> - .bdrv_parse_filename = sd_parse_filename,\n> - .bdrv_file_open = sd_open,\n> - .bdrv_reopen_prepare = sd_reopen_prepare,\n> - .bdrv_reopen_commit = sd_reopen_commit,\n> - .bdrv_reopen_abort = sd_reopen_abort,\n> - .bdrv_close = sd_close,\n> - .bdrv_create = sd_create,\n> - .bdrv_has_zero_init = bdrv_has_zero_init_1,\n> - .bdrv_getlength = sd_getlength,\n\nThe existing style is indeed ugly since it has no consistency,...\n\n> + .format_name = \"sheepdog\",\n> + .protocol_name = \"sheepdog\",\n> + .instance_size = sizeof(BDRVSheepdogState),\n> + .bdrv_parse_filename = sd_parse_filename,\n> + .bdrv_file_open = sd_open,\n> + .bdrv_reopen_prepare = sd_reopen_prepare,\n> + .bdrv_reopen_commit = sd_reopen_commit,\n> + .bdrv_reopen_abort = sd_reopen_abort,\n> + .bdrv_close = sd_close,\n> + .bdrv_create = sd_create,\n> + .bdrv_has_zero_init = bdrv_has_zero_init_1,\n> + .bdrv_getlength = sd_getlength,\n> .bdrv_get_allocated_file_size = sd_get_allocated_file_size,\n\n...but aligning '=' requires mass reformatting if you get any longer\n.bdrv_ function callback added down the road. If it were me, I'd just\nconsistently use a single space everywhere, as in:\n\n.format_name = \"sheepdog\",\n.protocol_name = \"sheepdog\",\n\nbut that's my personal opinion, and not a hard rule, so I won't be\nbothered if you don't take it.\n\n> static BlockDriver bdrv_sheepdog_tcp = {\n> - .format_name = \"sheepdog\",\n> - .protocol_name = \"sheepdog+tcp\",\n> - .instance_size = sizeof(BDRVSheepdogState),\n> - .bdrv_parse_filename = sd_parse_filename,\n> + .format_name = \"sheepdog\",\n> + .protocol_name = \"sheepdog+tcp\",\n> + .instance_size = sizeof(BDRVSheepdogState),\n> + .bdrv_parse_filename = sd_parse_filename,\n> .bdrv_file_open = sd_open,\n\nSee, with your style, this row now stands out as being missed; with my\nstyle, this line needs no edits.\n\nBut your changes are indeed semantic no-ops, so whether you fix the few\nunaligned lines per your style, or redo to a consistent style of only a\nsingle space, you can add:\nReviewed-by: Eric Blake ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjGLb5tBLz9sP5\n\tfor ;\n\tThu, 31 Aug 2017 05:49:57 +1000 (AEST)","from localhost ([::1]:52421 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn8zq-0001Ct-DD\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 15:49:54 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48111)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn8yn-0000pa-7c\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 15:48:50 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn8ym-0002YW-4r\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 15:48:49 -0400","from mx1.redhat.com ([209.132.183.28]:46338)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dn8yh-0002XS-GR; Wed, 30 Aug 2017 15:48:43 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 3AA967E433;\n\tWed, 30 Aug 2017 19:48:42 +0000 (UTC)","from [10.10.122.186] (ovpn-122-186.rdu2.redhat.com [10.10.122.186])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id ED416173D3;\n\tWed, 30 Aug 2017 19:48:40 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 3AA967E433","To":"Jeff Cody , qemu-devel@nongnu.org","References":"\n\t<30210223ca3a13c64b4ba623479b69ae23fa865e.1504112061.git.jcody@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"","Date":"Wed, 30 Aug 2017 14:48:40 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<30210223ca3a13c64b4ba623479b69ae23fa865e.1504112061.git.jcody@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"4n1rB7snNq1VVPXI67rIm8H1gQUo8OsUa\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tWed, 30 Aug 2017 19:48:42 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v2 4/7] block/sheepdog: code beautification","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"mitake.hitoshi@lab.ntt.co.jp, namei.unix@gmail.com, qemu-block@nongnu.org,\n\trjones@redhat.com, kwolf@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]