[{"id":1760443,"web_url":"http://patchwork.ozlabs.org/comment/1760443/","msgid":"<89e43927-f8aa-d12c-893b-6a5cb5e9351d@redhat.com>","list_archive_url":null,"date":"2017-08-30T19:53:53","subject":"Re: [Qemu-devel] [PATCH v2 7/7] block/curl: code cleanup to comply\n\twith coding style","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 08/30/2017 11:57 AM, Jeff Cody wrote:\n> This addresses non-functional changes to help curl.c better comply\n> with the coding styles (comments, indentation, brackets, etc.).\n> \n> One minor code change is the combination of two if statements into\n> a single if statement.\n> \n> Signed-off-by: Jeff Cody \n> ---\n> block/curl.c | 100 +++++++++++++++++++++++++++++++----------------------------\n> 1 file changed, 52 insertions(+), 48 deletions(-)\n> \n\n> -#define CURL_BLOCK_OPT_URL \"url\"\n> -#define CURL_BLOCK_OPT_READAHEAD \"readahead\"\n> -#define CURL_BLOCK_OPT_SSLVERIFY \"sslverify\"\n> -#define CURL_BLOCK_OPT_TIMEOUT \"timeout\"\n> -#define CURL_BLOCK_OPT_COOKIE \"cookie\"\n> -#define CURL_BLOCK_OPT_COOKIE_SECRET \"cookie-secret\"\n> -#define CURL_BLOCK_OPT_USERNAME \"username\"\n> -#define CURL_BLOCK_OPT_PASSWORD_SECRET \"password-secret\"\n> -#define CURL_BLOCK_OPT_PROXY_USERNAME \"proxy-username\"\n\nAnother change from inconsistent spacing,\n\n> +#define CURL_BLOCK_OPT_URL \"url\"\n> +#define CURL_BLOCK_OPT_READAHEAD \"readahead\"\n> +#define CURL_BLOCK_OPT_SSLVERIFY \"sslverify\"\n> +#define CURL_BLOCK_OPT_TIMEOUT \"timeout\"\n> +#define CURL_BLOCK_OPT_COOKIE \"cookie\"\n> +#define CURL_BLOCK_OPT_COOKIE_SECRET \"cookie-secret\"\n> +#define CURL_BLOCK_OPT_USERNAME \"username\"\n> +#define CURL_BLOCK_OPT_PASSWORD_SECRET \"password-secret\"\n> +#define CURL_BLOCK_OPT_PROXY_USERNAME \"proxy-username\"\n> #define CURL_BLOCK_OPT_PROXY_PASSWORD_SECRET \"proxy-password-secret\"\n\nto something that is consistent but requires a mass-edit if we add a\nlonger name.\n\n\n> @@ -235,7 +236,7 @@ static size_t curl_header_cb(void *ptr, size_t size, size_t nmemb, void *opaque)\n> /* Called from curl_multi_do_locked, with s->mutex held. */\n> static size_t curl_read_cb(void *ptr, size_t size, size_t nmemb, void *opaque)\n> {\n> - CURLState *s = ((CURLState*)opaque);\n> + CURLState *s = ((CURLState *)opaque);\n\nUmm, this is C, so why not just:\n\nCURLState *s = opaque;\n\nThose are minor findings, so whether or not you address them,\nReviewed-by: Eric Blake ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjGRg4Cd5z9s8P\n\tfor ;\n\tThu, 31 Aug 2017 05:54:23 +1000 (AEST)","from localhost ([::1]:52440 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn949-0004bs-Od\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 15:54:21 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49392)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn93q-0004aa-HL\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 15:54:03 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn93p-000488-Ec\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 15:54:02 -0400","from mx1.redhat.com ([209.132.183.28]:33376)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dn93k-000475-Sz; Wed, 30 Aug 2017 15:53:57 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B06A3C047B6F;\n\tWed, 30 Aug 2017 19:53:55 +0000 (UTC)","from [10.10.122.186] (ovpn-122-186.rdu2.redhat.com [10.10.122.186])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 6262D1713F;\n\tWed, 30 Aug 2017 19:53:54 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B06A3C047B6F","To":"Jeff Cody , qemu-devel@nongnu.org","References":"\n\t","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<89e43927-f8aa-d12c-893b-6a5cb5e9351d@redhat.com>","Date":"Wed, 30 Aug 2017 14:53:53 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"mNdMetDiT0VfqsJu8dHoXBCseQ2Xhh5gL\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tWed, 30 Aug 2017 19:53:55 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v2 7/7] block/curl: code cleanup to comply\n\twith coding style","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"mitake.hitoshi@lab.ntt.co.jp, namei.unix@gmail.com, qemu-block@nongnu.org,\n\trjones@redhat.com, kwolf@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]